136880 2014-09-16 19:23:22 -0700 Add unprefixed flexbox display values and property names/values 2014-09-17 15:07:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino graouts joepeck timothy webkit-bug-importer oldest_to_newest 1035664 0 dino 2014-09-16 19:23:22 -0700 Add unprefixed flexbox display values and property names/values 1035665 1 webkit-bug-importer 2014-09-16 19:23:54 -0700 <rdar://problem/18361137> 1035668 2 238234 dino 2014-09-16 19:34:09 -0700 Created attachment 238234 Patch 1035744 3 238234 joepeck 2014-09-17 11:49:27 -0700 Comment on attachment 238234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238234&action=review > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:365 > + "flex", "-webkit-flex", "inline-flex", "-webkit-inline-flex", "-webkit-grid", "-webkit-inline-grid" You can remove the prefixed versions. > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:675 > + "align-content": [ > + "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > + ], > "-webkit-align-content": [ > "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > ], All of these are identical! So the duplication is unnecessary. You should just remove the "-webkit-" prefix versions. Things will just work for prefixed and unprefixed autocompletion (see WebInspector.CSSKeywordCompletions.forProperty). 1035780 4 dino 2014-09-17 15:07:02 -0700 Committed r173705: <http://trac.webkit.org/changeset/173705> 238234 2014-09-16 19:34:09 -0700 2014-09-17 13:32:59 -0700 Patch bug-136880-20140917123406.patch text/plain 3772 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz NDU4OGQzY2M3YTk1MzU1MDI5YjI0MWIzNzUwZGExZTViOTkyNGI0Li5lMTZhNWQ3NmU2ZGZmYTEx ZTdiMjJhNDNmN2U5ZjVjMDFiMmE4OTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wOS0xNiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgQWRkIHVucHJlZml4ZWQgZmxleGJveCBkaXNwbGF5IHZhbHVlcyBhbmQgcHJvcGVy dHkgbmFtZXMvdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzY4ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4MzYxMTM3PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOiBBZGQgYWxsIHRoZSBub3cgdW5wcmVm aXhlZAorICAgICAgICBmbGV4IHByb3BlcnRpZXMuCisKIDIwMTQtMDktMTEgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXgg YXNzZXJ0IGluIFF1aWNrQ29uc29sZSAtIG1haW4gZnJhbWUgZXhlY3V0aW9uIGNvbnRleHQgcGF0 aCBjb21wb25lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCmluZGV4IDVk NmM2OGFmM2E5OTg2ZGJmODM3YmY5MTMwNjJhYjI4MmYyZGM2ODEuLmQxNTIzZWM2NmMyNThhMzMz N2NmYWRmOWMzNTEzZDAwOWQwOGMzZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0 aW9ucy5qcwpAQCAtMzYyLDcgKzM2Miw3IEBAIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxl dGlvbnMuX3Byb3BlcnR5S2V5d29yZE1hcCA9IHsKICAgICAgICAgIm5vbmUiLCAiaW5saW5lIiwg ImJsb2NrIiwgImxpc3QtaXRlbSIsICJjb21wYWN0IiwgImlubGluZS1ibG9jayIsICJ0YWJsZSIs ICJpbmxpbmUtdGFibGUiLAogICAgICAgICAidGFibGUtcm93LWdyb3VwIiwgInRhYmxlLWhlYWRl ci1ncm91cCIsICJ0YWJsZS1mb290ZXItZ3JvdXAiLCAidGFibGUtcm93IiwgInRhYmxlLWNvbHVt bi1ncm91cCIsCiAgICAgICAgICJ0YWJsZS1jb2x1bW4iLCAidGFibGUtY2VsbCIsICJ0YWJsZS1j YXB0aW9uIiwgIi13ZWJraXQtYm94IiwgIi13ZWJraXQtaW5saW5lLWJveCIsICItd2FwLW1hcnF1 ZWUiLAotICAgICAgICAiLXdlYmtpdC1mbGV4IiwgIi13ZWJraXQtaW5saW5lLWZsZXgiLCAiLXdl YmtpdC1ncmlkIiwgIi13ZWJraXQtaW5saW5lLWdyaWQiCisgICAgICAgICJmbGV4IiwgIi13ZWJr aXQtZmxleCIsICJpbmxpbmUtZmxleCIsICItd2Via2l0LWlubGluZS1mbGV4IiwgIi13ZWJraXQt Z3JpZCIsICItd2Via2l0LWlubGluZS1ncmlkIgogICAgIF0sCiAgICAgImltYWdlLXJlbmRlcmlu ZyI6IFsKICAgICAgICAgImF1dG8iLCAib3B0aW1pemVTcGVlZCIsICJvcHRpbWl6ZVF1YWxpdHki LCAiLXdlYmtpdC1jcmlzcC1lZGdlcyIsICItd2Via2l0LW9wdGltaXplLWNvbnRyYXN0IgpAQCAt NjY3LDMxICs2NjcsNTkgQEAgV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fcHJv cGVydHlLZXl3b3JkTWFwID0gewogICAgICItd2Via2l0LWJveC1kZWNvcmF0aW9uLWJyZWFrIjog WwogICAgICAgICAic2xpY2UiLCAiY2xvbmUiCiAgICAgXSwKKyAgICAiYWxpZ24tY29udGVudCI6 IFsKKyAgICAgICAgImZsZXgtc3RhcnQiLCAiZmxleC1lbmQiLCAiY2VudGVyIiwgInNwYWNlLWJl dHdlZW4iLCAic3BhY2UtYXJvdW5kIiwgInN0cmV0Y2giCisgICAgXSwKICAgICAiLXdlYmtpdC1h bGlnbi1jb250ZW50IjogWwogICAgICAgICAiZmxleC1zdGFydCIsICJmbGV4LWVuZCIsICJjZW50 ZXIiLCAic3BhY2UtYmV0d2VlbiIsICJzcGFjZS1hcm91bmQiLCAic3RyZXRjaCIKICAgICBdLAor ICAgICJhbGlnbi1pdGVtcyI6IFsKKyAgICAgICAgImZsZXgtc3RhcnQiLCAiZmxleC1lbmQiLCAi Y2VudGVyIiwgImJhc2VsaW5lIiwgInN0cmV0Y2giCisgICAgXSwKICAgICAiLXdlYmtpdC1hbGln bi1pdGVtcyI6IFsKICAgICAgICAgImZsZXgtc3RhcnQiLCAiZmxleC1lbmQiLCAiY2VudGVyIiwg ImJhc2VsaW5lIiwgInN0cmV0Y2giCiAgICAgXSwKKyAgICAiYWxpZ24tc2VsZiI6IFsKKyAgICAg ICAgImF1dG8iLCAiZmxleC1zdGFydCIsICJmbGV4LWVuZCIsICJjZW50ZXIiLCAiYmFzZWxpbmUi LCAic3RyZXRjaCIKKyAgICBdLAogICAgICItd2Via2l0LWFsaWduLXNlbGYiOiBbCiAgICAgICAg ICJhdXRvIiwgImZsZXgtc3RhcnQiLCAiZmxleC1lbmQiLCAiY2VudGVyIiwgImJhc2VsaW5lIiwg InN0cmV0Y2giCiAgICAgXSwKKyAgICAianVzdGlmeS1jb250ZW50IjogWworICAgICAgICAiZmxl eC1zdGFydCIsICJmbGV4LWVuZCIsICJjZW50ZXIiLCAic3BhY2UtYmV0d2VlbiIsICJzcGFjZS1h cm91bmQiCisgICAgXSwKICAgICAiLXdlYmtpdC1qdXN0aWZ5LWNvbnRlbnQiOiBbCiAgICAgICAg ICJmbGV4LXN0YXJ0IiwgImZsZXgtZW5kIiwgImNlbnRlciIsICJzcGFjZS1iZXR3ZWVuIiwgInNw YWNlLWFyb3VuZCIKICAgICBdLAorICAgICJmbGV4LWRpcmVjdGlvbiI6IFsKKyAgICAgICAgInJv dyIsICJyb3ctcmV2ZXJzZSIsICJjb2x1bW4iLCAiY29sdW1uLXJldmVyc2UiCisgICAgXSwKICAg ICAiLXdlYmtpdC1mbGV4LWRpcmVjdGlvbiI6IFsKICAgICAgICAgInJvdyIsICJyb3ctcmV2ZXJz ZSIsICJjb2x1bW4iLCAiY29sdW1uLXJldmVyc2UiCiAgICAgXSwKKyAgICAiZmxleC13cmFwIjog WworICAgICAgICAibm93cmFwIiwgIndyYXAiLCAid3JhcC1yZXZlcnNlIgorICAgIF0sCiAgICAg Ii13ZWJraXQtZmxleC13cmFwIjogWwogICAgICAgICAibm93cmFwIiwgIndyYXAiLCAid3JhcC1y ZXZlcnNlIgogICAgIF0sCisgICAgImZsZXgtZmxvdyI6IFsKKyAgICAgICAgInJvdyIsICJyb3ct cmV2ZXJzZSIsICJjb2x1bW4iLCAiY29sdW1uLXJldmVyc2UiLAorICAgICAgICAibm93cmFwIiwg IndyYXAiLCAid3JhcC1yZXZlcnNlIgorICAgIF0sCiAgICAgIi13ZWJraXQtZmxleC1mbG93Ijog WwogICAgICAgICAicm93IiwgInJvdy1yZXZlcnNlIiwgImNvbHVtbiIsICJjb2x1bW4tcmV2ZXJz ZSIsCiAgICAgICAgICJub3dyYXAiLCAid3JhcCIsICJ3cmFwLXJldmVyc2UiCiAgICAgXSwKKyAg ICAiZmxleCI6IFsKKyAgICAgICAgIm5vbmUiCisgICAgXSwKICAgICAiLXdlYmtpdC1mbGV4Ijog WwogICAgICAgICAibm9uZSIKICAgICBdLAorICAgICJmbGV4LWJhc2lzIjogWworICAgICAgICAi YXV0byIKKyAgICBdLAogICAgICItd2Via2l0LWZsZXgtYmFzaXMiOiBbCiAgICAgICAgICJhdXRv IgogICAgIF0sCg==