13688 2007-05-11 21:14:43 -0700 REGRESSION (r20943+): Colloquy doesn't show any messages 2007-05-12 00:02:34 -0700 1 1 1 Unclassified WebKit CSS 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 aroben hyatt timothy oldest_to_newest 10263 0 aroben 2007-05-11 21:14:43 -0700 Sometime after r20943, Colloquy stopped showing messages. Repro steps: 1. Launch Colloquy with DYLD_FRAMEWORK_PATH set to a post-r20943 WebKit 2. Type a message Results: The message doesn't appear in the chat window. 10253 1 14502 timothy 2007-05-11 21:53:47 -0700 Created attachment 14502 Test case This test should fill the whole view port green. 10254 2 timothy 2007-05-11 21:58:09 -0700 This has to do with CSS tables. Colloquy has a body CSS rule: body { display: table } And other rules for table-row and table-cell. I'll look at redoing this in Colloquy (it was rather whacky, but it worked!) 10255 3 timothy 2007-05-11 21:59:00 -0700 This test works in Firefox also. 10257 4 14503 hyatt 2007-05-11 23:19:47 -0700 Created attachment 14503 More complicated test case to really illustrate the problem Firefox 2 and Safari 2 both fail this one too. WebKit fails it the worst though. 10258 5 14504 hyatt 2007-05-11 23:45:46 -0700 Created attachment 14504 Patch to fix bug The behavior in this patch exactly matches Gran Paradiso Alpha 4. Empty cells (with no lines) had their baseline wrongly at the top in FFX2 (one of the reasons it failed Acid2). Now that the baseline of the cell is on the bottom, Gran Paradiso Alpha 4 passes this test case as well. I even tried putting text in cell 2 in the test case, wondering if the cell would move such that it hung out of the table itself. It did indeed do that with both my patch and Gran Paradiso. 10249 6 hyatt 2007-05-12 00:02:34 -0700 Fixed in r21425. 14502 2007-05-11 21:53:47 -0700 2007-05-11 23:19:47 -0700 Test case css-table.html text/html 569 timothy PGh0bWw+CjxoZWFkPgoJPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCWh0bWwgewoJCWhlaWdodDog MTAwJTsKCQl3aWR0aDogMTAwJTsKCQlvdmVyZmxvdzogaGlkZGVuOwoJfQoKCWJvZHkgewoJCWRp c3BsYXk6IHRhYmxlOwoJCWJvcmRlcjogbm9uZTsKCQlib3JkZXItc3BhY2luZzogMDsKCQltYXJn aW46IDA7CgkJaGVpZ2h0OiAxMDAlOwoJCXdpZHRoOiAxMDAlOwoJCWJhY2tncm91bmQtY29sb3I6 IHJlZDsKCX0KCgkuYm9keSB7CgkJZGlzcGxheTogdGFibGUtcm93OwoJCWJvcmRlcjogbm9uZTsK CX0KCgkuYm9keSA+ICogewoJCWRpc3BsYXk6IHRhYmxlLWNlbGw7CgkJYm9yZGVyOiBub25lOwoJ CWhlaWdodDogMTAwJTsKCQl3aWR0aDogMTAwJTsKCX0KCgkuYm9keSA+ICogPiBpZnJhbWUgewoJ CWJvcmRlcjogbm9uZTsKCQloZWlnaHQ6IDEwMCU7CgkJd2lkdGg6IDEwMCU7CgkJYmFja2dyb3Vu ZC1jb2xvcjogZ3JlZW47Cgl9Cgk8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5Pgo8ZGl2IGNsYXNzPSJi b2R5Ij48ZGl2PjxpZnJhbWU+PC9pZnJhbWU+PC9kaXY+PC9kaXY+CjwvYm9keT4KPC9odG1sPgo= 14503 2007-05-11 23:19:47 -0700 2007-05-11 23:19:47 -0700 More complicated test case to really illustrate the problem css-table.html text/html 852 hyatt PGh0bWw+CjxoZWFkPgoJPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCWh0bWwgewoJCWhlaWdodDog MTAwJTsKCQl3aWR0aDogMTAwJTsKCQlvdmVyZmxvdzogaGlkZGVuOwoJfQoKCWJvZHkgewoJCWRp c3BsYXk6IHRhYmxlOwoJCWJvcmRlcjogbm9uZTsKCQlib3JkZXItc3BhY2luZzogMDsKCQltYXJn aW46IDA7CgkJaGVpZ2h0OiAxMDAlOwoJCXdpZHRoOiAxMDAlOwoJCWJhY2tncm91bmQtY29sb3I6 IHJlZDsKCX0KCgkuYm9keSB7CgkJZGlzcGxheTogdGFibGUtcm93OwoJCWJvcmRlcjogbm9uZTsK CX0KCgkuYm9keSA+IGRpdiB7CgkJZGlzcGxheTogdGFibGUtY2VsbDsKCQlib3JkZXI6IG5vbmU7 CgkJaGVpZ2h0OiAxMDAlOwoJCXdpZHRoOiA1MCU7CiAgICAgICAgICAgICAgICBiYWNrZ3JvdW5k LWNvbG9yOiByZWQ7Cgl9CgogICAgICAgIGRpdi5jZWxsMSB7CgkJYm9yZGVyOiBub25lOwoJCWhl aWdodDogMTAwJTsKCQl3aWR0aDogMTAwJTsKCQliYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKCX0K ICAgICAgICAKICAgICAgICBkaXYuY2VsbDIgewoJCWJvcmRlcjogbm9uZTsKCQloZWlnaHQ6IDUw JTsKCQl3aWR0aDogMTAwJTsKCQliYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKCX0KCTwvc3R5bGU+ CjwvaGVhZD4KPGJvZHk+CjxkaXYgc3R5bGU9InBvc2l0aW9uOmFic29sdXRlO3JpZ2h0OjA7dG9w OjA7d2lkdGg6NTAlO2hlaWdodDo1MCU7YmFja2dyb3VuZC1jb2xvcjpncmVlbiI+PC9kaXY+Cjxk aXYgY2xhc3M9ImJvZHkiPjxkaXY+PGRpdiBjbGFzcz0iY2VsbDEiPjwvZGl2PjwvZGl2PjxkaXY+ PGRpdiBjbGFzcz0iY2VsbDIiPjwvZGl2PjwvZGl2PjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 14504 2007-05-11 23:45:46 -0700 2007-05-11 23:54:51 -0700 Patch to fix bug patch.txt text/plain 2223 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJl bmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCShyZXZpc2lvbiAyMTQyMikKKysrIHJlbmRl cmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNyArMTc3 LDcgQEAgYm9vbCBSZW5kZXJUYWJsZVNlY3Rpb246OmVuc3VyZVJvd3MoaW50IAogICAgICAgICAg ICAgbV9ncmlkW3JdLnJvdyA9IG5ldyBSb3cobkNvbHMpOwogICAgICAgICAgICAgbV9ncmlkW3Jd LnJvdy0+ZmlsbChlbXB0eUNlbGxTdHJ1Y3QpOwogICAgICAgICAgICAgbV9ncmlkW3JdLnJvd1Jl bmRlcmVyID0gMDsKLSAgICAgICAgICAgIG1fZ3JpZFtyXS5iYXNlTGluZSA9IDA7CisgICAgICAg ICAgICBtX2dyaWRbcl0uYmFzZWxpbmUgPSAwOwogICAgICAgICAgICAgbV9ncmlkW3JdLmhlaWdo dCA9IExlbmd0aCgpOwogICAgICAgICB9CiAgICAgfQpAQCAtMzc4LDcgKzM3OCw3IEBAIHZvaWQg UmVuZGVyVGFibGVTZWN0aW9uOjpjYWxjUm93SGVpZ2h0KCkKICAgICAgICAgaWYgKGJhc2VsaW5l KSB7CiAgICAgICAgICAgICAvLyBpbmNyZWFzZSByb3doZWlnaHQgaWYgYmFzZWxpbmUgcmVxdWly ZXMKICAgICAgICAgICAgIG1fcm93UG9zW3IgKyAxXSA9IG1heChtX3Jvd1Bvc1tyICsgMV0sIGJh c2VsaW5lICsgYmRlc2MgKyAobV9ncmlkW3JdLnJvd1JlbmRlcmVyID8gc3BhY2luZyA6IDApKTsK LSAgICAgICAgICAgIG1fZ3JpZFtyXS5iYXNlTGluZSA9IGJhc2VsaW5lOworICAgICAgICAgICAg bV9ncmlkW3JdLmJhc2VsaW5lID0gYmFzZWxpbmU7CiAgICAgICAgIH0KIAogICAgICAgICBtX3Jv d1Bvc1tyICsgMV0gPSBtYXgobV9yb3dQb3NbciArIDFdLCBtX3Jvd1Bvc1tyXSk7CkBAIC01MjUs NiArNTI1LDE0IEBAIGludCBSZW5kZXJUYWJsZVNlY3Rpb246OmxheW91dFJvd3MoaW50IHQKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBySGVpZ2h0IC0gY2VsbC0+ Ym9yZGVyVG9wKCkgLSBjZWxsLT5wYWRkaW5nVG9wKCkgLSAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2VsbC0+Ym9yZGVyQm90dG9tKCkgLSBj ZWxsLT5wYWRkaW5nQm90dG9tKCkpKTsKICAgICAgICAgICAgICAgICBjZWxsLT5sYXlvdXRJZk5l ZWRlZCgpOworICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIC8vIElmIHRoZSBiYXNl bGluZSBtb3ZlZCwgd2UgbWF5IGhhdmUgdG8gdXBkYXRlIHRoZSBkYXRhIGZvciBvdXIgcm93LiBG aW5kIG91dCB0aGUgbmV3IGJhc2VsaW5lLgorICAgICAgICAgICAgICAgIEVWZXJ0aWNhbEFsaWdu IHZhID0gY2VsbC0+c3R5bGUoKS0+dmVydGljYWxBbGlnbigpOworICAgICAgICAgICAgICAgIGlm ICh2YSA9PSBCQVNFTElORSB8fCB2YSA9PSBURVhUX0JPVFRPTSB8fCB2YSA9PSBURVhUX1RPUCB8 fCB2YSA9PSBTVVBFUiB8fCB2YSA9PSBTVUIpIHsKKyAgICAgICAgICAgICAgICAgICAgaW50IGIg PSBjZWxsLT5iYXNlbGluZVBvc2l0aW9uKCk7CisgICAgICAgICAgICAgICAgICAgIGlmIChiID4g Y2VsbC0+Ym9yZGVyVG9wKCkgKyBjZWxsLT5wYWRkaW5nVG9wKCkpCisgICAgICAgICAgICAgICAg ICAgICAgICBtX2dyaWRbcl0uYmFzZWxpbmUgPSBtYXgobV9ncmlkW3JdLmJhc2VsaW5lLCBiKTsK KyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAKICAgICAgICAg ICAgIGludCB0ZSA9IDA7CkBAIC01MzQsNyArNTQyLDcgQEAgaW50IFJlbmRlclRhYmxlU2VjdGlv bjo6bGF5b3V0Um93cyhpbnQgdAogICAgICAgICAgICAgICAgIGNhc2UgVEVYVF9UT1A6CiAgICAg ICAgICAgICAgICAgY2FzZSBURVhUX0JPVFRPTToKICAgICAgICAgICAgICAgICBjYXNlIEJBU0VM SU5FOgotICAgICAgICAgICAgICAgICAgICB0ZSA9IGdldEJhc2VsaW5lKHIpIC0gY2VsbC0+YmFz ZWxpbmVQb3NpdGlvbigpIDsKKyAgICAgICAgICAgICAgICAgICAgdGUgPSBnZXRCYXNlbGluZShy KSAtIGNlbGwtPmJhc2VsaW5lUG9zaXRpb24oKTsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICAgICAgY2FzZSBUT1A6CiAgICAgICAgICAgICAgICAgICAgIHRlID0gMDsK