136875 2014-09-16 16:53:06 -0700 Web Inspector: Reduce a bit of churn setting initial remote inspection state 2014-09-16 17:49:35 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1035625 0 joepeck 2014-09-16 16:53:06 -0700 Currently JSGlobalObjects always set remote inspection enabled in construction, and then JSDOMGlobalObjects would disable it. Instead move the remote inspection enabling on JSGlobalObjects to the JSContext/JSGlobalContextRef API boundaries. This way the JSGlobalObject within web pages are never temporarily debuggable reducing the amount of churn surrounding toggling this setting. This does mean that only JSGlobalObjects made through the JSC C/ObjC APIs are debuggable, but that covers the majority. I found only jsc directly instantiates a JSGlobalObject via subclassing. 1035626 1 webkit-bug-importer 2014-09-16 16:54:17 -0700 <rdar://problem/18359599> 1035628 2 238221 joepeck 2014-09-16 17:01:18 -0700 Created attachment 238221 [PATCH] Proposed Fix 1035631 3 238221 timothy 2014-09-16 17:06:00 -0700 Comment on attachment 238221 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=238221&action=review > Source/JavaScriptCore/ChangeLog:10 > + Set the defaultl remote debuggable state at the API boundary. Typo: default 1035649 4 238221 commit-queue 2014-09-16 17:49:33 -0700 Comment on attachment 238221 [PATCH] Proposed Fix Clearing flags on attachment: 238221 Committed r173683: <http://trac.webkit.org/changeset/173683> 1035650 5 commit-queue 2014-09-16 17:49:35 -0700 All reviewed patches have been landed. Closing bug. 238221 2014-09-16 17:01:18 -0700 2014-09-16 17:49:33 -0700 [PATCH] Proposed Fix rwi-init.patch text/plain 3951 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcAppbmRleCA2MzdiOTlk Li4wMmUyYjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4 dFJlZi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3Bw CkBAIC0xMzgsNiArMTM4LDkgQEAgSlNHbG9iYWxDb250ZXh0UmVmIEpTR2xvYmFsQ29udGV4dENy ZWF0ZUluR3JvdXAoSlNDb250ZXh0R3JvdXBSZWYgZ3JvdXAsIEpTQ2xhc3MKIAogICAgIGlmICgh Z2xvYmFsT2JqZWN0Q2xhc3MpIHsKICAgICAgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVj dCA9IEpTR2xvYmFsT2JqZWN0OjpjcmVhdGUoKnZtLCBKU0dsb2JhbE9iamVjdDo6Y3JlYXRlU3Ry dWN0dXJlKCp2bSwganNOdWxsKCkpKTsKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKKyAg ICAgICAgZ2xvYmFsT2JqZWN0LT5zZXRSZW1vdGVEZWJ1Z2dpbmdFbmFibGVkKHRydWUpOworI2Vu ZGlmCiAgICAgICAgIHJldHVybiBKU0dsb2JhbENvbnRleHRSZXRhaW4odG9HbG9iYWxSZWYoZ2xv YmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpKTsKICAgICB9CiAKQEAgLTE0Nyw2ICsxNTAsOSBAQCBK U0dsb2JhbENvbnRleHRSZWYgSlNHbG9iYWxDb250ZXh0Q3JlYXRlSW5Hcm91cChKU0NvbnRleHRH cm91cFJlZiBncm91cCwgSlNDbGFzcwogICAgIGlmICghcHJvdG90eXBlKQogICAgICAgICBwcm90 b3R5cGUgPSBqc051bGwoKTsKICAgICBnbG9iYWxPYmplY3QtPnJlc2V0UHJvdG90eXBlKCp2bSwg cHJvdG90eXBlKTsKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKKyAgICBnbG9iYWxPYmpl Y3QtPnNldFJlbW90ZURlYnVnZ2luZ0VuYWJsZWQodHJ1ZSk7CisjZW5kaWYKICAgICByZXR1cm4g SlNHbG9iYWxDb250ZXh0UmV0YWluKHRvR2xvYmFsUmVmKGV4ZWMpKTsKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggNzM1OTYyNy4uMWY4NzYwNiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDktMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgYSBiaXQgb2Yg Y2h1cm4gc2V0dGluZyBpbml0aWFsIHJlbW90ZSBpbnNwZWN0aW9uIHN0YXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4NzUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQSS9KU0NvbnRleHRSZWYu Y3BwOgorICAgICAgICAoSlNHbG9iYWxDb250ZXh0Q3JlYXRlSW5Hcm91cCk6CisgICAgICAgIFNl dCB0aGUgZGVmYXVsdGwgcmVtb3RlIGRlYnVnZ2FibGUgc3RhdGUgYXQgdGhlIEFQSSBib3VuZGFy eS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwOgorICAgICAgICAoSlND OjpKU0dsb2JhbE9iamVjdDo6aW5pdCk6CisgICAgICAgIERvIG5vdCBzZXQgcmVtb3RlIGRlYnVn Z2FibGUgc3RhdGUgaGVyZS4gTGV0IGNsaWVudHMgc2V0IGl0LgorCiAyMDE0LTA5LTE2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgSlNDIHRlc3QgZ2Fy ZGVuaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2Jh bE9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVj dC5jcHAKaW5kZXggNzNlYTA3Ni4uMGUxMDg2YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcApAQCAtMjExLDcgKzIxMSw2IEBAIHZvaWQg SlNHbG9iYWxPYmplY3Q6OmluaXQoKQogICAgIG1faW5zcGVjdG9yQ29udHJvbGxlciA9IHN0ZDo6 bWFrZV91bmlxdWU8SW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI+ KCp0aGlzKTsKICAgICBtX2luc3BlY3RvckRlYnVnZ2FibGUgPSBzdGQ6Om1ha2VfdW5pcXVlPEpT R2xvYmFsT2JqZWN0RGVidWdnYWJsZT4oKnRoaXMpOwogICAgIG1faW5zcGVjdG9yRGVidWdnYWJs ZS0+aW5pdCgpOwotICAgIG1faW5zcGVjdG9yRGVidWdnYWJsZS0+c2V0UmVtb3RlRGVidWdnaW5n QWxsb3dlZCh0cnVlKTsKICAgICBtX2NvbnNvbGVDbGllbnQgPSBtX2luc3BlY3RvckNvbnRyb2xs ZXItPmNvbnNvbGVDbGllbnQoKTsKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU5ZmQ1My4uOWEz MDkxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA5LTE2ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVk dWNlIGEgYml0IG9mIGNodXJuIHNldHRpbmcgaW5pdGlhbCByZW1vdGUgaW5zcGVjdGlvbiBzdGF0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2ODc1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTUds b2JhbE9iamVjdDo6ZmluaXNoQ3JlYXRpb24pOgorICAgICAgICBXZSBubyBsb25nZXIgbmVlZCB0 byB0b2dnbGUgdGhpcyBzdGF0ZS4KKwogMjAxNC0wOS0xNiAgcGVhdm9Ab3V0bG9vay5jb20gIDxw ZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBbQ3VybF0gU29tZXRpbWVzIGluY29tcGxldGUg b3IgZW1wdHkgY29udGVudCBjYW4gYmUgbG9hZGVkIGZyb20gY2FjaGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5jcHAKaW5kZXggY2IxMTk3ZC4u YWM5ZGQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01HbG9i YWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFs T2JqZWN0LmNwcApAQCAtNTcsMjAgKzU3LDEyIEBAIHZvaWQgSlNET01HbG9iYWxPYmplY3Q6OmZp bmlzaENyZWF0aW9uKFZNJiB2bSkKIHsKICAgICBCYXNlOjpmaW5pc2hDcmVhdGlvbih2bSk7CiAg ICAgQVNTRVJUKGluaGVyaXRzKGluZm8oKSkpOwotCi0jaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNU T1IpCi0gICAgc2V0UmVtb3RlRGVidWdnaW5nRW5hYmxlZChmYWxzZSk7Ci0jZW5kaWYKIH0KIAog dm9pZCBKU0RPTUdsb2JhbE9iamVjdDo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtLCBKU09iamVjdCog dGhpc1ZhbHVlKQogewogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtLCB0aGlzVmFsdWUpOwog ICAgIEFTU0VSVChpbmhlcml0cyhpbmZvKCkpKTsKLQotI2lmIEVOQUJMRShSRU1PVEVfSU5TUEVD VE9SKQotICAgIHNldFJlbW90ZURlYnVnZ2luZ0VuYWJsZWQoZmFsc2UpOwotI2VuZGlmCiB9CiAK IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIEpTRE9NR2xvYmFsT2JqZWN0OjpzY3JpcHRFeGVjdXRp b25Db250ZXh0KCkgY29uc3QK