<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136874</bug_id>
          
          <creation_ts>2014-09-16 15:28:49 -0700</creation_ts>
          <short_desc>[Win] __BUILD_NUMBER_SHORT__ not defined</short_desc>
          <delta_ts>2024-03-10 19:20:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">alex.christensen</reporter>
          <assigned_to name="Alex Christensen">alex.christensen</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>bfulgham</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1035607</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">alex.christensen</who>
    <bug_when>2014-09-16 15:28:49 -0700</bug_when>
    <thetext>Recently when compiling WinCairo, I&apos;m getting this error:
     1&gt;..\..\win\WebKit.resources\WebKit.rc(51): error RC2104: undefined keyword or key name: __BUILD_NUMBER_SHORT__

I&apos;m not sure why it&apos;s there, but getting rid of it fixes my problem.  Does it break anything else?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035609</commentid>
    <comment_count>1</comment_count>
      <attachid>238216</attachid>
    <who name="Alex Christensen">alex.christensen</who>
    <bug_when>2014-09-16 15:31:03 -0700</bug_when>
    <thetext>Created attachment 238216
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1036246</commentid>
    <comment_count>2</comment_count>
      <attachid>238216</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-09-19 17:06:21 -0700</bug_when>
    <thetext>Comment on attachment 238216
Patch

__BUILD_NUMBER_SHORT_ should be created by auto-version.pl (and defined in &quot;autoversion.h&quot;). We don&apos;t want to make the change you propose. Most likely you just need to make sure auto-version.pl runs during the build to create the necessary autoversion.h file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2019998</commentid>
    <comment_count>3</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2024-03-10 19:20:32 -0700</bug_when>
    <thetext>If not mistaken this file is gone with: https://commits.webkit.org/260397@main

Marking this as &apos;RESOLVED CONFIGURATION CHANGED&apos;, please reopen, if I am wrong.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>238216</attachid>
            <date>2014-09-16 15:31:03 -0700</date>
            <delta_ts>2014-09-19 17:06:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-136874-20140916163136.patch</filename>
            <type>text/plain</type>
            <size>1375</size>
            <attacher name="Alex Christensen">alex.christensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzY3MikKKysrIFNvdXJjZS9XZWJLaXQv
d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTE2
ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg
W1dpbkNhaXJvXSBCdWlsZCBmaXggd2hlbiBfX0JVSUxEX05VTUJFUl9TSE9SVF9fIGlzIG5vdCBk
ZWZpbmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTM2ODc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBXZWJLaXQucmVzb3VyY2VzL1dlYktpdC5yYzoKKyAgICAgICAgUmVtb3ZlZCByZWZlcmVuY2Ug
dG8gX19CVUlMRF9OVU1CRVJfU0hPUlRfXy4KKwogMjAxNC0wOS0wNiAgQnJpYW4gSi4gQnVyZyAg
PGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY29udmVy
dCBEb2NrU2lkZSB0byBhbiBlbnVtIGNsYXNzCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJL
aXQucmVzb3VyY2VzL1dlYktpdC5yYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9X
ZWJLaXQucmVzb3VyY2VzL1dlYktpdC5yYwkocmV2aXNpb24gMTczNjcwKQorKysgU291cmNlL1dl
YktpdC93aW4vV2ViS2l0LnJlc291cmNlcy9XZWJLaXQucmMJKHdvcmtpbmcgY29weSkKQEAgLTQw
LDEzICs0MCwzIEBAIElEUl9GU19WSURFT19BVURJT19WT0xVTUVfTE9XICAgIFBORwogSURSX0ZT
X1ZJREVPX0VYSVRfRlVMTFNDUkVFTiAgICAgUE5HICAgICAgICAgICAgICAgICAgICAgImZzVmlk
ZW9FeGl0RnVsbHNjcmVlbi5wbmciCiBJRFJfRlNfVklERU9fUEFVU0UgICAgICAgICAgICAgICBQ
TkcgICAgICAgICAgICAgICAgICAgICAiZnNWaWRlb1BhdXNlLnBuZyIKIElEUl9GU19WSURFT19Q
TEFZICAgICAgICAgICAgICAgIFBORyAgICAgICAgICAgICAgICAgICAgICJmc1ZpZGVvUGxheS5w
bmciCi0KLS8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCi0vLwotLy8gU1RSSU5HVEFCTEUKLS8vCi0KLVNU
UklOR1RBQkxFIAotQkVHSU4KLSAgICBCVUlMRF9OVU1CRVIgX19CVUlMRF9OVU1CRVJfU0hPUlRf
XwotRU5ECg==
</data>
<flag name="review"
          id="262981"
          type_id="1"
          status="-"
          setter="bfulgham"
    />
          </attachment>
      

    </bug>

</bugzilla>