136872 2014-09-16 15:01:07 -0700 [Mac] MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput doesn't work with rotated movies 2021-10-05 03:27:21 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=231225 InRadar P2 Normal --- 1 eric.carlson eric.carlson bfulgham jer.noble jonlee simon.fraser thorton oldest_to_newest 1035600 0 eric.carlson 2014-09-16 15:01:07 -0700 MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput doesn't consider a video track with a transform. 1035601 1 eric.carlson 2014-09-16 15:03:07 -0700 <rdar://problem/18187713> 1035602 2 238215 eric.carlson 2014-09-16 15:08:51 -0700 Created attachment 238215 Proposed patch. 1035615 3 bfulgham 2014-09-16 16:12:22 -0700 Committed r173677: <http://trac.webkit.org/changeset/173677> 1035617 4 bfulgham 2014-09-16 16:27:31 -0700 Committed r173678: <http://trac.webkit.org/changeset/173678> 238215 2014-09-16 15:08:51 -0700 2014-09-16 15:28:23 -0700 Proposed patch. patch_1.txt text/plain 3509 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzY3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTE2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIE1lZGlhUGxh eWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnBhaW50V2l0aFZpZGVvT3V0cHV0IGRvZXNuJ3Qg d29yayB3aXRoIHJvdGF0ZWQgbW92aWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzY4NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01l ZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpwYWludFdpdGhJbWFnZUdlbmVyYXRv cik6IEFkZCBsb2dnaW5nLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uT2JqQzo6cGFpbnRXaXRoVmlkZW9PdXRwdXQpOiBBcHBseSB0aGUgdmlkZW8gdHJh Y2sKKyAgICAgICAgICAgIHByZWZlcnJlZCB0cmFuc2Zvcm0uCisKIDIwMTQtMDktMTYgIEVucmlj YSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIEhUTUxDb252ZXJ0 ZXIgZnJvbSBlZGl0aW5nL2NvY29hIHRvIHBsYXRmb3JtL2NvY29hLgpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDLm1tCShyZXZpc2lvbiAxNzMzMTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b25PYmpDLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDAxLDYgKzE0MDEsOCBAQCB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQzo6cGFpbnRXaXRoSW1hZ2VHZW5lcmF0b3IoR3JhcGhpY3NDb250ZXh0 KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0KQogeworICAgIExPRyhNZWRpYSwgIk1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnBhaW50V2l0aEltYWdlR2VuZXJhdG9yKCVw KSIsIHRoaXMpOworCiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlID0gY3JlYXRlSW1h Z2VGb3JUaW1lSW5SZWN0KGN1cnJlbnRUaW1lKCksIHJlY3QpOwogICAgIGlmIChpbWFnZSkgewog ICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKmNvbnRleHQpOwpA QCAtMjAwMiwxOCArMjAwNCwyOCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6CiB7CiAgICAgdXBkYXRlTGFzdEltYWdlKCk7CiAKLSAgICBpZiAobV9sYXN0SW1hZ2Up IHsKLSAgICAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKCpjb250ZXh0 KTsKKyAgICBpZiAoIW1fbGFzdEltYWdlKQorICAgICAgICByZXR1cm47CiAKLSAgICAgICAgSW50 UmVjdCBpbWFnZVJlY3QoMCwgMCwgQ0dJbWFnZUdldFdpZHRoKG1fbGFzdEltYWdlLmdldCgpKSwg Q0dJbWFnZUdldEhlaWdodChtX2xhc3RJbWFnZS5nZXQoKSkpOworICAgIEFWQXNzZXRUcmFjayog Zmlyc3RFbmFibGVkVmlkZW9UcmFjayA9IGZpcnN0RW5hYmxlZFRyYWNrKFttX2F2QXNzZXQuZ2V0 KCkgdHJhY2tzV2l0aE1lZGlhQ2hhcmFjdGVyaXN0aWM6QVZNZWRpYUNoYXJhY3RlcmlzdGljVmlz dWFsXSk7CisgICAgaWYgKCFmaXJzdEVuYWJsZWRWaWRlb1RyYWNrKQorICAgICAgICByZXR1cm47 CiAKLSAgICAgICAgY29udGV4dC0+ZHJhd05hdGl2ZUltYWdlKG1fbGFzdEltYWdlLmdldCgpLCBp bWFnZVJlY3Quc2l6ZSgpLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBvdXRwdXRSZWN0LCBpbWFnZVJl Y3QpOworICAgIExPRyhNZWRpYSwgIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 OnBhaW50V2l0aFZpZGVvT3V0cHV0KCVwKSIsIHRoaXMpOworCisgICAgR3JhcGhpY3NDb250ZXh0 U3RhdGVTYXZlciBzdGF0ZVNhdmVyKCpjb250ZXh0KTsKKyAgICBGbG9hdFJlY3QgaW1hZ2VSZWN0 KDAsIDAsIENHSW1hZ2VHZXRXaWR0aChtX2xhc3RJbWFnZS5nZXQoKSksIENHSW1hZ2VHZXRIZWln aHQobV9sYXN0SW1hZ2UuZ2V0KCkpKTsKKyAgICBBZmZpbmVUcmFuc2Zvcm0gdmlkZW9UcmFuc2Zv cm0gPSBbZmlyc3RFbmFibGVkVmlkZW9UcmFjayBwcmVmZXJyZWRUcmFuc2Zvcm1dOworICAgIEZs b2F0UmVjdCB0cmFuc2Zvcm1lZE91dHB1dFJlY3QgPSB2aWRlb1RyYW5zZm9ybS5pbnZlcnNlKCku bWFwUmVjdChvdXRwdXRSZWN0KTsKKworICAgIGNvbnRleHQtPmNvbmNhdENUTSh2aWRlb1RyYW5z Zm9ybSk7CisgICAgY29udGV4dC0+ZHJhd05hdGl2ZUltYWdlKG1fbGFzdEltYWdlLmdldCgpLCBp bWFnZVJlY3Quc2l6ZSgpLCBDb2xvclNwYWNlRGV2aWNlUkdCLCB0cmFuc2Zvcm1lZE91dHB1dFJl Y3QsIGltYWdlUmVjdCk7CisKKyAgICAvLyBJZiB3ZSBoYXZlIGNyZWF0ZWQgYW4gQVZBc3NldElt YWdlR2VuZXJhdG9yIGluIHRoZSBwYXN0IGR1ZSB0byBtX3ZpZGVvT3V0cHV0IG5vdCBoYXZpbmcg YW4gYXZhaWxhYmxlCisgICAgLy8gdmlkZW8gZnJhbWUsIGRlc3Ryb3kgaXQgbm93IHRoYXQgaXQg aXMgbm8gbG9uZ2VyIG5lZWRlZC4KKyAgICBpZiAobV9pbWFnZUdlbmVyYXRvcikKKyAgICAgICAg ZGVzdHJveUltYWdlR2VuZXJhdG9yKCk7CiAKLSAgICAgICAgLy8gSWYgd2UgaGF2ZSBjcmVhdGVk IGFuIEFWQXNzZXRJbWFnZUdlbmVyYXRvciBpbiB0aGUgcGFzdCBkdWUgdG8gbV92aWRlb091dHB1 dCBub3QgaGF2aW5nIGFuIGF2YWlsYWJsZQotICAgICAgICAvLyB2aWRlbyBmcmFtZSwgZGVzdHJv eSBpdCBub3cgdGhhdCBpdCBpcyBubyBsb25nZXIgbmVlZGVkLgotICAgICAgICBpZiAobV9pbWFn ZUdlbmVyYXRvcikKLSAgICAgICAgICAgIGRlc3Ryb3lJbWFnZUdlbmVyYXRvcigpOwotICAgIH0K IH0KIAogUGFzc05hdGl2ZUltYWdlUHRyIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akM6Om5hdGl2ZUltYWdlRm9yQ3VycmVudFRpbWUoKQo=