136866 2014-09-16 13:36:51 -0700 Exclude page visibility from PageThrottler's hysteresis 2014-09-17 09:32:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 1035563 0 barraclough 2014-09-16 13:36:51 -0700 Including visibility in the hysteresis mechanism has the effect of prolonging the visually idle timeout, and causing the page hide event to be run at foreground priority. Neither of these are particularly desirable. Instead separate visibility from the rest of the page activities we track (and apply hysteresis to), and feed this directly into determination of the UserActivity state. 1035568 1 238205 barraclough 2014-09-16 13:43:37 -0700 Created attachment 238205 Fix 1035573 2 238205 ggaren 2014-09-16 13:51:56 -0700 Comment on attachment 238205 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=238205&action=review r=me > Source/WebCore/page/PageThrottler.cpp:78 > + // Allow throttling if there is no page activity, and the page is viibly idle. "visually" > Source/WebCore/platform/HysteresisActivity.h:37 > + Waiting, I wonder if "Waiting" would be clearer if it said what it was waiting for. Maybe "WaitingToStop" or "WillStop" "WillStopAfterDelay" or "WillStopSoon". 1035725 3 barraclough 2014-09-17 09:32:57 -0700 Committed revision 173693. 238205 2014-09-16 13:43:37 -0700 2014-09-16 13:51:55 -0700 Fix 136866.1.patch text/plain 6676 barraclough SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzY2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM4IEBACisyMDE0LTA5LTE2ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIEV4Y2x1ZGUgcGFn ZSB2aXNpYmlsaXR5IGZyb20gUGFnZVRocm90dGxlcidzIGh5c3RlcmVzaXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjg2NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY2x1ZGluZyB2aXNpYmlsaXR5 IGluIHRoZSBoeXN0ZXJlc2lzIG1lY2hhbmlzbSBoYXMgdGhlIGVmZmVjdCBvZiBwcm9sb25naW5n IHRoZSB2aXN1YWxseQorICAgICAgICBpZGxlIHRpbWVvdXQsIGFuZCBjYXVzaW5nIHRoZSBwYWdl IGhpZGUgZXZlbnQgdG8gYmUgcnVuIGF0IGZvcmVncm91bmQgcHJpb3JpdHkuIE5laXRoZXIgb2YK KyAgICAgICAgdGhlc2UgYXJlIHBhcnRpY3VsYXJseSBkZXNpcmFibGUuIEluc3RlYWQgc2VwYXJh dGUgdmlzaWJpbGl0eSBmcm9tIHRoZSByZXN0IG9mIHRoZSBwYWdlCisgICAgICAgIGFjdGl2aXRp ZXMgd2UgdHJhY2sgKGFuZCBhcHBseSBoeXN0ZXJlc2lzIHRvKSwgYW5kIGZlZWQgdGhpcyBkaXJl Y3RseSBpbnRvIGRldGVybWluYXRpb24KKyAgICAgICAgb2YgdGhlIFVzZXJBY3Rpdml0eSBzdGF0 ZS4KKworICAgICAgICAqIHBhZ2UvUGFnZVRocm90dGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQYWdlVGhyb3R0bGVyOjpQYWdlVGhyb3R0bGVyKToKKyAgICAgICAgICAgIC0gd2hlbiB0aGUg UGFnZVRocm90dGxlciBpcyBpbnN0YW50aWF0ZWQgY2FsbCB1cGRhdGVVc2VyQWN0aXZpdHkgdG8g c2V0IGluaXRpYWwgVXNlckFjdGl2aXR5LgorICAgICAgICAoV2ViQ29yZTo6UGFnZVRocm90dGxl cjo6aW5jcmVtZW50QWN0aXZpdHlDb3VudCk6CisgICAgICAgICAgICAtIHNpbXBsaWZpZWQgLSB3 aGVuIG1fYWN0aXZpdHlDb3VudCBiZWNvbWVzIG5vbi16ZXJvLCBzdGFydCBtX2h5c3RlcmVzaXMu CisgICAgICAgIChXZWJDb3JlOjpQYWdlVGhyb3R0bGVyOjpkZWNyZW1lbnRBY3Rpdml0eUNvdW50 KToKKyAgICAgICAgICAgIC0gc2ltcGxpZmllZCAtIHdoZW4gbV9hY3Rpdml0eUNvdW50IGJlY29t ZXMgemVybywgc3RvcCBtX2h5c3RlcmVzaXMuCisgICAgICAgIChXZWJDb3JlOjpQYWdlVGhyb3R0 bGVyOjp1cGRhdGVVc2VyQWN0aXZpdHkpOgorICAgICAgICAgICAgLSBlbmQgdGhlIFVzZXJBY3Rp dml0eSAoYWxsb3cgQXBwTmFwKSBpZiB2aXN1YWxseSBpZGxlIGFuZCBubyBwYWdlIGFjdGl2aXR5 IGlzIHRha2luZyBwbGFjZS4KKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VUaHJvdHRsZXI6OnNldFZp ZXdTdGF0ZSk6CisgICAgICAgICAgICAtIHdoZW4gdGhlIHZpc3VhbGx5IGlkbGUgc3RhdGUgY2hh bmdlZCBjYWxsIHVwZGF0ZVVzZXJBY3Rpdml0eSB0byB1cGRhdGUgdGhlIFVzZXJBY3Rpdml0eS4K KyAgICAgICAgKFdlYkNvcmU6OlBhZ2VUaHJvdHRsZXI6OnN0YXJ0ZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UGFnZVRocm90dGxlcjo6c3RvcHBlZCk6CisgICAgICAgICAgICAtIHdoZW4gdGhlIGh5 c3RlcmVzaXMgc3RhdGUgY2hhbmdlZCBjYWxsIHVwZGF0ZVVzZXJBY3Rpdml0eSB0byB1cGRhdGUg dGhlIFVzZXJBY3Rpdml0eS4KKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VUaHJvdHRsZXI6OnVwZGF0 ZUh5c3RlcmVzaXMpOiBEZWxldGVkLgorICAgICAgICAgICAgLSByZW1vdmVkOiBzaW1wbGlmaWVk IHRoZSBoeXN0ZXJlc2lzIHRyaWdnZXIsIHdlIG5vdyBpbmNvcnBvcmF0ZSB2aXN1YWxseSBpZGxl IHN0YXRlIGluIHVwZGF0ZVVzZXJBY3Rpdml0eS4KKyAgICAgICAgKiBwYWdlL1BhZ2VUaHJvdHRs ZXIuaDoKKyAgICAgICAgICAgIC0gcmVtb3ZlZCB1cGRhdGVIeXN0ZXJlc2lzLCBhZGRlZCB1cGRh dGVVc2VyQWN0aXZpdHkuCisgICAgICAgICogcGxhdGZvcm0vSHlzdGVyZXNpc0FjdGl2aXR5Lmg6 CisgICAgICAgIChXZWJDb3JlOjpIeXN0ZXJlc2lzQWN0aXZpdHk6OnN0YXRlKToKKyAgICAgICAg ICAgIC0gZGV0ZXJtaW5lIHRoZSBjdXJlbnQgc3RhdGUgb2YgdGhlIEh5c3RlcmVzaXNBY3Rpdml0 eSAtIHN0YXJ0ZWQsIHdhaXRpbmcsIG9yIHN0b3BwZWQuCisKIDIwMTQtMDktMTYgIHBlYXZvQG91 dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW0N1cmxdIFNvbWV0aW1l cyBpbmNvbXBsZXRlIG9yIGVtcHR5IGNvbnRlbnQgY2FuIGJlIGxvYWRlZCBmcm9tIGNhY2hlLgpJ bmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVGhyb3R0bGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VUaHJvdHRsZXIuY3BwCShyZXZpc2lvbiAxNzM0NzYp CisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VUaHJvdHRsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNiwxMiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBhZ2VU aHJvdHRsZXIuaCIKIAotI2luY2x1ZGUgIkNocm9tZS5oIgotI2luY2x1ZGUgIkNocm9tZUNsaWVu dC5oIgotI2luY2x1ZGUgIk1haW5GcmFtZS5oIgotI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRl ICJQYWdlQWN0aXZpdHlBc3NlcnRpb25Ub2tlbi5oIgotI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRy YXMuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00Myw4ICszOCw3IEBAIFBhZ2VUaHJv dHRsZXI6OlBhZ2VUaHJvdHRsZXIoUGFnZSYgcGFnZSwKICAgICAsIG1fYWN0aXZpdHkoIlBhZ2Ug aXMgYWN0aXZlLiIpCiAgICAgLCBtX2FjdGl2aXR5Q291bnQoMCkKIHsKLSAgICBpZiAoIShtX3Zp ZXdTdGF0ZSAmIFZpZXdTdGF0ZTo6SXNWaXN1YWxseUlkbGUpKQotICAgICAgICBtX2h5c3RlcmVz aXMuc3RhcnQoKTsKKyAgICB1cGRhdGVVc2VyQWN0aXZpdHkoKTsKIH0KIAogc3RkOjp1bmlxdWVf cHRyPFBhZ2VBY3Rpdml0eUFzc2VydGlvblRva2VuPiBQYWdlVGhyb3R0bGVyOjptZWRpYUFjdGl2 aXR5VG9rZW4oKQpAQCAtNTksMjIgKzUzLDMzIEBAIHN0ZDo6dW5pcXVlX3B0cjxQYWdlQWN0aXZp dHlBc3NlcnRpb25Ub2sKIAogdm9pZCBQYWdlVGhyb3R0bGVyOjppbmNyZW1lbnRBY3Rpdml0eUNv dW50KCkKIHsKLSAgICArK21fYWN0aXZpdHlDb3VudDsKLSAgICB1cGRhdGVIeXN0ZXJlc2lzKCk7 CisgICAgLy8gSWYgbV9hY3Rpdml0eUNvdW50IGlzIG5vbnplcm8sIHN0YXRlIG11c3QgYmUgU3Rh cnRlZDsgaWYgbV9hY3Rpdml0eUNvdW50IGlzIHplcm8sIHN0YXRlIG1heSBiZSBXYWl0aW5nIG9y IFN0b3BwZWQuCisgICAgQVNTRVJUKCEhbV9hY3Rpdml0eUNvdW50ID09IChtX2h5c3RlcmVzaXMu c3RhdGUoKSA9PSBIeXN0ZXJlc2lzU3RhdGU6OlN0YXJ0ZWQpKTsKKworICAgIGlmICghbV9hY3Rp dml0eUNvdW50KyspCisgICAgICAgIG1faHlzdGVyZXNpcy5zdGFydCgpOworCisgICAgQVNTRVJU KG1fYWN0aXZpdHlDb3VudCAmJiBtX2h5c3RlcmVzaXMuc3RhdGUoKSA9PSBIeXN0ZXJlc2lzU3Rh dGU6OlN0YXJ0ZWQpOwogfQogCiB2b2lkIFBhZ2VUaHJvdHRsZXI6OmRlY3JlbWVudEFjdGl2aXR5 Q291bnQoKQogewotICAgIC0tbV9hY3Rpdml0eUNvdW50OwotICAgIHVwZGF0ZUh5c3RlcmVzaXMo KTsKKyAgICBBU1NFUlQobV9hY3Rpdml0eUNvdW50ICYmIG1faHlzdGVyZXNpcy5zdGF0ZSgpID09 IEh5c3RlcmVzaXNTdGF0ZTo6U3RhcnRlZCk7CisKKyAgICBpZiAoIS0tbV9hY3Rpdml0eUNvdW50 KQorICAgICAgICBtX2h5c3RlcmVzaXMuc3RvcCgpOworCisgICAgLy8gSWYgbV9hY3Rpdml0eUNv dW50IGlzIG5vbnplcm8sIHN0YXRlIG11c3QgYmUgU3RhcnRlZDsgaWYgbV9hY3Rpdml0eUNvdW50 IGlzIHplcm8sIHN0YXRlIG1heSBiZSBXYWl0aW5nIG9yIFN0b3BwZWQuCisgICAgQVNTRVJUKCEh bV9hY3Rpdml0eUNvdW50ID09IChtX2h5c3RlcmVzaXMuc3RhdGUoKSA9PSBIeXN0ZXJlc2lzU3Rh dGU6OlN0YXJ0ZWQpKTsKIH0KIAotdm9pZCBQYWdlVGhyb3R0bGVyOjp1cGRhdGVIeXN0ZXJlc2lz KCkKK3ZvaWQgUGFnZVRocm90dGxlcjo6dXBkYXRlVXNlckFjdGl2aXR5KCkKIHsKLSAgICBpZiAo bV9hY3Rpdml0eUNvdW50IHx8ICEobV92aWV3U3RhdGUgJiBWaWV3U3RhdGU6OklzVmlzdWFsbHlJ ZGxlKSkKLSAgICAgICAgbV9oeXN0ZXJlc2lzLnN0YXJ0KCk7CisgICAgLy8gQWxsb3cgdGhyb3R0 bGluZyBpZiB0aGVyZSBpcyBubyBwYWdlIGFjdGl2aXR5LCBhbmQgdGhlIHBhZ2UgaXMgdmlpYmx5 IGlkbGUuCisgICAgaWYgKG1faHlzdGVyZXNpcy5zdGF0ZSgpID09IEh5c3RlcmVzaXNTdGF0ZTo6 U3RvcHBlZCAmJiBtX3ZpZXdTdGF0ZSAmIFZpZXdTdGF0ZTo6SXNWaXN1YWxseUlkbGUpCisgICAg ICAgIG1fYWN0aXZpdHkuZW5kQWN0aXZpdHkoKTsKICAgICBlbHNlCi0gICAgICAgIG1faHlzdGVy ZXNpcy5zdG9wKCk7CisgICAgICAgIG1fYWN0aXZpdHkuYmVnaW5BY3Rpdml0eSgpOwogfQogCiB2 b2lkIFBhZ2VUaHJvdHRsZXI6OnNldFZpZXdTdGF0ZShWaWV3U3RhdGU6OkZsYWdzIHZpZXdTdGF0 ZSkKQEAgLTgzLDE3ICs4OCwxNyBAQCB2b2lkIFBhZ2VUaHJvdHRsZXI6OnNldFZpZXdTdGF0ZShW aWV3U3RhCiAgICAgbV92aWV3U3RhdGUgPSB2aWV3U3RhdGU7CiAKICAgICBpZiAoY2hhbmdlZCAm IFZpZXdTdGF0ZTo6SXNWaXN1YWxseUlkbGUpCi0gICAgICAgIHVwZGF0ZUh5c3RlcmVzaXMoKTsK KyAgICAgICAgdXBkYXRlVXNlckFjdGl2aXR5KCk7CiB9CiAKIHZvaWQgUGFnZVRocm90dGxlcjo6 c3RhcnRlZCgpCiB7Ci0gICAgbV9hY3Rpdml0eS5iZWdpbkFjdGl2aXR5KCk7CisgICAgdXBkYXRl VXNlckFjdGl2aXR5KCk7CiB9CiAKIHZvaWQgUGFnZVRocm90dGxlcjo6c3RvcHBlZCgpCiB7Ci0g ICAgbV9hY3Rpdml0eS5lbmRBY3Rpdml0eSgpOworICAgIHVwZGF0ZVVzZXJBY3Rpdml0eSgpOwog fQogCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VUaHJvdHRsZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VUaHJvdHRsZXIuaAkocmV2aXNpb24gMTcz NDc2KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVGhyb3R0bGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTMwLDcgKzMwLDYgQEAKIAogI2luY2x1ZGUgIlVzZXJBY3Rpdml0eS5oIgogI2luY2x1 ZGUgIlZpZXdTdGF0ZS5oIgotI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3Rm L1dlYWtQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNTYsNyArNTUsNyBAQCBwcml2 YXRlOgogICAgIHZvaWQgaW5jcmVtZW50QWN0aXZpdHlDb3VudCgpOwogICAgIHZvaWQgZGVjcmVt ZW50QWN0aXZpdHlDb3VudCgpOwogCi0gICAgdm9pZCB1cGRhdGVIeXN0ZXJlc2lzKCk7CisgICAg dm9pZCB1cGRhdGVVc2VyQWN0aXZpdHkoKTsKIAogICAgIGZyaWVuZCBjbGFzcyBIeXN0ZXJlc2lz QWN0aXZpdHk8UGFnZVRocm90dGxlcj47CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzdGFydGVk KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9IeXN0ZXJlc2lzQWN0aXZpdHkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9IeXN0ZXJlc2lzQWN0aXZpdHku aAkocmV2aXNpb24gMTczNDc2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vSHlzdGVyZXNp c0FjdGl2aXR5LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDEyIEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogc3RhdGljIGNvbnN0IGRvdWJsZSBEZWZhdWx0SHlzdGVyZXNpc1NlY29uZHMg PSA1LjA7CiAKK2VudW0gY2xhc3MgSHlzdGVyZXNpc1N0YXRlIHsKKyAgICBTdGFydGVkLAorICAg IFdhaXRpbmcsCisgICAgU3RvcHBlZAorfTsKKwogdGVtcGxhdGU8dHlwZW5hbWUgRGVsZWdhdGU+ CiBjbGFzcyBIeXN0ZXJlc2lzQWN0aXZpdHkgewogcHVibGljOgpAQCAtNzIsNiArNzgsMTUgQEAg cHVibGljOgogICAgICAgICB9CiAgICAgfQogCisgICAgSHlzdGVyZXNpc1N0YXRlIHN0YXRlKCkg Y29uc3QKKyAgICB7CisgICAgICAgIGlmIChtX2FjdGl2ZSkKKyAgICAgICAgICAgIHJldHVybiBI eXN0ZXJlc2lzU3RhdGU6OlN0YXJ0ZWQ7CisgICAgICAgIGlmIChtX3RpbWVyLmlzQWN0aXZlKCkp CisgICAgICAgICAgICByZXR1cm4gSHlzdGVyZXNpc1N0YXRlOjpXYWl0aW5nOworICAgICAgICBy ZXR1cm4gSHlzdGVyZXNpc1N0YXRlOjpTdG9wcGVkOworICAgIH0KKyAgICAKIHByaXZhdGU6CiAg ICAgdm9pZCBoeXN0ZXJlc2lzVGltZXJGaXJlZChUaW1lcjxIeXN0ZXJlc2lzQWN0aXZpdHk+JikK ICAgICB7Cg==