136857 2014-09-16 07:29:47 -0700 [GTK] Minibrowser : Add keyboard support for stop page load 2014-09-23 02:26:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned commit-queue gustavo mrobinson pnormand oldest_to_newest 1035464 0 kumar.rohit 2014-09-16 07:29:47 -0700 Currently GTK Minibrowser support stop page load only using mouse click on stop load icon. Add keyboard support for stop page load using 'Escape' and 'F6' keys. 1035465 1 238180 kumar.rohit 2014-09-16 07:36:59 -0700 Created attachment 238180 Patch 1036666 2 238518 kumar.rohit 2014-09-23 00:11:20 -0700 Created attachment 238518 Patch 1036687 3 238518 commit-queue 2014-09-23 02:26:21 -0700 Comment on attachment 238518 Patch Clearing flags on attachment: 238518 Committed r173869: <http://trac.webkit.org/changeset/173869> 1036688 4 commit-queue 2014-09-23 02:26:24 -0700 All reviewed patches have been landed. Closing bug. 238180 2014-09-16 07:36:59 -0700 2014-09-23 00:11:08 -0700 Patch bug-136857-20140916200759.patch text/plain 2159 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjIwODQwOTFiZDdjMmVjNzlhYzQ4YzM2MmI1NzQ3Zjlk NjBmOTkyNC4uOTdmOGUyMDkxZTYwMTQ1N2RhYjIyOTcxYTRiM2UwZjk3ZjhiNTRjZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTA5LTE2ICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGtleWJvYXJkIHN1cHBvcnQgZm9yIHN0 b3AgcGFnZSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY4NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChzdG9wUGFn ZUxvYWQpOiBDYWxsYmFjayB0byBzdG9wIHBhZ2UgbG9hZC4KKyAgICAgICAgKGJyb3dzZXJfd2lu ZG93X2luaXQpOgorCiAyMDE0LTA5LTE2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBnYXJkZW5pbmcsIHNraXAgb25lIG1vcmUgdGVz dHMgb24gV2luZG93cy4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDI3 NTQ5MzE1MDBiNjQyNWY2NzlmOTU1MzMzMjAxZWVlMTFjMjAxMmMuLjVjOWZkZWVlNDEzZGRlOGE3 Y2M0ODc2NzFhZjc1OGJlZDY0NTk0NTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5k b3cuYwpAQCAtNTQwLDYgKzU0MCwxMSBAQCBzdGF0aWMgdm9pZCByZWxvYWRQYWdlSWdub3JpbmdD YWNoZShCcm93c2VyV2luZG93ICp3aW5kb3csIGdwb2ludGVyIHVzZXJfZGF0YSkKICAgICB3ZWJr aXRfd2ViX3ZpZXdfcmVsb2FkX2J5cGFzc19jYWNoZSh3aW5kb3ctPndlYlZpZXcpOwogfQogCitz dGF0aWMgdm9pZCBzdG9wUGFnZUxvYWQoQnJvd3NlcldpbmRvdyAqd2luZG93LCBncG9pbnRlciB1 c2VyX2RhdGEpCit7CisgICAgd2Via2l0X3dlYl92aWV3X3N0b3BfbG9hZGluZyh3aW5kb3ctPndl YlZpZXcpOworfQorCiBzdGF0aWMgdm9pZCBicm93c2VyV2luZG93RmluYWxpemUoR09iamVjdCAq Z09iamVjdCkKIHsKICAgICBCcm93c2VyV2luZG93ICp3aW5kb3cgPSBCUk9XU0VSX1dJTkRPVyhn T2JqZWN0KTsKQEAgLTYyNSw2ICs2MzAsMTIgQEAgc3RhdGljIHZvaWQgYnJvd3Nlcl93aW5kb3df aW5pdChCcm93c2VyV2luZG93ICp3aW5kb3cpCiAgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5lY3Qo d2luZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX1IsIEdES19DT05UUk9MX01BU0sgfCBHREtfU0hJ RlRfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCiAgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAo R19DQUxMQkFDSyhyZWxvYWRQYWdlSWdub3JpbmdDYWNoZSksIHdpbmRvdywgTlVMTCkpOwogCisg ICAgLyogU3RvcCBwYWdlIGxvYWQgKi8gCisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5lY3Qod2lu ZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX0Y2LCAwLCBHVEtfQUNDRUxfVklTSUJMRSwKKyAgICAg ICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKHN0b3BQYWdlTG9hZCksIHdpbmRvdywg TlVMTCkpOworICAgIGd0a19hY2NlbF9ncm91cF9jb25uZWN0KHdpbmRvdy0+YWNjZWxHcm91cCwg R0RLX0tFWV9Fc2NhcGUsIDAsIEdUS19BQ0NFTF9WSVNJQkxFLAorICAgICAgICBnX2NjbG9zdXJl X25ld19zd2FwKEdfQ0FMTEJBQ0soc3RvcFBhZ2VMb2FkKSwgd2luZG93LCBOVUxMKSk7CisKICAg ICBHdGtXaWRnZXQgKnRvb2xiYXIgPSBndGtfdG9vbGJhcl9uZXcoKTsKICAgICB3aW5kb3ctPnRv b2xiYXIgPSB0b29sYmFyOwogICAgIGd0a19vcmllbnRhYmxlX3NldF9vcmllbnRhdGlvbihHVEtf T1JJRU5UQUJMRSh0b29sYmFyKSwgR1RLX09SSUVOVEFUSU9OX0hPUklaT05UQUwpOwo= 238518 2014-09-23 00:11:20 -0700 2014-09-23 02:26:21 -0700 Patch bug-136857-20140923124221.patch text/plain 2356 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzE4YzU2NDQ3MzdmMDgwMWY1YmI5M2Y0OTgzZWZiZTk3 ZmEzMDM3OC4uYWVlNmJmNzczNTE5YTMzOTAzMzNjN2JhZTcxMzBlNTU2MmM0NDZmMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA5LTIzICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGtleWJvYXJkIHN1cHBvcnQgZm9yIHN0 b3AgcGFnZSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY4NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBLZXlib2FyZCBzdXBwb3J0IHRvIHN0b3AgcGFnZSBsb2FkIGluIEdUSyBNaW5pYnJvd3Nl ciB1c2luZyBGNiBhbmQgRXNjYXBlIGtleXMuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsv QnJvd3NlcldpbmRvdy5jOgorICAgICAgICAoc3RvcFBhZ2VMb2FkKTogQ2FsbGJhY2sgdG8gc3Rv cCBwYWdlIGxvYWQuCisgICAgICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKwogMjAxNC0wOS0y MiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gVGVzdCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2Nhbi1zaG93LW1pbWUtdHlwZSBmYWls cyBpZiBldmluY2UgYnJvd3NlciBwbHVnaW4gaXMgaW5zdGFsbGVkCmRpZmYgLS1naXQgYS9Ub29s cy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L0Jyb3dzZXJXaW5kb3cuYwppbmRleCAyNzU0OTMxNTAwYjY0MjVmNjc5Zjk1NTMzMzIwMWVlZTEx YzIwMTJjLi5kNjkyNDFlZWMwNzVkNmI3MjMxMjIyZGQ3N2EzOTdkNDU0ZWUzM2Q5IDEwMDY0NAot LS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01p bmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKQEAgLTU0MCw2ICs1NDAsMTIgQEAgc3RhdGlj IHZvaWQgcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGUoQnJvd3NlcldpbmRvdyAqd2luZG93LCBncG9p bnRlciB1c2VyX2RhdGEpCiAgICAgd2Via2l0X3dlYl92aWV3X3JlbG9hZF9ieXBhc3NfY2FjaGUo d2luZG93LT53ZWJWaWV3KTsKIH0KIAorc3RhdGljIHZvaWQgc3RvcFBhZ2VMb2FkKEJyb3dzZXJX aW5kb3cgKndpbmRvdywgZ3BvaW50ZXIgdXNlcl9kYXRhKQoreworICAgIGlmICh3ZWJraXRfd2Vi X3ZpZXdfaXNfbG9hZGluZyh3aW5kb3ctPndlYlZpZXcpKQorICAgICAgICB3ZWJraXRfd2ViX3Zp ZXdfc3RvcF9sb2FkaW5nKHdpbmRvdy0+d2ViVmlldyk7Cit9CisKIHN0YXRpYyB2b2lkIGJyb3dz ZXJXaW5kb3dGaW5hbGl6ZShHT2JqZWN0ICpnT2JqZWN0KQogewogICAgIEJyb3dzZXJXaW5kb3cg KndpbmRvdyA9IEJST1dTRVJfV0lORE9XKGdPYmplY3QpOwpAQCAtNjI1LDYgKzYzMSwxMiBAQCBz dGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndpbmRvdykKICAg ICBndGtfYWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfUiwg R0RLX0NPTlRST0xfTUFTSyB8IEdES19TSElGVF9NQVNLLCBHVEtfQUNDRUxfVklTSUJMRSwKICAg ICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKHJlbG9hZFBhZ2VJZ25vcmluZ0Nh Y2hlKSwgd2luZG93LCBOVUxMKSk7CiAKKyAgICAvKiBTdG9wIHBhZ2UgbG9hZCAqLyAKKyAgICBn dGtfYWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfRjYsIDAs IEdUS19BQ0NFTF9WSVNJQkxFLAorICAgICAgICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJB Q0soc3RvcFBhZ2VMb2FkKSwgd2luZG93LCBOVUxMKSk7CisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nv bm5lY3Qod2luZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX0VzY2FwZSwgMCwgR1RLX0FDQ0VMX1ZJ U0lCTEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAoR19DQUxMQkFDSyhzdG9wUGFnZUxv YWQpLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dpZGdldCAqdG9vbGJhciA9IGd0a190b29s YmFyX25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9IHRvb2xiYXI7CiAgICAgZ3RrX29yaWVu dGFibGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRBQkxFKHRvb2xiYXIpLCBHVEtfT1JJRU5U QVRJT05fSE9SSVpPTlRBTCk7Cg==