136856 2014-09-16 07:13:13 -0700 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II) 2014-09-18 10:15:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126604 131054 136125 1 ossy ossy commit-queue ggaren lforschler msaboff ossy rniwa oldest_to_newest 1035460 0 ossy 2014-09-16 07:13:13 -0700 The original failure count introduced in: https://trac.webkit.org/changeset/166608 https://trac.webkit.org/changeset/161461 And the http://trac.webkit.org/changeset/172829 tried to fixed the buggy failure counter, but it turned out it isn't enough, because the regexp should respect the 4 spaces at the beginning. 1035462 1 238179 ossy 2014-09-16 07:25:16 -0700 Created attachment 238179 Patch 1035463 2 commit-queue 2014-09-16 07:27:30 -0700 Attachment 238179 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157: [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:160: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:163: [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:178: [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:181: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:184: [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1035947 3 238179 commit-queue 2014-09-18 10:15:14 -0700 Comment on attachment 238179 Patch Clearing flags on attachment: 238179 Committed r173725: <http://trac.webkit.org/changeset/173725> 1035948 4 commit-queue 2014-09-18 10:15:20 -0700 All reviewed patches have been landed. Closing bug. 238179 2014-09-16 07:25:16 -0700 2014-09-18 10:15:12 -0700 Patch bug-136856-20140916162524.patch text/plain 4486 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjIwODQwOTFiZDdjMmVjNzlhYzQ4YzM2MmI1NzQ3Zjlk NjBmOTkyNC4uMzc5MDdiODE0ZTk1OTkwNTQ1NzMwOWRiNmUxMjBmNDc5Yzg0ZGFmYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDE0LTA5LTE2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgRml4IGNvdW50RmFpbHVyZXMgb2YgUnVuTExJTlRDTG9vcFRlc3RzIGFuZCBSdW4z MmJpdEpTQ1Rlc3RzIChJSSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNjg1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZzoKKyAgICAgICAgKFJ1bkxMSU5UQ0xvb3BUZXN0cy5jb3VudEZhaWx1cmVzKToKKyAg ICAgICAgKFJ1bjMyYml0SlNDVGVzdHMuY291bnRGYWlsdXJlcyk6CisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoUnVuTExJTlRDTG9vcFRlc3RzVGVzdC50ZXN0X2ZhaWx1cmVzKToKKyAgICAg ICAgKFJ1bkxMSU5UQ0xvb3BUZXN0c1Rlc3QudGVzdF9mYWlsdXJlKToKKyAgICAgICAgKFJ1bkxM SU5UQ0xvb3BUZXN0c1Rlc3QudGVzdF9ub19mYWlsdXJlKToKKyAgICAgICAgKFJ1bjMyYml0SlND VGVzdHNUZXN0LnRlc3RfZmFpbHVyZXMpOgorICAgICAgICAoUnVuMzJiaXRKU0NUZXN0c1Rlc3Qu dGVzdF9mYWlsdXJlKToKKyAgICAgICAgKFJ1bjMyYml0SlNDVGVzdHNUZXN0LnRlc3Rfbm9fZmFp bHVyZSk6CisKKzIwMTQtMDktMTYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9y Zz4KKwogICAgICAgICBVbnJldmlld2VkIGdhcmRlbmluZywgc2tpcCBvbmUgbW9yZSB0ZXN0cyBv biBXaW5kb3dzLgogCiAgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6 CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvbWFzdGVyLmNmZwppbmRleCAxODBjM2UwNjIyMzdiODY4YTg5NDQ0NmYxZDkxMjI4 ZDRhM2RmMzczLi5iNDNiNzQ1ODU5MTk3ZTMwM2RkZjMxYmE5ZDBjYmNmNzVhMWY4MjJkIDEwMDY0 NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9t YXN0ZXIuY2ZnCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKQEAgLTU1Miw3ICs1NTIsNyBAQCBjbGFzcyBSdW5MTElOVENMb29w VGVzdHMoVGVzdFdpdGhGYWlsdXJlQ291bnQpOgogICAgIGRlZiBjb3VudEZhaWx1cmVzKHNlbGYs IGNtZCk6CiAgICAgICAgIGxvZ1RleHQgPSBjbWQubG9nc1snc3RkaW8nXS5nZXRUZXh0KCkKICAg ICAgICAgIyBXZSdyZSBsb29raW5nIGZvciB0aGUgbGluZSB0aGF0IGxvb2tzIGxpa2UgdGhpczog MCByZWdyZXNzaW9ucyBmb3VuZC4KLSAgICAgICAgcmVnZXggPSByZS5jb21waWxlKHInKD9QPGNv dW50PlxkKykgcmVncmVzc2lvbnM/IGZvdW5kLicpCisgICAgICAgIHJlZ2V4ID0gcmUuY29tcGls ZShyJ1xzKig/UDxjb3VudD5cZCspIHJlZ3Jlc3Npb25zPyBmb3VuZC4nKQogICAgICAgICBmb3Ig bGluZSBpbiBsb2dUZXh0LnNwbGl0bGluZXMoKToKICAgICAgICAgICAgIG1hdGNoID0gcmVnZXgu bWF0Y2gobGluZSkKICAgICAgICAgICAgIGlmIG5vdCBtYXRjaDoKQEAgLTU3MSw3ICs1NzEsNyBA QCBjbGFzcyBSdW4zMmJpdEpTQ1Rlc3RzKFRlc3RXaXRoRmFpbHVyZUNvdW50KToKICAgICBkZWYg Y291bnRGYWlsdXJlcyhzZWxmLCBjbWQpOgogICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0 ZGlvJ10uZ2V0VGV4dCgpCiAgICAgICAgICMgV2UncmUgbG9va2luZyBmb3IgdGhlIGxpbmUgdGhh dCBsb29rcyBsaWtlIHRoaXM6IDAgZmFpbHVyZXMgZm91bmQuCi0gICAgICAgIHJlZ2V4ID0gcmUu Y29tcGlsZShyJyg/UDxjb3VudD5cZCspIGZhaWx1cmVzPyBmb3VuZC4nKQorICAgICAgICByZWdl eCA9IHJlLmNvbXBpbGUocidccyooP1A8Y291bnQ+XGQrKSBmYWlsdXJlcz8gZm91bmQuJykKICAg ICAgICAgZm9yIGxpbmUgaW4gbG9nVGV4dC5zcGxpdGxpbmVzKCk6CiAgICAgICAgICAgICBtYXRj aCA9IHJlZ2V4Lm1hdGNoKGxpbmUpCiAgICAgICAgICAgICBpZiBub3QgbWF0Y2g6CmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0 ZXJjZmdfdW5pdHRlc3QucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkKaW5kZXggY2MzNGI4NGIzOGNlOTk0ZGI0 NjQ4ZTZlZDllOTlhZDJmNjlkYzE2MS4uMDU4N2Y2OWFkNWE2YzNmZmM3Y2MzYmM0NGQxYmViMTFm NjMzZGMzZSAxMDA3NTUKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weQpAQCAt MTU0LDEzICsxNTQsMTMgQEAgY2xhc3MgUnVuTExJTlRDTG9vcFRlc3RzVGVzdCh1bml0dGVzdC5U ZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoYWN0dWFsX3RleHQsIGV4cGVjdGVk X3RleHQpCiAKICAgICBkZWYgdGVzdF9mYWlsdXJlcyhzZWxmKToKLSAgICAgICAgc2VsZi5hc3Nl cnRSZXN1bHRzKEZBSUxVUkUsIFsnNSByZWdyZXNzaW9ucyBmb3VuZC4nXSwgMSwgICc1IHJlZ3Jl c3Npb25zIGZvdW5kLicpCisgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhGQUlMVVJFLCBbJzUg cmVncmVzc2lvbnMgZm91bmQuJ10sIDEsICAnICAgIDUgcmVncmVzc2lvbnMgZm91bmQuJykKIAog ICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6Ci0gICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhG QUlMVVJFLCBbJzEgcmVncmVzc2lvbnMgZm91bmQuJ10sIDEsICAnMSByZWdyZXNzaW9uIGZvdW5k LicpCisgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhGQUlMVVJFLCBbJzEgcmVncmVzc2lvbnMg Zm91bmQuJ10sIDEsICAnICAgIDEgcmVncmVzc2lvbiBmb3VuZC4nKQogCiAgICAgZGVmIHRlc3Rf bm9fZmFpbHVyZShzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRSZXN1bHRzKFNVQ0NFU1MsIFsn d2Via2l0LWpzYy1jbG9vcC10ZXN0J10sIDAsICAnMCByZWdyZXNzaW9ucyBmb3VuZC4nKQorICAg ICAgICBzZWxmLmFzc2VydFJlc3VsdHMoU1VDQ0VTUywgWyd3ZWJraXQtanNjLWNsb29wLXRlc3Qn XSwgMCwgICcgICAgMCByZWdyZXNzaW9ucyBmb3VuZC4nKQogCiAKIGNsYXNzIFJ1bjMyYml0SlND VGVzdHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKQEAgLTE3NSwxMyArMTc1LDEzIEBAIGNsYXNz IFJ1bjMyYml0SlNDVGVzdHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChhY3R1YWxfdGV4dCwgZXhwZWN0ZWRfdGV4dCkKIAogICAgIGRlZiB0ZXN0X2Zh aWx1cmVzKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWyc1IHJl Z3Jlc3Npb25zIGZvdW5kLiddLCAxLCAgJzUgZmFpbHVyZXMgZm91bmQuJykKKyAgICAgICAgc2Vs Zi5hc3NlcnRSZXN1bHRzKEZBSUxVUkUsIFsnNSByZWdyZXNzaW9ucyBmb3VuZC4nXSwgMSwgICcg ICAgNSBmYWlsdXJlcyBmb3VuZC4nKQogCiAgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKLSAg ICAgICAgc2VsZi5hc3NlcnRSZXN1bHRzKEZBSUxVUkUsIFsnMSByZWdyZXNzaW9ucyBmb3VuZC4n XSwgMSwgICcxIGZhaWx1cmUgZm91bmQuJykKKyAgICAgICAgc2VsZi5hc3NlcnRSZXN1bHRzKEZB SUxVUkUsIFsnMSByZWdyZXNzaW9ucyBmb3VuZC4nXSwgMSwgICcgICAgMSBmYWlsdXJlIGZvdW5k LicpCiAKICAgICBkZWYgdGVzdF9ub19mYWlsdXJlKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2Vy dFJlc3VsdHMoU1VDQ0VTUywgWyd3ZWJraXQtMzJiaXQtanNjLXRlc3QnXSwgMCwgICcwIGZhaWx1 cmVzIGZvdW5kLicpCisgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhTVUNDRVNTLCBbJ3dlYmtp dC0zMmJpdC1qc2MtdGVzdCddLCAwLCAgJyAgICAwIGZhaWx1cmVzIGZvdW5kLicpCiAKIAogY2xh c3MgUnVuVW5pdFRlc3RzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6Cg==