136850 2014-09-16 03:18:07 -0700 W3C test importer should copy .htaccess files 2014-09-23 10:10:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf bjonesbe commit-queue glenn rhauck oldest_to_newest 1035435 0 youennf 2014-09-16 03:18:07 -0700 Currently W3C test import skip all files starting with '.' .htaccess is used to control serving files on HTTP and should be copied. 1035436 1 238171 youennf 2014-09-16 03:21:49 -0700 Created attachment 238171 Patch 1036558 2 238171 bjonesbe 2014-09-22 10:47:03 -0700 Comment on attachment 238171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238171&action=review > Tools/Scripts/webkitpy/w3c/test_importer.py:184 > if filename.startswith('.') or filename.endswith('.pl'): > - continue # For some reason the w3c repo contains random perl scripts we don't care about. > + if not filename == '.htaccess': > + continue # For some reason the w3c repo contains random perl scripts we don't care about. This is getting messy. I would add a helper like should_skip_file(), and move all of the tests there. Then this would be something like: if self.should_skip_file(filename): continue 1036671 3 238520 youennf 2014-09-23 01:09:37 -0700 Created attachment 238520 Added helper function 1036743 4 238520 bjonesbe 2014-09-23 09:34:14 -0700 Comment on attachment 238520 Added helper function r=me 1036749 5 238520 commit-queue 2014-09-23 10:10:44 -0700 Comment on attachment 238520 Added helper function Clearing flags on attachment: 238520 Committed r173876: <http://trac.webkit.org/changeset/173876> 1036750 6 commit-queue 2014-09-23 10:10:47 -0700 All reviewed patches have been landed. Closing bug. 238171 2014-09-16 03:21:49 -0700 2014-09-23 01:09:31 -0700 Patch bug-136850-20140916122145.patch text/plain 1593 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjAxYjEwMjM2OGU4YzVmZGE3NWZiZjI1NjQwOWYxYzJj NjVlZmFiNy4uM2FlOWQwZmIxNjIzM2M5YTlkMzY0ZTRjYzVkNDhhN2M4NTRhZGM5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA5LTE2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIGNvcHkgLmh0YWNjZXNzIGZp bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4 NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHk6CisgICAgICAgIChUZXN0SW1wb3J0 ZXIuZmluZF9pbXBvcnRhYmxlX3Rlc3RzKTogQWRkZWQgIi5odGFjY2VzcyIgZmlsZSBzcGVjaWZp YyB0ZXN0LgorCiAyMDE0LTA5LTEyICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9u LmVkdT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW1pbmQgYWJvdXQgcmViYXNlbGluaW5n IGdlbmVyYXRvciB0ZXN0IHJlc3VsdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0 X2ltcG9ydGVyLnB5CmluZGV4IGQwYTE5NDUxZTQ3YzNjNDg3NDA1NzY2NWRjNzQ4ZTIzZWUyODIy NmIuLjJjNzc2MGE5MWE1N2QzZmM5NzM0NmJjOTJiNGYyMGNjYzRiNGE2N2UgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtMTgwLDcgKzE4MCw4IEBA IGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICAgICAgICAgICMgRklYTUU6IFRo aXMgYmxvY2sgc2hvdWxkIHJlYWxseSBiZSBhIHNlcGFyYXRlIGZ1bmN0aW9uLCBidXQgdGhlIGVh cmx5LWNvbnRpbnVlcyBtYWtlIHRoYXQgZGlmZmljdWx0LgogCiAgICAgICAgICAgICAgICAgaWYg ZmlsZW5hbWUuc3RhcnRzd2l0aCgnLicpIG9yIGZpbGVuYW1lLmVuZHN3aXRoKCcucGwnKToKLSAg ICAgICAgICAgICAgICAgICAgY29udGludWUgICMgRm9yIHNvbWUgcmVhc29uIHRoZSB3M2MgcmVw byBjb250YWlucyByYW5kb20gcGVybCBzY3JpcHRzIHdlIGRvbid0IGNhcmUgYWJvdXQuCisgICAg ICAgICAgICAgICAgICAgIGlmIG5vdCBmaWxlbmFtZSA9PSAnLmh0YWNjZXNzJzoKKyAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlICAjIEZvciBzb21lIHJlYXNvbiB0aGUgdzNjIHJlcG8g Y29udGFpbnMgcmFuZG9tIHBlcmwgc2NyaXB0cyB3ZSBkb24ndCBjYXJlIGFib3V0LgogCiAgICAg ICAgICAgICAgICAgZnVsbHBhdGggPSBvcy5wYXRoLmpvaW4ocm9vdCwgZmlsZW5hbWUpCiAK 238520 2014-09-23 01:09:37 -0700 2014-09-23 10:10:44 -0700 Added helper function bug-136850-20140923100935.patch text/plain 2369 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzE4YzU2NDQ3MzdmMDgwMWY1YmI5M2Y0OTgzZWZiZTk3 ZmEzMDM3OC4uZjg5NTZjNGEwMjhhNGJjN2I5N2UyNDQ5N2Y0NDNmOWIzMDZlZTE2OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA5LTIzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIGNvcHkgLmh0YWNjZXNzIGZp bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4 NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHk6CisgICAgICAgIChUZXN0SW1wb3J0 ZXIuc2hvdWxkX3NraXBfZmlsZSk6IEhlbHBlciBmdW5jdGlvbiB0byBjaGVjayB3aGV0aGVyIHRv IHNraXAgZmlsZSBvciBub3QuIEFkZGVkICIuaHRhY2Nlc3MiIGZpbGUgc3BlY2lmaWMgY2hlY2su CisgICAgICAgIChUZXN0SW1wb3J0ZXIpOgorICAgICAgICAoVGVzdEltcG9ydGVyLmZpbmRfaW1w b3J0YWJsZV90ZXN0cyk6IE1ha2luZyB1c2Ugb2YgbmV3IGhlbHBlciBmdW5jdGlvbi4KKwogMjAx NC0wOS0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gVGVzdCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2Nhbi1zaG93LW1pbWUtdHlw ZSBmYWlscyBpZiBldmluY2UgYnJvd3NlciBwbHVnaW4gaXMgaW5zdGFsbGVkCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9ydGVyLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQppbmRleCBkMGExOTQ1MWU0N2MzYzQ4 NzQwNTc2NjVkYzc0OGUyM2VlMjgyMjZiLi42ZTc1ZWMwYjg1OWFkY2FkYWFjNzNlOTE2NjE5MzE0 OGI0Y2EwMWIzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2lt cG9ydGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIu cHkKQEAgLTE2NCw2ICsxNjQsMTQgQEAgY2xhc3MgVGVzdEltcG9ydGVyKG9iamVjdCk6CiAgICAg ICAgIHNob3VsZF9za2lwID0gc3ViZGlyLnN0YXJ0c3dpdGgoJy4nKSBvciAocm9vdCA9PSBzZWxm LnNvdXJjZV9kaXJlY3RvcnkgYW5kIHN1YmRpciBpbiBESVJTX1RPX1NLSVApCiAgICAgICAgIHJl dHVybiBub3Qgc2hvdWxkX3NraXAKIAorICAgIGRlZiBzaG91bGRfc2tpcF9maWxlKHNlbGYsIGZp bGVuYW1lKToKKyAgICAgICAgIyBGb3Igc29tZSByZWFzb24gdGhlIHczYyByZXBvIGNvbnRhaW5z IHJhbmRvbSBwZXJsIHNjcmlwdHMgd2UgZG9uJ3QgY2FyZSBhYm91dC4KKyAgICAgICAgaWYgZmls ZW5hbWUuZW5kc3dpdGgoJy5wbCcpOgorICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAg aWYgZmlsZW5hbWUuc3RhcnRzd2l0aCgnLicpOgorICAgICAgICAgICAgcmV0dXJuIG5vdCBmaWxl bmFtZSA9PSAnLmh0YWNjZXNzJworICAgICAgICByZXR1cm4gRmFsc2UKKwogICAgIGRlZiBmaW5k X2ltcG9ydGFibGVfdGVzdHMoc2VsZiwgZGlyZWN0b3J5KToKICAgICAgICAgIyBGSVhNRTogdXNl IGZpbGVzeXN0ZW0KICAgICAgICAgZm9yIHJvb3QsIGRpcnMsIGZpbGVzIGluIG9zLndhbGsoZGly ZWN0b3J5KToKQEAgLTE3OSw4ICsxODcsOCBAQCBjbGFzcyBUZXN0SW1wb3J0ZXIob2JqZWN0KToK ICAgICAgICAgICAgIGZvciBmaWxlbmFtZSBpbiBmaWxlczoKICAgICAgICAgICAgICAgICAjIEZJ WE1FOiBUaGlzIGJsb2NrIHNob3VsZCByZWFsbHkgYmUgYSBzZXBhcmF0ZSBmdW5jdGlvbiwgYnV0 IHRoZSBlYXJseS1jb250aW51ZXMgbWFrZSB0aGF0IGRpZmZpY3VsdC4KIAotICAgICAgICAgICAg ICAgIGlmIGZpbGVuYW1lLnN0YXJ0c3dpdGgoJy4nKSBvciBmaWxlbmFtZS5lbmRzd2l0aCgnLnBs Jyk6Ci0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlICAjIEZvciBzb21lIHJlYXNvbiB0aGUg dzNjIHJlcG8gY29udGFpbnMgcmFuZG9tIHBlcmwgc2NyaXB0cyB3ZSBkb24ndCBjYXJlIGFib3V0 LgorICAgICAgICAgICAgICAgIGlmIHNlbGYuc2hvdWxkX3NraXBfZmlsZShmaWxlbmFtZSk6Cisg ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKICAgICAgICAgICAgICAgICBmdWxscGF0aCA9 IG9zLnBhdGguam9pbihyb290LCBmaWxlbmFtZSkKIAo=