136842 2014-09-15 16:11:53 -0700 Un-inline the Node constructor 2014-09-15 18:15:50 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue darin oldest_to_newest 1035328 0 cdumez 2014-09-15 16:11:53 -0700 Un-inline the Node constructor as it does not seem to impact performance: http://dromaeo.com/?id=226992,226998 This reduces the stripped binary size by ~4Kb. 1035330 1 238145 cdumez 2014-09-15 16:14:04 -0700 Created attachment 238145 Patch 1035334 2 238145 benjamin 2014-09-15 16:48:32 -0700 Comment on attachment 238145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review > Source/WebCore/dom/Node.cpp:295 > + , m_parentNode(0) > + , m_treeScope(&document) > + , m_previous(0) > + , m_next(0) Let's take the opportunity to fix 0->nullptr. 1035338 3 238149 cdumez 2014-09-15 16:58:00 -0700 Created attachment 238149 Patch 1035339 4 238145 cdumez 2014-09-15 16:58:22 -0700 Comment on attachment 238145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review >> Source/WebCore/dom/Node.cpp:295 >> + , m_next(0) > > Let's take the opportunity to fix 0->nullptr. Done. 1035350 5 238149 commit-queue 2014-09-15 18:15:46 -0700 Comment on attachment 238149 Patch Clearing flags on attachment: 238149 Committed r173643: <http://trac.webkit.org/changeset/173643> 1035351 6 commit-queue 2014-09-15 18:15:50 -0700 All reviewed patches have been landed. Closing bug. 238145 2014-09-15 16:14:04 -0700 2014-09-15 16:58:22 -0700 Patch bug-136842-20140915161402.patch text/plain 2445 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTg0NTZmNjA5YzIyMTZh Y2FlZjg2MGRmMWFmNTk2ODc1ZDI4NTRmZi4uNjZkNWNkMWY0ZWViMmIwMmQ3OGZiNzRmODdmOTRh MGJlMWY5ODZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA5LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW4taW5saW5lIHRoZSBOb2Rl IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVbi1pbmxpbmUgdGhlIE5vZGUgY29uc3RydWN0b3IgYXMgaXQgZG9lcyBub3Qgc2VlbSB0 byBpbXBhY3QKKyAgICAgICAgcGVyZm9ybWFuY2UsIGJhc2VkIG9uIG15IHRlc3Rpbmc6CisgICAg ICAgIGh0dHA6Ly9kcm9tYWVvLmNvbS8/aWQ9MjI2OTkyLDIyNjk5OAorCisgICAgICAgIFRoaXMg cmVkdWNlcyB0aGUgc3RyaXBwZWQgYmluYXJ5IHNpemUgYnkgfjRLYi4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5o OgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6Tm9kZSk6IERlbGV0ZWQuCisgICAgICAgICogZG9t L05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6Tm9kZSk6CisKIDIwMTQtMDktMTUg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBs b2dpYyBmaXggZnJvbSByMTczNjMxLiBMb2dpYyBmb3IgaW5jbHVkZVNoYWRvd0RPTSB3YXMgcmV2 ZXJzZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDgyMWRkOGYzMDQ0MGM3NmMwNzQwNzkzYmEw NmYxNTRmYzdmYWU5MWUuLjA1YjIyNmQzYWVhZTY3YTRkODliYTYwZWUyMDk1ZGNiZWNkNTg5ZmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xNzI4LDIwICsxNzI4LDYgQEAgaW5saW5lIGJvb2wg Tm9kZTo6aXNEb2N1bWVudE5vZGUoKSBjb25zdAogICAgIHJldHVybiB0aGlzID09ICZkb2N1bWVu dCgpOwogfQogCi1pbmxpbmUgTm9kZTo6Tm9kZShEb2N1bWVudCYgZG9jdW1lbnQsIENvbnN0cnVj dGlvblR5cGUgdHlwZSkKLSAgICA6IG1fbm9kZUZsYWdzKHR5cGUpCi0gICAgLCBtX3BhcmVudE5v ZGUoMCkKLSAgICAsIG1fdHJlZVNjb3BlKCZkb2N1bWVudCkKLSAgICAsIG1fcHJldmlvdXMoMCkK LSAgICAsIG1fbmV4dCgwKQotewotICAgIGRvY3VtZW50LmluY3JlbWVudFJlZmVyZW5jaW5nTm9k ZUNvdW50KCk7Ci0KLSNpZiAhZGVmaW5lZChOREVCVUcpIHx8IChkZWZpbmVkKERVTVBfTk9ERV9T VEFUSVNUSUNTKSAmJiBEVU1QX05PREVfU1RBVElTVElDUykKLSAgICB0cmFja0ZvckRlYnVnZ2lu ZygpOwotI2VuZGlmCi19Ci0KIGlubGluZSBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBOb2RlOjpz Y3JpcHRFeGVjdXRpb25Db250ZXh0KCkgY29uc3QKIHsKICAgICByZXR1cm4gJmRvY3VtZW50KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vTm9kZS5jcHAKaW5kZXggNmUwOGY3MzZiNmIyNDMyOWRjYTZjZTJjNjk5MTNkNzZjMGQy ZWI0NS4uYjQ0YjY5Njc3NGZlNjBhY2ZhZDY4OWJlNTRiODE3MWQ1NzlhNjk4OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmNwcApAQCAtMjg3LDYgKzI4NywyMCBAQCB2b2lkIE5vZGU6OnRyYWNrRm9yRGVidWdnaW5n KCkKICNlbmRpZgogfQogCitOb2RlOjpOb2RlKERvY3VtZW50JiBkb2N1bWVudCwgQ29uc3RydWN0 aW9uVHlwZSB0eXBlKQorICAgIDogbV9ub2RlRmxhZ3ModHlwZSkKKyAgICAsIG1fcGFyZW50Tm9k ZSgwKQorICAgICwgbV90cmVlU2NvcGUoJmRvY3VtZW50KQorICAgICwgbV9wcmV2aW91cygwKQor ICAgICwgbV9uZXh0KDApCit7CisgICAgZG9jdW1lbnQuaW5jcmVtZW50UmVmZXJlbmNpbmdOb2Rl Q291bnQoKTsKKworI2lmICFkZWZpbmVkKE5ERUJVRykgfHwgKGRlZmluZWQoRFVNUF9OT0RFX1NU QVRJU1RJQ1MpICYmIERVTVBfTk9ERV9TVEFUSVNUSUNTKQorICAgIHRyYWNrRm9yRGVidWdnaW5n KCk7CisjZW5kaWYKK30KKwogTm9kZTo6fk5vZGUoKQogewogI2lmbmRlZiBOREVCVUcK 238149 2014-09-15 16:58:00 -0700 2014-09-15 18:15:46 -0700 Patch bug-136842-20140915165757.patch text/plain 2411 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ4YjQ5NDExNzY5MjMw MDA1NTc3ZjMyYzQ0YTljYzNmNWM0MGZiZi4uNGYzYTY1ODMzNzk1MzNhY2VhN2YyYzUzZjM4YTBk NzJmZTM0N2ZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA5LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW4taW5saW5lIHRoZSBOb2Rl IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQb3VsYWluLgorCisg ICAgICAgIFVuLWlubGluZSB0aGUgTm9kZSBjb25zdHJ1Y3RvciBhcyBpdCBkb2VzIG5vdCBzZWVt IHRvIGltcGFjdAorICAgICAgICBwZXJmb3JtYW5jZSwgYmFzZWQgb24gbXkgdGVzdGluZzoKKyAg ICAgICAgaHR0cDovL2Ryb21hZW8uY29tLz9pZD0yMjY5OTIsMjI2OTk4CisKKyAgICAgICAgVGhp cyByZWR1Y2VzIHRoZSBzdHJpcHBlZCBiaW5hcnkgc2l6ZSBieSB+NEtiLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZG9tL0RvY3VtZW50 Lmg6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpOb2RlKTogRGVsZXRlZC4KKyAgICAgICAgKiBk b20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpOb2RlKToKKwogMjAxNC0wOS0x NSAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIE5hbWlu ZyBjbGVhbi11cC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggODIxZGQ4ZjMwNDQwYzc2YzA3NDA3 OTNiYTA2ZjE1NGZjN2ZhZTkxZS4uMDViMjI2ZDNhZWFlNjdhNGQ4OWJhNjBlZTIwOTVkY2JlY2Q1 ODlmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTE3MjgsMjAgKzE3MjgsNiBAQCBpbmxpbmUg Ym9vbCBOb2RlOjppc0RvY3VtZW50Tm9kZSgpIGNvbnN0CiAgICAgcmV0dXJuIHRoaXMgPT0gJmRv Y3VtZW50KCk7CiB9CiAKLWlubGluZSBOb2RlOjpOb2RlKERvY3VtZW50JiBkb2N1bWVudCwgQ29u c3RydWN0aW9uVHlwZSB0eXBlKQotICAgIDogbV9ub2RlRmxhZ3ModHlwZSkKLSAgICAsIG1fcGFy ZW50Tm9kZSgwKQotICAgICwgbV90cmVlU2NvcGUoJmRvY3VtZW50KQotICAgICwgbV9wcmV2aW91 cygwKQotICAgICwgbV9uZXh0KDApCi17Ci0gICAgZG9jdW1lbnQuaW5jcmVtZW50UmVmZXJlbmNp bmdOb2RlQ291bnQoKTsKLQotI2lmICFkZWZpbmVkKE5ERUJVRykgfHwgKGRlZmluZWQoRFVNUF9O T0RFX1NUQVRJU1RJQ1MpICYmIERVTVBfTk9ERV9TVEFUSVNUSUNTKQotICAgIHRyYWNrRm9yRGVi dWdnaW5nKCk7Ci0jZW5kaWYKLX0KLQogaW5saW5lIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIE5v ZGU6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdAogewogICAgIHJldHVybiAmZG9jdW1l bnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCA2ZTA4ZjczNmI2YjI0MzI5ZGNhNmNlMmM2OTkxM2Q3 NmMwZDJlYjQ1Li43ODBjNjVkOTNiMTlkNmFlMTE5NDFkMDJjYzk1MjU0ZDFmZWNkNzdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL05vZGUuY3BwCkBAIC0yODcsNiArMjg3LDIwIEBAIHZvaWQgTm9kZTo6dHJhY2tGb3JEZWJ1 Z2dpbmcoKQogI2VuZGlmCiB9CiAKK05vZGU6Ok5vZGUoRG9jdW1lbnQmIGRvY3VtZW50LCBDb25z dHJ1Y3Rpb25UeXBlIHR5cGUpCisgICAgOiBtX25vZGVGbGFncyh0eXBlKQorICAgICwgbV9wYXJl bnROb2RlKG51bGxwdHIpCisgICAgLCBtX3RyZWVTY29wZSgmZG9jdW1lbnQpCisgICAgLCBtX3By ZXZpb3VzKG51bGxwdHIpCisgICAgLCBtX25leHQobnVsbHB0cikKK3sKKyAgICBkb2N1bWVudC5p bmNyZW1lbnRSZWZlcmVuY2luZ05vZGVDb3VudCgpOworCisjaWYgIWRlZmluZWQoTkRFQlVHKSB8 fCAoZGVmaW5lZChEVU1QX05PREVfU1RBVElTVElDUykgJiYgRFVNUF9OT0RFX1NUQVRJU1RJQ1Mp CisgICAgdHJhY2tGb3JEZWJ1Z2dpbmcoKTsKKyNlbmRpZgorfQorCiBOb2RlOjp+Tm9kZSgpCiB7 CiAjaWZuZGVmIE5ERUJVRwo=