136822 2014-09-15 05:56:14 -0700 [EFL] Ecore and Eina are initialized twice in TestWebKitAPI 2014-09-15 07:45:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 135606 1 g.czajkowski g.czajkowski commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1035235 0 g.czajkowski 2014-09-15 05:56:14 -0700 In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily initialized as we already does it in PlatformWebView::PlatformWebView calling ewk_init(). The reason for that was to ensure testing for example, WTF where creating the view is not mandatory. Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp in order to properly initalize and release EWebKit. 1035236 1 238123 g.czajkowski 2014-09-15 05:57:35 -0700 Created attachment 238123 Patch 1035241 2 238123 gyuyoung.kim 2014-09-15 07:08:58 -0700 Comment on attachment 238123 Patch LGTM. r=me. 1035248 3 238123 commit-queue 2014-09-15 07:45:40 -0700 Comment on attachment 238123 Patch Clearing flags on attachment: 238123 Committed r173621: <http://trac.webkit.org/changeset/173621> 1035249 4 commit-queue 2014-09-15 07:45:44 -0700 All reviewed patches have been landed. Closing bug. 238123 2014-09-15 05:57:35 -0700 2014-09-15 07:45:40 -0700 Patch bug-136822-20140915145731.patch text/plain 3822 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjAxYjEwMjM2OGU4YzVmZGE3NWZiZjI1NjQwOWYxYzJj NjVlZmFiNy4uNjllNzUwM2YxYjk3OTBmOWI4ZmQxZjg5ZjQ3MDk5MzI4NTVhNzIyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE0LTA5LTE1ICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIEVjb3JlIGFuZCBFaW5hIGFyZSBpbml0aWFsaXplZCB0 d2ljZSBpbiBUZXN0V2ViS2l0QVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzY4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbiBUZXN0V2ViS2l0QVBJL2VmbC9tYWluLmNwcCwgZWNvcmUgYW5kIGVp bmEgbW9kdWxlcyBhcmUgdW5uZWNlc3NhcmlseQorICAgICAgICBpbml0aWFsaXplZCBhcyB3ZSBh bHJlYWR5IGRvZXMgaXQgaW4gUGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcKKyAgICAg ICAgY2FsbGluZyBld2tfaW5pdCgpLiBUaGUgcmVhc29uIGZvciB0aGF0IHdhcyB0byBlbnN1cmUg dGVzdGluZyBmb3IgZXhhbXBsZSwKKyAgICAgICAgV1RGIHdoZXJlIGNyZWF0aW5nIHRoZSB2aWV3 IGlzIG5vdCBtYW5kYXRvcnkuCisKKyAgICAgICAgQ2FsbCBld2tfaW5pdCgpIGFuZCBld2tfc2h1 dGRvd24oKSBpbiBUZXN0V2ViS2l0QVBJL2VmbC9tYWluLmNwcAorICAgICAgICBpbiBvcmRlciB0 byBwcm9wZXJseSBpbml0YWxpemUgYW5kIHJlbGVhc2UgRVdlYktpdC4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2U6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9l ZmwvUGxhdGZvcm1XZWJWaWV3LmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlBsYXRmb3Jt V2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlBsYXRm b3JtV2ViVmlldzo6flBsYXRmb3JtV2ViVmlldyk6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9l ZmwvbWFpbi5jcHA6CisgICAgICAgIChtYWluKToKKwogMjAxNC0wOS0xMiAgQnJpYW4gSi4gQnVy ZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVt aW5kIGFib3V0IHJlYmFzZWxpbmluZyBnZW5lcmF0b3IgdGVzdCByZXN1bHRzCmRpZmYgLS1naXQg YS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNtYWtlIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCBlN2E5MmNlMDk3ZDJjMDViMmIyYTIwYWE4NjE1 YTgyOTAyOWQzOTJlLi5iMWE2ZTBlZDlhZDI0N2U4ODU1OTllMDRhOTM1ZDQwZDA1NDAwMjI2IDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTM2LDkgKzM2LDE2IEBAIHNl dCh3ZWJraXQyX2FwaV9oYXJuZXNzX1NPVVJDRVMKICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9l ZmwvUGxhdGZvcm1XZWJWaWV3LmNwcAogKQogCitsaXN0KEFQUEVORCB0ZXN0X3d0Zl9MSUJSQVJJ RVMKKyAgICBXZWJLaXQyCispCisKK2xpc3QoQVBQRU5EIHRlc3Rfd2ViY29yZV9MSUJSQVJJRVMK KyAgICBXZWJLaXQyCispCisKIGxpc3QoQVBQRU5EIFRlc3RKYXZhU2NyaXB0Q29yZV9MSUJSQVJJ RVMKLSAgICAke0VDT1JFX0xJQlJBUklFU30KLSAgICAke0VJTkFfTElCUkFSSUVTfQorICAgIFdl YktpdDIKICkKIAogIyBUaGUgbGlzdCBiZWxvdyB3b3JrcyBsaWtlIGEgdGVzdCBleHBlY3RhdGlv bi4gVGVzdHMgaW4gdGhlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2VmbC9QbGF0 Zm9ybVdlYlZpZXcuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3 LmNwcAppbmRleCBjYmVjNDJkYTdhYWVmZmI1OGMxZDRlM2NkYTYxM2VhYjEzZjg5MDM2Li41NGRh YWQ4NDg5Mjg0MDFiNmY0YjJiZWQyOTAyNmM4ODg2ZWI5NWI3IDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0V2ViS2l0QVBJL2VmbC9QbGF0Zm9ybVdlYlZpZXcuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvZWZsL1BsYXRmb3JtV2ViVmlldy5jcHAKQEAgLTY2LDcgKzY2LDYgQEAgc3RhdGljIHZv aWQgb25XZWJQcm9jZXNzQ3Jhc2hlZCh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiBldmVudElu Zm8pCiAKIFBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLQ29udGV4dFJlZiBjb250 ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYpCiB7Ci0gICAgZXdrX2luaXQoKTsK ICAgICBtX3dpbmRvdyA9IGNyZWF0ZUVjb3JlRXZhcygpOwogCiAgICAgbV92aWV3ID0gRVdLVmll d0NyZWF0ZShjb250ZXh0UmVmLCBwYWdlR3JvdXBSZWYsIGVjb3JlX2V2YXNfZ2V0KG1fd2luZG93 KSwgLyogc21hcnQgKi8gMCk7CkBAIC04Myw3ICs4Miw2IEBAIFBsYXRmb3JtV2ViVmlldzo6flBs YXRmb3JtV2ViVmlldygpCiAgICAgZXZhc19vYmplY3RfZGVsKG1fdmlldyk7CiAKICAgICBlY29y ZV9ldmFzX2ZyZWUobV93aW5kb3cpOwotICAgIGV3a19zaHV0ZG93bigpOwogfQogCiB2b2lkIFBs YXRmb3JtV2ViVmlldzo6cmVzaXplVG8odW5zaWduZWQgd2lkdGgsIHVuc2lnbmVkIGhlaWdodCkK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZWZsL21haW4uY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9lZmwvbWFpbi5jcHAKaW5kZXggODkwZTNjNjZhZGViMzU3OWY5ZjQzMTA1MjJm NDAxYTliZDUwYTU1Ny4uZmMyOWIxZTBlMzliZjkzYmEyZWYwNTRkYjc4NTFkMjNhMzI2YzE2MSAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9lZmwvbWFpbi5jcHAKKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9lZmwvbWFpbi5jcHAKQEAgLTI2LDkgKzI2LDggQEAKIAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIlRlc3RzQ29udHJvbGxlci5oIgotI2luY2x1ZGUgPEVjb3Jl Lmg+Ci0jaW5jbHVkZSA8RWluYS5oPgogI2luY2x1ZGUgPGdldG9wdC5oPgorI2luY2x1ZGUgPEVX ZWJLaXQyLmg+CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KIAogYm9vbCB1c2VYMTFXaW5k b3cgPSBmYWxzZTsKQEAgLTUyLDE4ICs1MSwxNCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioq IGFyZ3YpCiAgICAgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFjZU9uQ3Jhc2hIb29rKCk7CiAgICAg c2V0ZW52KCJXRUJLSVRfRVhFQ19QQVRIIiwgV0VCS0lUX0VYRUNfUEFUSCwgZmFsc2UpOwogCi0g ICAgaWYgKCFlaW5hX2luaXQoKSkKLSAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKLQotICAg IGlmICghZWNvcmVfaW5pdCgpKQorICAgIGlmICghZXdrX2luaXQoKSkKICAgICAgICAgcmV0dXJu IEVYSVRfRkFJTFVSRTsKIAogICAgIHVzZVgxMVdpbmRvdyA9IGNoZWNrRm9yVXNlWDExV2luZG93 QXJndW1lbnQoYXJnYywgYXJndik7CiAKICAgICBpbnQgcmV0dXJuQ29kZSA9IFRlc3RXZWJLaXRB UEk6OlRlc3RzQ29udHJvbGxlcjo6c2hhcmVkKCkucnVuKGFyZ2MsIGFyZ3YpID8gRVhJVF9TVUND RVNTIDogRVhJVF9GQUlMVVJFOwogCi0gICAgZWNvcmVfc2h1dGRvd24oKTsKLSAgICBlaW5hX3No dXRkb3duKCk7CisgICAgZXdrX3NodXRkb3duKCk7CiAKICAgICByZXR1cm4gcmV0dXJuQ29kZTsK IH0K