136821 2014-09-15 05:31:59 -0700 Remove ORWT related crufts from webkitdirs.pm 2014-09-15 20:50:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mtiborinf webkit-unassigned benjamin commit-queue gyuyoung.kim ossy oldest_to_newest 1035231 0 mtiborinf 2014-09-15 05:31:59 -0700 old-run-webkit-tests was removed from trunk by http://trac.webkit.org/changeset/171967, so we can remove ORWT related crufts from webkitdirs.pm. 1035232 1 238122 mtiborinf 2014-09-15 05:34:37 -0700 Created attachment 238122 Patch This patch will removed ORWT related crufts from webkitdirs.pm. 1035372 2 238122 ap 2014-09-15 20:13:13 -0700 Comment on attachment 238122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238122&action=review r=me assuming that webkitperl tests passed (test-webkitperl). EWS doesn't run these. > Tools/Scripts/webkitdirs.pm:-1184 > -sub isPerianInstalled() Interesting - there was recently a conjecture that tests fail on some machines because of Perian. Perhaps we should start checking for it in nrwt. 1035377 3 238122 commit-queue 2014-09-15 20:50:22 -0700 Comment on attachment 238122 Patch Clearing flags on attachment: 238122 Committed r173647: <http://trac.webkit.org/changeset/173647> 1035378 4 commit-queue 2014-09-15 20:50:25 -0700 All reviewed patches have been landed. Closing bug. 238122 2014-09-15 05:34:37 -0700 2014-09-15 20:50:21 -0700 Patch patch_v2.patch text/plain 2887 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYWI5 NDRlLi45ZjEwZTFhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDktMTUgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIE9S V1QgcmVsYXRlZCBjcnVmdHMgZnJvbSB3ZWJraXRkaXJzLnBtCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4MjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg ICAgICAgKGlzUGVyaWFuSW5zdGFsbGVkKTogRGVsZXRlZC4KKyAgICAgICAgKGRldGVybWluZUlQ aG9uZVNpbXVsYXRvclZlcnNpb24pOiBEZWxldGVkLgorICAgICAgICAoaVBob25lU2ltdWxhdG9y VmVyc2lvbik6IERlbGV0ZWQuCisgICAgICAgIChpc1Nub3dMZW9wYXJkKTogRGVsZXRlZC4KKyAg ICAgICAgKGlzTGlvbik6IERlbGV0ZWQuCisgICAgICAgIChxdWl0SU9TU2ltdWxhdG9yKTogRGVs ZXRlZC4KKwogMjAxNC0wOS0xNSAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNv bT4KIAogICAgICAgICBbV2luQ2Fpcm9dIE1ha2UgaXQgZWFzaWVyIHRvIGVuYWJsZS9kaXNhYmxl IEdTdHJlYW1lci4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCAwZjMwMWY1Li44OTgwZTNiIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC0xMDEsNyArMTAxLDYgQEAgbXkgJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGly OwogbXkgJHNvdXJjZURpcjsKIG15ICRjdXJyZW50U1ZOUmV2aXNpb247CiBteSAkZGVidWdnZXI7 Ci1teSAkaVBob25lU2ltdWxhdG9yVmVyc2lvbjsKIG15ICRkaWRMb2FkSVBob25lU2ltdWxhdG9y Tm90aWZpY2F0aW9uOwogbXkgJG5tUGF0aDsKIG15ICRvc1hWZXJzaW9uOwpAQCAtMTE4MSw0OCAr MTE4MCw2IEBAIHN1YiBpc0lPU1dlYktpdCgpCiAgICAgcmV0dXJuIGlzQXBwbGVNYWNXZWJLaXQo KSAmJiAod2lsbFVzZUlPU0RldmljZVNES1doZW5CdWlsZGluZygpIHx8IHdpbGxVc2VJT1NTaW11 bGF0b3JTREtXaGVuQnVpbGRpbmcoKSk7CiB9CiAKLXN1YiBpc1Blcmlhbkluc3RhbGxlZCgpCi17 Ci0gICAgaWYgKCFpc0FwcGxlV2ViS2l0KCkpIHsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQot Ci0gICAgaWYgKC1kICIvTGlicmFyeS9RdWlja1RpbWUvUGVyaWFuLmNvbXBvbmVudCIpIHsKLSAg ICAgICAgcmV0dXJuIDE7Ci0gICAgfQotCi0gICAgaWYgKC1kICIkRU5We0hPTUV9L0xpYnJhcnkv UXVpY2tUaW1lL1Blcmlhbi5jb21wb25lbnQiKSB7Ci0gICAgICAgIHJldHVybiAxOwotICAgIH0K LQotICAgIHJldHVybiAwOwotfQotCi1zdWIgZGV0ZXJtaW5lSVBob25lU2ltdWxhdG9yVmVyc2lv bigpCi17Ci0gICAgcmV0dXJuIGlmICRpUGhvbmVTaW11bGF0b3JWZXJzaW9uOwotCi0gICAgaWYg KCFpc0lPU1dlYktpdCgpKSB7Ci0gICAgICAgICRpUGhvbmVTaW11bGF0b3JWZXJzaW9uID0gLTE7 Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBteSAkdmVyc2lvbiA9IGAvdXNyL2xvY2Fs L2Jpbi9wc3dfdmVycyAtcHJvZHVjdFZlcnNpb25gOwotICAgIG15IEBzcGxpdFZlcnNpb24gPSBz cGxpdCgvXC4vLCAkdmVyc2lvbik7Ci0gICAgQHNwbGl0VmVyc2lvbiA+PSAyIG9yIGRpZSAiSW52 YWxpZCB2ZXJzaW9uICR2ZXJzaW9uIjsKLSAgICAkaVBob25lU2ltdWxhdG9yVmVyc2lvbiA9IHsK LSAgICAgICAgICAgICJtYWpvciIgPT4gJHNwbGl0VmVyc2lvblswXSwKLSAgICAgICAgICAgICJt aW5vciIgPT4gJHNwbGl0VmVyc2lvblsxXSwKLSAgICAgICAgICAgICJzdWJtaW5vciIgPT4gZGVm aW5lZCgkc3BsaXRWZXJzaW9uWzJdID8gJHNwbGl0VmVyc2lvblsyXSA6IDApLAotICAgIH07Ci19 Ci0KLXN1YiBpUGhvbmVTaW11bGF0b3JWZXJzaW9uKCkKLXsKLSAgICBkZXRlcm1pbmVJUGhvbmVT aW11bGF0b3JWZXJzaW9uKCk7Ci0gICAgcmV0dXJuICRpUGhvbmVTaW11bGF0b3JWZXJzaW9uOwot fQotCiBzdWIgZGV0ZXJtaW5lTm1QYXRoKCkKIHsKICAgICByZXR1cm4gaWYgJG5tUGF0aDsKQEAg LTEyNjUsMTYgKzEyMjIsNiBAQCBzdWIgb3NYVmVyc2lvbigpCiAgICAgcmV0dXJuICRvc1hWZXJz aW9uOwogfQogCi1zdWIgaXNTbm93TGVvcGFyZCgpCi17Ci0gICAgcmV0dXJuIGlzRGFyd2luKCkg JiYgb3NYVmVyc2lvbigpLT57Im1pbm9yIn0gPT0gNjsKLX0KLQotc3ViIGlzTGlvbigpCi17Ci0g ICAgcmV0dXJuIGlzRGFyd2luKCkgJiYgb3NYVmVyc2lvbigpLT57Im1pbm9yIn0gPT0gNzsKLX0K LQogc3ViIGlzV2luZG93c05UKCkKIHsKICAgICByZXR1cm4gJEVOVnsnT1MnfSBlcSAnV2luZG93 c19OVCc7CkBAIC0yMTI3LDExICsyMDc0LDYgQEAgc3ViIG9wZW5JT1NTaW11bGF0b3IoKQogICAg ICRpUGhvbmVTaW11bGF0b3JOb3RpZmljYXRpb24tPnN0b3BPYnNlcnZpbmdSZWFkeU5vdGlmaWNh dGlvbigpOwogfQogCi1zdWIgcXVpdElPU1NpbXVsYXRvcigpCi17Ci0gICAgcmV0dXJuIHN5c3Rl bSB7Im9zYXNjcmlwdCJ9ICJvc2FzY3JpcHQiLCAiLWUiLCAndGVsbCBhcHBsaWNhdGlvbiAiaU9T IFNpbXVsYXRvciIgdG8gcXVpdCc7Ci19Ci0KIHN1YiBpb3NTaW11bGF0b3JEZXZpY2VCeU5hbWUo JCkKIHsKICAgICBteSAoJHNpbXVsYXRvck5hbWUpID0gQF87Cg==