<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136820</bug_id>
          
          <creation_ts>2014-09-15 05:18:45 -0700</creation_ts>
          <short_desc>Fix FindICU.cmake</short_desc>
          <delta_ts>2014-09-16 01:57:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tibor Mészáros">mtiborinf</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1035223</commentid>
    <comment_count>0</comment_count>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-09-15 05:18:45 -0700</bug_when>
    <thetext>FindICU.cmake doesn&apos;t find headers and libraries when we cross
compiled WebKit. But it works properly when I added pkg-config
hints similar to other Find*.cmake scripts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035224</commentid>
    <comment_count>1</comment_count>
      <attachid>238120</attachid>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-09-15 05:23:10 -0700</bug_when>
    <thetext>Created attachment 238120
Patch

Patch for this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035226</commentid>
    <comment_count>2</comment_count>
      <attachid>238120</attachid>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-09-15 05:23:56 -0700</bug_when>
    <thetext>Comment on attachment 238120
Patch

failed upload</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035228</commentid>
    <comment_count>3</comment_count>
      <attachid>238121</attachid>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-09-15 05:24:57 -0700</bug_when>
    <thetext>Created attachment 238121
Patch v2

corrected patch file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035406</commentid>
    <comment_count>4</comment_count>
      <attachid>238121</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-09-16 01:20:21 -0700</bug_when>
    <thetext>Comment on attachment 238121
Patch v2

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035417</commentid>
    <comment_count>5</comment_count>
      <attachid>238121</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-09-16 01:57:22 -0700</bug_when>
    <thetext>Comment on attachment 238121
Patch v2

Clearing flags on attachment: 238121

Committed r173655: &lt;http://trac.webkit.org/changeset/173655&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035418</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-09-16 01:57:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>238120</attachid>
            <date>2014-09-15 05:23:10 -0700</date>
            <delta_ts>2014-09-15 05:23:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch_v2.patch</filename>
            <type>text/plain</type>
            <size>1104</size>
            <attacher name="Tibor Mészáros">mtiborinf</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NzQz
Yzc5Li44ODIzOTY2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDktMDggIFRpYm9yIE1lc3phcm9zICA8dG1l
c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIEVX
ZWJMYXVuY2hlciBmcm9tIHdlYmtpdGRpcnMucG0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAo
bGF1bmNoZXJOYW1lKToKKwogMjAxNC0wOS0wNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXog
IDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVbnJldmlld2VkIEdUSyBnYXJk
ZW5pbmcuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T
Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggN2JiZjIzNy4uMGYzMDFmNSAxMDA3NTUKLS0tIGEv
VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly
cy5wbQpAQCAtMTQwNSwxNCArMTQwNSwxMiBAQCBzdWIgbGF1bmNoZXJQYXRoKCkKIAogc3ViIGxh
dW5jaGVyTmFtZSgpCiB7Ci0gICAgaWYgKGlzR3RrKCkpIHsKKyAgICBpZiAoaXNHdGsoKSB8fCBp
c0VmbCgpKSB7CiAgICAgICAgIHJldHVybiAiTWluaUJyb3dzZXIiOwogICAgIH0gZWxzaWYgKGlz
QXBwbGVNYWNXZWJLaXQoKSkgewogICAgICAgICByZXR1cm4gIlNhZmFyaSI7CiAgICAgfSBlbHNp
ZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7CiAgICAgICAgIHJldHVybiAiV2luTGF1bmNoZXIiOwot
ICAgIH0gZWxzaWYgKGlzRWZsKCkpIHsKLSAgICAgICAgcmV0dXJuICJFV2ViTGF1bmNoZXIvTWlu
aUJyb3dzZXIiOwogICAgIH0gZWxzaWYgKGlzV2luQ0UoKSkgewogICAgICAgICByZXR1cm4gIldp
bkNFTGF1bmNoZXIiOwogICAgIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>238121</attachid>
            <date>2014-09-15 05:24:57 -0700</date>
            <delta_ts>2014-09-16 01:57:22 -0700</delta_ts>
            <desc>Patch v2</desc>
            <filename>patch_final.patch</filename>
            <type>text/plain</type>
            <size>1415</size>
            <attacher name="Tibor Mészáros">mtiborinf</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2OWRhOTk5Li5lNGM1MDlj
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK
KzIwMTQtMDktMTUgIFRpYm9yIE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRuZXIu
c2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IEZpbmRJQ1UuY21ha2UKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjgyMAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRJQ1Uu
Y21ha2U6CisKIDIwMTQtMDktMTUgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29t
PgogCiAgICAgICAgIFtDTWFrZV0gUmVtb3ZlIEZJTkRfUEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRf
QVJHUyBjYWxsIGZvciBXQVlMQU5EX0VHTCBpbiBGaW5kV2F5bGFuZC5jbWFrZQpkaWZmIC0tZ2l0
IGEvU291cmNlL2NtYWtlL0ZpbmRJQ1UuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZElDVS5jbWFr
ZQppbmRleCBhM2ZlNzk1Li5iN2JkMzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZElD
VS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmluZElDVS5jbWFrZQpAQCAtOSwxMCArOSwxNSBA
QAogIyAgSUNVX0kxOE5fTElCUkFSSUVTIC0gTGlicmFyaWVzIHRvIGxpbmsgYWdhaW5zdCBmb3Ig
SUNVIGludGVybmF0aW9uYWxpYXRpb24KICMgICAgICAgICAgICAgICAgICAgICAgIChub3RlOiBp
biBhZGRpdGlvbiB0byBJQ1VfTElCUkFSSUVTKQogCitmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQor
cGtnX2NoZWNrX21vZHVsZXMoUENfSUNVIGljdS11YykKKwogIyBMb29rIGZvciB0aGUgaGVhZGVy
IGZpbGUuCiBmaW5kX3BhdGgoCiAgICAgSUNVX0lOQ0xVREVfRElSCiAgICAgTkFNRVMgdW5pY29k
ZS91dHlwZXMuaAorICAgIEhJTlRTICR7UENfSUNVX0lOQ0xVREVfRElSU30KKyAgICAgICAgICAk
e1BDX0lDVV9JTkNMVURFRElSfQogICAgIERPQyAiSW5jbHVkZSBkaXJlY3RvcnkgZm9yIHRoZSBJ
Q1UgbGlicmFyeSIpCiBtYXJrX2FzX2FkdmFuY2VkKElDVV9JTkNMVURFX0RJUikKIApAQCAtMjAs
NiArMjUsOCBAQCBtYXJrX2FzX2FkdmFuY2VkKElDVV9JTkNMVURFX0RJUikKIGZpbmRfbGlicmFy
eSgKICAgICBJQ1VfTElCUkFSWQogICAgIE5BTUVTIGljdXVjIGN5Z2ljdXVjIGN5Z2ljdXVjMzIK
KyAgICBISU5UUyAke1BDX0lDVV9MSUJSQVJZX0RJUlN9CisgICAgICAgICAgJHtQQ19JQ1VfTElC
RElSfQogICAgIERPQyAiTGlicmFyaWVzIHRvIGxpbmsgYWdhaW5zdCBmb3IgdGhlIGNvbW1vbiBw
YXJ0cyBvZiBJQ1UiKQogbWFya19hc19hZHZhbmNlZChJQ1VfTElCUkFSWSkKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>