136808 2014-09-14 18:46:23 -0700 Fix post-mortem nits for r173528 & r173549 2014-09-14 22:41:09 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin oldest_to_newest 1035137 0 cdumez 2014-09-14 18:46:23 -0700 Fix post-mortem nits for r173528 & r173549, mainly about using "auto" and fastGetAttribute(). 1035138 1 238100 cdumez 2014-09-14 18:52:22 -0700 Created attachment 238100 Patch 1035170 2 238100 commit-queue 2014-09-14 22:41:06 -0700 Comment on attachment 238100 Patch Clearing flags on attachment: 238100 Committed r173613: <http://trac.webkit.org/changeset/173613> 1035171 3 commit-queue 2014-09-14 22:41:09 -0700 All reviewed patches have been landed. Closing bug. 238100 2014-09-14 18:52:22 -0700 2014-09-14 22:41:05 -0700 Patch bug-136808-20140914185219.patch text/plain 2999 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM5Yzg2NTJkMjBlYzgz Y2QxOWI1ZDg5Y2I0NzIxYmI2ZjkwMzgwNC4uNzY0ZGU5ZjYyODhiNDZhMTk4Y2RjYmUxMjliZGM5 OWEzMWMwMWI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA5LTE0ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcG9zdC1tb3J0 ZW0gbml0cyBmb3IgcjE3MzUyOCAmIHIxNzM1NDkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBwb3N0LW1vcnRlbSBuaXRzIGZvciByMTczNTI4ICYg cjE3MzU0OS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6OmFsdGVybmF0aXZlVGV4dEZv cldlYkFyZWEpOgorICAgICAgICAtIFVzZSBhdXRvKiBpbnN0ZWFkIG9mIG1vcmUgc3BlY2lmaWMg dHlwZXMuCisgICAgICAgIC0gVXNlIGZhc3RHZXRBdHRyaWJ1dGUoKSBpbnN0ZWFkIG9mIGdldEF0 dHJpYnV0ZSgpIGFzIHRoaXMgaXMKKyAgICAgICAgICBzdXBwb3J0ZWQgZm9yIHRoZSAidGl0bGUi IGF0dHJpYnV0ZS4KKworICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246OnNldFNlbGVjdGlvbkZyb21Ob25lKToKKyAg ICAgICAgVXNlIGF1dG8qIGluc3RlYWQgb2YgbW9yZSBzcGVjaWZpYyB0eXBlcy4KKwogMjAxNC0w OS0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERyb3AgTm9k ZVRyYXZlcnNhbDo6bmV4dFNraXBwaW5nQ2hpbGRyZW4oKSBvdmVybG9hZCB0YWtpbmcgYSBDb250 YWluZXJOb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlOb2RlT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCmluZGV4IGU2MzNjN2I5NTIyMWVmYTI3ZDExMzY0MWE1 MDY0YTc0M2VjYmJlZTcuLmZjNDE1OGQxOTJhYmMwOWQ1ZGFiODMyNWRlNDNiNTQzOTI1MjZkNDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5v ZGVPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eU5vZGVPYmplY3QuY3BwCkBAIC0xNDYxLDkgKzE0NjEsOSBAQCBTdHJpbmcgQWNjZXNzaWJp bGl0eU5vZGVPYmplY3Q6OmFsdGVybmF0aXZlVGV4dEZvcldlYkFyZWEoKSBjb25zdAogICAgICAg ICAgICAgcmV0dXJuIGFyaWFMYWJlbDsKICAgICB9CiAgICAgCi0gICAgaWYgKEhUTUxGcmFtZU93 bmVyRWxlbWVudCogb3duZXIgPSBkb2N1bWVudC0+b3duZXJFbGVtZW50KCkpIHsKKyAgICBpZiAo YXV0byogb3duZXIgPSBkb2N1bWVudC0+b3duZXJFbGVtZW50KCkpIHsKICAgICAgICAgaWYgKG93 bmVyLT5oYXNUYWdOYW1lKGZyYW1lVGFnKSB8fCBvd25lci0+aGFzVGFnTmFtZShpZnJhbWVUYWcp KSB7Ci0gICAgICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIHRpdGxlID0gb3duZXItPmdldEF0 dHJpYnV0ZSh0aXRsZUF0dHIpOworICAgICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiB0aXRs ZSA9IG93bmVyLT5mYXN0R2V0QXR0cmlidXRlKHRpdGxlQXR0cik7CiAgICAgICAgICAgICBpZiAo IXRpdGxlLmlzRW1wdHkoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gdGl0bGU7CiAgICAgICAg IH0KQEAgLTE0NzQsNyArMTQ3NCw3IEBAIFN0cmluZyBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6 YWx0ZXJuYXRpdmVUZXh0Rm9yV2ViQXJlYSgpIGNvbnN0CiAgICAgaWYgKCFkb2N1bWVudFRpdGxl LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIGRvY3VtZW50VGl0bGU7CiAgICAgCi0gICAgaWYg KEhUTUxFbGVtZW50KiBib2R5ID0gZG9jdW1lbnQtPmJvZHkoKSkKKyAgICBpZiAoYXV0byogYm9k eSA9IGRvY3VtZW50LT5ib2R5KCkpCiAgICAgICAgIHJldHVybiBib2R5LT5nZXROYW1lQXR0cmli dXRlKCk7CiAgICAgCiAgICAgcmV0dXJuIFN0cmluZygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0ZyYW1lU2VsZWN0aW9uLmNwcAppbmRleCA3Yjg4MTUxYzMyYmY3MzQzNDVmMjM2OTYzNGVjMjkw OGMxMjEwNWQ3Li5mOGYyNDBkZTE5N2RkOWJjODEyNTAxMDQ5MjNiNGU5ZmJhMjEyM2NjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcApAQCAtMjExMiw3ICsyMTEy LDcgQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6c2V0U2VsZWN0aW9uRnJvbU5vbmUoKQogICAgICAg ICByZXR1cm47CiAjZW5kaWYKIAotICAgIEVsZW1lbnQqIGRvY3VtZW50RWxlbWVudCA9IGRvY3Vt ZW50LT5kb2N1bWVudEVsZW1lbnQoKTsKKyAgICBhdXRvKiBkb2N1bWVudEVsZW1lbnQgPSBkb2N1 bWVudC0+ZG9jdW1lbnRFbGVtZW50KCk7CiAgICAgaWYgKCFkb2N1bWVudEVsZW1lbnQpCiAgICAg ICAgIHJldHVybjsKICAgICBpZiAoYXV0byBib2R5ID0gY2hpbGRyZW5PZlR5cGU8SFRNTEJvZHlF bGVtZW50PigqZG9jdW1lbnRFbGVtZW50KS5maXJzdCgpKQo=