136804 2014-09-13 09:55:34 -0700 Should call [BKSProcessAssertion invalidate] 2014-09-15 10:28:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 barraclough barraclough ddkilzer mitz sam oldest_to_newest 1035070 0 barraclough 2014-09-13 09:55:34 -0700 <rdar://problem/17897780> We should invalidate the process assertion before releasing it. Fortunately this is really easy, since there is a simple 1:1 relationship with ProcessAssertion, with their lifetimes matching exactly. 1035071 1 238087 barraclough 2014-09-13 09:58:22 -0700 Created attachment 238087 Fix 1035074 2 sam 2014-09-13 11:49:53 -0700 Why do we need to do this? What does it fix? 1035085 3 barraclough 2014-09-13 18:52:07 -0700 (In reply to comment #2) > Why do we need to do this? What does it fix? See <rdar://problem/17897780>. 1035264 4 ddkilzer 2014-09-15 09:29:46 -0700 (In reply to comment #2) > Why do we need to do this? What does it fix? It fixes a race condition that can cause a crash when closing a tab in MobileSafari. 1035268 5 barraclough 2014-09-15 10:10:37 -0700 Committed revision 173623. 1035269 6 mitz 2014-09-15 10:28:49 -0700 I wish this bug (and the ChangeLog entry) had a title that explained why we were doing this. Something like “Safari crashed when closing a tab in -[BKSProcessAssertionClient _handleDestroy:]”. 238087 2014-09-13 09:58:22 -0700 2014-09-14 13:35:01 -0700 Fix 136804.1.patch text/plain 3102 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzYwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA5LTEzICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFNob3VsZCBjYWxs IFtCS1NQcm9jZXNzQXNzZXJ0aW9uIGludmFsaWRhdGVdCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzE3ODk3NzgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIHNob3VsZCBpbnZhbGlkYXRlIHRoZSBwcm9jZXNzIGFzc2VydGlvbiBiZWZvcmUgcmVs ZWFzaW5nIGl0LiBGb3J0dW5hdGVseSB0aGlzIGlzIHJlYWxseSBlYXN5LAorICAgICAgICBzaW5j ZSB0aGVyZSBpcyBhIHNpbXBsZSAxOjEgcmVsYXRpb25zaGlwIHdpdGggUHJvY2Vzc0Fzc2VydGlv biwgd2l0aCB0aGVpciBsaWZldGltZXMgbWF0Y2hpbmcgZXhhY3RseS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0Fz c2VydGlvbjo6flByb2Nlc3NBc3NlcnRpb24pOgorICAgICAgICAgICAgLSBuby1vcCBpbXBsZW1l bnRhdGlvbi4KKyAgICAgICAgKiBVSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oOgorICAgICAg ICAgICAgLSBhZGRlZCBkZXN0cnVjdG9yLgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvUHJvY2Vz c0Fzc2VydGlvbklPUy5tbToKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0Fzc2VydGlvbjo6flBy b2Nlc3NBc3NlcnRpb24pOgorICAgICAgICAgICAgLSBkZXN0cnVjdG9yIGludmFsaWRhdGVzIHRo ZSBCS1NQcm9jZXNzQXNzZXJ0aW9uLgorCiAyMDE0LTA5LTEwICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmUtYWRkIHRoZSByZXF1ZXN0IGF1dG9jb21w bGV0ZSBmZWF0dXJlCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2Vy dGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Byb2Nlc3NB c3NlcnRpb24uY3BwCShyZXZpc2lvbiAxNzM0NzYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUHJvY2Vzc0Fzc2VydGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDEwIEBA IFByb2Nlc3NBc3NlcnRpb246OlByb2Nlc3NBc3NlcnRpb24ocGlkX3QKIHsKIH0KIAorUHJvY2Vz c0Fzc2VydGlvbjo6flByb2Nlc3NBc3NlcnRpb24oKQoreworfQorCiB2b2lkIFByb2Nlc3NBc3Nl cnRpb246OnNldFN0YXRlKEFzc2VydGlvblN0YXRlIGFzc2VydGlvblN0YXRlKQogewogICAgIGlm IChtX2Fzc2VydGlvblN0YXRlID09IGFzc2VydGlvblN0YXRlKQpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1Byb2Nlc3NBc3NlcnRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oCShyZXZpc2lvbiAxNzM0NzYpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oCSh3b3JraW5nIGNvcHkp CkBAIC00Miw3ICs0Miw4IEBAIGVudW0gY2xhc3MgQXNzZXJ0aW9uU3RhdGUgewogY2xhc3MgUHJv Y2Vzc0Fzc2VydGlvbiB7CiBwdWJsaWM6CiAgICAgUHJvY2Vzc0Fzc2VydGlvbihwaWRfdCwgQXNz ZXJ0aW9uU3RhdGUpOwotICAgIAorICAgIH5Qcm9jZXNzQXNzZXJ0aW9uKCk7CisKICAgICBBc3Nl cnRpb25TdGF0ZSBzdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fYXNzZXJ0aW9uU3RhdGU7IH0KICAg ICAKICAgICB2b2lkIHNldFN0YXRlKEFzc2VydGlvblN0YXRlKTsKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0JKHJldmlz aW9uIDE3MzQ3NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2Vy dGlvbklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTU4LDYgKzE1OCwxMSBAQCBQcm9jZXNzQXNz ZXJ0aW9uOjpQcm9jZXNzQXNzZXJ0aW9uKHBpZF90CiAgICAgbV9hc3NlcnRpb24gPSBhZG9wdE5T KFtbQktTUHJvY2Vzc0Fzc2VydGlvbiBhbGxvY10gaW5pdFdpdGhQSUQ6cGlkIGZsYWdzOmZsYWdz Rm9yU3RhdGUoYXNzZXJ0aW9uU3RhdGUpIHJlYXNvbjpCS1NQcm9jZXNzQXNzZXJ0aW9uUmVhc29u RXh0ZW5zaW9uIG5hbWU6QCJXZWIgY29udGVudCB2aXNpYmxlIiB3aXRoSGFuZGxlcjpoYW5kbGVy XSk7CiB9CiAKK1Byb2Nlc3NBc3NlcnRpb246On5Qcm9jZXNzQXNzZXJ0aW9uKCkKK3sKKyAgICBb bV9hc3NlcnRpb24gaW52YWxpZGF0ZV07Cit9CisKIHZvaWQgUHJvY2Vzc0Fzc2VydGlvbjo6c2V0 U3RhdGUoQXNzZXJ0aW9uU3RhdGUgYXNzZXJ0aW9uU3RhdGUpCiB7CiAgICAgaWYgKG1fYXNzZXJ0 aW9uU3RhdGUgPT0gYXNzZXJ0aW9uU3RhdGUpCkBAIC0yMDEsNiArMjA2LDEwIEBAIFByb2Nlc3NB c3NlcnRpb246OlByb2Nlc3NBc3NlcnRpb24ocGlkX3QKIHsKIH0KIAorUHJvY2Vzc0Fzc2VydGlv bjo6flByb2Nlc3NBc3NlcnRpb24oKQoreworfQorCiB2b2lkIFByb2Nlc3NBc3NlcnRpb246OnNl dFN0YXRlKEFzc2VydGlvblN0YXRlIGFzc2VydGlvblN0YXRlKQogewogICAgIG1fYXNzZXJ0aW9u U3RhdGUgPSBhc3NlcnRpb25TdGF0ZTsK