136793 2014-09-12 16:13:46 -0700 Multiple EWS or commit bots can pick up processing of the same patch 2014-09-12 16:33:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap rniwa oldest_to_newest 1034993 0 ap 2014-09-12 16:13:46 -0700 Only one bot from each queue is supposed to be processing a given patch; havoc ensues otherwise. But this happens pretty frequently. Turns out that the server doesn't let a bot chew on a patch for more than an hour, and releases it for other bots to take. In worst case, a bot needs to clean, update, apply the patch, build, test, re-test, rollout, build, test, commit. That takes more than an hour. 1034994 1 238072 ap 2014-09-12 16:16:50 -0700 Created attachment 238072 proposed fix 1035000 2 ap 2014-09-12 16:33:25 -0700 Committed <http://trac.webkit.org/r173587>. 238072 2014-09-12 16:16:50 -0700 2014-09-12 16:27:07 -0700 proposed fix queueTimeout.txt text/plain 2347 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzU4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE0LTA5LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE11bHRpcGxlIEVXUyBvciBjb21taXQgYm90cyBjYW4gcGljayB1cCBwcm9j ZXNzaW5nIG9mIHRoZSBzYW1lIHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzY3OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDaGFuZ2UgdGltZW91dCBmcm9tIG9uZSBob3VyIHRvIHR3byBob3Vy cy4gVGhpcyB3aWxsIGxldCBib3RzIGZpbmlzaCwgYW5kIGluIHRoZQorICAgICAgICB1bmxpa2Vs eSBldmVudCBvZiBhIGJvdCBiZWluZyBmcm96ZW4sIHdpbGwgb25seSBkZWxheSBwYXRjaCBwcm9j ZXNzaW5nIHJlc3RhcnQgYnkKKyAgICAgICAgb25lIGhvdXIuCisKKyAgICAgICAgKiBRdWV1ZVN0 YXR1c1NlcnZlci9hcHAueWFtbDoKKyAgICAgICAgKiBRdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9h Y3RpdmV3b3JraXRlbXMucHk6IChBY3RpdmVXb3JrSXRlbXMuZGVhY3RpdmF0ZV9leHBpcmVkKToK KwogMjAxNC0wOS0xMSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAg W1dlYktpdDJdIFdLSW1hZ2VDcmVhdGVDR0ltYWdlIGNyYXNoZXMgd2hlbiBwYXNzZWQgYSBudWxs IFdLSW1hZ2UKSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sCShyZXZpc2lvbiAxNzM1ODQp CisrKyBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9hcHAueWFtbAkod29ya2luZyBjb3B5KQpAQCAt MSw1ICsxLDUgQEAKIGFwcGxpY2F0aW9uOiB3ZWJraXQtcXVldWVzCi12ZXJzaW9uOiAxNjIzNTgg IyBCdWd6aWxsYSBidWcgSUQgb2YgbGFzdCBtYWpvciBjaGFuZ2UKK3ZlcnNpb246IDE3MzU4NSAj IEJ1Z3ppbGxhIGJ1ZyBJRCBvZiBsYXN0IG1ham9yIGNoYW5nZQogcnVudGltZTogcHl0aG9uCiBh cGlfdmVyc2lvbjogMQogCkluZGV4OiBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9hY3Rp dmV3b3JraXRlbXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvbW9k ZWwvYWN0aXZld29ya2l0ZW1zLnB5CShyZXZpc2lvbiAxNzM1ODQpCisrKyBUb29scy9RdWV1ZVN0 YXR1c1NlcnZlci9tb2RlbC9hY3RpdmV3b3JraXRlbXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTc5 LDggKzc5LDEwIEBAIGNsYXNzIEFjdGl2ZVdvcmtJdGVtcyhkYi5Nb2RlbCwgUXVldWVQcm8KICAg ICAgICAgcmV0dXJuIGRiLnJ1bl9pbl90cmFuc2FjdGlvbihzZWxmLl9leHBpcmVfaXRlbSwgc2Vs Zi5rZXkoKSwgaXRlbV9pZCkKIAogICAgIGRlZiBkZWFjdGl2YXRlX2V4cGlyZWQoc2VsZiwgbm93 KToKLSAgICAgICAgb25lX2hvdXJfYWdvID0gdGltZS5ta3RpbWUoKG5vdyAtIHRpbWVkZWx0YSht aW51dGVzPTYwKSkudGltZXR1cGxlKCkpCi0gICAgICAgIG5vbmV4cGlyZWRfcGFpcnMgPSBbcGFp ciBmb3IgcGFpciBpbiBzZWxmLl9pdGVtX3RpbWVfcGFpcnMoKSBpZiBwYWlyWzFdID4gb25lX2hv dXJfYWdvXQorICAgICAgICAjIElmIHRoZSBwYXRjaCBpcyBzdGlsbCBhY3RpdmUgYWZ0ZXIgdGhp cyBtdWNoIHRpbWUsIHRoZW4gYSBib3QgbXVzdCBoYXZlIGZyb3plbiBvciByZWJvb3RlZCwKKyAg ICAgICAgIyBhbmQgZHJvcHBlZCB0aGUgcGF0Y2ggb24gdGhlIGZsb29yLiBMZXQgYW5vdGhlciBi b3QgcGljayBpdCB1cC4KKyAgICAgICAgdHdvX2hvdXJzX2FnbyA9IHRpbWUubWt0aW1lKChub3cg LSB0aW1lZGVsdGEobWludXRlcz0xMjApKS50aW1ldHVwbGUoKSkKKyAgICAgICAgbm9uZXhwaXJl ZF9wYWlycyA9IFtwYWlyIGZvciBwYWlyIGluIHNlbGYuX2l0ZW1fdGltZV9wYWlycygpIGlmIHBh aXJbMV0gPiB0d29faG91cnNfYWdvXQogICAgICAgICBzZWxmLl9zZXRfaXRlbV90aW1lX3BhaXJz KG5vbmV4cGlyZWRfcGFpcnMpCiAKICAgICBkZWYgbmV4dF9pdGVtKHNlbGYsIHdvcmtfaXRlbV9p ZHMsIG5vdyk6Cg==