136791 2014-09-12 15:29:33 -0700 Mac queue slaves should reboot every so often 2014-09-25 23:15:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap lforschler matthew_hanson oldest_to_newest 1034977 0 rniwa 2014-09-12 15:29:33 -0700 Right now, Mac EWS, commit queue, etc... don't reboot ever. Reboot them every 24 hours to keep the sanity. 1034979 1 238067 rniwa 2014-09-12 15:31:34 -0700 Created attachment 238067 Fixes the bug 1034989 2 238067 ap 2014-09-12 15:56:57 -0700 Comment on attachment 238067 Fixes the bug Ideally, it would only reboot at night, so that this doesn't happen when someone is logged into the machine, investigating something. I don't know how to even formally express the wish though. 1034991 3 lforschler 2014-09-12 16:00:38 -0700 Maybe we could target a range of time to update... say between 3am and 6am. Then, select our 'time to reboot' to fall into that range. 1034997 4 rniwa 2014-09-12 16:27:39 -0700 Yeah, or the first time we finished past midnight? 1035584 5 238210 rniwa 2014-09-16 14:23:43 -0700 Created attachment 238210 Reboot between 1am and 6am 1035595 6 238210 ap 2014-09-16 14:51:09 -0700 Comment on attachment 238210 Reboot between 1am and 6am View in context: https://bugs.webkit.org/attachment.cgi?id=238210&action=review > Tools/ChangeLog:8 > + Reboot Mac queue slaves every 12 hours between 1 A.M. and 6 A.M. The end result would be closer to every 24 hours than every 12 hours, wouldn't it? I'd just say "every night between 1am and 6am". > Tools/EWSTools/start-queue-mac.sh:41 > +TIME_TO_REBOOT=$(( $(date +%s) + 3600 * 12)) # Reboot every 12 hours between 1am and 6am. Perhaps a "why" comment would help here (we only want to reboot at night to reduce the likelihood of confusing unexpected things happening while people are looking). 1035603 7 rniwa 2014-09-16 15:15:08 -0700 Committed r173671: <http://trac.webkit.org/changeset/173671> 1037417 8 ap 2014-09-25 23:15:05 -0700 So the bot will only reboot if it happens to finish during this time period - it will not if it was idle all night, correct? 238067 2014-09-12 15:31:34 -0700 2014-09-16 14:23:39 -0700 Fixes the bug bug-136791-20140912153130.patch text/plain 1565 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzU4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTA5LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE1hYyBxdWV1ZSBzbGF2ZXMgc2hvdWxkIHJlYm9vdCBldmVyeSBzbyBvZnRlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NzkxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVib290IE1h YyBxdWV1ZSBzbGF2ZXMgZXZlcnkgMjQgaG91cnMuCisKKyAgICAgICAgKiBFV1NUb29scy9zdGFy dC1xdWV1ZS1tYWMuc2g6CisKIDIwMTQtMDktMTEgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtXZWJLaXQyXSBXS0ltYWdlQ3JlYXRlQ0dJbWFnZSBjcmFzaGVzIHdo ZW4gcGFzc2VkIGEgbnVsbCBXS0ltYWdlCkluZGV4OiBUb29scy9FV1NUb29scy9zdGFydC1xdWV1 ZS1tYWMuc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtbWFjLnNo CShyZXZpc2lvbiAxNzI3NDMpCisrKyBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS1tYWMuc2gJ KHdvcmtpbmcgY29weSkKQEAgLTM4LDggKzM4LDkgQEAgUkVTRVRfQUZURVJfSVRFUkFUSU9OPSQz CiBzaGlmdCAzCiBRVUVVRV9QQVJBTVM9IiRAIgogCi13aGlsZSA6Ci1kbworVElNRV9UT19SRUJP T1Q9JCgoICQoZGF0ZSArJXMpICsgMzYwMCAqIDI0KSkgIyBSZWJvb3QgZXZlcnkgMjQgaG91cnMu CisKK3doaWxlIFsgVElNRV9UT19SRUJPT1QgLWd0ICQoZGF0ZSArJXMpIF07IGRvCiAgICAgIyBE ZWxldGUgbG9nIGZpbGVzIG9sZGVyIHRoYW4gMTQgZGF5cywgbW92ZSBhc2lkZSB0aGUgbWFpbiBt YWMtZXdzLmxvZyBmaWxlIHRvIHByZXZlbnQgaXQgZnJvbSBncm93aW5nIGV4dHJhIGxhcmdlLgog ICAgIGNkIC9Wb2x1bWVzL0RhdGEvRVdTLyRRVUVVRV9OQU1FLWxvZ3MKICAgICBmaW5kIC4gLW10 aW1lICsxNCAtZGVsZXRlCkBAIC03MSw0ICs3Miw3IEBAIGRvCiAgICAgIyBXZSB1c2UgLS1leGl0 LWFmdGVyLWl0ZXJhdGlvbiB0byBwaWNrIHVwIGFueSBjaGFuZ2VzIHRvIHdlYmtpdC1wYXRjaCwg aW5jbHVkaW5nCiAgICAgIyBjaGFuZ2VzIHRvIHRoZSBjb250cmlidXRvcnMuanNvbiBmaWxlLgog ICAgIC4vVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2ggJFFVRVVFX05BTUUgLS1ib3QtaWQ9JEJP VF9JRCAtLW5vLWNvbmZpcm0gLS1leGl0LWFmdGVyLWl0ZXJhdGlvbiAkUkVTRVRfQUZURVJfSVRF UkFUSU9OICRRVUVVRV9QQVJBTVMKKwogZG9uZQorCitvc2FzY3JpcHQgLWUgJ3RlbGwgYXBwICJT eXN0ZW0gRXZlbnRzIiB0byByZXN0YXJ0Jwo= 238210 2014-09-16 14:23:43 -0700 2014-09-16 14:51:09 -0700 Reboot between 1am and 6am bug-136791-20140916142333.patch text/plain 1661 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzU4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTA5LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE1hYyBxdWV1ZSBzbGF2ZXMgc2hvdWxkIHJlYm9vdCBldmVyeSBzbyBvZnRlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NzkxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVib290IE1h YyBxdWV1ZSBzbGF2ZXMgZXZlcnkgMTIgaG91cnMgYmV0d2VlbiAxIEEuTS4gYW5kIDYgQS5NLgor CisgICAgICAgICogRVdTVG9vbHMvc3RhcnQtcXVldWUtbWFjLnNoOgorCiAyMDE0LTA5LTExICBB bmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViS2l0Ml0gV0tJbWFn ZUNyZWF0ZUNHSW1hZ2UgY3Jhc2hlcyB3aGVuIHBhc3NlZCBhIG51bGwgV0tJbWFnZQpJbmRleDog VG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtbWFjLnNoCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0VX U1Rvb2xzL3N0YXJ0LXF1ZXVlLW1hYy5zaAkocmV2aXNpb24gMTcyNzQzKQorKysgVG9vbHMvRVdT VG9vbHMvc3RhcnQtcXVldWUtbWFjLnNoCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw4ICszOCw5IEBA IFJFU0VUX0FGVEVSX0lURVJBVElPTj0kMwogc2hpZnQgMwogUVVFVUVfUEFSQU1TPSIkQCIKIAot d2hpbGUgOgotZG8KK1RJTUVfVE9fUkVCT09UPSQoKCAkKGRhdGUgKyVzKSArIDM2MDAgKiAxMikp ICMgUmVib290IGV2ZXJ5IDEyIGhvdXJzIGJldHdlZW4gMWFtIGFuZCA2YW0uCisKK3doaWxlIFsg JFRJTUVfVE9fUkVCT09UIC1ndCAkKGRhdGUgKyVzKSBdIHx8IFsgJChkYXRlICslSCkgLWx0IDEg XSB8fCBbICQoZGF0ZSArJUgpIC1nZSA2IF07IGRvCiAgICAgIyBEZWxldGUgbG9nIGZpbGVzIG9s ZGVyIHRoYW4gMTQgZGF5cywgbW92ZSBhc2lkZSB0aGUgbWFpbiBtYWMtZXdzLmxvZyBmaWxlIHRv IHByZXZlbnQgaXQgZnJvbSBncm93aW5nIGV4dHJhIGxhcmdlLgogICAgIGNkIC9Wb2x1bWVzL0Rh dGEvRVdTLyRRVUVVRV9OQU1FLWxvZ3MKICAgICBmaW5kIC4gLW10aW1lICsxNCAtZGVsZXRlCkBA IC03MSw0ICs3Miw3IEBAIGRvCiAgICAgIyBXZSB1c2UgLS1leGl0LWFmdGVyLWl0ZXJhdGlvbiB0 byBwaWNrIHVwIGFueSBjaGFuZ2VzIHRvIHdlYmtpdC1wYXRjaCwgaW5jbHVkaW5nCiAgICAgIyBj aGFuZ2VzIHRvIHRoZSBjb250cmlidXRvcnMuanNvbiBmaWxlLgogICAgIC4vVG9vbHMvU2NyaXB0 cy93ZWJraXQtcGF0Y2ggJFFVRVVFX05BTUUgLS1ib3QtaWQ9JEJPVF9JRCAtLW5vLWNvbmZpcm0g LS1leGl0LWFmdGVyLWl0ZXJhdGlvbiAkUkVTRVRfQUZURVJfSVRFUkFUSU9OICRRVUVVRV9QQVJB TVMKKwogZG9uZQorCitvc2FzY3JpcHQgLWUgJ3RlbGwgYXBwICJTeXN0ZW0gRXZlbnRzIiB0byBy ZXN0YXJ0Jwo=