136779 2014-09-12 05:09:34 -0700 Remove shouldAbortEarly cruft from master.cfg 2014-09-16 01:16:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged webkit-unassigned commit-queue dburkart lforschler matthew_hanson ossy oldest_to_newest 1034844 0 evab.u-szeged 2014-09-12 05:09:34 -0700 All bots abort after 50 crashes or 500 failures, nobody uses this feature. 1034845 1 238022 evab.u-szeged 2014-09-12 05:12:57 -0700 Created attachment 238022 Patch 1034871 2 238022 ossy 2014-09-12 09:05:16 -0700 Comment on attachment 238022 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238022&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-381 > - self.setCommand(self.command + ["--exit-after-n-crashes-or-timeouts", "50", "--exit-after-n-failures", "500"]) This line shouldn't be removed, we need --exit-after-* unconditionally. (shouldAbortEarly is always True) 1035242 3 238126 evab.u-szeged 2014-09-15 07:15:00 -0700 Created attachment 238126 Patch 1035396 4 ossy 2014-09-16 01:09:42 -0700 This property was introduced in http://trac.webkit.org/changeset/126044 and the WTR bug was fixed by http://trac.webkit.org/changeset/126418 in 3 days. It happened 2 years before, since then we didn't need this hack to make bots not to exit early. So let's remove it. On a serious regression exit after 50 timeout is really necessary until the culprit patch is rolled out. 50 timeouts take 50*35s = 1750s = 29.16mins on WK1 and 50*80s = 66.66mins on WK2. If we disabled the early exit, it would cause infinite builds on the bots. If we will really need this hack in the future, I prefer adding it back as per builder configurable option, like SVNMirror. 1035404 5 238126 commit-queue 2014-09-16 01:16:49 -0700 Comment on attachment 238126 Patch Clearing flags on attachment: 238126 Committed r173653: <http://trac.webkit.org/changeset/173653> 1035405 6 commit-queue 2014-09-16 01:16:52 -0700 All reviewed patches have been landed. Closing bug. 238022 2014-09-12 05:12:57 -0700 2014-09-15 07:14:52 -0700 Patch bug-136779-20140912141252.patch text/plain 2651 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWY5MTIwNzA2NDY4YThiZTVmMDE5ZGQ5ODc2OTBjNjAx MzRhZDNhOC4uOWIxNGI0NDRlMjFmMjgyN2FmZTE4Y2FhY2ZlNTQ0NTcxMzE1YzA3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA5LTEyICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNob3VsZEFib3J0RWFybHkgY3J1ZnQgZnJv bSBtYXN0ZXIuY2ZnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY3NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5j Zmc6CisgICAgICAgIChDb25maWd1cmVCdWlsZC5zdGFydCk6CisgICAgICAgIChSdW5XZWJLaXRU ZXN0cy5zdGFydCk6CisgICAgICAgIChSdW5XZWJLaXQyVGVzdHMuc3RhcnQpOiBEZWxldGVkLgor CiAyMDE0LTA5LTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIGxsZGJfd2Via2l0LnB5OmJ0anMgZG9lc24ndCB3b3JrIHdpdGggcmVsZWFzZSBidWlsZHMK ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGM1Y2VjZGJlNzkwMDg4NGFlMzQ0MDBlYmE4MjI5ZDJk NTExMTViODEuLjUwNTA1YTA5M2JmODdiMDUzMmRmYWExNWI4ZWZkYTIyZWY2ZWFlM2IgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21h c3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvbWFzdGVyLmNmZwpAQCAtMTExLDcgKzExMSw2IEBAIGNsYXNzIENvbmZpZ3VyZUJ1aWxk KGJ1aWxkc3RlcC5CdWlsZFN0ZXApOgogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJjb25maWd1 cmF0aW9uIiwgc2VsZi5jb25maWd1cmF0aW9uKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJh cmNoaXRlY3R1cmUiLCBzZWxmLmFyY2hpdGVjdHVyZSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0 eSgiYnVpbGRPbmx5Iiwgc2VsZi5idWlsZE9ubHkpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHko InNob3VsZEFib3J0RWFybHkiLCBUcnVlKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJhZGRp dGlvbmFsQXJndW1lbnRzIiwgc2VsZi5hZGRpdGlvbmFsQXJndW1lbnRzKQogICAgICAgICBzZWxm LnNldFByb3BlcnR5KCJTVk5NaXJyb3IiLCBzZWxmLlNWTk1pcnJvcikKICAgICAgICAgc2VsZi5m aW5pc2hlZChTVUNDRVNTKQpAQCAtMzcyLDEzICszNzEsMTAgQEAgY2xhc3MgUnVuV2ViS2l0VGVz dHMoc2hlbGwuVGVzdCk6CiAKICAgICBkZWYgc3RhcnQoc2VsZik6CiAgICAgICAgIHBsYXRmb3Jt ID0gc2VsZi5nZXRQcm9wZXJ0eSgncGxhdGZvcm0nKQotICAgICAgICBzaG91bGRBYm9ydEVhcmx5 ID0gc2VsZi5nZXRQcm9wZXJ0eSgnc2hvdWxkQWJvcnRFYXJseScpCiAgICAgICAgIGFwcGVuZEN1 c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxhdGZvcm0sIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1bGxQbGF0 Zm9ybScpKQogICAgICAgICBhZGRpdGlvbmFsQXJndW1lbnRzID0gc2VsZi5nZXRQcm9wZXJ0eSgn YWRkaXRpb25hbEFyZ3VtZW50cycpCiAgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ21h YycpOgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS1uby1i dWlsZCddKQotICAgICAgICBpZiBzaG91bGRBYm9ydEVhcmx5OgotICAgICAgICAgICAgc2VsZi5z ZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsiLS1leGl0LWFmdGVyLW4tY3Jhc2hlcy1vci10aW1l b3V0cyIsICI1MCIsICItLWV4aXQtYWZ0ZXItbi1mYWlsdXJlcyIsICI1MDAiXSkKICAgICAgICAg aWYgcGxhdGZvcm0gPT0gIndpbiI6CiAgICAgICAgICAgICByb290QXJndW1lbnQgPSBbJy0tcm9v dD0nICsgb3MucGF0aC5qb2luKCJXZWJLaXRCdWlsZCIsIHNlbGYuZ2V0UHJvcGVydHkoJ2NvbmZp Z3VyYXRpb24nKSwgImJpbjMyIildCiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5j b21tYW5kICsgWyctLW5vLWJ1aWxkJ10pCkBAIC02OTQsNyArNjkwLDYgQEAgY2xhc3MgUnVuV2Vi S2l0TGVha1Rlc3RzKFJ1bldlYktpdFRlc3RzKToKIAogY2xhc3MgUnVuV2ViS2l0MlRlc3RzKFJ1 bldlYktpdFRlc3RzKToKICAgICBkZWYgc3RhcnQoc2VsZik6Ci0gICAgICAgIHNlbGYuc2V0UHJv cGVydHkoInNob3VsZEFib3J0RWFybHkiLCBUcnVlKQogICAgICAgICBzZWxmLnNldENvbW1hbmQo c2VsZi5jb21tYW5kICsgWyItLXdlYmtpdC10ZXN0LXJ1bm5lciJdKQogCiAgICAgICAgIHJldHVy biBSdW5XZWJLaXRUZXN0cy5zdGFydChzZWxmKQo= 238126 2014-09-15 07:15:00 -0700 2014-09-16 01:16:49 -0700 Patch bug-136779-20140915161454.patch text/plain 2780 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmFiOTQ0ZTk3ZjYwM2Y1OGQ5NDczMmI4ZTFiZmQyYzFh OGY1YmQ1Ny4uM2RkZjkwMDBiMDNhZGU1Y2M2NDYzNTBlNzRmNmQ3Yjg4YjE3Y2I5YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA5LTE1ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNob3VsZEFib3J0RWFybHkgY3J1ZnQgZnJv bSBtYXN0ZXIuY2ZnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY3NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5j Zmc6CisgICAgICAgIChDb25maWd1cmVCdWlsZC5zdGFydCk6CisgICAgICAgIChSdW5XZWJLaXRU ZXN0cy5zdGFydCk6CisgICAgICAgIChSdW5XZWJLaXQyVGVzdHMuc3RhcnQpOiBEZWxldGVkLgor CiAyMDE0LTA5LTE1ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAg ICAgICAgIFtXaW5DYWlyb10gTWFrZSBpdCBlYXNpZXIgdG8gZW5hYmxlL2Rpc2FibGUgR1N0cmVh bWVyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvbWFzdGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL21hc3Rlci5jZmcKaW5kZXggYzVjZWNkYmU3OTAwODg0YWUzNDQwMGViYTgy MjlkMmQ1MTExNWI4MS4uMTgwYzNlMDYyMjM3Yjg2OGE4OTQ0NDZmMWQ5MTIyOGQ0YTNkZjM3MyAx MDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCkBAIC0xMTEsNyArMTExLDYgQEAgY2xhc3MgQ29uZmlndXJl QnVpbGQoYnVpbGRzdGVwLkJ1aWxkU3RlcCk6CiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoImNv bmZpZ3VyYXRpb24iLCBzZWxmLmNvbmZpZ3VyYXRpb24pCiAgICAgICAgIHNlbGYuc2V0UHJvcGVy dHkoImFyY2hpdGVjdHVyZSIsIHNlbGYuYXJjaGl0ZWN0dXJlKQogICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCJidWlsZE9ubHkiLCBzZWxmLmJ1aWxkT25seSkKLSAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgic2hvdWxkQWJvcnRFYXJseSIsIFRydWUpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHko ImFkZGl0aW9uYWxBcmd1bWVudHMiLCBzZWxmLmFkZGl0aW9uYWxBcmd1bWVudHMpCiAgICAgICAg IHNlbGYuc2V0UHJvcGVydHkoIlNWTk1pcnJvciIsIHNlbGYuU1ZOTWlycm9yKQogICAgICAgICBz ZWxmLmZpbmlzaGVkKFNVQ0NFU1MpCkBAIC0zNzIsMTMgKzM3MSwxMyBAQCBjbGFzcyBSdW5XZWJL aXRUZXN0cyhzaGVsbC5UZXN0KToKIAogICAgIGRlZiBzdGFydChzZWxmKToKICAgICAgICAgcGxh dGZvcm0gPSBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpCi0gICAgICAgIHNob3VsZEFib3J0 RWFybHkgPSBzZWxmLmdldFByb3BlcnR5KCdzaG91bGRBYm9ydEVhcmx5JykKICAgICAgICAgYXBw ZW5kQ3VzdG9tQnVpbGRGbGFncyhzZWxmLCBwbGF0Zm9ybSwgc2VsZi5nZXRQcm9wZXJ0eSgnZnVs bFBsYXRmb3JtJykpCiAgICAgICAgIGFkZGl0aW9uYWxBcmd1bWVudHMgPSBzZWxmLmdldFByb3Bl cnR5KCdhZGRpdGlvbmFsQXJndW1lbnRzJykKKworICAgICAgICBzZWxmLnNldENvbW1hbmQoc2Vs Zi5jb21tYW5kICsgWyItLWV4aXQtYWZ0ZXItbi1jcmFzaGVzLW9yLXRpbWVvdXRzIiwgIjUwIiwg Ii0tZXhpdC1hZnRlci1uLWZhaWx1cmVzIiwgIjUwMCJdKQorCiAgICAgICAgIGlmIHBsYXRmb3Jt LnN0YXJ0c3dpdGgoJ21hYycpOgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29t bWFuZCArIFsnLS1uby1idWlsZCddKQotICAgICAgICBpZiBzaG91bGRBYm9ydEVhcmx5OgotICAg ICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsiLS1leGl0LWFmdGVyLW4t Y3Jhc2hlcy1vci10aW1lb3V0cyIsICI1MCIsICItLWV4aXQtYWZ0ZXItbi1mYWlsdXJlcyIsICI1 MDAiXSkKICAgICAgICAgaWYgcGxhdGZvcm0gPT0gIndpbiI6CiAgICAgICAgICAgICByb290QXJn dW1lbnQgPSBbJy0tcm9vdD0nICsgb3MucGF0aC5qb2luKCJXZWJLaXRCdWlsZCIsIHNlbGYuZ2V0 UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nKSwgImJpbjMyIildCiAgICAgICAgICAgICBzZWxmLnNl dENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLW5vLWJ1aWxkJ10pCkBAIC02OTQsNyArNjkzLDYg QEAgY2xhc3MgUnVuV2ViS2l0TGVha1Rlc3RzKFJ1bldlYktpdFRlc3RzKToKIAogY2xhc3MgUnVu V2ViS2l0MlRlc3RzKFJ1bldlYktpdFRlc3RzKToKICAgICBkZWYgc3RhcnQoc2VsZik6Ci0gICAg ICAgIHNlbGYuc2V0UHJvcGVydHkoInNob3VsZEFib3J0RWFybHkiLCBUcnVlKQogICAgICAgICBz ZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyItLXdlYmtpdC10ZXN0LXJ1bm5lciJdKQog CiAgICAgICAgIHJldHVybiBSdW5XZWJLaXRUZXN0cy5zdGFydChzZWxmKQo=