136775 2014-09-12 00:51:43 -0700 Generate toFooElementData() using ELEMENT_DATA_TYPE_CASTS 2014-09-14 22:28:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136773 1 gyuyoung.kim gyuyoung.kim cmarcelo commit-queue darin d-r esprehn+autocc fmalita kangil.han pdr schenney sergio oldest_to_newest 1034829 0 gyuyoung.kim 2014-09-12 00:51:43 -0700 SSIA 1034830 1 238019 gyuyoung.kim 2014-09-12 00:58:18 -0700 Created attachment 238019 Patch 1035062 2 gyuyoung.kim 2014-09-13 07:02:41 -0700 CC'ing Darin 1035108 3 238019 darin 2014-09-14 12:32:46 -0700 Comment on attachment 238019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238019&action=review > Source/WebCore/dom/ElementData.h:186 > + TYPE_CASTS_BASE(ToValueTypeName, ElementData, elementData, pointerPredicate, referencePredicate) We need to fix TYPE_CASTS_BASE. It’s kind of dumb that we need one expression for -> and one for . in every single invocation. We can use *(x) in the macro to dereference the pointer instead. We should go make that change globally to make every single use of the macro simpler. 1035144 4 gyuyoung.kim 2014-09-14 20:03:12 -0700 (In reply to comment #3) > (From update of attachment 238019 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238019&action=review > > > Source/WebCore/dom/ElementData.h:186 > > + TYPE_CASTS_BASE(ToValueTypeName, ElementData, elementData, pointerPredicate, referencePredicate) > > We need to fix TYPE_CASTS_BASE. It’s kind of dumb that we need one expression for -> and one for . in every single invocation. We can use *(x) in the macro to dereference the pointer instead. We should go make that change globally to make every single use of the macro simpler. I agree your suggestion. It looks it would be nicer to file a new bug to handle this suggestion. I'm going to file a bug for this. 1035146 5 gyuyoung.kim 2014-09-14 20:05:33 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 238019 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=238019&action=review > > > > > Source/WebCore/dom/ElementData.h:186 > > > + TYPE_CASTS_BASE(ToValueTypeName, ElementData, elementData, pointerPredicate, referencePredicate) > > > > We need to fix TYPE_CASTS_BASE. It’s kind of dumb that we need one expression for -> and one for . in every single invocation. We can use *(x) in the macro to dereference the pointer instead. We should go make that change globally to make every single use of the macro simpler. > > I agree your suggestion. It looks it would be nicer to file a new bug to handle this suggestion. I'm going to file a bug for this. I file a Bug 136809. I'm gonna upload a patch for this. 1035147 6 238019 commit-queue 2014-09-14 20:40:27 -0700 Comment on attachment 238019 Patch Clearing flags on attachment: 238019 Committed r173610: <http://trac.webkit.org/changeset/173610> 1035148 7 commit-queue 2014-09-14 20:40:32 -0700 All reviewed patches have been landed. Closing bug. 1035160 8 darin 2014-09-14 22:13:49 -0700 (In reply to comment #5) > I file a Bug 136809. I'm gonna upload a patch for this. Bug 136809 is about .get(); doesn’t sound like the same thing to me. Maybe you filed a different bug about the -> vs. dot thing? 1035162 9 gyuyoung.kim 2014-09-14 22:21:54 -0700 (In reply to comment #8) > (In reply to comment #5) > > I file a Bug 136809. I'm gonna upload a patch for this. > > Bug 136809 is about .get(); doesn’t sound like the same thing to me. Maybe you filed a different bug about the -> vs. dot thing? Darin, now I understand that you suggested to dereference a pointer in TYPE_CAST_BASE using *(x) use, and then we can adjust it to WebKit globally, right ? If so, Bug 136809 will handle it. If bug title is a little strange, I will change the title when I prepare a patch for the bug. 1035163 10 darin 2014-09-14 22:23:35 -0700 Great, looking forward to seeing it. 1035164 11 gyuyoung.kim 2014-09-14 22:24:39 -0700 (In reply to comment #10) > Great, looking forward to seeing it. Now I have very urgent local work, So, I will be able to prepare the patch after going back to my home. :) Please wait for my patch ! 1035165 12 darin 2014-09-14 22:28:14 -0700 Absolutely. I will wait patiently. I may not have a chance to look at it for a while since I have more patch reviewing time on weekends. 238019 2014-09-12 00:58:18 -0700 2014-09-14 20:40:26 -0700 Patch bug-136775-20140912165814.patch text/plain 7268 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc0NDY0MGNjYmQ3M2Yw YjZhYTQyZGQzOWMxMDkzNzE4MjUzYWZkOC4uODQ4ZWNmNDUzM2UxNzQzNmEyYjFmODJlMGE1MmJk OWZiMWEyZDVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA5LTEyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgR2VuZXJhdGUg dG9Gb29FbGVtZW50RGF0YSgpIHVzaW5nIEVMRU1FTlRfREFUQV9UWVBFX0NBU1RTCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY3NzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBhIHN0ZXAgdG8gdXNl IHRvRm9vLCB0aGlzIHBhdGNoIGludHJvZHVjZXMgRUxFTUVOVF9EQVRBX1RZUEVfQ0FTVFMgZm9y IHRvRm9vRWxlbWVudERhdGEoKS4KKyAgICAgICAgVGhpcyB3aWxsIGhlbHAgdG8gZGV0ZWN0IHdy b25nIHR5cGUgY2FzdC4gQWRkaXRvbmFsbHkgdGhpcyBwYXRjaCBoZWxwcyB0byByZW1vdmUgYXJn dW1lbnQgdHlwZSBvZiBSZWZQdHIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlv ciBjaGFuZ2VzLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6Y2xvbmVBdHRyaWJ1dGVzRnJvbUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6Y3JlYXRlVW5pcXVlRWxlbWVudERhdGEpOgorICAgICAgICAqIGRvbS9FbGVt ZW50RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6ZGVzdHJveSk6Cisg ICAgICAgICogZG9tL0VsZW1lbnREYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0 YTo6bGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnREYXRhOjphdHRyaWJ1dGVCYXNl KToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnREYXRhOjpwcmVzZW50YXRpb25BdHRyaWJ1dGVT dHlsZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6YXR0cmlidXRlc0l0ZXJhdG9y KToKKyAgICAgICAgKiBzdmcvU1ZHU1ZHRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT VkdTVkdFbGVtZW50OjpzZXR1cEluaXRpYWxWaWV3KTogUmVtb3ZlIHN0YXRpY19jYXN0PFNWR1NW R0VsZW1lbnQqPgorCiAyMDE0LTA5LTExICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYXR0ZW1wdCBvbiB3aW5kb3dzIHBv cnQgc2luY2UgcjE3MzU1My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCBkOWVlNjc1MDRhOTZl OGIxMWQ5NDE4ZDA5NjI2OTg0YThkMzZhOWI3Li40MTBlZTliOGNmZDA4YmE5Y2Q4MTc2MTIyYmM5 MGRlOWFjNWNlOWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yOTI3LDcgKzI5MjcsNyBA QCB2b2lkIEVsZW1lbnQ6OmNsb25lQXR0cmlidXRlc0Zyb21FbGVtZW50KGNvbnN0IEVsZW1lbnQm IG90aGVyKQogICAgIGlmIChvdGhlci5tX2VsZW1lbnREYXRhLT5pc1VuaXF1ZSgpCiAgICAgICAg ICYmICFvdGhlci5tX2VsZW1lbnREYXRhLT5wcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZSgpCiAg ICAgICAgICYmICghb3RoZXIubV9lbGVtZW50RGF0YS0+aW5saW5lU3R5bGUoKSB8fCAhb3RoZXIu bV9lbGVtZW50RGF0YS0+aW5saW5lU3R5bGUoKS0+aGFzQ1NTT01XcmFwcGVyKCkpKQotICAgICAg ICBjb25zdF9jYXN0PEVsZW1lbnQmPihvdGhlcikubV9lbGVtZW50RGF0YSA9IHN0YXRpY19jYXN0 PGNvbnN0IFVuaXF1ZUVsZW1lbnREYXRhKj4ob3RoZXIubV9lbGVtZW50RGF0YS5nZXQoKSktPm1h a2VTaGFyZWFibGVDb3B5KCk7CisgICAgICAgIGNvbnN0X2Nhc3Q8RWxlbWVudCY+KG90aGVyKS5t X2VsZW1lbnREYXRhID0gdG9VbmlxdWVFbGVtZW50RGF0YShvdGhlci5tX2VsZW1lbnREYXRhKS0+ bWFrZVNoYXJlYWJsZUNvcHkoKTsKIAogICAgIGlmICghb3RoZXIubV9lbGVtZW50RGF0YS0+aXNV bmlxdWUoKSkKICAgICAgICAgbV9lbGVtZW50RGF0YSA9IG90aGVyLm1fZWxlbWVudERhdGE7CkBA IC0yOTQ4LDEwICsyOTQ4LDggQEAgdm9pZCBFbGVtZW50OjpjcmVhdGVVbmlxdWVFbGVtZW50RGF0 YSgpCiB7CiAgICAgaWYgKCFtX2VsZW1lbnREYXRhKQogICAgICAgICBtX2VsZW1lbnREYXRhID0g VW5pcXVlRWxlbWVudERhdGE6OmNyZWF0ZSgpOwotICAgIGVsc2UgewotICAgICAgICBBU1NFUlQo IW1fZWxlbWVudERhdGEtPmlzVW5pcXVlKCkpOwotICAgICAgICBtX2VsZW1lbnREYXRhID0gc3Rh dGljX2Nhc3Q8U2hhcmVhYmxlRWxlbWVudERhdGEqPihtX2VsZW1lbnREYXRhLmdldCgpKS0+bWFr ZVVuaXF1ZUNvcHkoKTsKLSAgICB9CisgICAgZWxzZQorICAgICAgICBtX2VsZW1lbnREYXRhID0g dG9TaGFyZWFibGVFbGVtZW50RGF0YShtX2VsZW1lbnREYXRhKS0+bWFrZVVuaXF1ZUNvcHkoKTsK IH0KIAogYm9vbCBFbGVtZW50OjpoYXNQZW5kaW5nUmVzb3VyY2VzKCkgY29uc3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudERhdGEuY3BwCmluZGV4IGFjZjE3NTQ5MzlmMmZkZWQzODY5OTQ1YmQwODRjODFm YTdjNDk4YmYuLjM5MjNmMzU2YTJkNWE0YzdjYzA1ZWIxY2ZjN2JhOWRiZDc0ZGFiOGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGF0YS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnREYXRhLmNwcApAQCAtMzYsOSArMzYsOSBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiB2b2lkIEVsZW1lbnREYXRhOjpkZXN0cm95KCkKIHsKICAgICBpZiAoaXNVbmlxdWUo KSkKLSAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PFVuaXF1ZUVsZW1lbnREYXRhKj4odGhpcyk7 CisgICAgICAgIGRlbGV0ZSB0b1VuaXF1ZUVsZW1lbnREYXRhKHRoaXMpOwogICAgIGVsc2UKLSAg ICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PFNoYXJlYWJsZUVsZW1lbnREYXRhKj4odGhpcyk7Cisg ICAgICAgIGRlbGV0ZSB0b1NoYXJlYWJsZUVsZW1lbnREYXRhKHRoaXMpOwogfQogCiBFbGVtZW50 RGF0YTo6RWxlbWVudERhdGEoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudERhdGEuaAppbmRleCAwMzcxOTVk ZjhlZmQ5ZWIyNGQ0NDQ2MGJkYjllOGYzZTZiODU3YTRmLi40MWFmYzY3YWJjM2VmMDZmOGEyNDc2 ODhhNzQwMzUyMzcyODhhNTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dERhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudERhdGEuaApAQCAtMTgxLDYg KzE4MSwxMCBAQCBwcml2YXRlOgogICAgIFBhc3NSZWY8VW5pcXVlRWxlbWVudERhdGE+IG1ha2VV bmlxdWVDb3B5KCkgY29uc3Q7CiB9OwogCisjZGVmaW5lIEVMRU1FTlRfREFUQV9UWVBFX0NBU1RT KFRvVmFsdWVUeXBlTmFtZSwgcG9pbnRlclByZWRpY2F0ZSwgcmVmZXJlbmNlUHJlZGljYXRlKSBc CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFRvVmFsdWVUeXBlTmFtZSogdG8jI1Rv VmFsdWVUeXBlTmFtZShjb25zdCBSZWZQdHI8VD4mIGVsZW1lbnREYXRhKSB7IHJldHVybiB0byMj VG9WYWx1ZVR5cGVOYW1lKGVsZW1lbnREYXRhLmdldCgpKTsgfSBcCisgICAgVFlQRV9DQVNUU19C QVNFKFRvVmFsdWVUeXBlTmFtZSwgRWxlbWVudERhdGEsIGVsZW1lbnREYXRhLCBwb2ludGVyUHJl ZGljYXRlLCByZWZlcmVuY2VQcmVkaWNhdGUpCisKICNpZiBDT01QSUxFUihNU1ZDKQogI3ByYWdt YSB3YXJuaW5nKHB1c2gpCiAjcHJhZ21hIHdhcm5pbmcoZGlzYWJsZTogNDIwMCkgLy8gRGlzYWJs ZSAiemVyby1zaXplZCBhcnJheSBpbiBzdHJ1Y3QvdW5pb24iIHdhcm5pbmcKQEAgLTE5OSw2ICsy MDMsOCBAQCBwdWJsaWM6CiAgICAgQXR0cmlidXRlIG1fYXR0cmlidXRlQXJyYXlbMF07CiB9Owog CitFTEVNRU5UX0RBVEFfVFlQRV9DQVNUUyhTaGFyZWFibGVFbGVtZW50RGF0YSwgIWVsZW1lbnRE YXRhLT5pc1VuaXF1ZSgpLCAhZWxlbWVudERhdGEuaXNVbmlxdWUoKSkKKwogI2lmIENPTVBJTEVS KE1TVkMpCiAjcHJhZ21hIHdhcm5pbmcocG9wKQogI2VuZGlmCkBAIC0yMjYsNiArMjMyLDggQEAg cHVibGljOgogICAgIEF0dHJpYnV0ZVZlY3RvciBtX2F0dHJpYnV0ZVZlY3RvcjsKIH07CiAKK0VM RU1FTlRfREFUQV9UWVBFX0NBU1RTKFVuaXF1ZUVsZW1lbnREYXRhLCBlbGVtZW50RGF0YS0+aXNV bmlxdWUoKSwgZWxlbWVudERhdGEuaXNVbmlxdWUoKSkKKwogaW5saW5lIHZvaWQgRWxlbWVudERh dGE6OmRlcmVmKCkKIHsKICAgICBpZiAoIWRlcmVmQmFzZSgpKQpAQCAtMjM2LDMxICsyNDQsMzEg QEAgaW5saW5lIHZvaWQgRWxlbWVudERhdGE6OmRlcmVmKCkKIGlubGluZSB1bnNpZ25lZCBFbGVt ZW50RGF0YTo6bGVuZ3RoKCkgY29uc3QKIHsKICAgICBpZiAoaXNVbmlxdWUoKSkKLSAgICAgICAg cmV0dXJuIHN0YXRpY19jYXN0PGNvbnN0IFVuaXF1ZUVsZW1lbnREYXRhKj4odGhpcyktPm1fYXR0 cmlidXRlVmVjdG9yLnNpemUoKTsKKyAgICAgICAgcmV0dXJuIHRvVW5pcXVlRWxlbWVudERhdGEo dGhpcyktPm1fYXR0cmlidXRlVmVjdG9yLnNpemUoKTsKICAgICByZXR1cm4gYXJyYXlTaXplKCk7 CiB9CiAKIGlubGluZSBjb25zdCBBdHRyaWJ1dGUqIEVsZW1lbnREYXRhOjphdHRyaWJ1dGVCYXNl KCkgY29uc3QKIHsKICAgICBpZiAoaXNVbmlxdWUoKSkKLSAgICAgICAgcmV0dXJuIHN0YXRpY19j YXN0PGNvbnN0IFVuaXF1ZUVsZW1lbnREYXRhKj4odGhpcyktPm1fYXR0cmlidXRlVmVjdG9yLmRh dGEoKTsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3QgU2hhcmVhYmxlRWxlbWVudERhdGEq Pih0aGlzKS0+bV9hdHRyaWJ1dGVBcnJheTsKKyAgICAgICAgcmV0dXJuIHRvVW5pcXVlRWxlbWVu dERhdGEodGhpcyktPm1fYXR0cmlidXRlVmVjdG9yLmRhdGEoKTsKKyAgICByZXR1cm4gdG9TaGFy ZWFibGVFbGVtZW50RGF0YSh0aGlzKS0+bV9hdHRyaWJ1dGVBcnJheTsKIH0KIAogaW5saW5lIGNv bnN0IFN0eWxlUHJvcGVydGllcyogRWxlbWVudERhdGE6OnByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0 eWxlKCkgY29uc3QKIHsKICAgICBpZiAoIWlzVW5pcXVlKCkpCiAgICAgICAgIHJldHVybiAwOwot ICAgIHJldHVybiBzdGF0aWNfY2FzdDxjb25zdCBVbmlxdWVFbGVtZW50RGF0YSo+KHRoaXMpLT5t X3ByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlLmdldCgpOworICAgIHJldHVybiB0b1VuaXF1ZUVs ZW1lbnREYXRhKHRoaXMpLT5tX3ByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlLmdldCgpOwogfQog CiBpbmxpbmUgQXR0cmlidXRlSXRlcmF0b3JBY2Nlc3NvciBFbGVtZW50RGF0YTo6YXR0cmlidXRl c0l0ZXJhdG9yKCkgY29uc3QKIHsKICAgICBpZiAoaXNVbmlxdWUoKSkgewotICAgICAgICBjb25z dCBWZWN0b3I8QXR0cmlidXRlLCA0PiYgYXR0cmlidXRlVmVjdG9yID0gc3RhdGljX2Nhc3Q8Y29u c3QgVW5pcXVlRWxlbWVudERhdGEqPih0aGlzKS0+bV9hdHRyaWJ1dGVWZWN0b3I7CisgICAgICAg IGNvbnN0IFZlY3RvcjxBdHRyaWJ1dGUsIDQ+JiBhdHRyaWJ1dGVWZWN0b3IgPSB0b1VuaXF1ZUVs ZW1lbnREYXRhKHRoaXMpLT5tX2F0dHJpYnV0ZVZlY3RvcjsKICAgICAgICAgcmV0dXJuIEF0dHJp YnV0ZUl0ZXJhdG9yQWNjZXNzb3IoYXR0cmlidXRlVmVjdG9yLmRhdGEoKSwgYXR0cmlidXRlVmVj dG9yLnNpemUoKSk7CiAgICAgfQotICAgIHJldHVybiBBdHRyaWJ1dGVJdGVyYXRvckFjY2Vzc29y KHN0YXRpY19jYXN0PGNvbnN0IFNoYXJlYWJsZUVsZW1lbnREYXRhKj4odGhpcyktPm1fYXR0cmli dXRlQXJyYXksIGFycmF5U2l6ZSgpKTsKKyAgICByZXR1cm4gQXR0cmlidXRlSXRlcmF0b3JBY2Nl c3Nvcih0b1NoYXJlYWJsZUVsZW1lbnREYXRhKHRoaXMpLT5tX2F0dHJpYnV0ZUFycmF5LCBhcnJh eVNpemUoKSk7CiB9CiAKIEFMV0FZU19JTkxJTkUgY29uc3QgQXR0cmlidXRlKiBFbGVtZW50RGF0 YTo6ZmluZEF0dHJpYnV0ZUJ5TmFtZShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hv dWxkSWdub3JlQXR0cmlidXRlQ2FzZSkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdTVkdFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50 LmNwcAppbmRleCAzNmJkOTdmNGMzYjgxYWU5MzUzNzNlNTFkYWQ2MTAyZTlkZTI4NzYyLi5mZDI4 ZjQ2YzQ0ZDE2ZGZjZTI5NjAxODk4MGQwYWFlZmQxMzNkNWZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NW R1NWR0VsZW1lbnQuY3BwCkBAIC02NjUsNyArNjY1LDcgQEAgdm9pZCBTVkdTVkdFbGVtZW50Ojpz ZXR1cEluaXRpYWxWaWV3KGNvbnN0IFN0cmluZyYgZnJhZ21lbnRJZGVudGlmaWVyLCBFbGVtZW50 KgogICAgICAgICBpZiAoU1ZHVmlld0VsZW1lbnQqIHZpZXdFbGVtZW50ID0gdG9TVkdWaWV3RWxl bWVudChhbmNob3JOb2RlKSkgewogICAgICAgICAgICAgU1ZHRWxlbWVudCogZWxlbWVudCA9IFNW R0xvY2F0YWJsZTo6bmVhcmVzdFZpZXdwb3J0RWxlbWVudCh2aWV3RWxlbWVudCk7CiAgICAgICAg ICAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFtZShTVkdOYW1lczo6c3ZnVGFnKSkgewotICAgICAg ICAgICAgICAgIFNWR1NWR0VsZW1lbnQqIHN2ZyA9IHN0YXRpY19jYXN0PFNWR1NWR0VsZW1lbnQq PihlbGVtZW50KTsKKyAgICAgICAgICAgICAgICBTVkdTVkdFbGVtZW50KiBzdmcgPSB0b1NWR1NW R0VsZW1lbnQoZWxlbWVudCk7CiAgICAgICAgICAgICAgICAgc3ZnLT5pbmhlcml0Vmlld0F0dHJp YnV0ZXModmlld0VsZW1lbnQpOwogCiAgICAgICAgICAgICAgICAgaWYgKFJlbmRlckVsZW1lbnQq IHJlbmRlcmVyID0gc3ZnLT5yZW5kZXJlcigpKQo=