136763 2014-09-11 15:39:11 -0700 Simplify DOM tree traversal in FrameSelection::setSelectionFromNone() 2014-09-12 07:51:40 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue rniwa oldest_to_newest 1034737 0 cdumez 2014-09-11 15:39:11 -0700 Simplify DOM Tree traversal in FrameSelection::setSelectionFromNone(). We only need to traverse the direct children of the Document element to find the body. The previous code was potentially traversing descendants. The new code is consistent with Document::body() except that we only look for an HTMLBodyElement (and ignore HTMLFrameSetElement). 1034739 1 237992 cdumez 2014-09-11 15:51:47 -0700 Created attachment 237992 Patch 1034758 2 237992 rniwa 2014-09-11 16:58:34 -0700 Comment on attachment 237992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review > Source/WebCore/editing/FrameSelection.cpp:2117 > + Element* documentElement = document->documentElement(); > + if (!documentElement) > + return; If I were you, I'd declare documentElement inside the if condition and nest the if's. 1034772 3 237992 commit-queue 2014-09-11 17:40:20 -0700 Comment on attachment 237992 Patch Clearing flags on attachment: 237992 Committed r173549: <http://trac.webkit.org/changeset/173549> 1034773 4 commit-queue 2014-09-11 17:40:23 -0700 All reviewed patches have been landed. Closing bug. 1034779 5 237992 darin 2014-09-11 18:46:21 -0700 Comment on attachment 237992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review > Source/WebCore/editing/FrameSelection.cpp:2115 > + Element* documentElement = document->documentElement(); In a case like this I prefer to use auto*. Later we might make the documentElement() function return a more specific type and it would be nice not to have to visit this call site. 1034858 6 237992 cdumez 2014-09-12 07:51:40 -0700 Comment on attachment 237992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review >> Source/WebCore/editing/FrameSelection.cpp:2115 >> + Element* documentElement = document->documentElement(); > > In a case like this I prefer to use auto*. Later we might make the documentElement() function return a more specific type and it would be nice not to have to visit this call site. Ok, it makes sense. Would you like me to land another patch for the nit fix or is this for future reference? 237992 2014-09-11 15:51:47 -0700 2014-09-12 07:51:40 -0700 Patch bug-136763-20140911155143.patch text/plain 2316 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI2NDFlMjAwNmY1ZDJi M2RlZDJhOTYyYzMyZGJkNjAwY2Q4NmYwMy4uOTlkNGE3YTNmNmU4MTIzNzc2YjM0N2MzYzgwOWFk NDY1YWIzNjIxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA5LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgRE9NIHRyZWUg dHJhdmVyc2FsIGluIEZyYW1lU2VsZWN0aW9uOjpzZXRTZWxlY3Rpb25Gcm9tTm9uZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY3NjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IG5lZWQg dG8gdHJhdmVyc2UgdGhlIGRpcmVjdCBjaGlsZHJlbiBvZiB0aGUgRG9jdW1lbnQgZWxlbWVudCB0 bworICAgICAgICBmaW5kIHRoZSBib2R5LiBUaGUgcHJldmlvdXMgY29kZSB3YXMgcG90ZW50aWFs bHkgdHJhdmVyc2luZyBkZXNjZW5kYW50cy4KKyAgICAgICAgVGhlIG5ldyBjb2RlIGlzIGNvbnNp c3RlbnQgd2l0aCBEb2N1bWVudDo6Ym9keSgpIGV4Y2VwdCB0aGF0IHdlIG9ubHkKKyAgICAgICAg bG9vayBmb3IgYW4gSFRNTEJvZHlFbGVtZW50IChhbmQgaWdub3JlIEhUTUxGcmFtZVNldEVsZW1l bnQpLgorCisgICAgICAgIEFsc28gdXBkYXRlIHRoZSBjb2RlIHRvIHVzZSB0aWdodGVyIHR5cGlu ZyBmb3IgY2xhcml0eS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5n ZS4KKworICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVTZWxlY3Rpb246OnNldFNlbGVjdGlvbkZyb21Ob25lKToKKwogMjAxNC0wOS0x MSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGQgZml4IGlPUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5j cHAKaW5kZXggOGQzYWUyOWRiYmU0MzRhMTYxNjlkODhjNTQ1ZjdhNTc5MDRjNWI5ZS4uZjBhYzI3 OWE4N2MwZjdiMjRlODNhZjc1ZmQ1MGM2ODFkMjA3NjM2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKQEAgLTQxLDYgKzQxLDcgQEAKICNpbmNsdWRlICJGcmFt ZVRyZWUuaCIKICNpbmNsdWRlICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRl eHQuaCIKKyNpbmNsdWRlICJIVE1MQm9keUVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MRm9ybUVs ZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MRnJhbWVFbGVtZW50QmFzZS5oIgogI2luY2x1ZGUgIkhU TUxJbnB1dEVsZW1lbnQuaCIKQEAgLTIxMTEsMTEgKzIxMTIsMTEgQEAgdm9pZCBGcmFtZVNlbGVj dGlvbjo6c2V0U2VsZWN0aW9uRnJvbU5vbmUoKQogICAgICAgICByZXR1cm47CiAjZW5kaWYKIAot ICAgIE5vZGUqIG5vZGUgPSBkb2N1bWVudC0+ZG9jdW1lbnRFbGVtZW50KCk7Ci0gICAgd2hpbGUg KG5vZGUgJiYgIW5vZGUtPmhhc1RhZ05hbWUoYm9keVRhZykpCi0gICAgICAgIG5vZGUgPSBOb2Rl VHJhdmVyc2FsOjpuZXh0KG5vZGUpOwotICAgIGlmIChub2RlKQotICAgICAgICBzZXRTZWxlY3Rp b24oVmlzaWJsZVNlbGVjdGlvbihmaXJzdFBvc2l0aW9uSW5PckJlZm9yZU5vZGUobm9kZSksIERP V05TVFJFQU0pKTsKKyAgICBFbGVtZW50KiBkb2N1bWVudEVsZW1lbnQgPSBkb2N1bWVudC0+ZG9j dW1lbnRFbGVtZW50KCk7CisgICAgaWYgKCFkb2N1bWVudEVsZW1lbnQpCisgICAgICAgIHJldHVy bjsKKyAgICBpZiAoYXV0byBib2R5ID0gY2hpbGRyZW5PZlR5cGU8SFRNTEJvZHlFbGVtZW50Pigq ZG9jdW1lbnRFbGVtZW50KS5maXJzdCgpKQorICAgICAgICBzZXRTZWxlY3Rpb24oVmlzaWJsZVNl bGVjdGlvbihmaXJzdFBvc2l0aW9uSW5PckJlZm9yZU5vZGUoYm9keSksIERPV05TVFJFQU0pKTsK IH0KIAogYm9vbCBGcmFtZVNlbGVjdGlvbjo6c2hvdWxkQ2hhbmdlU2VsZWN0aW9uKGNvbnN0IFZp c2libGVTZWxlY3Rpb24mIG5ld1NlbGVjdGlvbikgY29uc3QK