136760 2014-09-11 15:05:37 -0700 lldb_webkit.py:btjs doesn't work with release builds 2014-09-11 18:04:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1034726 0 msaboff 2014-09-11 15:05:37 -0700 Due to the lack of debugging information, btjs cannot call into the the WebProcess via JSC::CallFrame::describeFrame(). 1034730 1 237989 msaboff 2014-09-11 15:12:00 -0700 Created attachment 237989 Patch 1034738 2 237989 jer.noble 2014-09-11 15:48:41 -0700 Comment on attachment 237989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237989&action=review r=me, with nit: > Tools/lldb/lldb_webkit.py:135 > + JSFrameDescription = frame.EvaluateExpression("(char*)_ZN3JSC9ExecState13describeFrameEv(0x%x)" % frame.GetFP()).GetSummary() It may make sense to add an "assert" which looks up that symbol and prints a sensible error message if it can't be found. 1034742 3 msaboff 2014-09-11 16:01:14 -0700 (In reply to comment #2) > (From update of attachment 237989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237989&action=review > > r=me, with nit: > > > Tools/lldb/lldb_webkit.py:135 > > + JSFrameDescription = frame.EvaluateExpression("(char*)_ZN3JSC9ExecState13describeFrameEv(0x%x)" % frame.GetFP()).GetSummary() > > It may make sense to add an "assert" which looks up that symbol and prints a sensible error message if it can't be found. I believe that EvaluateExpression() will return None if it has any problem evaluating whatever is in the quotes, including if the symbol can't be found. If the symbol isn't found or the call for some other reason, it just silently outputs the PC address. I'll create a check for both the symbols and output a once per btjs message that says JS annotated back traces isn't possible if neither form of the symbol can be found. I'll post the updated patch shortly. 1034762 4 238000 msaboff 2014-09-11 17:07:18 -0700 Created attachment 238000 Patch with suggested check for entry points 1034774 5 msaboff 2014-09-11 18:04:24 -0700 Committed r173550: <http://trac.webkit.org/changeset/173550> 237989 2014-09-11 15:12:00 -0700 2014-09-11 17:07:18 -0700 Patch 136760.patch text/plain 2340 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzU0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTA5LTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIGxsZGJfd2Via2l0LnB5OmJ0anMgZG9lc24ndCB3b3JrIHdpdGggcmVsZWFz ZSBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHdlIGNhbid0IGdldCBhIHJlc3VsdCBjYWxsaW5nIEpTQzo6Q2FsbEZyYW1lOjpkZXNjcmli ZUZyYW1lKCksIHRyeSBjYWxsaW5nIHRoZQorICAgICAgICBtYW5nbGVkIG5hbWUgX1pOM0pTQzlF eGVjU3RhdGUxM2Rlc2NyaWJlRnJhbWVFdi4gIEFsc28gY2xlYW5lZCB1cCB0aGUgaGFuZGxpbmcg aWYKKyAgICAgICAgd2UgY2FuJ3QgZ2V0IGEgdmFsaWQgcmVzdWx0IGZyb20gdHJ5aW5nIGVpdGhl ciBjYWxsLiAgSW4gdGhhdCBjYXNlLCB3ZSBmYWxsYmFjayB0bworICAgICAgICBqdXN0IHNob3dp bmcgdGhlIFBDLgorCisgICAgICAgICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAgKGJ0 anMpOgorCiAyMDE0LTA5LTExICBSZWJlY2NhIEhhdWNrICA8cmhhdWNrQGFkb2JlLmNvbT4KIAog ICAgICAgICB3ZWJraXRweSB0ZXN0IGZhaWx1cmVzIGZyb20gaW1wb3J0LXczYy10ZXN0cwpJbmRl eDogVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9sbGRiL2xs ZGJfd2Via2l0LnB5CShyZXZpc2lvbiAxNzM1NDApCisrKyBUb29scy9sbGRiL2xsZGJfd2Via2l0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzEsMTEgKzEzMSwxNCBAQCBkZWYgYnRqcyhkZWJ1Z2dl ciwgY29tbWFuZCwgcmVzdWx0LCBpbnRlCiAgICAgICAgIGlmIG5vdCBmcmFtZSBvciBub3QgZnJh bWUuR2V0U3ltYm9sKCkgb3IgZnJhbWUuR2V0U3ltYm9sKCkuR2V0TmFtZSgpID09ICJsbGludF9l bnRyeSI6CiAgICAgICAgICAgICBjYWxsRnJhbWUgPSBmcmFtZS5HZXRTUCgpCiAgICAgICAgICAg ICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBmcmFtZS5FdmFsdWF0ZUV4cHJlc3Npb24oIigoSlNDOjpD YWxsRnJhbWUqKTB4JXgpLT5kZXNjcmliZUZyYW1lKCkiICUgZnJhbWUuR2V0RlAoKSkuR2V0U3Vt bWFyeSgpCi0gICAgICAgICAgICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBzdHJpbmcuc3RyaXAoSlNG cmFtZURlc2NyaXB0aW9uLCAnIicpCi0gICAgICAgICAgICBmcmFtZUZvcm1hdCA9ICcgICAgZnJh bWUgI3tudW19OiB7YWRkcjonICsgYWRkcmVzc0Zvcm1hdCArICd9IHtkZXNjfScKLSAgICAgICAg ICAgIHByaW50IGZyYW1lRm9ybWF0LmZvcm1hdChudW09ZnJhbWUuR2V0RnJhbWVJRCgpLCBhZGRy PWZyYW1lLkdldFBDKCksIGRlc2M9SlNGcmFtZURlc2NyaXB0aW9uKQotICAgICAgICBlbHNlOgot ICAgICAgICAgICAgcHJpbnQgJyAgICAlcycgJSBmcmFtZQorICAgICAgICAgICAgaWYgbm90IEpT RnJhbWVEZXNjcmlwdGlvbjoKKyAgICAgICAgICAgICAgICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBm cmFtZS5FdmFsdWF0ZUV4cHJlc3Npb24oIihjaGFyKilfWk4zSlNDOUV4ZWNTdGF0ZTEzZGVzY3Jp YmVGcmFtZUV2KDB4JXgpIiAlIGZyYW1lLkdldEZQKCkpLkdldFN1bW1hcnkoKQorICAgICAgICAg ICAgaWYgSlNGcmFtZURlc2NyaXB0aW9uOgorICAgICAgICAgICAgICAgIEpTRnJhbWVEZXNjcmlw dGlvbiA9IHN0cmluZy5zdHJpcChKU0ZyYW1lRGVzY3JpcHRpb24sICciJykKKyAgICAgICAgICAg ICAgICBmcmFtZUZvcm1hdCA9ICcgICAgZnJhbWUgI3tudW19OiB7YWRkcjonICsgYWRkcmVzc0Zv cm1hdCArICd9IHtkZXNjfScKKyAgICAgICAgICAgICAgICBwcmludCBmcmFtZUZvcm1hdC5mb3Jt YXQobnVtPWZyYW1lLkdldEZyYW1lSUQoKSwgYWRkcj1mcmFtZS5HZXRQQygpLCBkZXNjPUpTRnJh bWVEZXNjcmlwdGlvbikKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICBwcmludCAn ICAgICVzJyAlIGZyYW1lCiAKICMgRklYTUU6IFByb3ZpZGUgc3VwcG9ydCBmb3IgdGhlIGZvbGxv d2luZyB0eXBlczoKICMgZGVmIFdURlZlY3Rvcl9TdW1tYXJ5UHJvdmlkZXIodmFsb2JqLCBkaWN0 KToK 238000 2014-09-11 17:07:18 -0700 2014-09-11 18:02:11 -0700 Patch with suggested check for entry points 136760-2.patch text/plain 3367 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzU0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE0LTA5LTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIGxsZGJfd2Via2l0LnB5OmJ0anMgZG9lc24ndCB3b3JrIHdpdGggcmVsZWFz ZSBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHdlIGNhbid0IGdldCBhIHJlc3VsdCBjYWxsaW5nIEpTQzo6RXhlY1N0YXRlOjpkZXNjcmli ZUZyYW1lKCksIHRyeSBjYWxsaW5nIHRoZQorICAgICAgICBtYW5nbGVkIG5hbWUgX1pOM0pTQzlF eGVjU3RhdGUxM2Rlc2NyaWJlRnJhbWVFdi4gIEFsc28gY2xlYW5lZCB1cCB0aGUgaGFuZGxpbmcg aWYKKyAgICAgICAgd2UgY2FuJ3QgZ2V0IGEgdmFsaWQgcmVzdWx0IGZyb20gdHJ5aW5nIGVpdGhl ciBjYWxsLiAgSW4gdGhhdCBjYXNlLCB3ZSBmYWxsYmFjayB0bworICAgICAgICBqdXN0IHNob3dp bmcgdGhlIFBDLiAgQWxzbyBhZGRlZCBjaGVjayBmb3IgYm90aCBlbnRyeSBwb2ludHMuICBJZiBu ZWl0aGVyIGlzIGZvdW5kLAorICAgICAgICB3ZSBpc3N1ZSBhIHdhcm5pbmcgYW5kIG91dHB1dCB0 aGUgc3RhY2sgdHJhY2Ugd2l0aG91dCBKYXZhU2NyaXB0IGFubm90YXRpb25zLgorCisgICAgICAg ICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAgKGJ0anMpOgorCiAyMDE0LTA5LTExICBS ZWJlY2NhIEhhdWNrICA8cmhhdWNrQGFkb2JlLmNvbT4KIAogICAgICAgICB3ZWJraXRweSB0ZXN0 IGZhaWx1cmVzIGZyb20gaW1wb3J0LXczYy10ZXN0cwpJbmRleDogVG9vbHMvbGxkYi9sbGRiX3dl YmtpdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9sbGRiL2xsZGJfd2Via2l0LnB5CShyZXZpc2lv biAxNzM1NDYpCisrKyBUb29scy9sbGRiL2xsZGJfd2Via2l0LnB5CSh3b3JraW5nIGNvcHkpCkBA IC0xMDksNiArMTA5LDE0IEBAIGRlZiBidGpzKGRlYnVnZ2VyLCBjb21tYW5kLCByZXN1bHQsIGlu dGUKICAgICBwcm9jZXNzID0gdGFyZ2V0LkdldFByb2Nlc3MoKQogICAgIHRocmVhZCA9IHByb2Nl c3MuR2V0U2VsZWN0ZWRUaHJlYWQoKQogCisgICAgaWYgdGFyZ2V0LkZpbmRGdW5jdGlvbnMoIkpT Qzo6RXhlY1N0YXRlOjpkZXNjcmliZUZyYW1lIikuR2V0U2l6ZSgpIG9yIHRhcmdldC5GaW5kRnVu Y3Rpb25zKCJfWk4zSlNDOUV4ZWNTdGF0ZTEzZGVzY3JpYmVGcmFtZUV2IikuR2V0U2l6ZSgpOgor ICAgICAgICBhbm5vdGF0ZUpTRnJhbWVzID0gVHJ1ZQorICAgIGVsc2U6CisgICAgICAgIGFubm90 YXRlSlNGcmFtZXMgPSBGYWxzZQorCisgICAgaWYgbm90IGFubm90YXRlSlNGcmFtZXM6CisgICAg ICAgIHByaW50ICJXYXJuaW5nOiBDYW4ndCBmaW5kIEpTQzo6RXhlY1N0YXRlOjpkZXNjcmliZUZy YW1lKCkgaW4gZXhlY3V0YWJsZSB0byBhbm5vdGF0ZSBKYXZhU2NyaXB0IGZyYW1lcyIKKwogICAg IGJhY2t0cmFjZURlcHRoID0gdGhyZWFkLkdldE51bUZyYW1lcygpCiAKICAgICBpZiBsZW4oY29t bWFuZCkgPT0gMToKQEAgLTEyOCwxNCArMTM2LDE3IEBAIGRlZiBidGpzKGRlYnVnZ2VyLCBjb21t YW5kLCByZXN1bHQsIGludGUKIAogICAgICAgICBmdW5jdGlvbiA9IGZyYW1lLkdldEZ1bmN0aW9u KCkKIAotICAgICAgICBpZiBub3QgZnJhbWUgb3Igbm90IGZyYW1lLkdldFN5bWJvbCgpIG9yIGZy YW1lLkdldFN5bWJvbCgpLkdldE5hbWUoKSA9PSAibGxpbnRfZW50cnkiOgorICAgICAgICBpZiBh bm5vdGF0ZUpTRnJhbWVzIGFuZCBub3QgZnJhbWUgb3Igbm90IGZyYW1lLkdldFN5bWJvbCgpIG9y IGZyYW1lLkdldFN5bWJvbCgpLkdldE5hbWUoKSA9PSAibGxpbnRfZW50cnkiOgogICAgICAgICAg ICAgY2FsbEZyYW1lID0gZnJhbWUuR2V0U1AoKQotICAgICAgICAgICAgSlNGcmFtZURlc2NyaXB0 aW9uID0gZnJhbWUuRXZhbHVhdGVFeHByZXNzaW9uKCIoKEpTQzo6Q2FsbEZyYW1lKikweCV4KS0+ ZGVzY3JpYmVGcmFtZSgpIiAlIGZyYW1lLkdldEZQKCkpLkdldFN1bW1hcnkoKQotICAgICAgICAg ICAgSlNGcmFtZURlc2NyaXB0aW9uID0gc3RyaW5nLnN0cmlwKEpTRnJhbWVEZXNjcmlwdGlvbiwg JyInKQotICAgICAgICAgICAgZnJhbWVGb3JtYXQgPSAnICAgIGZyYW1lICN7bnVtfToge2FkZHI6 JyArIGFkZHJlc3NGb3JtYXQgKyAnfSB7ZGVzY30nCi0gICAgICAgICAgICBwcmludCBmcmFtZUZv cm1hdC5mb3JtYXQobnVtPWZyYW1lLkdldEZyYW1lSUQoKSwgYWRkcj1mcmFtZS5HZXRQQygpLCBk ZXNjPUpTRnJhbWVEZXNjcmlwdGlvbikKLSAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHByaW50 ICcgICAgJXMnICUgZnJhbWUKKyAgICAgICAgICAgIEpTRnJhbWVEZXNjcmlwdGlvbiA9IGZyYW1l LkV2YWx1YXRlRXhwcmVzc2lvbigiKChKU0M6OkV4ZWNTdGF0ZSopMHgleCktPmRlc2NyaWJlRnJh bWUoKSIgJSBmcmFtZS5HZXRGUCgpKS5HZXRTdW1tYXJ5KCkKKyAgICAgICAgICAgIGlmIG5vdCBK U0ZyYW1lRGVzY3JpcHRpb246CisgICAgICAgICAgICAgICAgSlNGcmFtZURlc2NyaXB0aW9uID0g ZnJhbWUuRXZhbHVhdGVFeHByZXNzaW9uKCIoY2hhciopX1pOM0pTQzlFeGVjU3RhdGUxM2Rlc2Ny aWJlRnJhbWVFdigweCV4KSIgJSBmcmFtZS5HZXRGUCgpKS5HZXRTdW1tYXJ5KCkKKyAgICAgICAg ICAgIGlmIEpTRnJhbWVEZXNjcmlwdGlvbjoKKyAgICAgICAgICAgICAgICBKU0ZyYW1lRGVzY3Jp cHRpb24gPSBzdHJpbmcuc3RyaXAoSlNGcmFtZURlc2NyaXB0aW9uLCAnIicpCisgICAgICAgICAg ICAgICAgZnJhbWVGb3JtYXQgPSAnICAgIGZyYW1lICN7bnVtfToge2FkZHI6JyArIGFkZHJlc3NG b3JtYXQgKyAnfSB7ZGVzY30nCisgICAgICAgICAgICAgICAgcHJpbnQgZnJhbWVGb3JtYXQuZm9y bWF0KG51bT1mcmFtZS5HZXRGcmFtZUlEKCksIGFkZHI9ZnJhbWUuR2V0UEMoKSwgZGVzYz1KU0Zy YW1lRGVzY3JpcHRpb24pCisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgcHJpbnQg JyAgICAlcycgJSBmcmFtZQogCiAjIEZJWE1FOiBQcm92aWRlIHN1cHBvcnQgZm9yIHRoZSBmb2xs b3dpbmcgdHlwZXM6CiAjIGRlZiBXVEZWZWN0b3JfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGlj dCk6Cg==