136759 2014-09-11 13:58:49 -0700 Web Inspector: remind about rebaselining generator test results 2014-09-12 17:35:36 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg burg commit-queue glenn graouts joepeck llango.u-szeged mattbaker ossy timothy webkit-bug-importer oldest_to_newest 1034715 0 burg 2014-09-11 13:58:49 -0700 paths that should trigger: inspector generator: Source/JavaScriptCore/inspector/scripts/codegen/ replay input generator: Source/JavaScriptCore/replay/scripts/ 1034716 1 burg 2014-09-11 13:59:54 -0700 Relevant scripts: Tools/Scripts/run-inspector-generator-tests Tools/Scripts/run-input-generator-tests 1034948 2 webkit-bug-importer 2014-09-12 14:10:42 -0700 <rdar://problem/18324319> 1034955 3 238058 burg 2014-09-12 14:21:17 -0700 Created attachment 238058 Patch 1034960 4 238058 joepeck 2014-09-12 14:39:41 -0700 Comment on attachment 238058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review > Tools/Scripts/webkitpy/common/config/watchlist:203 > + "filename": r"Source/JavaScriptCore/inspector/scripts/codegen", We may also want the generator script itself: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py > Tools/Scripts/webkitpy/common/config/watchlist:394 > + "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ] Throw a trailing comma! The others have it, and it makes future diffs much nicer =) 1035021 5 burg 2014-09-12 17:18:30 -0700 (In reply to comment #4) > (From update of attachment 238058 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:203 > > + "filename": r"Source/JavaScriptCore/inspector/scripts/codegen", > > We may also want the generator script itself: > > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py > > > Tools/Scripts/webkitpy/common/config/watchlist:394 > > + "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ] > > Throw a trailing comma! The others have it, and it makes future diffs much nicer =) OK 1035025 6 burg 2014-09-12 17:35:36 -0700 Committed r173594: <http://trac.webkit.org/changeset/173594> 238058 2014-09-12 14:21:17 -0700 2014-09-12 14:39:41 -0700 Patch bug-136759-20140912142113.patch text/plain 3096 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTM0MWNkNDgzYjg4NzhkNzYyMjFlMTI4YjhkMmM4NmQx ZWIxMmEwMy4uYzQ0ZDU4NDliMTk1Y2NmNDRkYjI5OTU2N2EyODE5ZDcyMmEyNzg1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA5LTEyICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW1pbmQgYWJvdXQgcmViYXNlbGluaW5nIGdlbmVy YXRvciB0ZXN0IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNjc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZvciBub3csIHdlIGNhbiBpbXBsZW1lbnQgdGhpcyBhcyBhIHdhdGNobGlzdCBt ZXNzYWdlLiBBZGQgd2F0Y2hsaXN0CisgICAgICAgIGdyb3VwcyBhbmQgbWVzc2FnZXMgZm9yIHRo ZSBpbnNwZWN0b3IgYW5kIHdlYiByZXBsYXkgZ2VuZXJhdG9ycy4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3Q6CisKIDIwMTQtMDktMTEgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJLaXQyXSBXS0ltYWdlQ3Jl YXRlQ0dJbWFnZSBjcmFzaGVzIHdoZW4gcGFzc2VkIGEgbnVsbCBXS0ltYWdlCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdAppbmRleCBmNjYwNjQ5YjY0 YjBkNDc1YWE5MDRiMTc3NjA0MTIyYmYwNjk3MmU5Li42NmVmNWJlMWE2YjhmNDgyZTI0YjEzZWZk ZGNjYzNlMzVjMWQyNjcxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jb25maWcvd2F0Y2hsaXN0CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy93YXRjaGxpc3QKQEAgLTE5OSw2ICsxOTksMTIgQEAKICAgICAgICAgICAgICAgICAgICAg ICAgIHIifFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci8uK1wuaWRsIgogICAgICAgICAgICAgICAg ICAgICAgICAgciJ8U291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbCIsCiAgICAgICAgIH0s CisgICAgICAgICJXZWJJbnNwZWN0b3JHZW5lcmF0b3IiOiB7CisgICAgICAgICAgICAiZmlsZW5h bWUiOiByIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuIiwK KyAgICAgICAgfSwKKyAgICAgICAgIldlYlJlcGxheUdlbmVyYXRvciI6IHsKKyAgICAgICAgICAg ICJmaWxlbmFtZSI6IHIiU291cmNlL0phdmFTY3JpcHRDb3JlL3JlcGxheS9zY3JpcHRzIiwKKyAg ICAgICAgfSwKICAgICAgICAgIldlYlNvY2tldCI6IHsKICAgICAgICAgICAgICJmaWxlbmFtZSI6 IHIiU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzIgogICAgICAgICAgICAgICAgICAg ICAgICAgciJ8U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay8ofC4rLylTb2NrZXRTdHJl YW0uKiIsCkBAIC0zNjYsNiArMzcyLDggQEAKICAgICAgICAgIldlYkdMIjogWyAiZGlub0BhcHBs ZS5jb20iLCAia29uZGFwYWxseWthbHlhbkBnbWFpbC5jb20iICwgInJvZ2VyX2ZvbmdAYXBwbGUu Y29tIiBdLAogICAgICAgICAiV2ViSURMIjogWyAiZXNwcmVobithdXRvY2NAY2hyb21pdW0ub3Jn IiwgImRjaHJpc0BnbWFpbC5jb20iLCAia29uZGFwYWxseWthbHlhbkBnbWFpbC5jb20iIF0sCiAg ICAgICAgICJXZWJJbnNwZWN0b3JBUEkiOiBbICJ0aW1vdGh5QGFwcGxlLmNvbSIsICJqb2VwZWNr QHdlYmtpdC5vcmciLCAiZ3Jhb3V0c0B3ZWJraXQub3JnIiBdLAorICAgICAgICAiV2ViSW5zcGVj dG9yR2VuZXJhdG9yIjogWyAiYnVyZ0Bjcy53YXNoaW5ndG9uLmVkdSIsICJqb2VwZWNrQHdlYmtp dC5vcmciIF0sCisgICAgICAgICJXZWJSZXBsYXlHZW5lcmF0b3IiOiBbICJidXJnQGNzLndhc2hp bmd0b24uZWR1IiBdLAogICAgICAgICAiV2ViS2l0R1RLVHJhbnNsYXRpb25zIjogWyAiZ25zQGdu b21lLm9yZyIsICJtcm9iaW5zb25Ad2Via2l0Lm9yZyIgXSwKICAgICAgICAgIldlYlNvY2tldCI6 IFsgInl1dGFrQGNocm9taXVtLm9yZyIsICJ0b3lvc2hpbSt3YXRjaGxpc3RAY2hyb21pdW0ub3Jn IiBdLAogICAgICAgICAiWFNTIjogWyAiZGJhdGVzQHdlYmtpdC5vcmciIF0sCkBAIC0zODIsNSAr MzkwLDcgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJTZWUgaHR0cDovL3Ry YWMud2Via2l0Lm9yZy93aWtpL1dlYktpdEdUSy9BZGRpbmdOZXdXZWJLaXQyQVBJIiwgXSwKICAg ICAgICAgIkFOR0xFIjogWyAiTm90ZSB0aGF0IHRoZXJlIGFyZSBpbXBvcnRhbnQgc3RlcHMgdG8g dGFrZSB3aGVuIHVwZGF0aW5nIEFOR0xFLiAiCiAgICAgICAgICAgICAgICAgICAgIlNlZSBodHRw Oi8vdHJhYy53ZWJraXQub3JnL3dpa2kvVXBkYXRpbmdBTkdMRSIsIF0sCisgICAgICAgICJXZWJJ bnNwZWN0b3JHZW5lcmF0b3IiOiBbICJUaGlzIHBhdGNoIG1vZGlmaWVzIHRoZSBpbnNwZWN0b3Ig cHJvdG9jb2wgZ2VuZXJhdG9yLiBQbGVhc2UgZW5zdXJlIHRoYXQgeW91IGhhdmUgcmViYXNlbGlu ZWQgYW55IGdlbmVyYXRvciB0ZXN0IHJlc3VsdHMgKGkuZS4sIGJ5IHJ1bm5pbmcgYFRvb2xzL1Nj cmlwdHMvcnVuLWluc3BlY3Rvci1nZW5lcmF0b3ItdGVzdHMgLS1yZXNldC1yZXN1bHRzYCkiIF0s CisgICAgICAgICJXZWJSZXBsYXlHZW5lcmF0b3IiOiBbICJUaGlzIHBhdGNoIG1vZGlmaWVzIHRo ZSBXRUJfUkVQTEFZIGlucHV0cyBnZW5lcmF0b3IuIFBsZWFzZSBlbnN1cmUgdGhhdCB5b3UgaGF2 ZSByZWJhc2VsaW5lZCBhbnkgZ2VuZXJhdG9yIHRlc3QgcmVzdWx0cyAoaS5lLiwgYnkgcnVubmlu ZyBgVG9vbHMvU2NyaXB0cy9ydW4taW5wdXQtZ2VuZXJhdG9yLXRlc3RzIC0tcmVzZXQtcmVzdWx0 c2ApIiBdCiAgICAgfSwKIH0K