136753 2014-09-11 13:10:19 -0700 [MIPS] abortWithReason missing 2016-01-07 09:06:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto jbriance annulen commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1034695 0 berto 2014-09-11 13:10:19 -0700 This is a follow-up to bug 136696. abortWithReason() is missing for MIPS, what results in the following errors: Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: there are no arguments to 'abortWithReason' that depend on a template parameter, so a declaration of 'abortWithReason' must be available [-fpermissive] Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: there are no arguments to 'abortWithReason' that depend on a template parameter, so a declaration of 'abortWithReason' must be available [-fpermissive] Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: 'abortWithReason' was not declared in this scope Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: 'abortWithReason' was not declared in this scope Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: 'abortWithReason' was not declared in this scope Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: 'abortWithReason' was not declared in this scope All this is happening if I disable the JIT compiler, if I try to enable it then there's several other missing functions and methods. I understand that it's not supported in MIPS? 1153413 1 268452 jbriance 2016-01-07 08:02:32 -0800 Created attachment 268452 Add two missing abortWithReason implementations in mips macro assembler 1153420 2 268452 commit-queue 2016-01-07 09:06:21 -0800 Comment on attachment 268452 Add two missing abortWithReason implementations in mips macro assembler Clearing flags on attachment: 268452 Committed r194699: <http://trac.webkit.org/changeset/194699> 1153421 3 commit-queue 2016-01-07 09:06:26 -0800 All reviewed patches have been landed. Closing bug. 268452 2016-01-07 08:02:32 -0800 2016-01-07 09:06:21 -0800 Add two missing abortWithReason implementations in mips macro assembler bug-136753.patch text/plain 1594 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0Njk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTAxLTA3ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBBZGQgdHdvIG1pc3NpbmcgYWJvcnRXaXRoUmVhc29uIGltcGxlbWVudGF0 aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2 NzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1i bGVyTUlQUzo6bWVtb3J5RmVuY2UpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6 OmFib3J0V2l0aFJlYXNvbik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6cmVh ZENhbGxUYXJnZXQpOgorCiAyMDE2LTAxLTA3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIG5ldyBvcjMyIGltcGxlbWVudGF0aW9uIHRvIE1hY3Jv QXNzZW1ibGVyQVJNIGFmdGVyIHIxOTQ2MTMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAkocmV2aXNpb24gMTk0Njk4 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMu aAkod29ya2luZyBjb3B5KQpAQCAtMjc3NSw2ICsyNzc1LDE4IEBAIHB1YmxpYzoKICAgICAgICAg bV9hc3NlbWJsZXIuc3luYygpOwogICAgIH0KIAorICAgIHZvaWQgYWJvcnRXaXRoUmVhc29uKEFi b3J0UmVhc29uIHJlYXNvbikKKyAgICB7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbTMyKHJlYXNv biksIGRhdGFUZW1wUmVnaXN0ZXIpOworICAgICAgICBicmVha3BvaW50KCk7CisgICAgfQorCisg ICAgdm9pZCBhYm9ydFdpdGhSZWFzb24oQWJvcnRSZWFzb24gcmVhc29uLCBpbnRwdHJfdCBtaXNj KQorICAgIHsKKyAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIobWlzYyksIGltbVRlbXBSZWdpc3Rl cik7CisgICAgICAgIGFib3J0V2l0aFJlYXNvbihyZWFzb24pOworICAgIH0KKwogICAgIHN0YXRp YyBGdW5jdGlvblB0ciByZWFkQ2FsbFRhcmdldChDb2RlTG9jYXRpb25DYWxsIGNhbGwpCiAgICAg ewogICAgICAgICByZXR1cm4gRnVuY3Rpb25QdHIocmVpbnRlcnByZXRfY2FzdDx2b2lkKCopKCk+ KE1JUFNBc3NlbWJsZXI6OnJlYWRDYWxsVGFyZ2V0KGNhbGwuZGF0YUxvY2F0aW9uKCkpKSk7Cg==