136748 2014-09-11 11:56:38 -0700 Web Inspector: Fix assert in QuickConsole - main frame execution context path component 2014-09-11 16:13:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1034664 0 joepeck 2014-09-11 11:56:38 -0700 Apparently this can happen on page navigations. It should be harmless to return anything because if the main frame changes, all execution context are thrown away, but we should return a more reasonable result. 1034666 1 237973 joepeck 2014-09-11 12:01:10 -0700 Created attachment 237973 [PATCH] Proposed Fix 1034736 2 webkit-bug-importer 2014-09-11 15:36:52 -0700 <rdar://problem/18312541> 1034745 3 237973 commit-queue 2014-09-11 16:13:04 -0700 Comment on attachment 237973 [PATCH] Proposed Fix Clearing flags on attachment: 237973 Committed r173547: <http://trac.webkit.org/changeset/173547> 1034746 4 commit-queue 2014-09-11 16:13:06 -0700 All reviewed patches have been landed. Closing bug. 237973 2014-09-11 12:01:10 -0700 2014-09-11 16:13:04 -0700 [PATCH] Proposed Fix fix-assert.patch text/plain 1699 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIyZTVlMGYuLjM3ODk2M2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA5LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGFz c2VydCBpbiBRdWlja0NvbnNvbGUgLSBtYWluIGZyYW1lIGV4ZWN1dGlvbiBjb250ZXh0IHBhdGgg Y29tcG9uZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzY3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNhbiBnZXQgY2FsbGVkIGZvciB0aGUgTWFpbkZyYW1lIG9uIHBhZ2UgbmF2aWdhdGlv bnMuCisgICAgICAgIEluIHN1Y2ggY2FzZXMgd2UgY2FuIHJldHVybiBhIGJldHRlciByZXN1bHQg ZnJvbSB0aGlzIG1ldGhvZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tD b25zb2xlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlF1aWNrQ29uc29sZS5wcm90b3R5cGUu X2luc2VydEV4ZWN1dGlvbkNvbnRleHRQYXRoQ29tcG9uZW50Rm9yRnJhbWUpOgorCisyMDE0LTA5 LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogRE9NIFRyZWUgc2VhcmNoIGhpZ2hsaWdodHMgYXJlIG5vdCBhcHBlYXJpbmcK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY2Mgog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9R dWlja0NvbnNvbGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9RdWlja0NvbnNvbGUuanMKaW5kZXggNDI0ZGM1ZS4uZTEwYWZlYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29s ZS5qcwpAQCAtMjQ2LDkgKzI0Niw4IEBAIFdlYkluc3BlY3Rvci5RdWlja0NvbnNvbGUucHJvdG90 eXBlID0gewogCiAgICAgX2luc2VydEV4ZWN1dGlvbkNvbnRleHRQYXRoQ29tcG9uZW50Rm9yRnJh bWU6IGZ1bmN0aW9uKGZyYW1lLCBza2lwUmVidWlsZCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUu YXNzZXJ0KCFmcmFtZS5pc01haW5GcmFtZSgpKTsKICAgICAgICAgaWYgKGZyYW1lLmlzTWFpbkZy YW1lKCkpCi0gICAgICAgICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAgICAgIHJldHVybiB0aGlz Ll9tYWluRnJhbWVFeGVjdXRpb25Db250ZXh0UGF0aENvbXBvbmVudDsKIAogICAgICAgICBjb25z b2xlLmFzc2VydCghdGhpcy5fZnJhbWVJZGVudGlmaWVyVG9FeGVjdXRpb25Db250ZXh0UGF0aENv bXBvbmVudE1hcFtmcmFtZS5pZF0pOwogICAgICAgICBpZiAodGhpcy5fZnJhbWVJZGVudGlmaWVy VG9FeGVjdXRpb25Db250ZXh0UGF0aENvbXBvbmVudE1hcFtmcmFtZS5pZF0pCg==