136743 2014-09-11 09:07:27 -0700 bmalloc: eager scavenge leaves behind a bogus allocator 2014-09-11 12:05:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren barraclough benjamin cmarcelo commit-queue kling oldest_to_newest 1034610 0 ggaren 2014-09-11 09:07:27 -0700 bmalloc: eager scavenge leaves behind a bogus allocator 1034611 1 237955 ggaren 2014-09-11 09:09:56 -0700 Created attachment 237955 Patch 1034667 2 237955 sam 2014-09-11 12:04:47 -0700 Comment on attachment 237955 Patch Looks good, though it would be good to add a test case and rename log() to something that implies it adds it to the "to-be-freed" list. 1034668 3 ggaren 2014-09-11 12:05:55 -0700 Committed r173524: <http://trac.webkit.org/changeset/173524> 237955 2014-09-11 09:09:56 -0700 2014-09-11 12:04:47 -0700 Patch bug-136743-20140911090953.patch text/plain 3538 ggaren SW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwCShyZXZpc2lvbiAxNzM0OTUpCisrKyBTb3VyY2UvV1RG L3d0Zi9GYXN0TWFsbG9jLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDYgKzEwMSwxMCBAQAog I2VuZGlmCiAjZW5kaWYKIAorI2lmIChQTEFURk9STShDT0NPQSkgJiYgKENQVShYODZfNjQpIHx8 IENQVShBUk02NCkpKQorI2RlZmluZSBVU0VfQk1BTExPQyAxCisjZW5kaWYKKwogI2lmICEoZGVm aW5lZChVU0VfU1lTVEVNX01BTExPQykgJiYgVVNFX1NZU1RFTV9NQUxMT0MpICYmIGRlZmluZWQo TkRFQlVHKQogI2RlZmluZSBGT1JDRV9TWVNURU1fTUFMTE9DIDAKICNlbHNlCkluZGV4OiBTb3Vy Y2UvYm1hbGxvYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNzM1MTMpCisrKyBTb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwyNSBAQAorMjAxNC0wOS0xMSAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgorCisgICAgICAgIGJtYWxsb2M6IGVhZ2VyIHNjYXZlbmdlIGxlYXZl cyBiZWhpbmQgYSBib2d1cyBhbGxvY2F0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNjc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJlIHN1cmUgdG8gY2xlYXIgdGhlIGFsbG9jYXRvciBhZnRlciBs b2dnaW5nIGl0IGluIHRoZSBlYWdlciBzY2F2ZW5nZQorICAgICAgICBjYXNlLCBzbyB0aGF0IHdl IGRvbid0IGxhdGVyIHRyeSB0byBhbGxvY2F0ZSBvdXQgb2YgdGhlIGxpbmVzIHRoYXQgd2UKKyAg ICAgICAgaGF2ZSB0aHJvd24gYXdheS4KKworICAgICAgICBXZSBkaWRuJ3QgbmVlZCB0byBkbyB0 aGlzIHByZXZpb3VzbHkgYmVjYXVzZSBzY2F2ZW5nZSB3b3VsZCBvbmx5IGhhcHBlbgorICAgICAg ICBhdCB0aHJlYWQgZXhpdCB0aW1lLCBhZnRlciB3aGljaCBubyBmdXJ0aGVyIGFsbG9jYXRpb24g ZnJvbSB0aGUgcGVyLXRocmVhZAorICAgICAgICBjYWNoZSB3b3VsZCB0YWtlIHBsYWNlLgorCisg ICAgICAgICogYm1hbGxvYy9BbGxvY2F0b3IuY3BwOgorICAgICAgICAoYm1hbGxvYzo6QWxsb2Nh dG9yOjpzY2F2ZW5nZSk6CisgICAgICAgICogYm1hbGxvYy9NZWRpdW1BbGxvY2F0b3IuaDoKKyAg ICAgICAgKGJtYWxsb2M6Ok1lZGl1bUFsbG9jYXRvcjo6Y2xlYXIpOgorICAgICAgICAqIGJtYWxs b2MvU21hbGxBbGxvY2F0b3IuaDoKKyAgICAgICAgKGJtYWxsb2M6OlNtYWxsQWxsb2NhdG9yOjpj bGVhcik6CisKIDIwMTQtMDktMDUgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBibWFsbG9jIHNob3VsZCBob25vciB0aGUgRmFzdE1hbGxvYyBzdGF0aXN0aWNz IEFQSQpJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BbGxvY2F0b3IuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTcz NDk1KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BbGxvY2F0b3IuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01NiwxMSArNTYsMTQgQEAgQWxsb2NhdG9yOjp+QWxsb2NhdG9yKCkKICAgICAKIHZv aWQgQWxsb2NhdG9yOjpzY2F2ZW5nZSgpCiB7Ci0gICAgZm9yIChhdXRvJiBhbGxvY2F0b3IgOiBt X3NtYWxsQWxsb2NhdG9ycykKKyAgICBmb3IgKGF1dG8mIGFsbG9jYXRvciA6IG1fc21hbGxBbGxv Y2F0b3JzKSB7CiAgICAgICAgIGxvZyhhbGxvY2F0b3IpOworICAgICAgICBhbGxvY2F0b3IuY2xl YXIoKTsKKyAgICB9CiAgICAgcHJvY2Vzc1NtYWxsQWxsb2NhdG9yTG9nKCk7CiAKICAgICBsb2co bV9tZWRpdW1BbGxvY2F0b3IpOworICAgIG1fbWVkaXVtQWxsb2NhdG9yLmNsZWFyKCk7CiAgICAg cHJvY2Vzc01lZGl1bUFsbG9jYXRvckxvZygpOwogfQogCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9i bWFsbG9jL01lZGl1bUFsbG9jYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvTWVkaXVtQWxsb2NhdG9yLmgJKHJldmlzaW9uIDE3MzQ5NSkKKysrIFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvTWVkaXVtQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1 LDkgQEAgcHVibGljOgogICAgIGJvb2wgYWxsb2NhdGUoc2l6ZV90LCB2b2lkKiYpOwogCiAgICAg dW5zaWduZWQgY2hhciBkZXJlZkNvdW50KCk7CisKICAgICB2b2lkIHJlZmlsbChNZWRpdW1MaW5l Kik7CisgICAgdm9pZCBjbGVhcigpOwogCiBwcml2YXRlOgogICAgIGNoYXIqIG1fZW5kOwpAQCAt MTAxLDYgKzEwMywxMyBAQCBpbmxpbmUgdm9pZCBNZWRpdW1BbGxvY2F0b3I6OnJlZmlsbChNZWRp CiAgICAgbV9vYmplY3RDb3VudCA9IDA7CiB9CiAKK2lubGluZSB2b2lkIE1lZGl1bUFsbG9jYXRv cjo6Y2xlYXIoKQoreworICAgIG1fZW5kID0gbnVsbHB0cjsKKyAgICBtX3JlbWFpbmluZyA9IDA7 CisgICAgbV9vYmplY3RDb3VudCA9IDA7Cit9CisKIH0gLy8gbmFtZXNwYWNlIGJtYWxsb2MKIAog I2VuZGlmIC8vIE1lZGl1bUFsbG9jYXRvcl9oCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9j L1NtYWxsQWxsb2NhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9T bWFsbEFsbG9jYXRvci5oCShyZXZpc2lvbiAxNzM0OTUpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFs bG9jL1NtYWxsQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDcgKzQ3LDkgQEAgcHVi bGljOgogCiAgICAgdW5zaWduZWQgc2hvcnQgb2JqZWN0Q291bnQoKTsKICAgICB1bnNpZ25lZCBj aGFyIGRlcmVmQ291bnQoKTsKKwogICAgIHZvaWQgcmVmaWxsKFNtYWxsTGluZSopOworICAgIHZv aWQgY2xlYXIoKTsKIAogcHJpdmF0ZToKICAgICBjaGFyKiBtX3B0cjsKQEAgLTEwNyw2ICsxMDks MTIgQEAgaW5saW5lIHZvaWQgU21hbGxBbGxvY2F0b3I6OnJlZmlsbChTbWFsbAogICAgIG1fcmVt YWluaW5nID0gbV9tYXhPYmplY3RDb3VudDsKIH0KIAoraW5saW5lIHZvaWQgU21hbGxBbGxvY2F0 b3I6OmNsZWFyKCkKK3sKKyAgICBtX3B0ciA9IG51bGxwdHI7CisgICAgbV9yZW1haW5pbmcgPSAw OworfQorCiB9IC8vIG5hbWVzcGFjZSBibWFsbG9jCiAKICNlbmRpZiAvLyBTbWFsbEFsbG9jYXRv cl9oCg==