136737 2014-09-11 01:55:13 -0700 CanvasRenderingContext2D should update the computed style while setting the font 2014-09-12 17:07:23 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivekg commit-queue darin esprehn+autocc gyuyoung.kim simon.fraser oldest_to_newest 1034560 0 vivekg 2014-09-11 01:55:13 -0700 Before accessing the computed style for populating 'font' property of CanvasRenderingContext2D we have to make sure we have a up-to-date computed style to avoid any stale reference. 1034564 1 237945 vivekg 2014-09-11 02:08:42 -0700 Created attachment 237945 Patch 1034565 2 vivekg 2014-09-11 02:12:37 -0700 Please take a look, thank you. 1034607 3 vivekg 2014-09-11 08:37:23 -0700 Here is the jsfiddle test: http://jsfiddle.net/j424ygda/ 1034898 4 vivekg 2014-09-12 11:32:42 -0700 Friendly ping! 1035016 5 237945 commit-queue 2014-09-12 17:07:19 -0700 Comment on attachment 237945 Patch Clearing flags on attachment: 237945 Committed r173591: <http://trac.webkit.org/changeset/173591> 1035017 6 commit-queue 2014-09-12 17:07:23 -0700 All reviewed patches have been landed. Closing bug. 237945 2014-09-11 02:08:42 -0700 2014-09-12 17:07:18 -0700 Patch bug-136737-20140911143840.patch text/plain 4827 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZhYWUxNjcyMWIwYmEw NDdiM2ZiMDhkNzc2NmM3Y2IyMDNjODQyMC4uYTk2NjgxNDJlMTllOTU1N2VlMGQ0MjFiYjU0MDVh MTExMjY0ZjBkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA5LTExICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIENhbnZhc1JlbmRl cmluZ0NvbnRleHQyRCBzaG91bGQgdXBkYXRlIHRoZSBjb21wdXRlZCBzdHlsZSB3aGlsZSBzZXR0 aW5nIHRoZSBmb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzY3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCZWZvcmUgYWNjZXNzaW5nIHRoZSBjb21wdXRlZCBzdHlsZSBmb3IgcG9wdWxhdGluZyAn Zm9udCcgcHJvcGVydHkgb2YgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJECisgICAgICAgIG1ha2Ug c3VyZSB0byBoYXZlIGFuIHVwLXRvLWRhdGUgY29tcHV0ZWQgc3R5bGUgYXZvaWRpbmcgYW55IHN0 YWxlIHJlZmVyZW5jZS4KKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtc2V0LWZv bnQtd2l0aC11cGRhdGVkLXN0eWxlLmh0bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJp bmdDb250ZXh0MkQ6OnNldEZvbnQpOgorCiAyMDE0LTA5LTEwICBHeXV5b3VuZyBLaW0gIDxneXV5 b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVXNlIEFTU0VSVCBpbnN0ZWFkIG9mIEFT U0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCA0NjBiYTQw YzhiYTIxNWU2NTE4MDFlMDdkMTRkMmU4N2ZlNThhZjE1Li41NWI3YWI5MmY3ZDE1ZWFhYTE4OGYz MDIzNWU4Y2Y0NWY0NDcxMTk0IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTIwODQsNiArMjA4NCw3IEBA IHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRGb250KGNvbnN0IFN0cmluZyYgbmV3 Rm9udCkKICAgICAvLyBNYXAgdGhlIDxjYW52YXM+IGZvbnQgaW50byB0aGUgdGV4dCBzdHlsZS4g SWYgdGhlIGZvbnQgdXNlcyBrZXl3b3JkcyBsaWtlIGxhcmdlci9zbWFsbGVyLCB0aGVzZSB3aWxs IHdvcmsKICAgICAvLyByZWxhdGl2ZSB0byB0aGUgY2FudmFzLgogICAgIFJlZlB0cjxSZW5kZXJT dHlsZT4gbmV3U3R5bGUgPSBSZW5kZXJTdHlsZTo6Y3JlYXRlKCk7CisgICAgY2FudmFzKCktPmRv Y3VtZW50KCkudXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogICAgIGlmIChSZW5kZXJTdHlsZSogY29t cHV0ZWRTdHlsZSA9IGNhbnZhcygpLT5jb21wdXRlZFN0eWxlKCkpCiAgICAgICAgIG5ld1N0eWxl LT5zZXRGb250RGVzY3JpcHRpb24oY29tcHV0ZWRTdHlsZS0+Zm9udERlc2NyaXB0aW9uKCkpOwog ICAgIGVsc2UgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IGU5ZjJkMGY3MTRiZDc1MGViZTNlMjQ2ZTJlM2UzYWFhNDFiZTUx NjEuLmY4MmFjYjU0MzFkZDEwZmNhYjFjZTZhNmVhNzYzNDY3MjBhMDlkNjMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wOS0xMSAgVml2ZWsgR2FsYXRhZ2UgIDx2aXZlay52Z0BzYW1zdW5n LmNvbT4KKworICAgICAgICBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQgc2hvdWxkIHVwZGF0ZSB0 aGUgY29tcHV0ZWQgc3R5bGUgd2hpbGUgc2V0dGluZyB0aGUgZm9udAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NzM3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtc2V0 LWZvbnQtd2l0aC11cGRhdGVkLXN0eWxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9jYW52YXMvY2FudmFzLXNldC1mb250LXdpdGgtdXBkYXRlZC1zdHlsZS5odG1sOiBBZGRl ZC4KKwogMjAxNC0wOS0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkIGdhcmRlbmluZy4gUmViYXNlbGluZSBmYWlsaW5nIG1lZGlhL3ZpZGVv LSB0ZXN0cyBicm9rZW4gYnkgcjE1NjU0Ni4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL2NhbnZhcy1zZXQtZm9udC13aXRoLXVwZGF0ZWQtc3R5bGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXNldC1mb250LXdpdGgtdXBkYXRlZC1zdHls ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzNlNzMxMjBkNGRjODdkODg3NjQ2NjU3NWFjOTE5 ZjBhZmQ3YWUyNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1zZXQtZm9udC13aXRoLXVwZGF0ZWQtc3R5bGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MiBAQAorVGVzdHMgdGhhdCBzZXR0aW5nIGZvbnQgb2YgQ2FudmFzIDJkIGNvbnRleHQgYWx3YXlz IHVzZXMgdXAtdG8tZGF0ZSBzdHlsZTogUEFTUworIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvY2FudmFzLXNldC1mb250LXdpdGgtdXBkYXRlZC1zdHlsZS5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXNldC1mb250LXdpdGgtdXBkYXRlZC1zdHlsZS5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjdjZWMyOGIyNjU5OWNjZDMwNmY1YTE3NjUyNTliNDIwNWQ3M2RiOTAK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtc2V0LWZv bnQtd2l0aC11cGRhdGVkLXN0eWxlLmh0bWwKQEAgLTAsMCArMSw1NCBAQAorPCFET0NUWVBFIEhU TUw+Cis8aHRtbD4KKzxzdHlsZT4KK2NhbnZhcyB7CisgICAgYm9yZGVyOiAxcHggc29saWQgYmxh Y2s7Cit9CisucGFzcyB7CisgICAgY29sb3I6IGdyZWVuOworICAgIGZvbnQtd2VpZ2h0OiBib2xk OworfQorCisuZmFpbCB7CisgICAgY29sb3I6IHJlZDsKKyAgICBmb250LXdlaWdodDogYm9sZDsK K30KKzwvc3R5bGU+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorPGRpdj4KKzxzcGFuPlRl c3RzIHRoYXQgc2V0dGluZyBmb250IG9mIENhbnZhcyAyZCBjb250ZXh0IGFsd2F5cyB1c2VzIHVw LXRvLWRhdGUgc3R5bGU6IDxzcGFuIGlkPSJyZXN1bHQiPjwvc3Bhbj48L3NwYW4+PGJyPgorPGNh bnZhcyBpZD0iZXhwZWN0ZWQiPjwvY2FudmFzPgorPGNhbnZhcyBpZD0iYWN0dWFsIj48L2NhbnZh cz4KKzwvZGl2PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoraWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBkcmF3 Q2FudmFzVGV4dChpZCwgdGV4dCwgZm9yY2VTdHlsZVVwZGF0ZSkKK3sKKyAgICB2YXIgY2FudmFz RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGlkKTsKKyAgICB2YXIgY29udGV4dCA9 IGNhbnZhc0VsZW1lbnQuZ2V0Q29udGV4dCgnMmQnKTsKKyAgICBjb250ZXh0LmZvbnQgPSAnMjBw eCBBcmlhbCc7CisgICAgY29udGV4dC5maWxsVGV4dChpZCwgMCwgMjApOworICAgIGNhbnZhc0Vs ZW1lbnQub2Zmc2V0VG9wOworICAgIGNhbnZhc0VsZW1lbnQuc3R5bGUuZm9udFNpemUgPSAnNjRw eCc7CisKKyAgICBpZiAoZm9yY2VTdHlsZVVwZGF0ZSkKKyAgICAgICAgY2FudmFzRWxlbWVudC5v ZmZzZXRUb3A7CisgICAgY29udGV4dC5mb250ID0gJzFlbSBDYWxpYnJpJzsKKyAgICBjb250ZXh0 LmZpbGxUZXh0KHRleHQsIDAsIDEwMCk7CisgICAgcmV0dXJuIGNvbnRleHQuZm9udDsKK30KKwor ZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgdmFyIGV4cGVjdGVkRm9udFNpemUgPSBkcmF3Q2Fu dmFzVGV4dCgnZXhwZWN0ZWQnLCAnU29tZSBUZXh0JywgdHJ1ZSk7CisgICAgdmFyIGFjdHVhbEZv bnRTaXplID0gZHJhd0NhbnZhc1RleHQoJ2FjdHVhbCcsICdTb21lIFRleHQnKTsKKyAgICB2YXIg cmVzdWx0RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKTsKKyAgICB2 YXIgcmVzdWx0ID0gZXhwZWN0ZWRGb250U2l6ZSA9PT0gYWN0dWFsRm9udFNpemUgPyAnUEFTUycg OiAnRkFJTCc7CisgICAgcmVzdWx0RWxlbWVudC50ZXh0Q29udGVudCA9IHJlc3VsdDsKKyAgICBy ZXN1bHRFbGVtZW50LmNsYXNzTmFtZSA9IChyZXN1bHQgPT09ICdQQVNTJykgPyAncGFzcycgOiAn ZmFpbCc7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K