136732 2014-09-10 20:39:49 -0700 Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION 2014-09-10 21:42:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136694 1 gyuyoung.kim gyuyoung.kim aestes commit-queue oldest_to_newest 1034512 0 gyuyoung.kim 2014-09-10 20:39:49 -0700 Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't need to be used anymore. ASSERT is enough for it. 1034514 1 237929 gyuyoung.kim 2014-09-10 20:40:36 -0700 Created attachment 237929 Patch 1034515 2 gyuyoung.kim 2014-09-10 20:42:14 -0700 Andy, Sorry about that. I missed to change it. Fixed those nits on this patch. 1034516 3 237929 aestes 2014-09-10 20:43:13 -0700 Comment on attachment 237929 Patch Thanks for following up! 1034522 4 237929 commit-queue 2014-09-10 21:42:52 -0700 Comment on attachment 237929 Patch Clearing flags on attachment: 237929 Committed r173507: <http://trac.webkit.org/changeset/173507> 1034523 5 commit-queue 2014-09-10 21:42:54 -0700 All reviewed patches have been landed. Closing bug. 237929 2014-09-10 20:40:36 -0700 2014-09-10 21:42:51 -0700 Patch bug-136732-20140911124032.patch text/plain 3262 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNmZmNlNjZmY2I0YjU1 M2VmMzI4NDcyZDJmODE4ODM0NDUzN2ZiNi4uNWZhNDIyMzEyMWFkMTIxZjllNTBlN2NlNmFmMGMw MGNmMGM5ZDUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA5LTEwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIEFTU0VS VCBpbnN0ZWFkIG9mIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY3MzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSByMTczNDU4IGNoYW5n ZWQgdG8gdXNlIHN0YXRpY19jYXN0PD4gd2l0aCB0b0ZvbywgQVNTRVJUX1dJVEhfU0VDVVJJVFlf SU1QTElDQVRJT04gZG9lc24ndAorICAgICAgICBuZWVkIHRvIGJlIHVzZWQgYW55bW9yZS4gQVNT RVJUIGlzIGVub3VnaCBmb3IgaXQuCisKKyAgICAgICAgKiB3b3JrZXJzL0RlZmF1bHRTaGFyZWRX b3JrZXJSZXBvc2l0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZFdvcmtlclByb3h5 OjphZGRUb1dvcmtlckRvY3VtZW50cyk6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJNZXNzYWdp bmdQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJNZXNzYWdpbmdQcm94eTo6c3Rh cnRXb3JrZXJHbG9iYWxTY29wZSk6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0Ojpkb2N1bWVudCk6CisKIDIwMTQtMDkt MDkgIE15bGVzIEMuIE1heGZpZWxkIDxtbWF4ZmllbGRAYXBwbGUuY29tPiAgPGxpdGhlcnVtQGdt YWlsLmNvbT4KIAogICAgICAgICBEZWxldGUgY2xhc3MgU2F2ZWREcmF3aW5nU3RhdGVGb3JNYXNr CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL0RlZmF1bHRTaGFyZWRXb3JrZXJS ZXBvc2l0b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvRGVmYXVsdFNoYXJlZFdvcmtl clJlcG9zaXRvcnkuY3BwCmluZGV4IGVlOWM2NzQ3NTU4M2JhNjc1MmM0MjcwNjM0ZGM4ZDA1YWFh MGI3ZGEuLjkzMGM2MTRhNDJkMDI3NjUzNTk3ZTI4YzY5YjU4MGY0ZDI5NzYzZDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvRGVmYXVsdFNoYXJlZFdvcmtlclJlcG9zaXRvcnku Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvRGVmYXVsdFNoYXJlZFdvcmtlclJlcG9z aXRvcnkuY3BwCkBAIC0yMjUsNyArMjI1LDcgQEAgdm9pZCBTaGFyZWRXb3JrZXJQcm94eTo6d29y a2VyR2xvYmFsU2NvcGVEZXN0cm95ZWQoKQogdm9pZCBTaGFyZWRXb3JrZXJQcm94eTo6YWRkVG9X b3JrZXJEb2N1bWVudHMoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKIHsKICAgICAv LyBOZXN0ZWQgd29ya2VycyBhcmUgbm90IHlldCBzdXBwb3J0ZWQsIHNvIHBhc3NlZC1pbiBjb250 ZXh0IHNob3VsZCBhbHdheXMgYmUgYSBEb2N1bWVudC4KLSAgICBBU1NFUlRfV0lUSF9TRUNVUklU WV9JTVBMSUNBVElPTihjb250ZXh0KTsKKyAgICBBU1NFUlQoY29udGV4dCk7CiAgICAgQVNTRVJU KCFpc0Nsb3NpbmcoKSk7CiAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX3dvcmtlckRvY3VtZW50c0xv Y2spOwogICAgIG1fd29ya2VyRG9jdW1lbnRzLmFkZCh0b0RvY3VtZW50KGNvbnRleHQpKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTWVzc2FnaW5nUHJveHkuY3Bw IGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJNZXNzYWdpbmdQcm94eS5jcHAKaW5kZXgg MmNkMDA5ZmVkYjY1ODVkNWIzZWQ5ZWQyZmEzYTYzNjFhNzk5MTU2ZC4uYzNjMThjMDc0ZWUzYWZl YjE3NzMyYmU0M2Y5N2IxZjc4ZTk4NGRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29y a2Vycy9Xb3JrZXJNZXNzYWdpbmdQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9Xb3JrZXJNZXNzYWdpbmdQcm94eS5jcHAKQEAgLTgyLDcgKzgyLDcgQEAgV29ya2VyTWVzc2Fn aW5nUHJveHk6On5Xb3JrZXJNZXNzYWdpbmdQcm94eSgpCiB2b2lkIFdvcmtlck1lc3NhZ2luZ1By b3h5OjpzdGFydFdvcmtlckdsb2JhbFNjb3BlKGNvbnN0IFVSTCYgc2NyaXB0VVJMLCBjb25zdCBT dHJpbmcmIHVzZXJBZ2VudCwgY29uc3QgU3RyaW5nJiBzb3VyY2VDb2RlLCBXb3JrZXJUaHJlYWRT dGFydE1vZGUgc3RhcnRNb2RlKQogewogICAgIC8vIEZJWE1FOiBUaGlzIG5lZWQgdG8gYmUgcmV2 aXNpdGVkIHdoZW4gd2Ugc3VwcG9ydCBuZXN0ZWQgd29ya2VyIG9uZSBkYXkKLSAgICBBU1NFUlRf V0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOworICAg IEFTU0VSVChtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOwogICAgIERvY3VtZW50KiBkb2N1bWVu dCA9IHRvRG9jdW1lbnQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKICAgICBHcm91cFNldHRp bmdzKiBzZXR0aW5ncyA9IDA7CiAgICAgaWYgKGRvY3VtZW50LT5wYWdlKCkpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUv eG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCA5YjMxZjJlMzE3ZDJjYmIzNGM5YmI4M2I2ZDcx ZWU0ZDBmM2NhMGUxLi43NGExMzAyYzhkMTNmYjdiYjk3MTdjYzU5YTZjN2I1YTYzYTVmMjZmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTE1NCw3ICsxNTQsNyBAQCBY TUxIdHRwUmVxdWVzdDo6flhNTEh0dHBSZXF1ZXN0KCkKIAogRG9jdW1lbnQqIFhNTEh0dHBSZXF1 ZXN0Ojpkb2N1bWVudCgpIGNvbnN0CiB7Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElD QVRJT04oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKKyAgICBBU1NFUlQoc2NyaXB0RXhlY3V0 aW9uQ29udGV4dCgpKTsKICAgICByZXR1cm4gdG9Eb2N1bWVudChzY3JpcHRFeGVjdXRpb25Db250 ZXh0KCkpOwogfQogCg==