136720 2014-09-10 15:48:30 -0700 [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop 2014-09-10 21:02:11 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 savagobr webkit-unassigned commit-queue d-r fmalita fpizlo gyuyoung.kim pdr schenney sergio zimmermann oldest_to_newest 1034444 0 savagobr 2014-09-10 15:48:30 -0700 Use some C++11 goodness to cleanup iterator loops. 1034445 1 237913 savagobr 2014-09-10 15:49:46 -0700 Created attachment 237913 Patch 1034506 2 237913 fpizlo 2014-09-10 19:32:41 -0700 Comment on attachment 237913 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > + for (auto& it : m_scheduledAnimations) { There is something funky going on with indentation here - is that a hardware tab? 1034507 3 fpizlo 2014-09-10 19:33:24 -0700 (In reply to comment #2) > (From update of attachment 237913 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > > > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > > + for (auto& it : m_scheduledAnimations) { > > There is something funky going on with indentation here - is that a hardware tab? Looks like spaces, but still, I think that this should be indented only 4 spaces. 1034509 4 237928 savagobr 2014-09-10 19:50:02 -0700 Created attachment 237928 Addressing the spaces issue. 1034518 5 237928 commit-queue 2014-09-10 21:02:05 -0700 Comment on attachment 237928 Addressing the spaces issue. Clearing flags on attachment: 237928 Committed r173506: <http://trac.webkit.org/changeset/173506> 1034519 6 commit-queue 2014-09-10 21:02:11 -0700 All reviewed patches have been landed. Closing bug. 237913 2014-09-10 15:49:46 -0700 2014-09-10 19:50:02 -0700 Patch bug-136720-20140910154944.patch text/plain 2378 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E5MmNmYmUyOTQwZjYz OGUzZTJiODU4NDRkNDg5Njc1MzM4MzI1Yi4uMmYzMTRhMjA5ZGZkOTUwNTliNzg4NWI4N2JhZjQy NTI0NDk4NGVhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTEwICBBZGVu aWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBbU1ZH XSBDbGVhbnVwIGl0ZXJhdG9yIGNvZGUgaW4gU01JTFRpbWVDb250YWluZXIgdXNpbmcgcmFuZ2Ut YmFzZWQgbG9vcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2NzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2Ugb24gYmVoYXZpb3IuCisKKyAgICAgICAgKiBzdmcv YW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNNSUxU aW1lQ29udGFpbmVyOjpzZXRFbGFwc2VkKToKKyAgICAgICAgKFdlYkNvcmU6OlNNSUxUaW1lQ29u dGFpbmVyOjp1cGRhdGVBbmltYXRpb25zKToKKwogMjAxNC0wOS0xMCAgcGVhdm9Ab3V0bG9vay5j b20gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBbQ3VybF0gQ29tcGlsZSBlcnJvciwg Q2VydGlmaWNhdGVJbmZvLmggaXMgbm90IGZvdW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9z dmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcAppbmRleCA2MTI0NjEyNGYzZDA5MjBi N2RhMzM3ZmZmMWFhZTk4NzgyNWY1NzFhLi44NWFiNTIwYzZiODYzMjg1OTBlZjllZDUwNzQ3NmEx NGJjNjZlNjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxU aW1lQ29udGFpbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxU aW1lQ29udGFpbmVyLmNwcApAQCAtMTg4LDkgKzE4OCw4IEBAIHZvaWQgU01JTFRpbWVDb250YWlu ZXI6OnNldEVsYXBzZWQoU01JTFRpbWUgdGltZSkKICNpZm5kZWYgTkRFQlVHCiAgICAgbV9wcmV2 ZW50U2NoZWR1bGVkQW5pbWF0aW9uc0NoYW5nZXMgPSB0cnVlOwogI2VuZGlmCi0gICAgR3JvdXBl ZEFuaW1hdGlvbnNNYXA6Oml0ZXJhdG9yIGVuZCA9IG1fc2NoZWR1bGVkQW5pbWF0aW9ucy5lbmQo KTsKLSAgICBmb3IgKEdyb3VwZWRBbmltYXRpb25zTWFwOjppdGVyYXRvciBpdCA9IG1fc2NoZWR1 bGVkQW5pbWF0aW9ucy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAgICAgICAgQW5pbWF0 aW9uc1ZlY3Rvciogc2NoZWR1bGVkID0gaXQtPnZhbHVlLmdldCgpOworICAgICAgICBmb3IgKGF1 dG8mIGl0IDogbV9zY2hlZHVsZWRBbmltYXRpb25zKSB7CisgICAgICAgIEFuaW1hdGlvbnNWZWN0 b3IqIHNjaGVkdWxlZCA9IGl0LnZhbHVlLmdldCgpOwogICAgICAgICB1bnNpZ25lZCBzaXplID0g c2NoZWR1bGVkLT5zaXplKCk7CiAgICAgICAgIGZvciAodW5zaWduZWQgbiA9IDA7IG4gPCBzaXpl OyBuKyspCiAgICAgICAgICAgICBzY2hlZHVsZWQtPmF0KG4pLT5yZXNldCgpOwpAQCAtMjY2LDkg KzI2NSw4IEBAIHZvaWQgU01JTFRpbWVDb250YWluZXI6OnVwZGF0ZUFuaW1hdGlvbnMoU01JTFRp bWUgZWxhcHNlZCwgYm9vbCBzZWVrVG9UaW1lKQogI2VuZGlmCiAKICAgICBBbmltYXRpb25zVmVj dG9yIGFuaW1hdGlvbnNUb0FwcGx5OwotICAgIEdyb3VwZWRBbmltYXRpb25zTWFwOjppdGVyYXRv ciBlbmQgPSBtX3NjaGVkdWxlZEFuaW1hdGlvbnMuZW5kKCk7Ci0gICAgZm9yIChHcm91cGVkQW5p bWF0aW9uc01hcDo6aXRlcmF0b3IgaXQgPSBtX3NjaGVkdWxlZEFuaW1hdGlvbnMuYmVnaW4oKTsg aXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAgIEFuaW1hdGlvbnNWZWN0b3IqIHNjaGVkdWxlZCA9 IGl0LT52YWx1ZS5nZXQoKTsKKyAgICBmb3IgKGF1dG8mIGl0IDogbV9zY2hlZHVsZWRBbmltYXRp b25zKSB7CisgICAgICAgIEFuaW1hdGlvbnNWZWN0b3IqIHNjaGVkdWxlZCA9IGl0LnZhbHVlLmdl dCgpOwogCiAgICAgICAgIC8vIFNvcnQgYWNjb3JkaW5nIHRvIHByaW9yaXR5LiBFbGVtZW50cyB3 aXRoIGxhdGVyIGJlZ2luIHRpbWUgaGF2ZSBoaWdoZXIgcHJpb3JpdHkuCiAgICAgICAgIC8vIElu IGNhc2Ugb2YgYSB0aWUsIGRvY3VtZW50IG9yZGVyIGRlY2lkZXMuIAo= 237928 2014-09-10 19:50:02 -0700 2014-09-10 21:02:04 -0700 Addressing the spaces issue. 0001-Cleanup-iterator-loop-addressing-reviewer-s-note.patch text/plain 2666 savagobr RnJvbSA4MDM1MGQ1MWI3YmU5OGEwNGIyODViODAxZDliODZjYzJkYmI3MmU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBXZWQsIDEwIFNlcCAyMDE0IDE1OjUxOjE3IC0wNzAwClN1YmplY3Q6IFtQ QVRDSF0gQ2xlYW51cCBpdGVyYXRvciBsb29wLCBhZGRyZXNzaW5nIHJldmlld2VyJ3Mgbm90ZS4K Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAxMyArKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1l Q29udGFpbmVyLmNwcCB8IDEwICsrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E5MmNmYi4uMmYzMTRhMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTEwICBBZGVuaWxzb24gQ2F2YWxj YW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBbU1ZHXSBDbGVhbnVwIGl0 ZXJhdG9yIGNvZGUgaW4gU01JTFRpbWVDb250YWluZXIgdXNpbmcgcmFuZ2UtYmFzZWQgbG9vcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NzIwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBjaGFuZ2Ugb24gYmVoYXZpb3IuCisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9uL1NN SUxUaW1lQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNNSUxUaW1lQ29udGFpbmVy OjpzZXRFbGFwc2VkKToKKyAgICAgICAgKFdlYkNvcmU6OlNNSUxUaW1lQ29udGFpbmVyOjp1cGRh dGVBbmltYXRpb25zKToKKwogMjAxNC0wOS0xMCAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0Bv dXRsb29rLmNvbT4KIAogICAgICAgICBbQ3VybF0gQ29tcGlsZSBlcnJvciwgQ2VydGlmaWNhdGVJ bmZvLmggaXMgbm90IGZvdW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1h dGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9u L1NNSUxUaW1lQ29udGFpbmVyLmNwcAppbmRleCA2MTI0NjEyLi45YWMwYjYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcApAQCAt MTg4LDkgKzE4OCw4IEBAIHZvaWQgU01JTFRpbWVDb250YWluZXI6OnNldEVsYXBzZWQoU01JTFRp bWUgdGltZSkKICNpZm5kZWYgTkRFQlVHCiAgICAgbV9wcmV2ZW50U2NoZWR1bGVkQW5pbWF0aW9u c0NoYW5nZXMgPSB0cnVlOwogI2VuZGlmCi0gICAgR3JvdXBlZEFuaW1hdGlvbnNNYXA6Oml0ZXJh dG9yIGVuZCA9IG1fc2NoZWR1bGVkQW5pbWF0aW9ucy5lbmQoKTsKLSAgICBmb3IgKEdyb3VwZWRB bmltYXRpb25zTWFwOjppdGVyYXRvciBpdCA9IG1fc2NoZWR1bGVkQW5pbWF0aW9ucy5iZWdpbigp OyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAgICAgICAgQW5pbWF0aW9uc1ZlY3Rvciogc2NoZWR1bGVk ID0gaXQtPnZhbHVlLmdldCgpOworICAgIGZvciAoYXV0byYgaXQgOiBtX3NjaGVkdWxlZEFuaW1h dGlvbnMpIHsKKyAgICAgICAgQW5pbWF0aW9uc1ZlY3Rvciogc2NoZWR1bGVkID0gaXQudmFsdWUu Z2V0KCk7CiAgICAgICAgIHVuc2lnbmVkIHNpemUgPSBzY2hlZHVsZWQtPnNpemUoKTsKICAgICAg ICAgZm9yICh1bnNpZ25lZCBuID0gMDsgbiA8IHNpemU7IG4rKykKICAgICAgICAgICAgIHNjaGVk dWxlZC0+YXQobiktPnJlc2V0KCk7CkBAIC0yNjYsOSArMjY1LDggQEAgdm9pZCBTTUlMVGltZUNv bnRhaW5lcjo6dXBkYXRlQW5pbWF0aW9ucyhTTUlMVGltZSBlbGFwc2VkLCBib29sIHNlZWtUb1Rp bWUpCiAjZW5kaWYKIAogICAgIEFuaW1hdGlvbnNWZWN0b3IgYW5pbWF0aW9uc1RvQXBwbHk7Ci0g ICAgR3JvdXBlZEFuaW1hdGlvbnNNYXA6Oml0ZXJhdG9yIGVuZCA9IG1fc2NoZWR1bGVkQW5pbWF0 aW9ucy5lbmQoKTsKLSAgICBmb3IgKEdyb3VwZWRBbmltYXRpb25zTWFwOjppdGVyYXRvciBpdCA9 IG1fc2NoZWR1bGVkQW5pbWF0aW9ucy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAgICAg ICAgQW5pbWF0aW9uc1ZlY3Rvciogc2NoZWR1bGVkID0gaXQtPnZhbHVlLmdldCgpOworICAgIGZv ciAoYXV0byYgaXQgOiBtX3NjaGVkdWxlZEFuaW1hdGlvbnMpIHsKKyAgICAgICAgQW5pbWF0aW9u c1ZlY3Rvciogc2NoZWR1bGVkID0gaXQudmFsdWUuZ2V0KCk7CiAKICAgICAgICAgLy8gU29ydCBh Y2NvcmRpbmcgdG8gcHJpb3JpdHkuIEVsZW1lbnRzIHdpdGggbGF0ZXIgYmVnaW4gdGltZSBoYXZl IGhpZ2hlciBwcmlvcml0eS4KICAgICAgICAgLy8gSW4gY2FzZSBvZiBhIHRpZSwgZG9jdW1lbnQg b3JkZXIgZGVjaWRlcy4gCi0tIAoxLjguNS4yIChBcHBsZSBHaXQtNDgpCgo=