136713 2014-09-10 13:25:48 -0700 Remove ImageSource::ShouldSkipMetadata 2014-09-10 15:23:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton mitz psolanki simon.fraser oldest_to_newest 1034382 0 thorton 2014-09-10 13:25:48 -0700 Remove ImageSource::ShouldSkipMetadata 1034383 1 237902 thorton 2014-09-10 13:26:17 -0700 Created attachment 237902 Patch 1034388 2 237902 psolanki 2014-09-10 13:34:09 -0700 Comment on attachment 237902 Patch Nice. 1034432 3 thorton 2014-09-10 15:23:22 -0700 http://trac.webkit.org/changeset/173493 237902 2014-09-10 13:26:17 -0700 2014-09-10 13:34:08 -0700 Patch bug-136713-20140910132613.patch text/plain 6148 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRhODI1YzEwNDYxYTQ1 ZTA4M2VmZDU5NTU4NjQxODJmZDE4ZmVmMC4uNzVkMzJlNmY4MjJiYjA3NWI1NTA5NzYxMTM0YTVj NmYwNmQxODdkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA5LTEwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBJbWFn ZVNvdXJjZTo6U2hvdWxkU2tpcE1ldGFkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmg6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVJbWFnZVNvdXJjZU9wdGlvbnMpOgorICAgICAgICAoV2ViQ29yZTo6 aW1hZ2VTb3VyY2VPcHRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlU291cmNlOjpmcmFt ZVNpemVBdEluZGV4KToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlU291cmNlOjpjcmVhdGVGcmFt ZUF0SW5kZXgpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OmZyYW1lRHVyYXRpb25B dEluZGV4KToKKyAgICAgICAgUmVtb3ZlIFNob3VsZFNraXBNZXRhZGF0YSBhbmQgdXNlcnMuIE5v Ym9keSBldmVyIHVzZXMgRG9Ob3RTa2lwTWV0YWRhdGEuCisKIDIwMTQtMDktMTAgIE15bGVzIEMu IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBMYXlpbmcgb3V0IGEg VGV4dFJ1biB1c2luZyBhbiBTVkcgZm9udCBpcyBPKG5eMikKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5oCmluZGV4IDI4MWY2MWM3ODcxZGVhYWZkMmY4 ZDFkMTE5OTg4OTVjYjhjYjMxZDMuLmFjZGQxY2U0Y2UzMDBkZTgxYzllMDYyZWVlNzYwN2JmNDcy YTcwYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdl U291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3Vy Y2UuaApAQCAtOTMsMTMgKzkzLDYgQEAgcHVibGljOgogICAgICAgICBHYW1tYUFuZENvbG9yUHJv ZmlsZUlnbm9yZWQKICAgICB9OwogCi0jaWYgVVNFKENHKQotICAgIGVudW0gU2hvdWxkU2tpcE1l dGFkYXRhIHsKLSAgICAgICAgRG9Ob3RTa2lwTWV0YWRhdGEsCi0gICAgICAgIFNraXBNZXRhZGF0 YQotICAgIH07Ci0jZW5kaWYKLQogICAgIEltYWdlU291cmNlKEFscGhhT3B0aW9uIGFscGhhT3B0 aW9uID0gQWxwaGFQcmVtdWx0aXBsaWVkLCBHYW1tYUFuZENvbG9yUHJvZmlsZU9wdGlvbiBnYW1t YUFuZENvbG9yUHJvZmlsZU9wdGlvbiA9IEdhbW1hQW5kQ29sb3JQcm9maWxlQXBwbGllZCk7CiAg ICAgfkltYWdlU291cmNlKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKaW5kZXggOTc5M2M5MWE1OTUyYWNiZGUzYjUz ZmU4ZDZlZGRmZTk5MDU2MTg4ZC4uZTRjYTg4NTVjMDU2YTZlZDgwZGUyZjYwMzBlODFhYTJlYmJh MmY3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1h Z2VTb3VyY2VDRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VTb3VyY2VDRy5jcHAKQEAgLTEwNiwxNCArMTA2LDEyIEBAIHZvaWQgSW1hZ2VTb3VyY2U6 OmNsZWFyKGJvb2wgZGVzdHJveUFsbEZyYW1lcywgc2l6ZV90LCBTaGFyZWRCdWZmZXIqIGRhdGEs IGJvb2wKICAgICAgICAgc2V0RGF0YShkYXRhLCBhbGxEYXRhUmVjZWl2ZWQpOwogfQogCi1zdGF0 aWMgQ0ZEaWN0aW9uYXJ5UmVmIGNyZWF0ZUltYWdlU291cmNlT3B0aW9ucyhJbWFnZVNvdXJjZTo6 U2hvdWxkU2tpcE1ldGFkYXRhIHNraXBNZXRhRGF0YSwgU3Vic2FtcGxpbmdMZXZlbCBzdWJzYW1w bGluZ0xldmVsKQorc3RhdGljIENGRGljdGlvbmFyeVJlZiBjcmVhdGVJbWFnZVNvdXJjZU9wdGlv bnMoU3Vic2FtcGxpbmdMZXZlbCBzdWJzYW1wbGluZ0xldmVsKQogewotICAgIGNvbnN0IENGQm9v bGVhblJlZiBpbWFnZVNvdXJjZVNraXBNZXRhZGF0YSA9IChza2lwTWV0YURhdGEgPT0gSW1hZ2VT b3VyY2U6OlNraXBNZXRhZGF0YSkgPyBrQ0ZCb29sZWFuVHJ1ZSA6IGtDRkJvb2xlYW5GYWxzZTsK LSAgICAKICAgICBpZiAoIXN1YnNhbXBsaW5nTGV2ZWwpIHsKICAgICAgICAgY29uc3QgdW5zaWdu ZWQgbnVtT3B0aW9ucyA9IDM7CiAgICAgICAgIGNvbnN0IHZvaWQqIGtleXNbbnVtT3B0aW9uc10g PSB7IGtDR0ltYWdlU291cmNlU2hvdWxkQ2FjaGUsIGtDR0ltYWdlU291cmNlU2hvdWxkUHJlZmVy UkdCMzIsIGtDR0ltYWdlU291cmNlU2tpcE1ldGFkYXRhIH07Ci0gICAgICAgIGNvbnN0IHZvaWQq IHZhbHVlc1tudW1PcHRpb25zXSA9IHsga0NGQm9vbGVhblRydWUsIGtDRkJvb2xlYW5UcnVlLCBp bWFnZVNvdXJjZVNraXBNZXRhZGF0YSB9OworICAgICAgICBjb25zdCB2b2lkKiB2YWx1ZXNbbnVt T3B0aW9uc10gPSB7IGtDRkJvb2xlYW5UcnVlLCBrQ0ZCb29sZWFuVHJ1ZSwga0NGQm9vbGVhblRy dWUgfTsKICAgICAgICAgcmV0dXJuIENGRGljdGlvbmFyeUNyZWF0ZShudWxscHRyLCBrZXlzLCB2 YWx1ZXMsIG51bU9wdGlvbnMsICZrQ0ZUeXBlRGljdGlvbmFyeUtleUNhbGxCYWNrcywgJmtDRlR5 cGVEaWN0aW9uYXJ5VmFsdWVDYWxsQmFja3MpOwogICAgIH0KIApAQCAtMTIzLDE2ICsxMjEsMTYg QEAgc3RhdGljIENGRGljdGlvbmFyeVJlZiBjcmVhdGVJbWFnZVNvdXJjZU9wdGlvbnMoSW1hZ2VT b3VyY2U6OlNob3VsZFNraXBNZXRhZGF0YQogICAgIFJldGFpblB0cjxDRk51bWJlclJlZj4gc3Vi c2FtcGxlTnVtYmVyID0gYWRvcHRDRihDRk51bWJlckNyZWF0ZShudWxscHRyLCAga0NGTnVtYmVy SW50VHlwZSwgICZzdWJzYW1wbGVJbnQpKTsKICAgICBjb25zdCBDRkluZGV4IG51bU9wdGlvbnMg PSA0OwogICAgIGNvbnN0IHZvaWQqIGtleXNbbnVtT3B0aW9uc10gPSB7IGtDR0ltYWdlU291cmNl U2hvdWxkQ2FjaGUsIGtDR0ltYWdlU291cmNlU2hvdWxkUHJlZmVyUkdCMzIsIGtDR0ltYWdlU291 cmNlU2tpcE1ldGFkYXRhLCBrQ0dJbWFnZVNvdXJjZVN1YnNhbXBsZUZhY3RvciB9OwotICAgIGNv bnN0IHZvaWQqIHZhbHVlc1tudW1PcHRpb25zXSA9IHsga0NGQm9vbGVhblRydWUsIGtDRkJvb2xl YW5UcnVlLCBpbWFnZVNvdXJjZVNraXBNZXRhZGF0YSwgc3Vic2FtcGxlTnVtYmVyLmdldCgpIH07 CisgICAgY29uc3Qgdm9pZCogdmFsdWVzW251bU9wdGlvbnNdID0geyBrQ0ZCb29sZWFuVHJ1ZSwg a0NGQm9vbGVhblRydWUsIGtDRkJvb2xlYW5UcnVlLCBzdWJzYW1wbGVOdW1iZXIuZ2V0KCkgfTsK ICAgICByZXR1cm4gQ0ZEaWN0aW9uYXJ5Q3JlYXRlKG51bGxwdHIsIGtleXMsIHZhbHVlcywgbnVt T3B0aW9ucywgJmtDRlR5cGVEaWN0aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25h cnlWYWx1ZUNhbGxCYWNrcyk7CiB9CiAKLXN0YXRpYyBDRkRpY3Rpb25hcnlSZWYgaW1hZ2VTb3Vy Y2VPcHRpb25zKEltYWdlU291cmNlOjpTaG91bGRTa2lwTWV0YWRhdGEgc2tpcE1ldGFkYXRhID0g SW1hZ2VTb3VyY2U6OlNraXBNZXRhZGF0YSwgU3Vic2FtcGxpbmdMZXZlbCBzdWJzYW1wbGluZ0xl dmVsID0gMCkKK3N0YXRpYyBDRkRpY3Rpb25hcnlSZWYgaW1hZ2VTb3VyY2VPcHRpb25zKFN1YnNh bXBsaW5nTGV2ZWwgc3Vic2FtcGxpbmdMZXZlbCA9IDApCiB7CiAgICAgaWYgKHN1YnNhbXBsaW5n TGV2ZWwpCi0gICAgICAgIHJldHVybiBjcmVhdGVJbWFnZVNvdXJjZU9wdGlvbnMoc2tpcE1ldGFk YXRhLCBzdWJzYW1wbGluZ0xldmVsKTsKKyAgICAgICAgcmV0dXJuIGNyZWF0ZUltYWdlU291cmNl T3B0aW9ucyhzdWJzYW1wbGluZ0xldmVsKTsKIAotICAgIHN0YXRpYyBDRkRpY3Rpb25hcnlSZWYg b3B0aW9ucyA9IGNyZWF0ZUltYWdlU291cmNlT3B0aW9ucyhza2lwTWV0YWRhdGEsIDApOworICAg IHN0YXRpYyBDRkRpY3Rpb25hcnlSZWYgb3B0aW9ucyA9IGNyZWF0ZUltYWdlU291cmNlT3B0aW9u cygwKTsKICAgICByZXR1cm4gb3B0aW9uczsKIH0KIApAQCAtMjM0LDcgKzIzMiw3IEBAIGJvb2wg SW1hZ2VTb3VyY2U6OmFsbG93U3Vic2FtcGxpbmdPZkZyYW1lQXRJbmRleChzaXplX3QpIGNvbnN0 CiAKIEludFNpemUgSW1hZ2VTb3VyY2U6OmZyYW1lU2l6ZUF0SW5kZXgoc2l6ZV90IGluZGV4LCBT dWJzYW1wbGluZ0xldmVsIHN1YnNhbXBsaW5nTGV2ZWwsIEltYWdlT3JpZW50YXRpb25EZXNjcmlw dGlvbiBkZXNjcmlwdGlvbikgY29uc3QKIHsKLSAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVm PiBwcm9wZXJ0aWVzID0gYWRvcHRDRihDR0ltYWdlU291cmNlQ29weVByb3BlcnRpZXNBdEluZGV4 KG1fZGVjb2RlciwgaW5kZXgsIGltYWdlU291cmNlT3B0aW9ucyhTa2lwTWV0YWRhdGEsIHN1YnNh bXBsaW5nTGV2ZWwpKSk7CisgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gcHJvcGVydGll cyA9IGFkb3B0Q0YoQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2RlY29kZXIs IGluZGV4LCBpbWFnZVNvdXJjZU9wdGlvbnMoc3Vic2FtcGxpbmdMZXZlbCkpKTsKIAogICAgIGlm ICghcHJvcGVydGllcykKICAgICAgICAgcmV0dXJuIEludFNpemUoKTsKQEAgLTM1MCw3ICszNDgs NyBAQCBDR0ltYWdlUmVmIEltYWdlU291cmNlOjpjcmVhdGVGcmFtZUF0SW5kZXgoc2l6ZV90IGlu ZGV4LCBTdWJzYW1wbGluZ0xldmVsIHN1YnNhbQogICAgIGlmICghaW5pdGlhbGl6ZWQoKSkKICAg ICAgICAgcmV0dXJuIDA7CiAKLSAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2UgPSBhZG9w dENGKENHSW1hZ2VTb3VyY2VDcmVhdGVJbWFnZUF0SW5kZXgobV9kZWNvZGVyLCBpbmRleCwgaW1h Z2VTb3VyY2VPcHRpb25zKFNraXBNZXRhZGF0YSwgc3Vic2FtcGxpbmdMZXZlbCkpKTsKKyAgICBS ZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2UgPSBhZG9wdENGKENHSW1hZ2VTb3VyY2VDcmVhdGVJ bWFnZUF0SW5kZXgobV9kZWNvZGVyLCBpbmRleCwgaW1hZ2VTb3VyY2VPcHRpb25zKHN1YnNhbXBs aW5nTGV2ZWwpKSk7CiAKICNpZiBQTEFURk9STShJT1MpCiAgICAgLy8gPHJkYXI6Ly9wcm9ibGVt LzczNzExOTg+IC0gQ29yZUdyYXBoaWNzIGNoYW5nZWQgdGhlIGRlZmF1bHQgY2FjaGluZyBiZWhh dmlvdXIgaW4gaU9TIDQuMCB0byBrQ0dJbWFnZUNhY2hpbmdUcmFuc2llbnQKQEAgLTQwNyw3ICs0 MDUsNyBAQCBmbG9hdCBJbWFnZVNvdXJjZTo6ZnJhbWVEdXJhdGlvbkF0SW5kZXgoc2l6ZV90IGlu ZGV4KQogICAgICAgICByZXR1cm4gMDsKIAogICAgIGZsb2F0IGR1cmF0aW9uID0gMDsKLSAgICBS ZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBwcm9wZXJ0aWVzID0gYWRvcHRDRihDR0ltYWdlU291 cmNlQ29weVByb3BlcnRpZXNBdEluZGV4KG1fZGVjb2RlciwgaW5kZXgsIGltYWdlU291cmNlT3B0 aW9ucyhTa2lwTWV0YWRhdGEpKSk7CisgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gcHJv cGVydGllcyA9IGFkb3B0Q0YoQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2Rl Y29kZXIsIGluZGV4LCBpbWFnZVNvdXJjZU9wdGlvbnMoKSkpOwogICAgIGlmIChwcm9wZXJ0aWVz KSB7CiAgICAgICAgIENGRGljdGlvbmFyeVJlZiBnaWZQcm9wZXJ0aWVzID0gKENGRGljdGlvbmFy eVJlZilDRkRpY3Rpb25hcnlHZXRWYWx1ZShwcm9wZXJ0aWVzLmdldCgpLCBrQ0dJbWFnZVByb3Bl cnR5R0lGRGljdGlvbmFyeSk7CiAgICAgICAgIGlmIChnaWZQcm9wZXJ0aWVzKSB7Cg==