136704 2014-09-10 06:47:07 -0700 [Curl] Optimization; avoid reallocating string many times. 2014-09-10 11:10:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue galpeter oldest_to_newest 1034284 0 peavo 2014-09-10 06:47:07 -0700 Adding individual characters to a string is inefficient, the string will be reallocated each time. 1034285 1 237889 peavo 2014-09-10 06:51:25 -0700 Created attachment 237889 Patch 1034311 2 237889 alex.christensen 2014-09-10 08:29:23 -0700 Comment on attachment 237889 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42 > + token = WTF::move(strToken); Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move? 1034328 3 237893 peavo 2014-09-10 09:09:08 -0700 Created attachment 237893 Patch 1034329 4 peavo 2014-09-10 09:09:40 -0700 (In reply to comment #2) > (From update of attachment 237889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review > > > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42 > > + token = WTF::move(strToken); > > Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move? Yes, thank you, updated patch :) 1034354 5 237893 commit-queue 2014-09-10 11:10:54 -0700 Comment on attachment 237893 Patch Clearing flags on attachment: 237893 Committed r173474: <http://trac.webkit.org/changeset/173474> 1034355 6 commit-queue 2014-09-10 11:10:57 -0700 All reviewed patches have been landed. Closing bug. 237889 2014-09-10 06:51:25 -0700 2014-09-10 09:09:00 -0700 Patch bug-136704-20140910155112.patch text/plain 1578 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQ1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTEwICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBPcHRpbWl6 YXRpb247IGF2b2lkIHJlYWxsb2NhdGluZyBzdHJpbmcgbWFueSB0aW1lcy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjcwNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGluZyBpbmRpdmlkdWFsIGNo YXJhY3RlcnMgdG8gYSBzdHJpbmcgaXMgaW5lZmZpY2llbnQsIHRoZSBzdHJpbmcgd2lsbCBiZSBy ZWFsbG9jYXRlZCBlYWNoIHRpbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q29va2llSmFyQ3VybC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkQ3VybENvb2tpZVRva2Vu KToKKwogMjAxNC0wOS0xMCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFVzZSB0b0RvY3VtZW50IGluc3RlYWQgb2Ygc3RhdGljX2Nhc3Q8RG9jdW1l bnQqPgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUph ckN1cmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9Db29raWVKYXJDdXJsLmNwcAkocmV2aXNpb24gMTczNDU3KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNSwxMCArMzUsMTEgQEAgc3RhdGljIHZvaWQgcmVhZEN1cmxDb29raWVUb2tlbihjb25z dCBjaAogewogICAgIC8vIFJlYWQgdGhlIG5leHQgdG9rZW4gZnJvbSBhIGNvb2tpZSB3aXRoIHRo ZSBOZXRzY2FwZSBjb29raWUgZm9ybWF0LgogICAgIC8vIEN1cmwgc2VwYXJhdGVzIGVhY2ggdG9r ZW4gaW4gbGluZSB3aXRoIHRhYiBjaGFyYWN0ZXIuCi0gICAgd2hpbGUgKGNvb2tpZSAmJiBjb29r aWVbMF0gJiYgY29va2llWzBdICE9ICdcdCcpIHsKLSAgICAgICAgdG9rZW4uYXBwZW5kKGNvb2tp ZVswXSk7CisgICAgY29uc3QgY2hhciogY29va2llU3RhcnQgPSBjb29raWU7CisgICAgd2hpbGUg KGNvb2tpZSAmJiBjb29raWVbMF0gJiYgY29va2llWzBdICE9ICdcdCcpCiAgICAgICAgIGNvb2tp ZSsrOwotICAgIH0KKyAgICBTdHJpbmcgc3RyVG9rZW4oY29va2llU3RhcnQsIGNvb2tpZSAtIGNv b2tpZVN0YXJ0KTsKKyAgICB0b2tlbiA9IFdURjo6bW92ZShzdHJUb2tlbik7CiAgICAgaWYgKGNv b2tpZVswXSA9PSAnXHQnKQogICAgICAgICBjb29raWUrKzsKIH0K 237893 2014-09-10 09:09:08 -0700 2014-09-10 11:10:53 -0700 Patch bug-136704-20140910180854.patch text/plain 1543 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQ1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTEwICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBPcHRpbWl6 YXRpb247IGF2b2lkIHJlYWxsb2NhdGluZyBzdHJpbmcgbWFueSB0aW1lcy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjcwNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGluZyBpbmRpdmlkdWFsIGNo YXJhY3RlcnMgdG8gYSBzdHJpbmcgaXMgaW5lZmZpY2llbnQsIHRoZSBzdHJpbmcgd2lsbCBiZSBy ZWFsbG9jYXRlZCBlYWNoIHRpbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q29va2llSmFyQ3VybC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkQ3VybENvb2tpZVRva2Vu KToKKwogMjAxNC0wOS0xMCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFVzZSB0b0RvY3VtZW50IGluc3RlYWQgb2Ygc3RhdGljX2Nhc3Q8RG9jdW1l bnQqPgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUph ckN1cmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9Db29raWVKYXJDdXJsLmNwcAkocmV2aXNpb24gMTczNDU3KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNSwxMCArMzUsMTAgQEAgc3RhdGljIHZvaWQgcmVhZEN1cmxDb29raWVUb2tlbihjb25z dCBjaAogewogICAgIC8vIFJlYWQgdGhlIG5leHQgdG9rZW4gZnJvbSBhIGNvb2tpZSB3aXRoIHRo ZSBOZXRzY2FwZSBjb29raWUgZm9ybWF0LgogICAgIC8vIEN1cmwgc2VwYXJhdGVzIGVhY2ggdG9r ZW4gaW4gbGluZSB3aXRoIHRhYiBjaGFyYWN0ZXIuCi0gICAgd2hpbGUgKGNvb2tpZSAmJiBjb29r aWVbMF0gJiYgY29va2llWzBdICE9ICdcdCcpIHsKLSAgICAgICAgdG9rZW4uYXBwZW5kKGNvb2tp ZVswXSk7CisgICAgY29uc3QgY2hhciogY29va2llU3RhcnQgPSBjb29raWU7CisgICAgd2hpbGUg KGNvb2tpZSAmJiBjb29raWVbMF0gJiYgY29va2llWzBdICE9ICdcdCcpCiAgICAgICAgIGNvb2tp ZSsrOwotICAgIH0KKyAgICB0b2tlbiA9IFN0cmluZyhjb29raWVTdGFydCwgY29va2llIC0gY29v a2llU3RhcnQpOwogICAgIGlmIChjb29raWVbMF0gPT0gJ1x0JykKICAgICAgICAgY29va2llKys7 CiB9Cg==