136698 2014-09-10 02:15:36 -0700 [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's 2014-09-10 23:41:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue darin gyuyoung.kim ryuan.choi oldest_to_newest 1034251 0 tanay.c 2014-09-10 02:15:36 -0700 Shift + Scroll in the browser should take the actions as follows: 1) User should navigate to previous webpage if he pressed Shift + Scroll Down direction 2) User should navigate to next webpage if he pressed Shift + Scroll Up direction 1034252 1 237883 tanay.c 2014-09-10 02:22:15 -0700 Created attachment 237883 Patch 1034520 2 237883 gyuyoung.kim 2014-09-10 21:36:10 -0700 Comment on attachment 237883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237883&action=review > Tools/ChangeLog:3 > + Shift+Scroll navigate to back or forward url's Please add [EFL] prefix. 1034524 3 237930 tanay.c 2014-09-10 21:49:03 -0700 Created attachment 237930 Patch 1034528 4 237930 gyuyoung.kim 2014-09-10 22:01:32 -0700 Comment on attachment 237930 Patch It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me. 1034529 5 tanay.c 2014-09-10 22:07:09 -0700 (In reply to comment #4) > (From update of attachment 237930 [details]) > It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me. Control + Scroll is the combination used for Zoom in current Web Browsers. We will support that too and upload in a separate patch. 1034540 6 237930 commit-queue 2014-09-10 23:41:13 -0700 Comment on attachment 237930 Patch Clearing flags on attachment: 237930 Committed r173508: <http://trac.webkit.org/changeset/173508> 1034541 7 commit-queue 2014-09-10 23:41:18 -0700 All reviewed patches have been landed. Closing bug. 237883 2014-09-10 02:22:15 -0700 2014-09-10 21:48:52 -0700 Patch bug-136698-20140910145238.patch text/plain 3241 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzQ1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTA5LTEwICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBTaGlmdCtTY3JvbGwgbmF2aWdhdGUgdG8gYmFjayBvciBmb3J3YXJkIHVybCdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2OTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93 c2VyL2VmbC9tYWluLmM6IEFkZGVkIGZ1bmN0aW9uYWxpdHkgdG8gc3VwcG9ydCBzaGlmdCBrZXkg KyBtb3VzZSBzY3JvbGwgdG8gbmF2aWdhdGUKKyAgICAgICAgKG9uX21vdXNlX3doZWVsKToKKyAg ICAgICAgKHdpbmRvd19mcmVlKToKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorCiAyMDE0LTA5 LTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1RLXSBhbGxvdyBvdmVyd3JpdGluZyBkZXN0aW5hdGlvbiBvZiBkb3dubG9hZApJbmRleDog VG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJv d3Nlci9lZmwvbWFpbi5jCShyZXZpc2lvbiAxNzMzNzEpCisrKyBUb29scy9NaW5pQnJvd3Nlci9l ZmwvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC0yODgsNiArMjg4LDI3IEBAIG9uX21vdXNlX291 dCh2b2lkICp1c2VyX2RhdGEsIEV2YXMgKmUsIEUKIH0KIAogc3RhdGljIHZvaWQKK29uX21vdXNl X3doZWVsKHZvaWQgKnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKmV3a192aWV3LCB2 b2lkICpldmVudF9pbmZvKQoreworICAgIEJyb3dzZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nl cl9XaW5kb3cgKil1c2VyX2RhdGE7CisgICAgY29uc3QgRXZhc19Nb2RpZmllciAqbW9kID0gZXZh c19rZXlfbW9kaWZpZXJfZ2V0KGUpOworICAgIEV2YXNfRXZlbnRfTW91c2VfV2hlZWwgKmV2ID0g KEV2YXNfRXZlbnRfTW91c2VfV2hlZWwgKilldmVudF9pbmZvOworICAgIEVpbmFfQm9vbCBzaGlm dFByZXNzZWQgPSBldmFzX2tleV9tb2RpZmllcl9pc19zZXQobW9kLCAiU2hpZnQiKTsKKworICAg IGlmICghc2hpZnRQcmVzc2VkKQorICAgICAgICByZXR1cm47CisKKyAgICAvKiBuYXZpZ2F0ZSBi YXNlZCBvbiBtb3VzZSB3aGVlbCBzY3JvbGwgZGlyZWN0aW9uIHdoZW4gc2hpZnQga2V5IGlzIHBy ZXNzZWQgKi8KKyAgICBpZiAoZXYtPnogPT0gLTEgJiYgZXdrX3ZpZXdfZm9yd2FyZF9wb3NzaWJs ZSh3aW5kb3ctPmV3a192aWV3KSkgeworICAgICAgICBld2tfdmlld19mb3J3YXJkKHdpbmRvdy0+ ZXdrX3ZpZXcpOworICAgICAgICBlbG1fb2JqZWN0X2Rpc2FibGVkX3NldCh3aW5kb3ctPmZvcndh cmRfYnV0dG9uLCAhZXdrX3ZpZXdfZm9yd2FyZF9wb3NzaWJsZSh3aW5kb3ctPmV3a192aWV3KSk7 CisgICAgfSBlbHNlIGlmIChldi0+eiA9PSAxICYmIGV3a192aWV3X2JhY2tfcG9zc2libGUod2lu ZG93LT5ld2tfdmlldykpIHsKKyAgICAgICAgZXdrX3ZpZXdfYmFjayh3aW5kb3ctPmV3a192aWV3 KTsKKyAgICAgICAgZWxtX29iamVjdF9kaXNhYmxlZF9zZXQod2luZG93LT5iYWNrX2J1dHRvbiwg IWV3a192aWV3X2JhY2tfcG9zc2libGUod2luZG93LT5ld2tfdmlldykpOyAgICAgICAKKyAgICB9 Cit9CisKK3N0YXRpYyB2b2lkCiBvbl93aW5kb3dfcmVzaXplKHZvaWQgKnVzZXJfZGF0YSwgRXZh cyAqZSwgRXZhc19PYmplY3QgKmVsbV93aW5kb3csIHZvaWQgKmV2ZW50X2luZm8pCiB7CiAgICAg QnJvd3Nlcl9XaW5kb3cgKndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKQEAg LTM0NCw2ICszNjUsNyBAQCBzdGF0aWMgdm9pZCB3aW5kb3dfZnJlZShCcm93c2VyX1dpbmRvdyAq CiAgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRvdy0+ZXdrX3ZpZXcsIEVW QVNfQ0FMTEJBQ0tfTU9VU0VfSU4sIG9uX21vdXNlX2luKTsKICAgICBldmFzX29iamVjdF9ldmVu dF9jYWxsYmFja19kZWwod2luZG93LT5ld2tfdmlldywgRVZBU19DQUxMQkFDS19NT1VTRV9PVVQs IG9uX21vdXNlX291dCk7CiAgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRv dy0+ZXdrX3ZpZXcsIEVWQVNfQ0FMTEJBQ0tfTU9VU0VfTU9WRSwgb25fbW91c2VfbW92ZSk7Cisg ICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRvdy0+ZXdrX3ZpZXcsIEVWQVNf Q0FMTEJBQ0tfTU9VU0VfV0hFRUwsIG9uX21vdXNlX3doZWVsKTsKIAogICAgIGV2YXNfb2JqZWN0 X2V2ZW50X2NhbGxiYWNrX2RlbCh3aW5kb3ctPmVsbV93aW5kb3csIEVWQVNfQ0FMTEJBQ0tfUkVT SVpFLCBvbl93aW5kb3dfcmVzaXplKTsKIApAQCAtMjE3NCw2ICsyMTk2LDcgQEAgc3RhdGljIEJy b3dzZXJfV2luZG93ICp3aW5kb3dfY3JlYXRlKEV2YQogICAgIGV2YXNfb2JqZWN0X2V2ZW50X2Nh bGxiYWNrX2FkZCh3aW5kb3ctPmV3a192aWV3LCBFVkFTX0NBTExCQUNLX01PVVNFX0lOLCBvbl9t b3VzZV9pbiwgd2luZG93KTsKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQod2lu ZG93LT5ld2tfdmlldywgRVZBU19DQUxMQkFDS19NT1VTRV9PVVQsIG9uX21vdXNlX291dCwgd2lu ZG93KTsKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQod2luZG93LT5ld2tfdmll dywgRVZBU19DQUxMQkFDS19NT1VTRV9NT1ZFLCBvbl9tb3VzZV9tb3ZlLCB3aW5kb3cpOworICAg IGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxiYWNrX2FkZCh3aW5kb3ctPmV3a192aWV3LCBFVkFTX0NB TExCQUNLX01PVVNFX1dIRUVMLCBvbl9tb3VzZV93aGVlbCwgd2luZG93KTsKICAgICBldmFzX29i amVjdF9ldmVudF9jYWxsYmFja19hZGQod2luZG93LT5lbG1fd2luZG93LCBFVkFTX0NBTExCQUNL X1JFU0laRSwgb25fd2luZG93X3Jlc2l6ZSwgd2luZG93KTsKICAgICAKICAgICBlbG1fYnV0dG9u X2F1dG9yZXBlYXRfc2V0KHdpbmRvdy0+YmFja19idXR0b24sIEVJTkFfVFJVRSk7Cg== 237930 2014-09-10 21:49:03 -0700 2014-09-10 23:41:13 -0700 Patch bug-136698-20140911101929.patch text/plain 3286 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzUwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTA5LTEwICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93c2VyIDogU2hpZnQrU2Nyb2xsIG5hdmlnYXRlIHRv IGJhY2sgb3IgZm9yd2FyZCB1cmwncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOiBBZGQgZnVuY3Rpb25hbGl0 eSB0byBzdXBwb3J0IHNoaWZ0ICsgbW91c2Ugc2Nyb2xsIG5hdmlnYXRpb24KKyAgICAgICAgKG9u X21vdXNlX3doZWVsKTogQWRkZWQuCisgICAgICAgICh3aW5kb3dfZnJlZSk6CisgICAgICAgICh3 aW5kb3dfY3JlYXRlKToKKwogMjAxNC0wOS0xMCAgUm9oaXQgS3VtYXIgIDxrdW1hci5yb2hpdEBz YW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93c2VyIDogQWRkIHRvb2x0 aXAgZm9yIHRvb2xiYXIgYnV0dG9ucyBpbiBNaW5pYnJvd3NlcgpJbmRleDogVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFp bi5jCShyZXZpc2lvbiAxNzM1MDYpCisrKyBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3 b3JraW5nIGNvcHkpCkBAIC0yODgsNiArMjg4LDI3IEBAIG9uX21vdXNlX291dCh2b2lkICp1c2Vy X2RhdGEsIEV2YXMgKmUsIEUKIH0KIAogc3RhdGljIHZvaWQKK29uX21vdXNlX3doZWVsKHZvaWQg KnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9p bmZvKQoreworICAgIEJyb3dzZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1 c2VyX2RhdGE7CisgICAgY29uc3QgRXZhc19Nb2RpZmllciAqbW9kID0gZXZhc19rZXlfbW9kaWZp ZXJfZ2V0KGUpOworICAgIEV2YXNfRXZlbnRfTW91c2VfV2hlZWwgKmV2ID0gKEV2YXNfRXZlbnRf TW91c2VfV2hlZWwgKilldmVudF9pbmZvOworICAgIEVpbmFfQm9vbCBzaGlmdFByZXNzZWQgPSBl dmFzX2tleV9tb2RpZmllcl9pc19zZXQobW9kLCAiU2hpZnQiKTsKKworICAgIGlmICghc2hpZnRQ cmVzc2VkKQorICAgICAgICByZXR1cm47CisKKyAgICAvKiBuYXZpZ2F0ZSBiYXNlZCBvbiBtb3Vz ZSB3aGVlbCBzY3JvbGwgZGlyZWN0aW9uIHdoZW4gc2hpZnQga2V5IGlzIHByZXNzZWQgKi8KKyAg ICBpZiAoZXYtPnogPT0gLTEgJiYgZXdrX3ZpZXdfZm9yd2FyZF9wb3NzaWJsZSh3aW5kb3ctPmV3 a192aWV3KSkgeworICAgICAgICBld2tfdmlld19mb3J3YXJkKHdpbmRvdy0+ZXdrX3ZpZXcpOwor ICAgICAgICBlbG1fb2JqZWN0X2Rpc2FibGVkX3NldCh3aW5kb3ctPmZvcndhcmRfYnV0dG9uLCAh ZXdrX3ZpZXdfZm9yd2FyZF9wb3NzaWJsZSh3aW5kb3ctPmV3a192aWV3KSk7CisgICAgfSBlbHNl IGlmIChldi0+eiA9PSAxICYmIGV3a192aWV3X2JhY2tfcG9zc2libGUod2luZG93LT5ld2tfdmll dykpIHsKKyAgICAgICAgZXdrX3ZpZXdfYmFjayh3aW5kb3ctPmV3a192aWV3KTsKKyAgICAgICAg ZWxtX29iamVjdF9kaXNhYmxlZF9zZXQod2luZG93LT5iYWNrX2J1dHRvbiwgIWV3a192aWV3X2Jh Y2tfcG9zc2libGUod2luZG93LT5ld2tfdmlldykpOyAgICAgICAKKyAgICB9Cit9CisKK3N0YXRp YyB2b2lkCiBvbl93aW5kb3dfcmVzaXplKHZvaWQgKnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19P YmplY3QgKmVsbV93aW5kb3csIHZvaWQgKmV2ZW50X2luZm8pCiB7CiAgICAgQnJvd3Nlcl9XaW5k b3cgKndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKQEAgLTM0NCw2ICszNjUs NyBAQCBzdGF0aWMgdm9pZCB3aW5kb3dfZnJlZShCcm93c2VyX1dpbmRvdyAqCiAgICAgZXZhc19v YmplY3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRvdy0+ZXdrX3ZpZXcsIEVWQVNfQ0FMTEJBQ0tf TU9VU0VfSU4sIG9uX21vdXNlX2luKTsKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19k ZWwod2luZG93LT5ld2tfdmlldywgRVZBU19DQUxMQkFDS19NT1VTRV9PVVQsIG9uX21vdXNlX291 dCk7CiAgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRvdy0+ZXdrX3ZpZXcs IEVWQVNfQ0FMTEJBQ0tfTU9VU0VfTU9WRSwgb25fbW91c2VfbW92ZSk7CisgICAgZXZhc19vYmpl Y3RfZXZlbnRfY2FsbGJhY2tfZGVsKHdpbmRvdy0+ZXdrX3ZpZXcsIEVWQVNfQ0FMTEJBQ0tfTU9V U0VfV0hFRUwsIG9uX21vdXNlX3doZWVsKTsKIAogICAgIGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxi YWNrX2RlbCh3aW5kb3ctPmVsbV93aW5kb3csIEVWQVNfQ0FMTEJBQ0tfUkVTSVpFLCBvbl93aW5k b3dfcmVzaXplKTsKIApAQCAtMjE4NCw2ICsyMjA2LDcgQEAgc3RhdGljIEJyb3dzZXJfV2luZG93 ICp3aW5kb3dfY3JlYXRlKEV2YQogICAgIGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxiYWNrX2FkZCh3 aW5kb3ctPmV3a192aWV3LCBFVkFTX0NBTExCQUNLX01PVVNFX0lOLCBvbl9tb3VzZV9pbiwgd2lu ZG93KTsKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQod2luZG93LT5ld2tfdmll dywgRVZBU19DQUxMQkFDS19NT1VTRV9PVVQsIG9uX21vdXNlX291dCwgd2luZG93KTsKICAgICBl dmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQod2luZG93LT5ld2tfdmlldywgRVZBU19DQUxM QkFDS19NT1VTRV9NT1ZFLCBvbl9tb3VzZV9tb3ZlLCB3aW5kb3cpOworICAgIGV2YXNfb2JqZWN0 X2V2ZW50X2NhbGxiYWNrX2FkZCh3aW5kb3ctPmV3a192aWV3LCBFVkFTX0NBTExCQUNLX01PVVNF X1dIRUVMLCBvbl9tb3VzZV93aGVlbCwgd2luZG93KTsKICAgICBldmFzX29iamVjdF9ldmVudF9j YWxsYmFja19hZGQod2luZG93LT5lbG1fd2luZG93LCBFVkFTX0NBTExCQUNLX1JFU0laRSwgb25f d2luZG93X3Jlc2l6ZSwgd2luZG93KTsKICAgICAKICAgICBlbG1fYnV0dG9uX2F1dG9yZXBlYXRf c2V0KHdpbmRvdy0+YmFja19idXR0b24sIEVJTkFfVFJVRSk7Cg==