136696 2014-09-10 01:34:54 -0700 [MIPS] branch32WithPatch missing 2014-09-10 07:59:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned commit-queue fpizlo galpeter kilvadyb msaboff oldest_to_newest 1034245 0 berto 2014-09-10 01:34:54 -0700 WebKitGTK+ fails to build in mips due to missing branch32WithPatch(): [ 2%] Building CXX object Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o [...] In file included from /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/bytecode/ValueRecovery.h:35:0, from /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/bytecode/CodeOrigin.h:32, from /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/bytecode/CodeBlock.h:42, from /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/assembler/MacroAssembler.h: In member function 'JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::PatchableJump JSC::MacroAssembler::patchableBranch32WithPatch(JSC::MacroAssemblerMIPS::RelationalCondition, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Address, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::DataLabel32&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::TrustedImm32)': /«BUILDDIR»/webkit2gtk-2.5.3+dfsg1/Source/JavaScriptCore/assembler/MacroAssembler.h:350:88: error: 'branch32WithPatch' was not declared in this scope return PatchableJump(branch32WithPatch(cond, left, dataLabel, initialRightValue)); Full log here: https://buildd.debian.org/status/fetch.php?pkg=webkit2gtk&arch=mipsel&ver=2.5.3%2Bdfsg1-1&stamp=1409924238 1034271 1 237886 galpeter 2014-09-10 06:05:38 -0700 Created attachment 237886 proposed fix 1034289 2 237886 msaboff 2014-09-10 07:24:13 -0700 Comment on attachment 237886 proposed fix r=me 1034295 3 237886 commit-queue 2014-09-10 07:59:41 -0700 Comment on attachment 237886 proposed fix Clearing flags on attachment: 237886 Committed r173461: <http://trac.webkit.org/changeset/173461> 1034296 4 commit-queue 2014-09-10 07:59:44 -0700 All reviewed patches have been landed. Closing bug. 237886 2014-09-10 06:05:38 -0700 2014-09-10 07:59:41 -0700 proposed fix mips_added_branch32withpatch.patch text/plain 1666 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRiYzU1NzEuLjFlYjU3YjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA5LTEwICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW01JUFNdIGJyYW5jaDMyV2l0aFBh dGNoIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjY5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIHRoZSBtaXNzaW5nIGJyYW5jaDMyV2l0aFBhdGNoLiBUaGUgaW1wbGVtZW50YXRp b24KKyAgICAgICAgaXMgY3VycmVudGx5IHRoZSBzYW1lIGFzIHRoZSBicmFuY2hQdHJpdGhQYXRj aCBiZWNhdXNlCisgICAgICAgIHRoZSBtYWNybyBhc3NlbWJsZXIgc3VwcG9ydHMgb25seSAzMiBi aXQgTUlQUy4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaDoKKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpicmFuY2gzMldpdGhQYXRjaCk6CisKIDIw MTQtMDktMDkgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRGlzYWJsZSB0aGUgInVucmVhY2hhYmxlLWNvZGUiIHdhcm5pbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCmluZGV4IDcx YjVmYTkuLjMyNzE1MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApAQCAtMjEyMCw2ICsyMTIwLDE2IEBAIHB1YmxpYzoK ICAgICAgICAgcmV0dXJuIHRlbXA7CiAgICAgfQogCisgICAgSnVtcCBicmFuY2gzMldpdGhQYXRj aChSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmQsIEFkZHJlc3MgbGVmdCwgRGF0YUxhYmVsMzImIGRh dGFMYWJlbCwgVHJ1c3RlZEltbTMyIGluaXRpYWxSaWdodFZhbHVlID0gVHJ1c3RlZEltbTMyKDAp KQorICAgIHsKKyAgICAgICAgbV9maXhlZFdpZHRoID0gdHJ1ZTsKKyAgICAgICAgbG9hZDMyKGxl ZnQsIGRhdGFUZW1wUmVnaXN0ZXIpOworICAgICAgICBkYXRhTGFiZWwgPSBtb3ZlV2l0aFBhdGNo KGluaXRpYWxSaWdodFZhbHVlLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICBKdW1wIHRlbXAg PSBicmFuY2gzMihjb25kLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW1UZW1wUmVnaXN0ZXIpOworICAg ICAgICBtX2ZpeGVkV2lkdGggPSBmYWxzZTsKKyAgICAgICAgcmV0dXJuIHRlbXA7CisgICAgfQor CiAgICAgRGF0YUxhYmVsUHRyIHN0b3JlUHRyV2l0aFBhdGNoKFRydXN0ZWRJbW1QdHIgaW5pdGlh bFZhbHVlLCBJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcykKICAgICB7CiAgICAgICAgIG1fZml4ZWRX aWR0aCA9IHRydWU7Cg==