136691 2014-09-09 18:29:28 -0700 Web Inspector: Eliminate typeof "undefined" checks 2014-09-10 16:10:26 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1034221 0 joepeck 2014-09-09 18:29:28 -0700 A long time ago, `undefined` could be re-assigned. Which could cause craziness comparing to undefined. That has not been the case for a while. We can just convert: typeof foo === "undefined" To: foo === undefined 1034222 1 237876 joepeck 2014-09-09 18:30:10 -0700 Created attachment 237876 [PATCH] Proposed Fix 1034441 2 237876 commit-queue 2014-09-10 15:41:29 -0700 Comment on attachment 237876 [PATCH] Proposed Fix Clearing flags on attachment: 237876 Committed r173494: <http://trac.webkit.org/changeset/173494> 1034442 3 commit-queue 2014-09-10 15:41:31 -0700 All reviewed patches have been landed. Closing bug. 1034452 4 237876 burg 2014-09-10 16:10:26 -0700 Comment on attachment 237876 [PATCH] Proposed Fix Was this supposed to include a change to .eslintrc? 237876 2014-09-09 18:30:10 -0700 2014-09-10 16:10:26 -0700 [PATCH] Proposed Fix undefined.patch text/plain 4810 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNhYmJmMzkuLjNjYjg2ZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA5LTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxpbWlu YXRlIHR5cGVvZiAidW5kZWZpbmVkIiBjaGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IubGlua2lmeVVSTEFzTm9kZSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IubGlua2lmeVN0cmluZ0FzRnJhZ21lbnQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJv dG9jb2wvSW5zcGVjdG9yQmFja2VuZC5qczoKKyAgICAgICAgKEluc3BlY3RvckJhY2tlbmQuQ29t bWFuZC5wcm90b3R5cGUuX2ludm9rZVdpdGhBcmd1bWVudHMpOgorICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQu cHJvdG90eXBlLmdldCByZXNpemVNZXRob2QpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvTmF2aWdhdGlvbkJhci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uQmFy LnByb3RvdHlwZS5nZXQgbWluaW11bVdpZHRoKToKKworMjAxNC0wOS0wOSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBF U0xpbnQqIG5vLWF2b2lkYWJsZS1iaW5kIHdhcm5pbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2OTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDBkMmI4NzguLjg1YzVlYzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKQEAgLTE2MjYsNyArMTYyNiw3IEBAIFdlYkluc3BlY3Rvci5saW5raWZ5VVJMQXNOb2RlID0g ZnVuY3Rpb24odXJsLCBsaW5rVGV4dCwgY2xhc3NlcywgdG9vbHRpcFRleHQpCiAgICAgYS5ocmVm ID0gdXJsOwogICAgIGEuY2xhc3NOYW1lID0gY2xhc3NlczsKIAotICAgIGlmICh0eXBlb2YgdG9v bHRpcFRleHQgPT09ICJ1bmRlZmluZWQiKQorICAgIGlmICh0b29sdGlwVGV4dCA9PT0gdW5kZWZp bmVkKQogICAgICAgICBhLnRpdGxlID0gdXJsOwogICAgIGVsc2UgaWYgKHR5cGVvZiB0b29sdGlw VGV4dCAhPT0gInN0cmluZyIgfHwgdG9vbHRpcFRleHQubGVuZ3RoKQogICAgICAgICBhLnRpdGxl ID0gdG9vbHRpcFRleHQ7CkBAIC0xNjc1LDcgKzE2NzUsNyBAQCBXZWJJbnNwZWN0b3IubGlua2lm eVN0cmluZ0FzRnJhZ21lbnQgPSBmdW5jdGlvbihzdHJpbmcpCiAgICAgZnVuY3Rpb24gbGlua2lm aWVyKHRpdGxlLCB1cmwsIGxpbmVOdW1iZXIpCiAgICAgewogICAgICAgICB2YXIgdXJsTm9kZSA9 IFdlYkluc3BlY3Rvci5saW5raWZ5VVJMQXNOb2RlKHVybCwgdGl0bGUsIHVuZGVmaW5lZCk7Ci0g ICAgICAgIGlmICh0eXBlb2YobGluZU51bWJlcikgIT09ICJ1bmRlZmluZWQiKQorICAgICAgICBp ZiAobGluZU51bWJlciAhPT0gdW5kZWZpbmVkKQogICAgICAgICAgICAgdXJsTm9kZS5saW5lTnVt YmVyID0gbGluZU51bWJlcjsKIAogICAgICAgICByZXR1cm4gdXJsTm9kZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJh Y2tlbmQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9J bnNwZWN0b3JCYWNrZW5kLmpzCmluZGV4IGZlNGU5M2UuLmQxNmFiNDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tl bmQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wv SW5zcGVjdG9yQmFja2VuZC5qcwpAQCAtNDMwLDcgKzQzMCw3IEBAIEluc3BlY3RvckJhY2tlbmQu Q29tbWFuZC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIHZhciB2 YWx1ZSA9IGNvbW1hbmRBcmd1bWVudHMuc2hpZnQoKTsKLSAgICAgICAgICAgIGlmIChvcHRpb25h bEZsYWcgJiYgdHlwZW9mIHZhbHVlID09PSAidW5kZWZpbmVkIikKKyAgICAgICAgICAgIGlmIChv cHRpb25hbEZsYWcgJiYgdmFsdWUgPT09IHVuZGVmaW5lZCkKICAgICAgICAgICAgICAgICBjb250 aW51ZTsKIAogICAgICAgICAgICAgaWYgKHR5cGVvZiB2YWx1ZSAhPT0gdHlwZU5hbWUpIHsKQEAg LTQ0Miw3ICs0NDIsNyBAQCBJbnNwZWN0b3JCYWNrZW5kLkNvbW1hbmQucHJvdG90eXBlID0gewog ICAgICAgICB9CiAKICAgICAgICAgaWYgKGNvbW1hbmRBcmd1bWVudHMubGVuZ3RoID09PSAxICYm ICFjYWxsYmFjaykgewotICAgICAgICAgICAgaWYgKHR5cGVvZiBjb21tYW5kQXJndW1lbnRzWzBd ICE9PSAidW5kZWZpbmVkIikgeworICAgICAgICAgICAgaWYgKGNvbW1hbmRBcmd1bWVudHNbMF0g IT09IHVuZGVmaW5lZCkgewogICAgICAgICAgICAgICAgIGNvbnNvbGUuZXJyb3IoIlByb3RvY29s IEVycm9yOiBPcHRpb25hbCBjYWxsYmFjayBhcmd1bWVudCBmb3IgbWV0aG9kICciICsgaW5zdGFu Y2UucXVhbGlmaWVkTmFtZSArICInIGNhbGwgbXVzdCBiZSBhIGZ1bmN0aW9uIGJ1dCBpdHMgdHlw ZSBpcyAnIiArIHR5cGVvZiBhcmdzWzBdICsgIicuIik7CiAgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwppbmRleCBkMWQyY2RjLi5hZjIwNGU1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3Jp ZC5qcwpAQCAtNDE0LDcgKzQxNCw3IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUg PSB7CiAgICAgfSwKIAogICAgIGluc2VydENvbHVtbjogZnVuY3Rpb24oY29sdW1uSWRlbnRpZmll ciwgY29sdW1uRGF0YSwgaW5zZXJ0aW9uSW5kZXgpIHsKLSAgICAgICAgaWYgKHR5cGVvZiBpbnNl cnRpb25JbmRleCA9PT0gInVuZGVmaW5lZCIpCisgICAgICAgIGlmIChpbnNlcnRpb25JbmRleCA9 PT0gdW5kZWZpbmVkKQogICAgICAgICAgICAgaW5zZXJ0aW9uSW5kZXggPSB0aGlzLm9yZGVyZWRD b2x1bW5zLmxlbmd0aDsKICAgICAgICAgaW5zZXJ0aW9uSW5kZXggPSBOdW1iZXIuY29uc3RyYWlu KGluc2VydGlvbkluZGV4LCAwLCB0aGlzLm9yZGVyZWRDb2x1bW5zLmxlbmd0aCk7CiAKQEAgLTEy MTcsNyArMTIxNyw3IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUgPSB7CiAKICAg ICBnZXQgcmVzaXplTWV0aG9kKCkKICAgICB7Ci0gICAgICAgIGlmICh0eXBlb2YgdGhpcy5fcmVz aXplTWV0aG9kID09PSAidW5kZWZpbmVkIikKKyAgICAgICAgaWYgKCF0aGlzLl9yZXNpemVNZXRo b2QpCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLkRhdGFHcmlkLlJlc2l6ZU1ldGhv ZC5OZWFyZXN0OwogICAgICAgICByZXR1cm4gdGhpcy5fcmVzaXplTWV0aG9kOwogICAgIH0sCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZp Z2F0aW9uQmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmF2aWdhdGlvbkJhci5qcwppbmRleCBhMjFiMWEyLi42MzA2MjkyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uQmFyLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25C YXIuanMKQEAgLTIzMyw3ICsyMzMsNyBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90 b3R5cGUgPSB7CiAKICAgICBnZXQgbWluaW11bVdpZHRoKCkKICAgICB7Ci0gICAgICAgIGlmICh0 eXBlb2YgdGhpcy5fbWluaW11bVdpZHRoID09PSAidW5kZWZpbmVkIiB8fCB0aGlzLl9taW5pbXVt V2lkdGhOZWVkc1JlY2FsY3VsYXRpb24pIHsKKyAgICAgICAgaWYgKHRoaXMuX21pbmltdW1XaWR0 aCA9PT0gdW5kZWZpbmVkIHx8IHRoaXMuX21pbmltdW1XaWR0aE5lZWRzUmVjYWxjdWxhdGlvbikg ewogICAgICAgICAgICAgdGhpcy5fbWluaW11bVdpZHRoID0gdGhpcy5fY2FsY3VsYXRlTWluaW11 bVdpZHRoKCk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5fbWluaW11bVdpZHRoTmVlZHNSZWNh bGN1bGF0aW9uOwogICAgICAgICB9Cg==