136690 2014-09-09 18:13:37 -0700 Web Inspector: Fix ESLint* no-avoidable-bind warnings 2014-09-10 08:49:13 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1034218 0 joepeck 2014-09-09 18:13:37 -0700 I wrote an ESLint rule to catch avoidable Function.prototype.bind call with a number of built-in Array/Set/Map functional methods and it caught some issues in our code: https://github.com/JosephPecoraro/eslint/commit/d64243a312b4e872bc3e63ccfa6ad84d2a29c675 UserInterface/Protocol/RemoteObject.js 358:35 error Function binding is avoidable. Use the optional thisArg argument of 'map' no-avoidable-bind UserInterface/Views/CSSStyleDetailsSidebarPanel.js 47:8 error Function binding is avoidable. Use the optional thisArg argument of 'forEach' no-avoidable-bind UserInterface/Views/LayerTreeSidebarPanel.js 269:8 error Function binding is avoidable. Use the optional thisArg argument of 'forEach' no-avoidable-bind 277:8 error Function binding is avoidable. Use the optional thisArg argument of 'forEach' no-avoidable-bind 283:8 error Function binding is avoidable. Use the optional thisArg argument of 'forEach' no-avoidable-bind UserInterface/Views/LogContentView.js 646:8 error Function binding is avoidable. Use the optional thisArg argument of 'forEach' no-avoidable-bind UserInterface/Views/TextResourceContentView.js 90:22 error Function binding is avoidable. Use the optional thisArg argument of 'filter' no-avoidable-bind 1034219 1 237875 joepeck 2014-09-09 18:14:25 -0700 Created attachment 237875 [PATCH] Proposed Fix 1034317 2 237875 commit-queue 2014-09-10 08:49:10 -0700 Comment on attachment 237875 [PATCH] Proposed Fix Clearing flags on attachment: 237875 Committed r173462: <http://trac.webkit.org/changeset/173462> 1034318 3 commit-queue 2014-09-10 08:49:13 -0700 All reviewed patches have been landed. Closing bug. 237875 2014-09-09 18:14:25 -0700 2014-09-10 08:49:09 -0700 [PATCH] Proposed Fix avoidable-fix.patch text/plain 5055 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZlY2JhYWIuLjNhYmJmMzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTA5LTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IEVT TGludCogbm8tYXZvaWRhYmxlLWJpbmQgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2NvbC9SZW1vdGVP YmplY3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9jYWxKU09OT2JqZWN0LnByb3RvdHlw ZS5fY2hpbGRyZW4pOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZXRh aWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGV0YWls c1NpZGViYXJQYW5lbCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9MYXllclRyZWVT aWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTGF5ZXJUcmVlU2lkZWJhclBh bmVsLnByb3RvdHlwZS5fdXBkYXRlRGF0YUdyaWQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9nQ29udGVu dFZpZXcucHJvdG90eXBlLl9maWx0ZXJNZXNzYWdlcyk6CisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UZXh0UmVzb3VyY2VDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0UmVzb3VyY2VDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IHN1cHBsZW1lbnRhbFJlcHJl c2VudGVkT2JqZWN0cyk6CisKKzIwMTQtMDktMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXggb2JzY3VyZSBFU0xpbnQg d2FybmluZ3MgYW5kIHNraXAgZGlyZWN0b3JpZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY4NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9SZW1vdGVPYmplY3QuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9SZW1vdGVPYmplY3QuanMKaW5k ZXggYjgyNzRiOS4uZTUzODllMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvUHJvdG9jb2wvUmVtb3RlT2JqZWN0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL1JlbW90ZU9iamVjdC5qcwpAQCAtMzU1LDcg KzM1NSw3IEBAIFdlYkluc3BlY3Rvci5Mb2NhbEpTT05PYmplY3QucHJvdG90eXBlID0gewogICAg ICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuUmVtb3RlT2JqZWN0UHJvcGVydHkocHJv cE5hbWUsIG5ldyBXZWJJbnNwZWN0b3IuTG9jYWxKU09OT2JqZWN0KHRoaXMuX3ZhbHVlW3Byb3BO YW1lXSkpOwogICAgICAgICB9CiAgICAgICAgIGlmICghdGhpcy5fY2FjaGVkQ2hpbGRyZW4pCi0g ICAgICAgICAgICB0aGlzLl9jYWNoZWRDaGlsZHJlbiA9IE9iamVjdC5rZXlzKHRoaXMuX3ZhbHVl IHx8IHt9KS5tYXAoYnVpbGRQcm9wZXJ0eS5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIHRoaXMu X2NhY2hlZENoaWxkcmVuID0gT2JqZWN0LmtleXModGhpcy5fdmFsdWUgfHwge30pLm1hcChidWls ZFByb3BlcnR5LCB0aGlzKTsKICAgICAgICAgcmV0dXJuIHRoaXMuX2NhY2hlZENoaWxkcmVuOwog ICAgIH0sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpp bmRleCBmNWViZWI0Li5jOWZjYjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZXRhaWxz U2lkZWJhclBhbmVsLmpzCkBAIC02Niw3ICs2Niw3IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURl dGFpbHNTaWRlYmFyUGFuZWwgPSBmdW5jdGlvbigpCiAgICAgICAgICAgICB9CiAKICAgICAgICAg ICAgIGdyb3VwRWxlbWVudC5hcHBlbmRDaGlsZChsYWJlbEVsZW1lbnQpOwotICAgICAgICB9LmJp bmQodGhpcykpOworICAgICAgICB9LCB0aGlzKTsKIAogICAgICAgICB0aGlzLl9jb250ZW50RWxl bWVudC5hcHBlbmRDaGlsZCh0aGlzLl9mb3JjZWRQc2V1ZG9DbGFzc0NvbnRhaW5lcik7CiAgICAg fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TGF5ZXJUcmVlU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTGF5ZXJUcmVlU2lkZWJhclBhbmVsLmpzCmluZGV4IGQ3YWVhZDYuLjA3NzA2 M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0xheWVyVHJlZVNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9MYXllclRyZWVTaWRlYmFyUGFuZWwuanMKQEAgLTI3MiwxOSArMjcy LDE5IEBAIFdlYkluc3BlY3Rvci5MYXllclRyZWVTaWRlYmFyUGFuZWwucHJvdG90eXBlID0gewog ICAgICAgICAgICAgICAgIGRhdGFHcmlkLnJlbW92ZUNoaWxkKG5vZGUpOwogICAgICAgICAgICAg ICAgIGRlbGV0ZSB0aGlzLl9kYXRhR3JpZE5vZGVzQnlMYXllcklkW2xheWVyLmxheWVySWRdOwog ICAgICAgICAgICAgfQotICAgICAgICB9LmJpbmQodGhpcykpOworICAgICAgICB9LCB0aGlzKTsK IAogICAgICAgICBtdXRhdGlvbnMuYWRkaXRpb25zLmZvckVhY2goZnVuY3Rpb24obGF5ZXIpIHsK ICAgICAgICAgICAgIHZhciBub2RlID0gdGhpcy5fZGF0YUdyaWROb2RlRm9yTGF5ZXIobGF5ZXIp OwogICAgICAgICAgICAgaWYgKG5vZGUpCiAgICAgICAgICAgICAgICAgZGF0YUdyaWQuYXBwZW5k Q2hpbGQobm9kZSk7Ci0gICAgICAgIH0uYmluZCh0aGlzKSk7CisgICAgICAgIH0sIHRoaXMpOwog CiAgICAgICAgIG11dGF0aW9ucy5wcmVzZXJ2ZWQuZm9yRWFjaChmdW5jdGlvbihsYXllcikgewog ICAgICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLl9kYXRhR3JpZE5vZGVzQnlMYXllcklkW2xheWVy LmxheWVySWRdOwogICAgICAgICAgICAgaWYgKG5vZGUpCiAgICAgICAgICAgICAgICAgbm9kZS5s YXllciA9IGxheWVyOwotICAgICAgICB9LmJpbmQodGhpcykpOworICAgICAgICB9LCB0aGlzKTsK IAogICAgICAgICB0aGlzLl9zb3J0RGF0YUdyaWQoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcwpp bmRleCBmZWZkYmRlLi5iMjFhYzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcwpAQCAtNjY3LDcg KzY2Nyw3IEBAIFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICAgICAgY2xhc3NMaXN0LnJlbW92ZShXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcu U2VsZWN0ZWRTdHlsZUNsYXNzTmFtZSk7CiAgICAgICAgICAgICAgICAgY2xhc3NMaXN0LmFkZChX ZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcuRmlsdGVyZWRPdXRTdHlsZUNsYXNzTmFtZSk7CiAg ICAgICAgICAgICB9Ci0gICAgICAgIH0uYmluZCh0aGlzKSk7CisgICAgICAgIH0sIHRoaXMpOwog CiAgICAgICAgIHRoaXMuX3BlcmZvcm1TZWFyY2goKTsKICAgICB9LApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNlQ29udGVu dFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0 UmVzb3VyY2VDb250ZW50Vmlldy5qcwppbmRleCA1YzljNWFhLi5jOGE1ZGQyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0UmVzb3VyY2VD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UZXh0UmVzb3VyY2VDb250ZW50Vmlldy5qcwpAQCAtODksNyArODksNyBAQCBXZWJJbnNw ZWN0b3IuVGV4dFJlc291cmNlQ29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgIHsKICAgICAg ICAgdmFyIG9iamVjdHMgPSBXZWJJbnNwZWN0b3IucHJvYmVNYW5hZ2VyLnByb2JlU2V0cy5maWx0 ZXIoZnVuY3Rpb24ocHJvYmVTZXQpIHsKICAgICAgICAgICAgIHJldHVybiB0aGlzLl9yZXNvdXJj ZS51cmwgPT09IHByb2JlU2V0LmJyZWFrcG9pbnQudXJsOwotICAgICAgICB9LmJpbmQodGhpcykp OworICAgICAgICB9LCB0aGlzKTsKIAogICAgICAgICAvLyBJZiB0aGUgU291cmNlQ29kZVRleHRF ZGl0b3IgaGFzIGFuIGV4ZWN1dGlvbkxpbmVOdW1iZXIsIHdlIGNhbiBhc3N1bWUKICAgICAgICAg Ly8gaXQgaXMgYWx3YXlzIHRoZSBhY3RpdmUgY2FsbCBmcmFtZS4K