13669 2007-05-10 16:30:47 -0700 Canvas transformations affect path construction 2008-01-28 17:52:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) PC OS X 10.4 RESOLVED INVALID http://www.hixie.ch/tests/adhoc/html/canvas/032.html P2 Normal --- 1 ian oliver darin gavin.sharp ggaren hyatt ian oliver oldest_to_newest 10370 0 ian 2007-05-10 16:30:47 -0700 STEPS TO REPRODUCE 1. Create a path. 2. Set a transformation. 3. Fill the path. ACTUAL RESULTS Transformation is ignored. EXPECTED RESULTS Transformation should have an affect. STEPS TO REPRODUCE 1. Set a transformation. 2. Create a path. 3. Undo the transformation. 4. Fill the path. ACTUAL RESULTS Transformation is applied. EXPECTED RESULTS Transformation should have no affect. 10374 1 ian 2007-05-10 16:54:20 -0700 TESTCASES http://www.hixie.ch/tests/adhoc/html/canvas/007.html http://www.hixie.ch/tests/adhoc/html/canvas/008.html http://www.hixie.ch/tests/adhoc/html/canvas/020.html http://www.hixie.ch/tests/adhoc/html/canvas/032.html (Some of these may also expose other bugs.) 10275 2 ian 2007-05-11 14:20:21 -0700 As mentioned on IRC, it would be really great to have this fixed soon so that we can determine whether this is possible to fix or not. If it's not possible to fix then we should change the spec, but that would make the platform quite sucky so I'd like to avoid doing that if at all possible. (You'd have to redraw the path everytime you wanted to paint it somewhere new, instead of being able to create the path once and rapidly paint it in multiple places.) 10277 3 14497 oliver 2007-05-11 14:49:29 -0700 Created attachment 14497 Patch that fixes problem Okay, this fixes behaviour to match spec -- still need to confirm that this doesn't destroy dashboard 57551 4 eric 2007-10-01 09:49:35 -0700 Hum. This looks like a really easy fix. The only problem is that it sounds like there needs to be some check of dashboard widgets with this patch applied. That's probably best done by some apple person (with access to leopard)... and probably that will only happen post-leopard (possibly compounding the problem). 59808 5 ian 2007-10-29 13:27:23 -0700 So this didn't make Safari 3... can we get a post-mortem? Was it too incompatible, requiring this to become WONTFIX? Or is it still something we can do? 68403 6 oliver 2008-01-27 19:25:17 -0800 For canvas.isPointInPath to be implemented completely and according to spec we need to land this patch. Although i hate to suggest it, should we consider having a dashboard compatibility quirk for this? I don't think we ever confirmed whether or not this would break dashboard. It should be noted however that firefox has this same behaviour. 68405 7 oliver 2008-01-27 19:31:39 -0800 Oooh, it occurs to me, could we make this dependent on being in html5 "strict"? eg. switch on the presence of the html5 doctype? (this type of compat quirk is new to me so i don't know how it works/if it's possible... i'm hoping hyatt would know :D ) Thoughts anyone? 68512 8 ian 2008-01-28 17:45:12 -0800 The spec changed recently, since Firefox and Safari refused to change to this behaviour, and the Opera guys requested that the spec change to match them. Thus I believe this bug is now invalid. 68514 9 oliver 2008-01-28 17:52:16 -0800 IT's a shame as feel the old specced behaviour was better in a number of ways -- ithnk we should really consider adding a Path object to HTML5 14497 2007-05-11 14:49:29 -0700 2007-05-11 14:49:29 -0700 Patch that fixes problem canvas_correction.patch text/plain 1038 oliver SW5kZXg6IFdlYkNvcmUvaHRtbC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCShyZXZpc2lv biAyMTQxNCkKKysrIFdlYkNvcmUvaHRtbC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yODEsNyArMjgxLDYgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OnNjYWxlKGZsbwogICAgIGlmICghYykKICAgICAgICAgcmV0dXJuOwogICAgIGMtPnNj YWxlKEZsb2F0U2l6ZShzeCwgc3kpKTsKLSAgICBzdGF0ZSgpLm1fcGF0aC50cmFuc2Zvcm0oQWZm aW5lVHJhbnNmb3JtKCkuc2NhbGUoMS4wL3N4LCAxLjAvc3kpKTsKIH0KIAogdm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQ6OnJvdGF0ZShmbG9hdCBhbmdsZUluUmFkaWFucykKQEAgLTI5MCw3 ICsyODksNiBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6cm90YXRlKGZsCiAgICAg aWYgKCFjKQogICAgICAgICByZXR1cm47CiAgICAgYy0+cm90YXRlKGFuZ2xlSW5SYWRpYW5zKTsK LSAgICBzdGF0ZSgpLm1fcGF0aC50cmFuc2Zvcm0oQWZmaW5lVHJhbnNmb3JtKCkucm90YXRlKC1h bmdsZUluUmFkaWFucy9NX1BJKjE4MCkpOwogfQogCiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRDo6dHJhbnNsYXRlKGZsb2F0IHR4LCBmbG9hdCB0eSkKQEAgLTI5OSw3ICsyOTcsNiBAQCB2 b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6dHJhbnNsYXRlCiAgICAgaWYgKCFjKQogICAg ICAgICByZXR1cm47CiAgICAgYy0+dHJhbnNsYXRlKHR4LCB0eSk7Ci0gICAgc3RhdGUoKS5tX3Bh dGgudHJhbnNmb3JtKEFmZmluZVRyYW5zZm9ybSgpLnRyYW5zbGF0ZSgtdHgsIC10eSkpOwogfQog CiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U3Ryb2tlQ29sb3IoY29uc3QgU3Ry aW5nJiBjb2xvcikK