136689 2014-09-09 17:55:15 -0700 AX: aria-labelledby is not honoring sub-node text 2014-09-10 14:24:28 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 136714 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1034215 0 cfleizach 2014-09-09 17:55:15 -0700 If something is labelled by a group of elements, and some of those elements are contained in sub-nodes, then all the text is not concatenated. <rdar://problem/17955424> 1034217 1 237874 cfleizach 2014-09-09 18:00:05 -0700 Created attachment 237874 patch 1034291 2 237874 commit-queue 2014-09-10 07:47:11 -0700 Comment on attachment 237874 patch Clearing flags on attachment: 237874 Committed r173459: <http://trac.webkit.org/changeset/173459> 1034292 3 commit-queue 2014-09-10 07:47:15 -0700 All reviewed patches have been landed. Closing bug. 1034394 4 jcraig 2014-09-10 13:51:58 -0700 These test cases are wrong. Generic groups (like your a and b divs) should not traverse their contents to calculate an accessible name. This is going to regress from some things. I'd recommend rolling this out and let me give you more robust test examples. 1034395 5 jcraig 2014-09-10 13:52:58 -0700 Actually we can probably just patch it rather than rolling it out. I'll clone. 1034400 6 jcraig 2014-09-10 14:06:04 -0700 bug 136689 1034402 7 jcraig 2014-09-10 14:06:31 -0700 whoops, bug 136714 1034407 8 cfleizach 2014-09-10 14:24:28 -0700 (In reply to comment #4) > These test cases are wrong. Generic groups (like your a and b divs) should not traverse their contents to calculate an accessible name. This is going to regress from some things. > > I'd recommend rolling this out and let me give you more robust test examples. What spec are you referring to? This returns current behavior to what it used to do. We used to gather all the textUnderElement(). The fix was to restore that behavior 237874 2014-09-09 18:00:05 -0700 2014-09-10 07:47:11 -0700 patch patch text/plain 4162 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQ1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA5LTA5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGFyaWEtbGFiZWxs ZWRieSBpcyBub3QgaG9ub3Jpbmcgc3ViLW5vZGUgdGV4dAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS9hcmlhLWxhYmVs bGVkYnktd2l0aC1kZXNjZW5kYW50cy5odG1sCisKKyAgICAgICAgV2hlbiBhcmlhLWxhYmVsbGVk YnkgcmV0cmlldmVzIHRoZSB0ZXh0VW5kZXJFbGVtZW50cyBpdCBuZWVkcyB0byBjb25zaWRlcgor ICAgICAgICBhbGwgc3ViLWNoaWxkcmVuLCBpbmNsdWRpbmcgZm9jdXNhYmxlIGNvbnRlbnQuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmFjY2Vzc2libGVOYW1lRm9yTm9kZSk6CisKIDIwMTQtMDktMDkgIFJv Z2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeCBmb3IgV2luZG93cy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCShyZXZpc2lvbiAxNzM0 MTMpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg1Nyw3ICsxODU3LDcgQEAKICAgICBBY2Nlc3Np YmlsaXR5T2JqZWN0KiBheE9iamVjdCA9IG5vZGUtPmRvY3VtZW50KCkuYXhPYmplY3RDYWNoZSgp LT5nZXRPckNyZWF0ZShub2RlKTsKICAgICBTdHJpbmcgdGV4dDsKICAgICBpZiAoYXhPYmplY3Qp Ci0gICAgICAgIHRleHQgPSBheE9iamVjdC0+dGV4dFVuZGVyRWxlbWVudCgpOworICAgICAgICB0 ZXh0ID0gYXhPYmplY3QtPnRleHRVbmRlckVsZW1lbnQoQWNjZXNzaWJpbGl0eVRleHRVbmRlckVs ZW1lbnRNb2RlKEFjY2Vzc2liaWxpdHlUZXh0VW5kZXJFbGVtZW50TW9kZTo6VGV4dFVuZGVyRWxl bWVudE1vZGVTa2lwSWdub3JlZENoaWxkcmVuLCB0cnVlKSk7CiAgICAgZWxzZQogICAgICAgICB0 ZXh0ID0gZWxlbWVudC0+aW5uZXJUZXh0KCk7CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzM0 NTMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxNC0wOS0wOSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgor CisgICAgICAgIEFYOiBhcmlhLWxhYmVsbGVkYnkgaXMgbm90IGhvbm9yaW5nIHN1Yi1ub2RlIHRl eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9hcmlhLWxhYmVsbGVkYnktd2l0aC1kZXNjZW5kYW50cy1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1sYWJlbGxlZGJ5LXdpdGgtZGVz Y2VuZGFudHMuaHRtbDogQWRkZWQuCisKIDIwMTQtMDktMDkgIFJvZ2VyIEZvbmcgIDxyb2dlcl9m b25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnNraXAgdHdvIHNuYXBzaG90dGluZyB0ZXN0cyB0 aGF0IHdvcmsgZm9yIG1lIGNvbnNpc3RlbnRseSBsb2NhbGx5LgpJbmRleDogTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9hcmlhLWxhYmVsbGVkYnktd2l0aC1kZXNjZW5kYW50cy1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWxhYmVsbGVk Ynktd2l0aC1kZXNjZW5kYW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbGFiZWxsZWRieS13aXRoLWRlc2NlbmRhbnRzLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3RzIHRoYXQg aWYgYXJpYS1sYWJlbGxlZGJ5IGlzIHBvaW50aW5nIHRvIG5vZGVzIHdpdGggZGVzY2VuZGFudHMs IGl0IHJldHVybnMgYWxsIHRleHQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCith cmlhLWxhYmVsbGVkYnkgZGVzY3JpcHRpb246IEFYRGVzY3JpcHRpb246IGhlbGxvIGxpbmsgd29y bGQgdGVzdDEgdGVzdDIgdGVzdDMKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbGFi ZWxsZWRieS13aXRoLWRlc2NlbmRhbnRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9hcmlhLWxhYmVsbGVkYnktd2l0aC1kZXNjZW5kYW50cy5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWxhYmVsbGVkYnktd2l0 aC1kZXNjZW5kYW50cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDIgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiBpZD0iY29udGVudCI+CisKKzxkaXYgYXJp YS1sYWJlbGxlZGJ5PSJhIGIiIGlkPSJncm91cCIgcm9sZT0iZ3JvdXAiPgorZ3JvdXAgdGV4dAor PC9kaXY+CisKKzxkaXYgaWQ9ImEiPgoraGVsbG8gPGEgaHJlZj0iIyI+bGluazwvYT4gd29ybGQK KzwvZGl2PgorCis8ZGl2IGlkPSJiIj4KKzxidXR0b24+dGVzdDE8L2J1dHRvbj4gCis8cCB0YWJp bmRleD0wPnRlc3QyIDxzcGFuIGFyaWEtaGlkZGVuPSJ0cnVlIj5oaWRkZW48L3NwYW4+IHRlc3Qz PC9wPgorPC9kaXY+CisKKzwvZGl2PgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVzY3JpcHRpb24oIlRoaXMg dGVzdHMgdGhhdCBpZiBhcmlhLWxhYmVsbGVkYnkgaXMgcG9pbnRpbmcgdG8gbm9kZXMgd2l0aCBk ZXNjZW5kYW50cywgaXQgcmV0dXJucyBhbGwgdGV4dC4iKTsKKworICAgIGlmICh3aW5kb3cuYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgICB2YXIgZ3JvdXAgPSBhY2Nlc3NpYmls aXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImdyb3VwIik7CisgICAgICAgICAg ZGVidWcoImFyaWEtbGFiZWxsZWRieSBkZXNjcmlwdGlvbjogIiArIGdyb3VwLmRlc2NyaXB0aW9u KTsKKyAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGVudCIpLnN0eWxlLnZp c2liaWxpdHkgPSAiaGlkZGVuIjsKKyAgICB9CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0i Li4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==