13667 2007-05-10 15:58:17 -0700 REGRESSION (r21363): Focus ring too tall 2007-05-10 16:20:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED data:text/html,<div style="outline: auto"><pre><span><pre>foo</pre></span></pre></div> HasReduction, LayoutTestFailure, Regression P1 Normal --- 1 mitz hyatt hyatt oldest_to_newest 10381 0 mitz 2007-05-10 15:58:17 -0700 See URL. Also responsible for this failure <http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/4047/editing/pasteboard/paste-pre-002-diffs.html> and a few others. 10380 1 14478 hyatt 2007-05-10 16:08:19 -0700 Created attachment 14478 Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty A block in the middle of a continuation should only include its collapsed margins if they aren't going to collapse beyond the inlines above/below. This is covered by existing layout tests (even the test I added to fix the original bug showed this problem, I just didn't notice it), sigh. This is purely a pixel issue, so isn't caught except by pixel layout tests. 10379 2 14478 bdakin 2007-05-10 16:16:05 -0700 Comment on attachment 14478 Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty r=me! 10376 3 hyatt 2007-05-10 16:20:04 -0700 Fixed 14478 2007-05-10 16:08:19 -0700 2007-05-10 16:16:05 -0700 Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty patch.txt text/plain 1234 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJGbG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcv UmVuZGVyRmxvdy5jcHAJKHJldmlzaW9uIDIxMzYzKQorKysgcmVuZGVyaW5nL1JlbmRlckZsb3cu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NzMsOSArNjczLDE0IEBAIHZvaWQgUmVuZGVyRmxvdzo6 YWRkRm9jdXNSaW5nUmVjdHMoR3JhcGgKIHsKICAgICBpZiAoaXNSZW5kZXJCbG9jaygpKSB7CiAg ICAgICAgIC8vIENvbnRpbnVhdGlvbnMgc2hvdWxkIGluY2x1ZGUgdGhlaXIgbWFyZ2lucyBpbiB0 aGUgb3V0bGluZSByZWN0LgotICAgICAgICBpZiAoY29udGludWF0aW9uKCkpCi0gICAgICAgICAg ICBncmFwaGljc0NvbnRleHQtPmFkZEZvY3VzUmluZ1JlY3QoSW50UmVjdCh0eCwgdHkgLSBjb2xs YXBzZWRNYXJnaW5Ub3AoKSwgd2lkdGgoKSwgaGVpZ2h0KCkgKyBjb2xsYXBzZWRNYXJnaW5Ub3Ao KSArIGNvbGxhcHNlZE1hcmdpbkJvdHRvbSgpKSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgaWYg KGNvbnRpbnVhdGlvbigpKSB7CisgICAgICAgICAgICBib29sIG5leHRJbmxpbmVIYXNMaW5lQm94 ID0gY29udGludWF0aW9uKCktPmZpcnN0TGluZUJveCgpOworICAgICAgICAgICAgYm9vbCBwcmV2 SW5saW5lSGFzTGluZUJveCA9IHN0YXRpY19jYXN0PFJlbmRlckZsb3cqPihjb250aW51YXRpb24o KS0+ZWxlbWVudCgpLT5yZW5kZXJlcigpKS0+Zmlyc3RMaW5lQm94KCk7CisgICAgICAgICAgICBp bnQgdG9wTWFyZ2luID0gcHJldklubGluZUhhc0xpbmVCb3ggPyBjb2xsYXBzZWRNYXJnaW5Ub3Ao KSA6IDA7CisgICAgICAgICAgICBpbnQgYm90dG9tTWFyZ2luID0gbmV4dElubGluZUhhc0xpbmVC b3ggPyBjb2xsYXBzZWRNYXJnaW5Cb3R0b20oKSA6IDA7CisgICAgICAgICAgICBncmFwaGljc0Nv bnRleHQtPmFkZEZvY3VzUmluZ1JlY3QoSW50UmVjdCh0eCwgdHkgLSB0b3BNYXJnaW4sIAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2lkdGgo KSwgaGVpZ2h0KCkgKyB0b3BNYXJnaW4gKyBib3R0b21NYXJnaW4pKTsKKyAgICAgICAgfSBlbHNl CiAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmFkZEZvY3VzUmluZ1JlY3QoSW50UmVjdCh0 eCwgdHksIHdpZHRoKCksIGhlaWdodCgpKSk7CiAgICAgfQogCg==