136667 2014-09-08 22:31:06 -0700 [WebKit2] Fix build error in WebKit2/WebProcess module 2014-09-08 23:42:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136631 1 shiva.jm webkit-unassigned commit-queue darin gyuyoung.kim ossy ryuan.choi sam oldest_to_newest 1034062 0 shiva.jm 2014-09-08 22:31:06 -0700 Getting Below Build error for EFL-WK2 build, since default case is not handled. [ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Plugins/Netscape/JSNPObject.cpp.o /home/shiva.jm/webkit-git/svngitsep/WebKit/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp: In function ‘std::chrono::milliseconds WebKit::maximumBufferingTime(WebCore::CachedResource*)’: /home/shiva.jm/webkit-git/svngitsep/WebKit/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:115:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Network/WebResourceLoadScheduler.cpp.o] Error 1 1034063 1 237841 shiva.jm 2014-09-08 22:36:15 -0700 Created attachment 237841 Patch Fix the build error by handling default case. 1034064 2 237841 darin 2014-09-08 22:43:59 -0700 Comment on attachment 237841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237841&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:116 > + default: > + return 0_ms; We don’t want a default here, because that will disable the warning that clang and other compilers give us when we forget to handle a case. Instead, we should put this return statement outside the switch, and we should also include ASSERT_NOT_REACHED. 1034069 3 237842 shiva.jm 2014-09-08 23:11:41 -0700 Created attachment 237842 Patch for landing 1034070 4 237842 gyuyoung.kim 2014-09-08 23:27:57 -0700 Comment on attachment 237842 Patch for landing cq=me 1034079 5 237842 ossy 2014-09-08 23:39:02 -0700 Comment on attachment 237842 Patch for landing Clearing flags on attachment: 237842 Committed r173420: <http://trac.webkit.org/changeset/173420> 1034080 6 ossy 2014-09-08 23:39:11 -0700 All reviewed patches have been landed. Closing bug. 237841 2014-09-08 22:36:15 -0700 2014-09-08 23:11:21 -0700 Patch bug-136667.patch text/plain 1151 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQxOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTA4ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIEZpeCBi dWlsZCBlcnJvciBpbiBXZWJLaXQyL1dlYlByb2Nlc3MgbW9kdWxlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2NjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIGJ1aWxkIGVycm9yIGJ5IGhh bmRsaW5nIGRlZmF1bHQgY2FzZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJS ZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjptYXhpbXVtQnVmZmVy aW5nVGltZSk6CisKIDIwMTQtMDktMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBpT1MgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2Fk U2NoZWR1bGVyLmNwcAkocmV2aXNpb24gMTczNDE4KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTExMSw2ICsxMTEsOSBAQCBzdGF0aWMgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyBtYXhp bXVtCiAgICAgY2FzZSBDYWNoZWRSZXNvdXJjZTo6WFNMU3R5bGVTaGVldDoKICNlbmRpZgogICAg ICAgICByZXR1cm4gMF9tczsKKworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiAwX21zOwog ICAgIH0KIH0KIAo= 237842 2014-09-08 23:11:41 -0700 2014-09-08 23:39:02 -0700 Patch for landing bug-136667-20140909120148.patch text/plain 1266 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQxOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTA4ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIEZpeCBi dWlsZCBlcnJvciBpbiBXZWJLaXQyL1dlYlByb2Nlc3MgbW9kdWxlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2NjcKKworICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBGaXggdGhlIGJ1aWxkIGVycm9yIGJ5IGhhbmRs aW5nIGRlZmF1bHQgY2FzZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNv dXJjZUxvYWRTY2hlZHVsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjptYXhpbXVtQnVmZmVyaW5n VGltZSk6CisKIDIwMTQtMDktMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHRoZSBpT1MgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2No ZWR1bGVyLmNwcAkocmV2aXNpb24gMTczNDE4KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTExMiw2ICsxMTIsOSBAQCBzdGF0aWMgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyBtYXhpbXVt CiAjZW5kaWYKICAgICAgICAgcmV0dXJuIDBfbXM7CiAgICAgfQorCisgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgcmV0dXJuIDBfbXM7CiB9CiAKIHZvaWQgV2ViUmVzb3VyY2VMb2FkU2No ZWR1bGVyOjpzY2hlZHVsZUxvYWQoUmVzb3VyY2VMb2FkZXIqIHJlc291cmNlTG9hZGVyLCBDYWNo ZWRSZXNvdXJjZSogcmVzb3VyY2UsIGJvb2wgc2hvdWxkQ2xlYXJSZWZlcnJlck9uSFRUUFNUb0hU VFBSZWRpcmVjdCkK