136661 2014-09-08 20:23:15 -0700 Web Inspector: Remove unused Console search highlight methods 2014-09-10 08:51:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1034046 0 joepeck 2014-09-08 20:23:15 -0700 There was some code in here that ESLint's "no-undef" complained about and would have thrown warnings. Turns out this code was completely unused. 1034049 1 237836 joepeck 2014-09-08 20:24:29 -0700 Created attachment 237836 [PATCH] Proposed Fix 1034319 2 237836 commit-queue 2014-09-10 08:51:27 -0700 Comment on attachment 237836 [PATCH] Proposed Fix Clearing flags on attachment: 237836 Committed r173463: <http://trac.webkit.org/changeset/173463> 1034320 3 commit-queue 2014-09-10 08:51:29 -0700 All reviewed patches have been landed. Closing bug. 237836 2014-09-08 20:24:29 -0700 2014-09-10 08:51:27 -0700 [PATCH] Proposed Fix console-cleanup.patch text/plain 4312 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU1YmZiZDcuLmRlOTJiNjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE0LTA5LTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVudXNlZCBDb25zb2xlIHNlYXJjaCBoaWdobGlnaHQgbWV0aG9kcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NjYxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRVNMaW50J3Mgbm8tdW5kZWYgd2Fybmlu ZyBjb21wbGFpbmVkIGFib3V0IHNvbWUgdW5kZWZpbmVkIHJlZmVyZW5jZXMKKyAgICAgICAgaW4g dGhlc2UgZnVuY3Rpb25zIHRoYXQgd291bGQgaGF2ZSB0aHJvd24gZXhjZXB0aW9ucy4gVHVybnMg b3V0IHRoaXMKKyAgICAgICAgY29kZSBpcyB1bnVzZWQsIGFuZCB3ZSBkbyBoaWdobGlnaHRpbmcg aW4gdGhlIGNvbnNvbGUgc2VwYXJhdGVseS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvQ29uc29sZUNvbW1hbmQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZUNvbW1h bmQucHJvdG90eXBlLmNsZWFySGlnaGxpZ2h0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Db25zb2xlQ29tbWFuZC5wcm90b3R5cGUuaGlnaGxpZ2h0U2VhcmNoUmVzdWx0cyk6IERl bGV0ZWQuCisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZUNvbW1hbmQucHJvdG90eXBlLm1h dGNoZXNSZWdleCk6IERlbGV0ZWQuCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25z b2xlTWVzc2FnZUltcGwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2VJ bXBsLnByb3RvdHlwZS5jbGVhckhpZ2hsaWdodCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJJbnNw ZWN0b3IuQ29uc29sZU1lc3NhZ2VJbXBsLnByb3RvdHlwZS5oaWdobGlnaHRTZWFyY2hSZXN1bHRz KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZUltcGwucHJv dG90eXBlLm1hdGNoZXNSZWdleCk6IERlbGV0ZWQuCisKKzIwMTQtMDktMDggIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXgg RVNMaW50IG5vLXVuZGVmIHdhcm5pbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzY2NjAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZUNvbW1hbmQuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlQ29tbWFuZC5qcwppbmRleCA4YWY5 NDBmLi40MzZiMGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db25zb2xlQ29tbWFuZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlQ29tbWFuZC5qcwpAQCAtMzksMzQgKzM5LDYgQEAg V2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kLnByb3RvdHlwZSA9IHsKIAogICAgIC8vIFB1Ymxp YwogCi0gICAgY2xlYXJIaWdobGlnaHQ6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIHZhciBo aWdobGlnaHRlZE1lc3NhZ2UgPSB0aGlzLl9mb3JtYXR0ZWRDb21tYW5kOwotICAgICAgICBkZWxl dGUgdGhpcy5fZm9ybWF0dGVkQ29tbWFuZDsKLSAgICAgICAgdGhpcy5fZm9ybWF0Q29tbWFuZCgp OwotICAgICAgICB0aGlzLl9lbGVtZW50LnJlcGxhY2VDaGlsZCh0aGlzLl9mb3JtYXR0ZWRDb21t YW5kLCBoaWdobGlnaHRlZE1lc3NhZ2UpOwotICAgIH0sCi0KLSAgICBoaWdobGlnaHRTZWFyY2hS ZXN1bHRzOiBmdW5jdGlvbihyZWdleE9iamVjdCkKLSAgICB7Ci0gICAgICAgIHJlZ2V4T2JqZWN0 Lmxhc3RJbmRleCA9IDA7Ci0gICAgICAgIHZhciB0ZXh0ID0gdGhpcy5jb21tYW5kOwotICAgICAg ICB2YXIgbWF0Y2ggPSByZWdleE9iamVjdC5leGVjKHRleHQpOwotICAgICAgICB2YXIgb2Zmc2V0 ID0gMDsKLSAgICAgICAgdmFyIG1hdGNoUmFuZ2VzID0gW107Ci0gICAgICAgIHdoaWxlIChtYXRj aCkgewotICAgICAgICAgICAgbWF0Y2hSYW5nZXMucHVzaCh7IG9mZnNldDogbWF0Y2guaW5kZXgs IGxlbmd0aDogbWF0Y2hbMF0ubGVuZ3RoIH0pOwotICAgICAgICAgICAgbWF0Y2ggPSByZWdleE9i amVjdC5leGVjKHRleHQpOwotICAgICAgICB9Ci0gICAgICAgIGhpZ2hsaWdodFNlYXJjaFJlc3Vs dHModGhpcy5fZm9ybWF0dGVkQ29tbWFuZCwgbWF0Y2hSYW5nZXMpOwotICAgICAgICB0aGlzLl9l bGVtZW50LnNjcm9sbEludG9WaWV3SWZOZWVkZWQoKTsKLSAgICB9LAotCi0gICAgbWF0Y2hlc1Jl Z2V4OiBmdW5jdGlvbihyZWdleE9iamVjdCkKLSAgICB7Ci0gICAgICAgIHJldHVybiByZWdleE9i amVjdC50ZXN0KHRoaXMuY29tbWFuZCk7Ci0gICAgfSwKLQogICAgIHRvTWVzc2FnZUVsZW1lbnQ6 IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5fZWxlbWVudCkgewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1l c3NhZ2VJbXBsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv Q29uc29sZU1lc3NhZ2VJbXBsLmpzCmluZGV4IDQxMzIyYmYuLmJiM2RmOTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdl SW1wbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b25zb2xlTWVzc2FnZUltcGwuanMKQEAgLTQ1Myw0MCArNDUzLDYgQEAgV2ViSW5zcGVjdG9yLkNv bnNvbGVNZXNzYWdlSW1wbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiBTdHJpbmcuZm9y bWF0KHBhcmFtZXRlcnNbMF0uZGVzY3JpcHRpb24sIHBhcmFtZXRlcnMuc2xpY2UoMSksIGZvcm1h dHRlcnMsIGZvcm1hdHRlZFJlc3VsdCwgYXBwZW5kKTsKICAgICB9LAogCi0gICAgY2xlYXJIaWdo bGlnaHQ6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIGlmICghdGhpcy5fZm9ybWF0dGVkTWVz c2FnZSkKLSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICB2YXIgaGlnaGxpZ2h0ZWRNZXNz YWdlID0gdGhpcy5fZm9ybWF0dGVkTWVzc2FnZTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2Zvcm1h dHRlZE1lc3NhZ2U7Ci0gICAgICAgIHRoaXMuX2Zvcm1hdE1lc3NhZ2UoKTsKLSAgICAgICAgdGhp cy5fZWxlbWVudC5yZXBsYWNlQ2hpbGQodGhpcy5fZm9ybWF0dGVkTWVzc2FnZSwgaGlnaGxpZ2h0 ZWRNZXNzYWdlKTsKLSAgICB9LAotCi0gICAgaGlnaGxpZ2h0U2VhcmNoUmVzdWx0czogZnVuY3Rp b24ocmVnZXhPYmplY3QpCi0gICAgewotICAgICAgICBpZiAoIXRoaXMuX2Zvcm1hdHRlZE1lc3Nh Z2UpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgcmVnZXhPYmplY3QubGFzdEluZGV4 ID0gMDsKLSAgICAgICAgdmFyIHRleHQgPSB0aGlzLm1lc3NhZ2U7Ci0gICAgICAgIHZhciBtYXRj aCA9IHJlZ2V4T2JqZWN0LmV4ZWModGV4dCk7Ci0gICAgICAgIHZhciBvZmZzZXQgPSAwOwotICAg ICAgICB2YXIgbWF0Y2hSYW5nZXMgPSBbXTsKLSAgICAgICAgd2hpbGUgKG1hdGNoKSB7Ci0gICAg ICAgICAgICBtYXRjaFJhbmdlcy5wdXNoKHsgb2Zmc2V0OiBtYXRjaC5pbmRleCwgbGVuZ3RoOiBt YXRjaFswXS5sZW5ndGggfSk7Ci0gICAgICAgICAgICBtYXRjaCA9IHJlZ2V4T2JqZWN0LmV4ZWMo dGV4dCk7Ci0gICAgICAgIH0KLSAgICAgICAgaGlnaGxpZ2h0U2VhcmNoUmVzdWx0cyh0aGlzLl9m b3JtYXR0ZWRNZXNzYWdlLCBtYXRjaFJhbmdlcyk7Ci0gICAgICAgIHRoaXMuX2VsZW1lbnQuc2Ny b2xsSW50b1ZpZXdJZk5lZWRlZCgpOwotICAgIH0sCi0KLSAgICBtYXRjaGVzUmVnZXg6IGZ1bmN0 aW9uKHJlZ2V4T2JqZWN0KQotICAgIHsKLSAgICAgICAgcmV0dXJuIHJlZ2V4T2JqZWN0LnRlc3Qo dGhpcy5tZXNzYWdlKTsKLSAgICB9LAotCiAgICAgdG9NZXNzYWdlRWxlbWVudDogZnVuY3Rpb24o KQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2VsZW1lbnQpCg==