136660 2014-09-08 20:21:29 -0700 Web Inspector: Fix ESLint no-undef warnings 2014-09-10 09:00:38 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1034043 0 joepeck 2014-09-08 20:21:29 -0700 ESLint emits a lot of no-undef warnings because we don't list all of our global utility functions (which we should probably namespace). However these looked like some straight forward mistakes, and I'll follow up with a few other larger issues it catches. 1034044 1 237834 joepeck 2014-09-08 20:22:11 -0700 Created attachment 237834 [PATCH] Proposed Fix 1034325 2 237834 commit-queue 2014-09-10 09:00:35 -0700 Comment on attachment 237834 [PATCH] Proposed Fix Clearing flags on attachment: 237834 Committed r173466: <http://trac.webkit.org/changeset/173466> 1034326 3 commit-queue 2014-09-10 09:00:38 -0700 All reviewed patches have been landed. Closing bug. 237834 2014-09-08 20:22:11 -0700 2014-09-10 09:00:35 -0700 [PATCH] Proposed Fix no-undef.patch text/plain 4390 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5NTNkZDEuLmU1YmZiZDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA5LTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IEVT TGludCBuby11bmRlZiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2NjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9ET01TZWFyY2hNYXRjaE9iamVj dC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVjdC5wcm90b3R5 cGUuX2dlbmVyYXRlQ2xhc3NOYW1lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TZWFyY2hN YXRjaE9iamVjdC50aXRsZUZvckRPTU5vZGUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9k ZWxzL0dyYWRpZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkdyYWRpZW50LmZyb21TdHJp bmcpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0aW9ucy5q czoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1JlcGxheURhc2hib2FyZFZpZXcuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVwbGF5RGFzaGJvYXJkVmlldyk6CisKKzIwMTQtMDkt MDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIg SW5zcGVjdG9yOiBGaXggRVNMaW50IG5vLWV4dHJhLWJpbmQgd2FybmluZ3MKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY1OQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NU2VhcmNoTWF0 Y2hPYmplY3QuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv RE9NU2VhcmNoTWF0Y2hPYmplY3QuanMKaW5kZXggNDZmMWQ4Ni4uMDQzNWQwNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTVNlYXJjaE1h dGNoT2JqZWN0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9ET01TZWFyY2hNYXRjaE9iamVjdC5qcwpAQCAtOTgsNyArOTgsNyBAQCBXZWJJbnNwZWN0 b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QucHJvdG90eXBlID0gewogICAgICAgICAgICAgcmV0dXJu IFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVjdC5ET01NYXRjaENoYXJhY3RlckRhdGFJ Y29uU3R5bGVDbGFzc05hbWU7CiAKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGNvbnNv bGUuZXJyb3IoIlVua25vd24gRE9NIG5vZGUgdHlwZTogIiwgbm9kZS5ub2RlVHlwZSgpKTsKKyAg ICAgICAgICAgIGNvbnNvbGUuZXJyb3IoIlVua25vd24gRE9NIG5vZGUgdHlwZTogIiwgdGhpcy5f ZG9tTm9kZS5ub2RlVHlwZSgpKTsKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuRE9N U2VhcmNoTWF0Y2hPYmplY3QuRE9NTWF0Y2hOb2RlSWNvblN0eWxlQ2xhc3NOYW1lOwogICAgICAg ICB9CiAgICAgfQpAQCAtMTI4LDcgKzEyOCw3IEBAIFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRj aE9iamVjdC50aXRsZUZvckRPTU5vZGUgPSBmdW5jdGlvbihkb21Ob2RlKQogICAgICAgICB2YXIg dGl0bGUgPSAiPCFET0NUWVBFICIgKyBkb21Ob2RlLm5vZGVOYW1lKCk7CiAgICAgICAgIGlmIChk b21Ob2RlLnB1YmxpY0lkKSB7CiAgICAgICAgICAgICB0aXRsZSArPSAiIFBVQkxJQyBcIiIgKyBk b21Ob2RlLnB1YmxpY0lkICsgIlwiIjsKLSAgICAgICAgICAgIGlmIChub2RlLnN5c3RlbUlkKQor ICAgICAgICAgICAgaWYgKGRvbU5vZGUuc3lzdGVtSWQpCiAgICAgICAgICAgICAgICAgdGl0bGUg Kz0gIiBcIiIgKyBkb21Ob2RlLnN5c3RlbUlkICsgIlwiIjsKICAgICAgICAgfSBlbHNlIGlmIChk b21Ob2RlLnN5c3RlbUlkKQogICAgICAgICAgICAgdGl0bGUgKz0gIiBTWVNURU0gXCIiICsgZG9t Tm9kZS5zeXN0ZW1JZCArICJcIiI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvR3JhZGllbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvR3JhZGllbnQuanMKaW5kZXggNmNhMTNiOC4uYzRlZWNlYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0dy YWRpZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9HcmFkaWVudC5qcwpAQCAtNDgsNiArNDgsNyBAQCBXZWJJbnNwZWN0b3IuR3JhZGllbnQgPSB7 CiAgICAgICAgIHZhciBjdXJyZW50UGFyYW0gPSAiIjsKICAgICAgICAgdmFyIG9wZW5QYXJlbnRo ZXNlcyA9IDA7CiAgICAgICAgIHZhciBjaCA9IG9wZW5pbmdQYXJlbnRoZXNpc0luZGV4ICsgMTsK KyAgICAgICAgdmFyIGMgPSBudWxsOwogICAgICAgICB3aGlsZSAoYyA9IGNzc1N0cmluZ1tjaF0p IHsKICAgICAgICAgICAgIGlmIChjID09PSAiKCIpCiAgICAgICAgICAgICAgICAgb3BlblBhcmVu dGhlc2VzKys7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db2RlTWlycm9yQWRkaXRpb25zLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0aW9ucy5qcwppbmRleCBhMjFjODBiLi43 ZGU2YzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db2RlTWlycm9yQWRkaXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JBZGRpdGlvbnMuanMKQEAgLTU1Miw2ICs1NTIs NyBAQAogICAgICAgICAgICAgICAgIHZhciBlbmRDaGFyID0gbWF0Y2guaW5kZXggKyBtYXRjaFsw XS5sZW5ndGg7CiAKICAgICAgICAgICAgICAgICB2YXIgb3BlblBhcmVudGhlc2VzID0gMDsKKyAg ICAgICAgICAgICAgICB2YXIgYyA9IG51bGw7CiAgICAgICAgICAgICAgICAgd2hpbGUgKGMgPSBs aW5lQ29udGVudFtlbmRDaGFyXSkgewogICAgICAgICAgICAgICAgICAgICBpZiAoYyA9PT0gIigi KQogICAgICAgICAgICAgICAgICAgICAgICAgb3BlblBhcmVudGhlc2VzKys7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXBsYXlEYXNoYm9h cmRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVw bGF5RGFzaGJvYXJkVmlldy5qcwppbmRleCBiMjI4OTI0Li5hNTNlYTExIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXBsYXlEYXNoYm9hcmRW aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jl cGxheURhc2hib2FyZFZpZXcuanMKQEAgLTMwLDggKzMwLDYgQEAgV2ViSW5zcGVjdG9yLlJlcGxh eURhc2hib2FyZFZpZXcgPSBmdW5jdGlvbihyZXByZXNlbnRlZE9iamVjdCkKICAgICB0aGlzLl9u YXZpZ2F0aW9uQmFyID0gbmV3IFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uQmFyOwogICAgIHRoaXMu ZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9uYXZpZ2F0aW9uQmFyLmVsZW1lbnQpOwogCi0gICAg cmVwbGF5TWFuYWdlciA9IFdlYkluc3BlY3Rvci5yZXBsYXlNYW5hZ2VyOwotCiAgICAgdGhpcy5f Y2FwdHVyZUJ1dHRvbkl0ZW0gPSBuZXcgV2ViSW5zcGVjdG9yLkFjdGl2YXRlQnV0dG9uTmF2aWdh dGlvbkl0ZW0oInJlcGxheS1kYXNoYm9hcmQtY2FwdHVyZSIsIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiU3RhcnQgUmVjb3JkaW5nIiksIFdlYkluc3BlY3Rvci5VSVN0cmluZygiU3RvcCBSZWNvcmRp bmciKSwgIkltYWdlcy9SZXBsYXlSZWNvcmRpbmdCdXR0b24uc3ZnIiwgMTYsIDE2KTsKICAgICB0 aGlzLl9jYXB0dXJlQnV0dG9uSXRlbS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5CdXR0 b25OYXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLl9jYXB0dXJlQnV0dG9uSXRlbUNs aWNrZWQsIHRoaXMpOwogICAgIHRoaXMuX2NhcHR1cmVCdXR0b25JdGVtLmhpZGRlbiA9IHRydWU7 Cg==