136659 2014-09-08 20:19:00 -0700 Web Inspector: Fix ESLint no-extra-bind warnings 2014-09-16 12:54:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1034041 0 joepeck 2014-09-08 20:19:00 -0700 There were two cases where we were doing an extra bind. One is a clear fix. The other looks like we might want to refactor and should be addressed separately. 1034042 1 237833 joepeck 2014-09-08 20:19:38 -0700 Created attachment 237833 [PATCH] Proposed Fix 1034047 2 jonowells 2014-09-08 20:24:00 -0700 The one in TypeTokenView.js? 1034054 3 joepeck 2014-09-08 20:41:19 -0700 (In reply to comment #2) > The one in TypeTokenView.js? Yeah. In that case the timeout identifier should be set to null after it is cleared... I have to take a deeper look at it and address is individually. 1034426 4 237833 burg 2014-09-10 15:13:43 -0700 Comment on attachment 237833 [PATCH] Proposed Fix Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes? (Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused) 1034433 5 joepeck 2014-09-10 15:24:28 -0700 (In reply to comment #4) > (From update of attachment 237833 [details]) > Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes? > > (Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused) I don't think there is one. One could be written pretty quickly though. 1035536 6 238193 joepeck 2014-09-16 12:10:15 -0700 Created attachment 238193 [PATCH] Proposed Fix 1035537 7 webkit-bug-importer 2014-09-16 12:10:47 -0700 <rdar://problem/18354652> 1035545 8 238193 commit-queue 2014-09-16 12:54:22 -0700 Comment on attachment 238193 [PATCH] Proposed Fix Clearing flags on attachment: 238193 Committed r173667: <http://trac.webkit.org/changeset/173667> 1035546 9 commit-queue 2014-09-16 12:54:25 -0700 All reviewed patches have been landed. Closing bug. 237833 2014-09-08 20:19:38 -0700 2014-09-16 12:10:15 -0700 [PATCH] Proposed Fix no-extra-bind.patch text/plain 1830 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS8uZXNsaW50cmMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvLmVzbGludHJjCmluZGV4IDA2NWYxMzguLjMyZDg1NmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS8uZXNsaW50cmMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJLy5lc2xpbnRyYwpAQCAtNTksNiArNTksNyBAQAogICAgICAgICAiZXFlcWVxIjogMiwKICAg ICAgICAgImN1cmx5IjogMCwKICAgICAgICAgInF1b3RlcyI6IFsyLCAiZG91YmxlIl0sCisgICAg ICAgICJuby1leHRyYS1iaW5kIjogMiwKICAgICAgICAgIm5vLXRyYWlsaW5nLXNwYWNlcyI6IDIs CiAgICAgICAgICJuby11bmRlcnNjb3JlLWRhbmdsZSI6IDAsCiAgICAgICAgICJuZXctcGFyZW5z IjogMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggZjc2ZWI4OS4uNjk1M2RkMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTQtMDktMDggIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBG aXggRVNMaW50IG5vLWV4dHJhLWJpbmQgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjY1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogLmVzbGludHJjOgorICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvTGF5ZXJUcmVlTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5MYXllclRyZWVNYW5hZ2VyLnByb3RvdHlwZS5sYXllcnNGb3JOb2RlKToKKworMjAxNC0w OS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IEZpeCBFU0xpbnQgZXFlcWVxIHdhcm5pbmdzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2NTgKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTGF5ZXJUcmVlTWFu YWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0xheWVyVHJlZU1hbmFnZXIuanMKaW5kZXggYWMyMmY0ZS4uMGM5YmY4ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTGF5ZXJUcmVl TWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9MYXllclRyZWVNYW5hZ2VyLmpzCkBAIC0xMzksNyArMTM5LDcgQEAgV2ViSW5zcGVj dG9yLkxheWVyVHJlZU1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICAgICAgdmFyIGZpcnN0 TGF5ZXIgPSBsYXllcnNbMF07CiAgICAgICAgICAgICB2YXIgbGF5ZXJGb3JOb2RlID0gZmlyc3RM YXllci5ub2RlSWQgPT09IG5vZGUuaWQgJiYgIWZpcnN0TGF5ZXIuaXNHZW5lcmF0ZWRDb250ZW50 ID8gbGF5ZXJzLnNoaWZ0KCkgOiBudWxsOwogICAgICAgICAgICAgY2FsbGJhY2sobGF5ZXJGb3JO b2RlLCBsYXllcnMpOwotICAgICAgICB9LmJpbmQodGhpcykpOworICAgICAgICB9KTsKICAgICB9 LAogCiAgICAgcmVhc29uc0ZvckNvbXBvc2l0aW5nTGF5ZXI6IGZ1bmN0aW9uKGxheWVyLCBjYWxs YmFjaykK 238193 2014-09-16 12:10:15 -0700 2014-09-16 12:54:22 -0700 [PATCH] Proposed Fix rebased.patch text/plain 1818 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS8uZXNsaW50cmMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvLmVzbGludHJjCmluZGV4IGQzYmY3YzQuLjhmZjg1MzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS8uZXNsaW50cmMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJLy5lc2xpbnRyYwpAQCAtNjMsNiArNjMsNyBAQAogICAgICAgICAibm8tY29tbWEtZGFuZ2xl IjogMCwKICAgICAgICAgIm5vLWNvbnNvbGUiOiAwLAogICAgICAgICAibm8tY29uc3RhbnQtY29u ZGl0aW9uIjogMCwKKyAgICAgICAgIm5vLWV4dHJhLWJpbmQiOiAyLAogICAgICAgICAibm8tZXh0 cmEtc2VtaSI6IDIsCiAgICAgICAgICJuby1wcm90byI6IDAsCiAgICAgICAgICJuby1yZXR1cm4t YXNzaWduIjogMiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNhZDcwOGMuLjM4MjMwNTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA5LTE2ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogRml4IEVTTGludCBuby1leHRyYS1iaW5kIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY2NTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIC5lc2xpbnRyYzoKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0xheWVyVHJlZU1hbmFnZXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuTGF5ZXJUcmVlTWFuYWdlci5wcm90b3R5cGUubGF5ZXJzRm9yTm9kZSk6CisK IDIwMTQtMDktMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBIaWRlIERPTSBzZWFyY2ggcmVzdWx0IGhpZ2hsaWdodHMgd2hl biBmaW5kIGJhbm5lciBpcyBub3Qgc2hvd2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTGF5ZXJUcmVlTWFuYWdlci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0xheWVyVHJlZU1h bmFnZXIuanMKaW5kZXggYWMyMmY0ZS4uMGM5YmY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTGF5ZXJUcmVlTWFuYWdlci5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9MYXll clRyZWVNYW5hZ2VyLmpzCkBAIC0xMzksNyArMTM5LDcgQEAgV2ViSW5zcGVjdG9yLkxheWVyVHJl ZU1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICAgICAgdmFyIGZpcnN0TGF5ZXIgPSBsYXll cnNbMF07CiAgICAgICAgICAgICB2YXIgbGF5ZXJGb3JOb2RlID0gZmlyc3RMYXllci5ub2RlSWQg PT09IG5vZGUuaWQgJiYgIWZpcnN0TGF5ZXIuaXNHZW5lcmF0ZWRDb250ZW50ID8gbGF5ZXJzLnNo aWZ0KCkgOiBudWxsOwogICAgICAgICAgICAgY2FsbGJhY2sobGF5ZXJGb3JOb2RlLCBsYXllcnMp OwotICAgICAgICB9LmJpbmQodGhpcykpOworICAgICAgICB9KTsKICAgICB9LAogCiAgICAgcmVh c29uc0ZvckNvbXBvc2l0aW5nTGF5ZXI6IGZ1bmN0aW9uKGxheWVyLCBjYWxsYmFjaykK