136646 2014-09-08 15:38:50 -0700 Modernize the loop in BitmapImage::dataChanged that clears incomplete frames and metadata 2022-10-09 06:21:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 thorton thorton ahmad.saleem792 commit-queue mitz simon.fraser oldest_to_newest 1033971 0 thorton 2014-09-08 15:38:50 -0700 Modernize the loop in BitmapImage::dataChanged that clears incomplete frames and metadata 1033972 1 237816 thorton 2014-09-08 15:39:13 -0700 Created attachment 237816 Patch 1033973 2 commit-queue 2014-09-08 15:41:45 -0700 Attachment 237816 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1904347 3 ahmad.saleem792 2022-10-09 06:21:16 -0700 It seems this didn't landed (While checking with bug ID on Webkit GitHub) but I am not able to find related code, which this patch was trying to modify. Do we need this? Thanks! 237816 2014-09-08 15:39:13 -0700 2014-09-08 19:36:27 -0700 Patch bug-136646-20140908153908.patch text/plain 2220 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWEwNGU0YzE4ZDczMzNk ZTU1YmFkNDg5ZTYwNTljYTNkMTczMDBiZi4uNzczZGFhYzBmYzY5MzExMGMwZmZkYzY4ZjNkMWFh OGVjODA5ZTQ5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTA5LTA4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIE1vZGVybml6ZSB0 aGUgbG9vcCBpbiBCaXRtYXBJbWFnZTo6ZGF0YUNoYW5nZWQgdGhhdCBjbGVhcnMgaW5jb21wbGV0 ZSBmcmFtZXMgYW5kIG1ldGFkYXRhCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcElt YWdlOjpkYXRhQ2hhbmdlZCk6CisgICAgICAgIE1vZGVybml6ZSB0aGlzIGxvb3AuCisKKzIwMTQt MDktMDggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAg VW5pZnkgdGhlIHBhcnQgb2YgQml0bWFwSW1hZ2U6OmRhdGFDaGFuZ2VkIHRoYXQgY2xlYXJzIGlu Y29tcGxldGUgZnJhbWVzIGFuZCBtZXRhZGF0YQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NjQ1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAppbmRleCAzMTYxMDkxMmQ3N2VmNDk0NzFmNzU3 M2JiYzE1YzEyMzhiZTUyMmUxLi40YWJiMzcyNjgwZTQyZTBmMzFhMDUzZmEyYmFjZTlkNzRkZTgy NGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJ bWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1h Z2UuY3BwCkBAIC0yODEsMTMgKzI4MSwxMSBAQCBib29sIEJpdG1hcEltYWdlOjpkYXRhQ2hhbmdl ZChib29sIGFsbERhdGFSZWNlaXZlZCkKICAgICAvLyBmcmFtZSBhZmZlY3RlZCBieSBhcHBlbmRp bmcgbmV3IGRhdGEgaGVyZS4gVGh1cyB3ZSBoYXZlIHRvIGNsZWFyIGFsbCB0aGUKICAgICAvLyBp bmNvbXBsZXRlIGZyYW1lcyB0byBiZSBzYWZlLgogICAgIHVuc2lnbmVkIGZyYW1lQnl0ZXNDbGVh cmVkID0gMDsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZnJhbWVzLnNpemUoKTsgKytp KSB7Ci0gICAgICAgIC8vIE5PVEU6IERvbid0IGNhbGwgZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgp IGhlcmUsIHRoYXQgd2lsbCB0cnkgdG8KLSAgICAgICAgLy8gZGVjb2RlIGFueSB1bmNhY2hlZCAo aS5lLiBuZXZlci1kZWNvZGVkIG9yCi0gICAgICAgIC8vIGNsZWFyZWQtb24tYS1wcmV2aW91cy1w YXNzKSBmcmFtZXMhCi0gICAgICAgIHVuc2lnbmVkIGZyYW1lQnl0ZXMgPSBtX2ZyYW1lc1tpXS5t X2ZyYW1lQnl0ZXM7Ci0gICAgICAgIGlmIChtX2ZyYW1lc1tpXS5tX2hhdmVNZXRhZGF0YSAmJiAh bV9mcmFtZXNbaV0ubV9pc0NvbXBsZXRlKQotICAgICAgICAgICAgZnJhbWVCeXRlc0NsZWFyZWQg Kz0gKG1fZnJhbWVzW2ldLmNsZWFyKHRydWUpID8gZnJhbWVCeXRlcyA6IDApOworICAgIGZvciAo RnJhbWVEYXRhJiBmcmFtZSA6IG1fZnJhbWVzKSB7CisgICAgICAgIC8vIE5PVEU6IERvbid0IGNh bGwgZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgpIGhlcmUsIHRoYXQgd2lsbCB0cnkgdG8gZGVjb2Rl CisgICAgICAgIC8vIGFueSB1bmNhY2hlZCAoaS5lLiBuZXZlci1kZWNvZGVkIG9yIGNsZWFyZWQt b24tYS1wcmV2aW91cy1wYXNzKSBmcmFtZXMhCisgICAgICAgIGlmIChmcmFtZS5tX2hhdmVNZXRh ZGF0YSAmJiAhZnJhbWUubV9pc0NvbXBsZXRlKQorICAgICAgICAgICAgZnJhbWVCeXRlc0NsZWFy ZWQgKz0gKGZyYW1lLmNsZWFyKHRydWUpID8gZnJhbWUubV9mcmFtZUJ5dGVzIDogMCk7CiAgICAg fQogICAgIGRlc3Ryb3lNZXRhZGF0YUFuZE5vdGlmeShmcmFtZUJ5dGVzQ2xlYXJlZCk7CiAK