136642 2014-09-08 13:20:22 -0700 Always update the referrer header in CachedResource 2014-09-08 14:22:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen ap commit-queue japhet oldest_to_newest 1033933 0 jochen 2014-09-08 13:20:22 -0700 Always update the referrer header in CachedResource 1033934 1 237807 jochen 2014-09-08 13:21:36 -0700 Created attachment 237807 Patch 1033935 2 jochen 2014-09-08 13:24:14 -0700 not sure how to test this. I added a similar patch in chromium here https://codereview.chromium.org/534233002, however, the loader code has diverged considerably meanwhile. 1033939 3 237807 ap 2014-09-08 13:36:37 -0700 Comment on attachment 237807 Patch Seems like a reasonable improvement for code clarity and robustness, even if it doesn't fix anything real in WebKit. 1033946 4 237807 commit-queue 2014-09-08 14:22:27 -0700 Comment on attachment 237807 Patch Clearing flags on attachment: 237807 Committed r173398: <http://trac.webkit.org/changeset/173398> 1033947 5 commit-queue 2014-09-08 14:22:31 -0700 All reviewed patches have been landed. Closing bug. 237807 2014-09-08 13:21:36 -0700 2014-09-08 14:22:27 -0700 Patch bug-136642-20140908222130.patch text/plain 1770 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJkYzc5NDNkZWM0Zjll YWYxYTdiNDIyZWE1MTk2NTFlMWViNWU1Ni4uYzY1MTU0OTg5MDZjZWYyYWU0YTEyY2NlNmQwM2I1 ZWJiZTZkMWUyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA5LTA4ICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsd2F5cyB1cGRh dGUgdGhlIHJlZmVycmVyIGhlYWRlciBpbiBDYWNoZWRSZXNvdXJjZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NjQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYSByZXF1ZXN0IGFscmVhZHkgaW5j bHVkZXMgYSByZWZlcnJlciBoZWFkZXIsIGFuZCB0aGUgZG9jdW1lbnQgaGFzCisgICAgICAgIGEg bm9uLWRlZmF1bHQgcmVmZXJyZXIgcG9saWN5LCBpdCBpcyBwb3NzaWJsZSB0aGF0IHdlIGhhdmUg dG8gbW9kaWZ5CisgICAgICAgIHRoZSByZWZlcnJlciBoZWFkZXIuCisKKyAgICAgICAgKiBsb2Fk ZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVz b3VyY2U6OmFkZEFkZGl0aW9uYWxSZXF1ZXN0SGVhZGVycyk6CisKIDIwMTQtMDktMDIgIEJyaWFu IEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIExlZ2FjeVByb2Zp bGVyOiByZW1vdmUgcmVkdW5kYW50IFByb2ZpbGVOb2RlIG1lbWJlcnMgYW5kIG90aGVyIGNsZWFu dXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJj ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCmlu ZGV4IGMzZTA5MjkzMWM5ZDdiOWY2MTQ2MGM4Yzc3MmRlYjUyNjMzZmRkODIuLjU5YjJkN2M3YTA0 N2ExZWVmNzg4MjQ0YzlhNmMwNjZkNTk1YzFhYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcApAQCAtMjU2LDcgKzI1Niw3IEBAIHZvaWQgQ2Fj aGVkUmVzb3VyY2U6OmFkZEFkZGl0aW9uYWxSZXF1ZXN0SGVhZGVycyhDYWNoZWRSZXNvdXJjZUxv YWRlciogY2FjaGVkUmVzCiAgICAgb3V0Z29pbmdSZWZlcnJlciA9IFNlY3VyaXR5UG9saWN5Ojpn ZW5lcmF0ZVJlZmVycmVySGVhZGVyKGNhY2hlZFJlc291cmNlTG9hZGVyLT5kb2N1bWVudCgpLT5y ZWZlcnJlclBvbGljeSgpLCBtX3Jlc291cmNlUmVxdWVzdC51cmwoKSwgb3V0Z29pbmdSZWZlcnJl cik7CiAgICAgaWYgKG91dGdvaW5nUmVmZXJyZXIuaXNFbXB0eSgpKQogICAgICAgICBtX3Jlc291 cmNlUmVxdWVzdC5jbGVhckhUVFBSZWZlcnJlcigpOwotICAgIGVsc2UgaWYgKCFtX3Jlc291cmNl UmVxdWVzdC5odHRwUmVmZXJyZXIoKSkKKyAgICBlbHNlCiAgICAgICAgIG1fcmVzb3VyY2VSZXF1 ZXN0LnNldEhUVFBSZWZlcnJlcihvdXRnb2luZ1JlZmVycmVyKTsKICAgICBGcmFtZUxvYWRlcjo6 YWRkSFRUUE9yaWdpbklmTmVlZGVkKG1fcmVzb3VyY2VSZXF1ZXN0LCBvdXRnb2luZ09yaWdpbik7 CiAK