136633 2014-09-08 09:15:07 -0700 [WinCairo] Compile error. 2014-09-08 12:21:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue darin eric.carlson glenn jer.noble philipj sergio oldest_to_newest 1033863 0 peavo 2014-09-08 09:15:07 -0700 Compiling AudioHardwareListener.cpp, I get the following compile error: AudioHardwareListener.h(35) : error C2365 : 'Unknown' : redefinition; previous definition was 'enumerator' (..\html\HTMLElementsAllInOne.cpp) C:\WebKit\Source\WebCore\platform\network\HTTPParsers.h(84) : see declaration of 'Unknown'. 1033865 1 237791 peavo 2014-09-08 09:18:24 -0700 Created attachment 237791 Patch 1033884 2 237793 peavo 2014-09-08 10:16:28 -0700 Created attachment 237793 Patch 1033885 3 peavo 2014-09-08 10:17:47 -0700 (In reply to comment #2) > Created an attachment (id=237793) [details] > Patch Previous patch caused some new compile errors. 1033887 4 237793 darin 2014-09-08 10:26:15 -0700 Comment on attachment 237793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237793&action=review > Source/WebCore/platform/audio/AudioHardwareListener.h:34 > +enum class AudioHardwareActivityType { I’m amazed that this compiles without adding AudioHardwareActivityType:: prefixes in various places. But if it does, great! 1033913 5 237793 commit-queue 2014-09-08 11:54:21 -0700 Comment on attachment 237793 Patch Clearing flags on attachment: 237793 Committed r173391: <http://trac.webkit.org/changeset/173391> 1033914 6 commit-queue 2014-09-08 11:54:25 -0700 All reviewed patches have been landed. Closing bug. 1033920 7 peavo 2014-09-08 12:21:00 -0700 (In reply to comment #4) > (From update of attachment 237793 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237793&action=review > > > Source/WebCore/platform/audio/AudioHardwareListener.h:34 > > +enum class AudioHardwareActivityType { > > I’m amazed that this compiles without adding AudioHardwareActivityType:: prefixes in various places. But if it does, great! Seems to build on all builders, thanks for reviewing :) 237791 2014-09-08 09:18:24 -0700 2014-09-08 10:16:19 -0700 Patch bug-136633-20140908181816.patch text/plain 1763 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzM4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTA4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjYzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEVudW0gbmFtZSBoYXMgYWxyZWFkeSBiZWVuIGRlZmluZWQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9hdWRpby9BdWRpb0hhcmR3YXJlTGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXVkaW9IYXJkd2FyZUxpc3RlbmVyOjpBdWRpb0hhcmR3YXJlTGlzdGVuZXIpOgorICAgICAgICAq IHBsYXRmb3JtL2F1ZGlvL0F1ZGlvSGFyZHdhcmVMaXN0ZW5lci5oOgorCiAyMDE0LTA5LTA4ICBH eXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTFtX SzJdIE1pbmlCcm93c2VyIGNvbWVzIHRvIGNyYXNoIG9uIGRlYnVnIG1vZGUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvSGFyZHdhcmVMaXN0ZW5lci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9IYXJkd2FyZUxpc3Rl bmVyLmNwcAkocmV2aXNpb24gMTczMzc5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vQXVkaW9IYXJkd2FyZUxpc3RlbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcs NyBAQCBQYXNzUmVmUHRyPEF1ZGlvSGFyZHdhcmVMaXN0ZW5lcj4gQXVkaW9ICiAKIEF1ZGlvSGFy ZHdhcmVMaXN0ZW5lcjo6QXVkaW9IYXJkd2FyZUxpc3RlbmVyKENsaWVudCYgY2xpZW50KQogICAg IDogbV9jbGllbnQoY2xpZW50KQotICAgICwgbV9hY3Rpdml0eShBdWRpb0hhcmR3YXJlQWN0aXZp dHlUeXBlOjpVbmtub3duKQorICAgICwgbV9hY3Rpdml0eShBdWRpb0hhcmR3YXJlQWN0aXZpdHlU eXBlOjpJc1Vua25vd24pCiAgICAgLCBtX291dHB1dERldmljZVN1cHBvcnRzTG93UG93ZXJNb2Rl KGZhbHNlKQogewogI2lmIFBMQVRGT1JNKElPUykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL0F1ZGlvSGFyZHdhcmVMaXN0ZW5lci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvSGFyZHdhcmVMaXN0ZW5lci5oCShyZXZpc2lvbiAx NzMzNzkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0hhcmR3YXJlTGlz dGVuZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQAogbmFtZXNwYWNlIFdlYkNv cmUgewogICAgIAogZW51bSBBdWRpb0hhcmR3YXJlQWN0aXZpdHlUeXBlIHsKLSAgICBVbmtub3du LAorICAgIElzVW5rbm93biwKICAgICBJc0FjdGl2ZSwKICAgICBJc0luYWN0aXZlCiB9Owo= 237793 2014-09-08 10:16:28 -0700 2014-09-08 11:54:21 -0700 Patch bug-136633-20140908191620.patch text/plain 1054 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzM4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA5LTA4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjYzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEVudW0gbmFtZSBoYXMgYWxyZWFkeSBiZWVuIGRlZmluZWQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9hdWRpby9BdWRpb0hhcmR3YXJlTGlzdGVuZXIuaDoKKwogMjAxNC0wOS0wOCAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxbV0syXSBN aW5pQnJvd3NlciBjb21lcyB0byBjcmFzaCBvbiBkZWJ1ZyBtb2RlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0hhcmR3YXJlTGlzdGVuZXIuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0hhcmR3YXJlTGlzdGVuZXIuaAko cmV2aXNpb24gMTczMzc5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9I YXJkd2FyZUxpc3RlbmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIAotZW51bSBBdWRpb0hhcmR3YXJlQWN0aXZpdHlUeXBlIHsK K2VudW0gY2xhc3MgQXVkaW9IYXJkd2FyZUFjdGl2aXR5VHlwZSB7CiAgICAgVW5rbm93biwKICAg ICBJc0FjdGl2ZSwKICAgICBJc0luYWN0aXZlCg==