136612 2014-09-07 12:46:56 -0700 REGRESSION (r172153): Text drawn with wrong color when second text shadow has zero offset and blur (breaks buttons at aws.amazon.com) 2014-09-15 13:05:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,<div%20style="color:%20green;%20text-shadow:%20yellow%2010px%2010px,%20red%200%200;">This%20should%20be%20green</div> InRadar, Regression P1 Normal --- 1 mitz mmaxfield commit-queue darin d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan mmaxfield pdr schenney sergio oldest_to_newest 1033749 0 mitz 2014-09-07 12:46:56 -0700 To reproduce, open the URL. The text is drawn in black, but it should be green. This was caused by <http://trac.webkit.org/r172153>, the fix for bug 135357. 1033751 1 mitz 2014-09-07 12:47:52 -0700 <rdar://problem/18260645> 1033930 2 237805 mmaxfield 2014-09-08 13:04:27 -0700 Created attachment 237805 Patch 1033943 3 237805 darin 2014-09-08 14:10:50 -0700 Comment on attachment 237805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237805&action=review > Source/WebCore/rendering/TextPainter.cpp:68 > static bool isEmptyShadow(const ShadowData* shadow) > { > if (!shadow) > - return true; > + return false; > return shadow->location() == IntPoint() && !shadow->radius(); > } I think it’s confusing to change the behavior of this function without changing its name. Maybe it should take a reference and the null check could be at the call site. Or maybe we can just call this a pure bug fix and say that the old behavior was a bug. > Source/WebCore/rendering/TextPainter.cpp:86 > + if (isEmptyShadow(shadow)) { > + shadow = shadow->next(); > + continue; > + } Should put this before the definitions of extraOffset and didSaveContext. > Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:598 > + bool didSaveContext = false; You forgot to change the code below to use this boolean! It still says “if (shadow->next())” but should say “if (didSaveContext)”. 1034034 4 237805 mmaxfield 2014-09-08 19:54:21 -0700 Comment on attachment 237805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237805&action=review >> Source/WebCore/rendering/TextPainter.cpp:68 >> } > > I think it’s confusing to change the behavior of this function without changing its name. Maybe it should take a reference and the null check could be at the call site. Or maybe we can just call this a pure bug fix and say that the old behavior was a bug. I think that calling this a pure bug fix is the right way to go. >> Source/WebCore/rendering/TextPainter.cpp:86 >> + } > > Should put this before the definitions of extraOffset and didSaveContext. Done. >> Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:598 >> + bool didSaveContext = false; > > You forgot to change the code below to use this boolean! It still says “if (shadow->next())” but should say “if (didSaveContext)”. Done. 1034035 5 mmaxfield 2014-09-08 19:56:51 -0700 http://trac.webkit.org/changeset/173418 1035050 6 mitz 2014-09-12 23:23:12 -0700 (In reply to comment #5) > http://trac.webkit.org/changeset/173418 This change made things worse! Now a single shadow with zero offset and blur makes text vanish entirely: <div style="color: green; text-shadow: blue 0 0">text</div> 1035052 7 mitz 2014-09-12 23:26:39 -0700 (In reply to comment #6) > (In reply to comment #5) > > http://trac.webkit.org/changeset/173418 > > This change made things worse! Now a single shadow with zero offset and blur makes text vanish entirely: > <div style="color: green; text-shadow: blue 0 0">text</div> Reported that separately as bug 136801. It’s incredible that there isn’t a single regression test for this. 1035105 8 darin 2014-09-14 12:05:46 -0700 Wow, really embarrassing. Myles, I won’t be able to think about anything other than this bug if we play Destiny now! 1035295 9 mmaxfield 2014-09-15 13:05:16 -0700 On it. 237805 2014-09-08 13:04:27 -0700 2014-09-08 19:54:20 -0700 Patch bug-136612-20140908130422.patch text/plain 9095 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdhZTE4ZWVkZjY2ZDA1 ZjNmZDMzMTMwYzU0NzUxNmI0NDc0N2MzMy4uMWUxMDY0MTBmMzE1M2U0OTI3MzFmMDcyZmE5Yzcz ZWI4YmI1YTA1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTA5LTA4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjE3MjE1Myk6IFRleHQgZHJhd24gd2l0aCB3cm9uZyBjb2xvciB3aGVuIHNlY29uZCB0ZXh0 IHNoYWRvdyBoYXMgemVybyBvZmZzZXQgYW5kIGJsdXIgKGJyZWFrcyBidXR0b25zIGF0IGF3cy5h bWF6b24uY29tKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2NjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgcjE3MjE1MyB3YXMgZnVuZGFtZW50YWxseSBicm9rZW4sIGFuZCB3b3VsZCByZXN0b3JlIGdy YXBoaWNzIGNvbnRleHRzIHRoYXQgaGFkIG5ldmVyIGJlZW4gc2F2ZWQuIFRoaXMgcGF0Y2gKKyAg ICAgICAgcmVpbXBsZW1lbnRzIHIxNzIxNTMgYnkgdXNpbmcgImNvbnRpbnVlIiB0byBza2lwIGxv b3AgaXRlcmF0aW9ucyBpbnN0ZWFkIG9mIGNoYW5naW5nIHRoZSBpbnRlcm5hbCBsb2dpYyBvZgor ICAgICAgICB0aGUgbG9vcC4KKworICAgICAgICBJbiBhZGRpdGlvbiwgSSBoYXZlIHJlZmFjdG9y ZWQgSW5saW5lVGV4dEJveDo6YXBwbHlTaGFkb3dUb0dyYXBoaWNzQ29udGV4dCgpIHRvIHRha2Ug YW4gZXh0cmEgYm9vbGVhbgorICAgICAgICByZWZlcmVuY2UgYXMgYW4gb3V0IHBhcmFtZXRlciBp biBvcmRlciB0byBtYWtlIGl0IG9idmlvdXMgaXQgaWYgc2F2ZWQgYSBncmFwaGljcyBjb250ZXh0 IHRoYXQgbmVlZHMKKyAgICAgICAgdG8gYmUgcmVzdG9yZWQuIFRoaXMgc2hvdWxkIG1ha2UgaXQg bGVzcyBsaWtlbHkgdG8gbWFrZSB0aGVzZSBraW5kcyBvZiBtaXN0YWtlcyBpbiB0aGUgZnV0dXJl LgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9lbXB0eS1zaGFkb3ctd2l0aC1jb2xvci5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbmxpbmVUZXh0Qm94OjphcHBseVNoYWRvd1RvR3JhcGhpY3NDb250ZXh0KTogQWRkIGJv b2wgcmVmZXJlbmNlIG91dCBwYXJhbS4KKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5lVGV4dEJv eC5oOiBEaXR0by4KKyAgICAgICAgKiByZW5kZXJpbmcvVGV4dFBhaW50ZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6aXNFbXB0eVNoYWRvdyk6IENoYW5nZSBsb2dpYyB0byBub3Qgc2tpcCBsb29w IGl0ZXJhdGlvbnMgb24gYSBudWxsIHNoYWRvdy4KKyAgICAgICAgKFdlYkNvcmU6OnBhaW50VGV4 dFdpdGhTaGFkb3dzKTogVXNlIGNvbnRpbnVlIHRvIHNraXAgbG9vcCBpdGVyYXRpb25zIGZvciBl bXB0eSBzaGFkb3dzLiBJbiBhZGRpdGlvbiwKKyAgICAgICAgdXNlIHRoZSBvdXQgcGFyYW0gaW4g SW5saW5lVGV4dEJveDo6YXBwbHlTaGFkb3dUb0dyYXBoaWNzQ29udGV4dCgpLgorICAgICAgICAq IHJlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT VkdJbmxpbmVUZXh0Qm94OjpwYWludFRleHRXaXRoU2hhZG93cyk6IFVwZGF0ZSBmb3IgbmV3IHNp Z3VyYXR1cmUgb2YKKyAgICAgICAgSW5saW5lVGV4dEJveDo6YXBwbHlTaGFkb3dUb0dyYXBoaWNz Q29udGV4dCgpLgorCiAyMDE0LTA5LTA4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ft c3VuZy5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIENTU19SVUxFX1RZUEVfQ0FTVFMsIGFuZCB1 c2UgaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAppbmRleCBh YTM0MDgxZjU4ODlhODNkNThhNGQ2MjE4MDY2OTA5ZGYzYTYyOWE2Li4yMWM0Njg0ODdiNzkxZGMw MGExNWQzYzcxZmUwMDVhMTJiMGNmZDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZVRleHRCb3guY3BwCkBAIC00MjQsNyArNDI0LDcgQEAgYm9vbCBJbmxpbmVUZXh0Qm94Ojpu b2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYg cmUKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLUZsb2F0U2l6ZSBJbmxpbmVUZXh0Qm94OjphcHBs eVNoYWRvd1RvR3JhcGhpY3NDb250ZXh0KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3Qg U2hhZG93RGF0YSogc2hhZG93LCBjb25zdCBGbG9hdFJlY3QmIHRleHRSZWN0LCBib29sIHN0cm9r ZWQsIGJvb2wgb3BhcXVlLCBib29sIGhvcml6b250YWwpCitGbG9hdFNpemUgSW5saW5lVGV4dEJv eDo6YXBwbHlTaGFkb3dUb0dyYXBoaWNzQ29udGV4dChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQs IGNvbnN0IFNoYWRvd0RhdGEqIHNoYWRvdywgY29uc3QgRmxvYXRSZWN0JiB0ZXh0UmVjdCwgYm9v bCBzdHJva2VkLCBib29sIG9wYXF1ZSwgYm9vbCBob3Jpem9udGFsLCBib29sJiBkaWRTYXZlQ29u dGV4dCkKIHsKICAgICBpZiAoIXNoYWRvdykKICAgICAgICAgcmV0dXJuIEZsb2F0U2l6ZSgpOwpA QCAtNDQ1LDYgKzQ0NSw3IEBAIEZsb2F0U2l6ZSBJbmxpbmVUZXh0Qm94OjphcHBseVNoYWRvd1Rv R3JhcGhpY3NDb250ZXh0KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwKIAogICAgICAgICBleHRy YU9mZnNldCA9IEZsb2F0U2l6ZSgwLCAyICogdGV4dFJlY3QuaGVpZ2h0KCkgKyBzdGQ6Om1heCgw LjBmLCBzaGFkb3dPZmZzZXQuaGVpZ2h0KCkpICsgc2hhZG93UmFkaXVzKTsKICAgICAgICAgc2hh ZG93T2Zmc2V0IC09IGV4dHJhT2Zmc2V0OworICAgICAgICBkaWRTYXZlQ29udGV4dCA9IHRydWU7 CiAgICAgfQogCiAgICAgY29udGV4dC0+c2V0U2hhZG93KHNoYWRvd09mZnNldCwgc2hhZG93UmFk aXVzLCBzaGFkb3dDb2xvciwgY29udGV4dC0+ZmlsbENvbG9yU3BhY2UoKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guaAppbmRleCA3MjFhM2NmY2M4YmQxZGRmN2FiNjlm YWFiNWRjZDI2YTA0YzJjZjlmLi42YjBhZTQ4OTlkMDE3YTRmMmRiYjE4ODAxMzA0Yzg2NWQ1M2Q3 OTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmgKQEAgLTE1NSw3 ICsxNTUsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBmbG9hdCBwb3NpdGlvbkZvck9mZnNldChp bnQgb2Zmc2V0KSBjb25zdDsKIAogICAgIC8vIE5lZWRzIHRvIGJlIHB1YmxpYywgc28gdGhlIHN0 YXRpYyBwYWludFRleHRXaXRoU2hhZG93cygpIGZ1bmN0aW9uIGNhbiB1c2UgaXQuCi0gICAgc3Rh dGljIEZsb2F0U2l6ZSBhcHBseVNoYWRvd1RvR3JhcGhpY3NDb250ZXh0KEdyYXBoaWNzQ29udGV4 dCosIGNvbnN0IFNoYWRvd0RhdGEqLCBjb25zdCBGbG9hdFJlY3QmIHRleHRSZWN0LCBib29sIHN0 cm9rZWQsIGJvb2wgb3BhcXVlLCBib29sIGhvcml6b250YWwpOworICAgIHN0YXRpYyBGbG9hdFNp emUgYXBwbHlTaGFkb3dUb0dyYXBoaWNzQ29udGV4dChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBT aGFkb3dEYXRhKiwgY29uc3QgRmxvYXRSZWN0JiB0ZXh0UmVjdCwgYm9vbCBzdHJva2VkLCBib29s IG9wYXF1ZSwgYm9vbCBob3Jpem9udGFsLCBib29sJiBkaWRTYXZlQ29udGV4dCk7CiAKIHByb3Rl Y3RlZDoKICAgICB2b2lkIHBhaW50Q29tcG9zaXRpb25CYWNrZ3JvdW5kKEdyYXBoaWNzQ29udGV4 dCosIGNvbnN0IEZsb2F0UG9pbnQmIGJveE9yaWdpbiwgY29uc3QgUmVuZGVyU3R5bGUmLCBjb25z dCBGb250JiwgaW50IHN0YXJ0UG9zLCBpbnQgZW5kUG9zKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvVGV4dFBhaW50ZXIuY3BwCmluZGV4IDM4ZjFiODQ1ZGZkMjE3YTAxYTE2NjY2ZmUyZjkzMDQw N2M1OTY0ZTMuLmEzYzliNDY3MTBlNDMyMDQwYTU0NmFjNmFhMjUzMzI2OWU4MTU0ODMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcApAQCAtNjMsNyArNjMsNyBAQCBz dGF0aWMgdm9pZCBkcmF3VGV4dE9yRW1waGFzaXNNYXJrcyhHcmFwaGljc0NvbnRleHQmIGNvbnRl eHQsIGNvbnN0IEZvbnQmIGZvbnQsCiBzdGF0aWMgYm9vbCBpc0VtcHR5U2hhZG93KGNvbnN0IFNo YWRvd0RhdGEqIHNoYWRvdykKIHsKICAgICBpZiAoIXNoYWRvdykKLSAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1cm4gc2hhZG93LT5sb2NhdGlvbigp ID09IEludFBvaW50KCkgJiYgIXNoYWRvdy0+cmFkaXVzKCk7CiB9CiAKQEAgLTc5LDkgKzc5LDEz IEBAIHN0YXRpYyB2b2lkIHBhaW50VGV4dFdpdGhTaGFkb3dzKEdyYXBoaWNzQ29udGV4dCogY29u dGV4dCwgY29uc3QgRm9udCYgZm9udCwgY29uCiAKICAgICBkbyB7CiAgICAgICAgIEludFNpemUg ZXh0cmFPZmZzZXQ7Ci0gICAgICAgIGJvb2wgc2hhZG93SXNFbXB0eSA9IGlzRW1wdHlTaGFkb3co c2hhZG93KTsKLSAgICAgICAgaWYgKCFzaGFkb3dJc0VtcHR5KQotICAgICAgICAgICAgZXh0cmFP ZmZzZXQgPSByb3VuZGVkSW50U2l6ZShJbmxpbmVUZXh0Qm94OjphcHBseVNoYWRvd1RvR3JhcGhp Y3NDb250ZXh0KGNvbnRleHQsIHNoYWRvdywgYm94UmVjdCwgc3Ryb2tlZCwgb3BhcXVlLCBob3Jp em9udGFsKSk7CisgICAgICAgIGJvb2wgZGlkU2F2ZUNvbnRleHQgPSBmYWxzZTsKKyAgICAgICAg aWYgKGlzRW1wdHlTaGFkb3coc2hhZG93KSkgeworICAgICAgICAgICAgc2hhZG93ID0gc2hhZG93 LT5uZXh0KCk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQorICAgICAgICBpZiAo c2hhZG93KQorICAgICAgICAgICAgZXh0cmFPZmZzZXQgPSByb3VuZGVkSW50U2l6ZShJbmxpbmVU ZXh0Qm94OjphcHBseVNoYWRvd1RvR3JhcGhpY3NDb250ZXh0KGNvbnRleHQsIHNoYWRvdywgYm94 UmVjdCwgc3Ryb2tlZCwgb3BhcXVlLCBob3Jpem9udGFsLCBkaWRTYXZlQ29udGV4dCkpOwogICAg ICAgICBlbHNlIGlmICghb3BhcXVlKQogICAgICAgICAgICAgY29udGV4dC0+c2V0RmlsbENvbG9y KGZpbGxDb2xvciwgZmlsbENvbG9yU3BhY2UpOwogCkBAIC05Nyw5ICsxMDEsOSBAQCBzdGF0aWMg dm9pZCBwYWludFRleHRXaXRoU2hhZG93cyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0 IEZvbnQmIGZvbnQsIGNvbgogICAgICAgICBpZiAoIXNoYWRvdykKICAgICAgICAgICAgIGJyZWFr OwogCi0gICAgICAgIGlmIChzaGFkb3ctPm5leHQoKSB8fCBzdHJva2VkIHx8ICFvcGFxdWUpCisg ICAgICAgIGlmIChkaWRTYXZlQ29udGV4dCkKICAgICAgICAgICAgIGNvbnRleHQtPnJlc3RvcmUo KTsKLSAgICAgICAgZWxzZSBpZiAoIXNoYWRvd0lzRW1wdHkpCisgICAgICAgIGVsc2UKICAgICAg ICAgICAgIGNvbnRleHQtPmNsZWFyU2hhZG93KCk7CiAKICAgICAgICAgc2hhZG93ID0gc2hhZG93 LT5uZXh0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lu bGluZVRleHRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdJbmxpbmVU ZXh0Qm94LmNwcAppbmRleCBkNDBiYWMzMmI2M2VmNjFkZWM1ZTViM2NmM2MzYzg2MzczNmM5ZDVj Li40NmE2ZTNiZjRmNjU5NDNkYzk2ZWIwZGFlZTE5ZWNlNTVkOTFhNTFiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lubGluZVRleHRCb3guY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5jcHAKQEAgLTU5NSw4 ICs1OTUsOSBAQCB2b2lkIFNWR0lubGluZVRleHRCb3g6OnBhaW50VGV4dFdpdGhTaGFkb3dzKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgUmVuZGVyU3R5bAogICAgICAgICAgICAgYnJlYWs7CiAK ICAgICAgICAgRmxvYXRTaXplIGV4dHJhT2Zmc2V0OworICAgICAgICBib29sIGRpZFNhdmVDb250 ZXh0ID0gZmFsc2U7CiAgICAgICAgIGlmIChzaGFkb3cpCi0gICAgICAgICAgICBleHRyYU9mZnNl dCA9IGFwcGx5U2hhZG93VG9HcmFwaGljc0NvbnRleHQoY29udGV4dCwgc2hhZG93LCBzaGFkb3dS ZWN0LCBmYWxzZSAvKiBzdHJva2VkICovLCB0cnVlIC8qIG9wYXF1ZSAqLywgdHJ1ZSAvKiBob3Jp em9udGFsICovKTsKKyAgICAgICAgICAgIGV4dHJhT2Zmc2V0ID0gYXBwbHlTaGFkb3dUb0dyYXBo aWNzQ29udGV4dChjb250ZXh0LCBzaGFkb3csIHNoYWRvd1JlY3QsIGZhbHNlIC8qIHN0cm9rZWQg Ki8sIHRydWUgLyogb3BhcXVlICovLCB0cnVlIC8qIGhvcml6b250YWwgKi8sIGRpZFNhdmVDb250 ZXh0KTsKIAogICAgICAgICBjb250ZXh0LT5zYXZlKCk7CiAgICAgICAgIGNvbnRleHQtPnNjYWxl KEZsb2F0U2l6ZSgxIC8gc2NhbGluZ0ZhY3RvciwgMSAvIHNjYWxpbmdGYWN0b3IpKTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA1N2YyNGM5ZDE0YTQ5MWE0OTgyYzIyMTlhMGQ4NTg4MjRiZGZmYWIxLi4zNTNhNzg1YmRmM2Vm YmM4NDJlMTFlODljZjU0NjA4YmEzYmFjMWE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQt MDktMDggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMTcyMTUzKTogVGV4dCBkcmF3biB3aXRoIHdyb25nIGNvbG9yIHdoZW4g c2Vjb25kIHRleHQgc2hhZG93IGhhcyB6ZXJvIG9mZnNldCBhbmQgYmx1ciAoYnJlYWtzIGJ1dHRv bnMgYXQgYXdzLmFtYXpvbi5jb20pCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzY2MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0ZXh0IGlzIGRyYXduIHdpdGggY29ycmVjdCBj b2xvciB3aGVuIHNlY29uZCB0ZXh0IHNoYWRvdyBoYXMgemVybyBvZmZzZXQgYW5kIGJsdXIKKwor ICAgICAgICAqIGZhc3QvdGV4dC9lbXB0eS1zaGFkb3ctd2l0aC1jb2xvci1leHBlY3RlZC5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvZW1wdHktc2hhZG93LXdpdGgtY29sb3IuaHRt bDogQWRkZWQuCisKIDIwMTQtMDktMDYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgogCiAgICAgICAgIFNlcmlhbGl6ZSBSZXNvdXJjZVJlc3BvbnNlcyB1c2luZyBXZWJLaXQgdHlw ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9lbXB0eS1zaGFkb3ctd2l0aC1j b2xvci1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2VtcHR5LXNoYWRvdy13 aXRoLWNvbG9yLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDVhNGQ5MjBmNzM1Y2NjOGY4NmYy ZDc3MDYwNTdiZmRlNDYyZjAzYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv dGV4dC9lbXB0eS1zaGFkb3ctd2l0aC1jb2xvci1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMTUg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKyN0ZXN0IHsKKyAg ICBjb2xvcjogZ3JlZW47CisgICAgZm9udC1zaXplOiAxNnB4OworfQorPC9zdHlsZT4KKzwvaGVh ZD4KKzxib2R5PgorVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCB0ZXh0IGRyYXduIHdpdGggYW4g ZW1wdHkgc2hhZG93IGlzIGNvbG9yZWQgY29ycmVjdGx5LiBJdCBwYXNzZXMgaWYgdGhlIGZvbGxv d2luZyB0ZXh0IGlzIGdyZWVuLgorPGRpdiBpZD0idGVzdCI+VGhpcyBzaG91bGQgYmUgZ3JlZW4u PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3Rl eHQvZW1wdHktc2hhZG93LXdpdGgtY29sb3IuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9l bXB0eS1zaGFkb3ctd2l0aC1jb2xvci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNmZGY5NWMzZmI3N2Q5MjEy ZGVjYjVkMjNmZjgxZDU5NDkzOGI3OGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3RleHQvZW1wdHktc2hhZG93LXdpdGgtY29sb3IuaHRtbApAQCAtMCwwICsxLDE3IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisjdGVzdCB7CisgICAgY29s b3I6IGdyZWVuOworICAgIGZvbnQtc2l6ZTogMTZweDsKKyAgICB0ZXh0LXNoYWRvdzogcmVkIDIw cHggMjBweCwgcmVkIDBweCAwcHg7CisgICAgb3ZlcmZsb3c6IGhpZGRlbjsKK30KKzwvc3R5bGU+ Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRoYXQgdGV4dCBkcmF3biB3 aXRoIGFuIGVtcHR5IHNoYWRvdyBpcyBjb2xvcmVkIGNvcnJlY3RseS4gSXQgcGFzc2VzIGlmIHRo ZSBmb2xsb3dpbmcgdGV4dCBpcyBncmVlbi4KKzxkaXYgaWQ9InRlc3QiPlRoaXMgc2hvdWxkIGJl IGdyZWVuLjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=