136600 2014-09-06 07:00:50 -0700 HTMLElement.cpp does not compile with new clang 2014-09-06 08:03:18 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer andersca cfleizach commit-queue dbates eae esprehn+autocc gyuyoung.kim krit mihnea oldest_to_newest 1033660 0 ddkilzer 2014-09-06 07:00:50 -0700 HTMLElement.cpp fails to build with new clang: Source/WebCore/html/HTMLElement.cpp:545:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] if (!this || !parentNode()) ~^~~~ 1 error generated. The |!this| check was added in <http://trac.webkit.org/r75738>. 1033661 1 237736 ddkilzer 2014-09-06 07:03:15 -0700 Created attachment 237736 Patch v1 1033665 2 237736 commit-queue 2014-09-06 08:03:14 -0700 Comment on attachment 237736 Patch v1 Clearing flags on attachment: 237736 Committed r173355: <http://trac.webkit.org/changeset/173355> 1033666 3 commit-queue 2014-09-06 08:03:18 -0700 All reviewed patches have been landed. Closing bug. 237736 2014-09-06 07:03:15 -0700 2014-09-06 08:03:14 -0700 Patch v1 bug-136600-20140906070300.patch text/plain 1730 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjcyMTEwNDgwODUwNzFh NjFiMmZjMzFiZDMwMDdiOTgyNjczNWMwMS4uOThjMzE2ZjdiMDk5MmU4ZjIwMTg3M2YwODllMTJl YWU0YzAzYzE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTA5LTA2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgSFRNTEVsZW1lbnQuY3Bw IGRvZXMgbm90IGNvbXBpbGUgd2l0aCBuZXcgY2xhbmcKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQu b3JnL2IvMTM2NjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeGVzIHRoZSBmb2xsb3dpbmcgc3RhdGljIGFuYWx5emVyIHdhcm5pbmc6CisKKyAg ICAgICAgICAgIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwOjU0NToxMDogZXJy b3I6ICd0aGlzJyBwb2ludGVyIGNhbm5vdCBiZSBudWxsIGluIHdlbGwtZGVmaW5lZCBDKysgY29k ZTsgcG9pbnRlciBtYXkgYmUgYXNzdW1lZCB0byBhbHdheXMgY29udmVydCB0byB0cnVlIFstV2Vy cm9yLC1XdW5kZWZpbmVkLWJvb2wtY29udmVyc2lvbl0KKyAgICAgICAgICAgICAgICBpZiAoIXRo aXMgfHwgIXBhcmVudE5vZGUoKSkKKyAgICAgICAgICAgICAgICAgICAgfl5+fn4KKworICAgICAg ICAqIGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6 OnNldE91dGVyVGV4dCk6IFJlbW92ZSAiIXRoaXMiIGNoZWNrIGFkZGVkCisgICAgICAgIGluIHI3 NTczOC4gIEl0IHdvdWxkIG9ubHkgY292ZXIgdXAgcmVhbCBidWdzLCBhbmQgaXNuJ3QgZXZlbiBo aXQKKyAgICAgICAgaW4gbGF5b3V0IHRlc3RzLgorCisyMDE0LTA5LTA2ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgTmV3IGNsYW5nIHdhcm5zIGFib3V0IGJv b2xlYW4gY2hlY2tzIGZvciB8dGhpc3wgcG9pbnRlciBpbiBSZW5kZXJPYmplY3QgZGVidWcgbWV0 aG9kcwogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzY1OTk+CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRWxlbWVudC5jcHAKaW5kZXggZjVlNTJlOWIxNzk3NTI5OGY4ZTA0NjdhODY4Njk1YjA3 YmFkMmJmMS4uYTZkNTc1ODEyNWFhYzU5MzZkOGJiYzU5ZTAwY2RiOGRhMWZlNjdlNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKQEAgLTU0Miw3ICs1NDIsNyBAQCB2b2lkIEhUTUxF bGVtZW50OjpzZXRPdXRlclRleHQoY29uc3QgU3RyaW5nJiB0ZXh0LCBFeGNlcHRpb25Db2RlJiBl YykKICAgICBlbHNlCiAgICAgICAgIG5ld0NoaWxkID0gVGV4dDo6Y3JlYXRlKGRvY3VtZW50KCks IHRleHQpOwogCi0gICAgaWYgKCF0aGlzIHx8ICFwYXJlbnROb2RlKCkpCisgICAgaWYgKCFwYXJl bnROb2RlKCkpCiAgICAgICAgIGVjID0gSElFUkFSQ0hZX1JFUVVFU1RfRVJSOwogICAgIGlmIChl YykKICAgICAgICAgcmV0dXJuOwo=