136591 2014-09-05 16:44:35 -0700 REGRESSION (r169407): Calls to RenderStyle::getRoundedBorderFor() in computeRoundedRectForBoxShape() still include RenderView pointer 2014-09-06 17:46:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer bjonesbe commit-queue darin esprehn+autocc glenn hyatt kondapallykalyan simon.fraser webkit-bug-importer zoltan oldest_to_newest 1033593 0 ddkilzer 2014-09-05 16:44:35 -0700 In <http://trac.webkit.org/r169407>, the RenderView pointer argument was removed from RenderStyle::getRoundedBorderFor(), but the code in computeRoundedRectForBoxShape() was never updated to remove the pointers. Newer versions of clang now warn about taking the address of a reference value (and the fact that it will never be NULL): Source/WebCore/rendering/shapes/BoxShape.cpp:74:117: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] RoundedRect::Radii radii = computeMarginBoxShapeRadii(style.getRoundedBorderFor(renderer.borderBoxRect(), &(renderer.view())).radii(), renderer); ~~~~~ ~^~~~~~~~~~~~~~~~ In file included from Source/WebCore/rendering/shapes/BoxShape.cpp:33: In file included from Source/WebCore/rendering/RenderBox.h:26: In file included from Source/WebCore/rendering/RenderBoxModelObject.h:28: In file included from Source/WebCore/rendering/RenderLayerModelObject.h:26: In file included from Source/WebCore/rendering/RenderElement.h:27: Source/WebCore/rendering/RenderObject.h:571:17: note: 'view' returns a reference RenderView& view() const { return *document().renderView(); }; ^ Source/WebCore/rendering/shapes/BoxShape.cpp:90:70: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] return style.getRoundedBorderFor(renderer.borderBoxRect(), &(renderer.view())); ~~~~~ ~^~~~~~~~~~~~~~~~ In file included from Source/WebCore/rendering/shapes/BoxShape.cpp:33: In file included from Source/WebCore/rendering/RenderBox.h:26: In file included from Source/WebCore/rendering/RenderBoxModelObject.h:28: In file included from Source/WebCore/rendering/RenderLayerModelObject.h:26: In file included from Source/WebCore/rendering/RenderElement.h:27: Source/WebCore/rendering/RenderObject.h:571:17: note: 'view' returns a reference RenderView& view() const { return *document().renderView(); }; ^ Source/WebCore/rendering/shapes/BoxShape.cpp:94:66: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] return style.getRoundedBorderFor(renderer.borderBoxRect(), &(renderer.view())); ~~~~~ ~^~~~~~~~~~~~~~~~ In file included from Source/WebCore/rendering/shapes/BoxShape.cpp:33: In file included from Source/WebCore/rendering/RenderBox.h:26: In file included from Source/WebCore/rendering/RenderBoxModelObject.h:28: In file included from Source/WebCore/rendering/RenderLayerModelObject.h:26: In file included from Source/WebCore/rendering/RenderElement.h:27: Source/WebCore/rendering/RenderObject.h:571:17: note: 'view' returns a reference RenderView& view() const { return *document().renderView(); }; ^ 3 errors generated. 1033594 1 ddkilzer 2014-09-05 16:45:01 -0700 <rdar://problem/18143731> 1033602 2 237724 ddkilzer 2014-09-05 16:56:47 -0700 Created attachment 237724 Patch v1 1033625 3 237724 commit-queue 2014-09-05 19:24:27 -0700 Comment on attachment 237724 Patch v1 Clearing flags on attachment: 237724 Committed r173348: <http://trac.webkit.org/changeset/173348> 1033626 4 commit-queue 2014-09-05 19:24:31 -0700 All reviewed patches have been landed. Closing bug. 1033711 5 darin 2014-09-06 17:46:43 -0700 This just shows us how dangerous arguments of type bool are! 237724 2014-09-05 16:56:47 -0700 2014-09-05 19:24:27 -0700 Patch v1 bug-136591-20140905165634.patch text/plain 2867 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhiMDdlNzllZjY1Nzdl ZDhjZjMwMmU4YjYwZmFiZTgzYjhmYzdhMi4uNmUzOGZmNzYzZjQ4Yjk1ZTM1NjBjNWVmYjhlOTVm NzQ5OWNlYWEzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA5LTA1ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE2 OTQwNyk6IENhbGxzIHRvIFJlbmRlclN0eWxlOjpnZXRSb3VuZGVkQm9yZGVyRm9yKCkgaW4gY29t cHV0ZVJvdW5kZWRSZWN0Rm9yQm94U2hhcGUoKSBzdGlsbCBpbmNsdWRlIFJlbmRlclZpZXcgcG9p bnRlcgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzY1OTE+CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xODE0MzczMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbiByMTY5NDA3LCB0aGUgUmVuZGVyVmlldyogYXJndW1lbnQgd2FzIHJl bW92ZWQgZnJvbQorICAgICAgICBSZW5kZXJTdHlsZTo6Z2V0Um91bmRlZEJvcmRlckZvcigpLiAg VGhpcyBhcmd1bWVudCB3YXMgbm90CisgICAgICAgIHJlbW92ZWQgZnJvbSB0aGVzZSBjYWxscyBp biBjb21wdXRlUm91bmRlZFJlY3RGb3JCb3hTaGFwZSgpLCBidXQKKyAgICAgICAgYmVjYXVzZSBn ZXRSb3VuZGVkQm9yZGVyRm9yKCkgYWx3YXlzIHJldHVybmVkIGEgcmVmZXJlbmNlLCBhbmQKKyAg ICAgICAgYmVjYXVzZSB0aGUgZGVmYXVsdCBmb3IgdGhlIG5leHQgYXJndW1lbnQgd2FzIHRydWUs IHRoZXJlIHdhcyBubworICAgICAgICBhY3R1YWwgY2hhbmdlIGluIGJlaGF2aW9yIGZyb20gdGhp cyBidWcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlIGlzIG5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9zaGFwZXMvQm94U2hhcGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y29tcHV0ZVJvdW5kZWRSZWN0Rm9yQm94U2hhcGUpOiBSZW1vdmUg UmVuZGVyVmlldyoKKyAgICAgICAgYXJndW1lbnRzIGZyb20gY2FsbHMgdG8gZ2V0Um91bmRlZEJv cmRlckZvcigpLgorCiAyMDE0LTA5LTA0ICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5n dG9uLmVkdT4KIAogICAgICAgICBMZWdhY3lQcm9maWxlcjogUHJvZmlsZU5vZGVzIHNob3VsZCBi ZSB1c2VkIG1vcmUgbGlrZSBzdHJ1Y3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc2hhcGVzL0JveFNoYXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFw ZXMvQm94U2hhcGUuY3BwCmluZGV4IDM4OWFhYzk1MTE1NDY5Yjc4NGQ0NmVmYjU0ODUwZjFiMmU5 MjY0MWYuLmE3NTlhZWIwNjIzOWUyOGU2YWI0NTI2ZmQ1MTQxMWQ4ZmE4MmJkZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvQm94U2hhcGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvQm94U2hhcGUuY3BwCkBAIC03MSw3ICs3MSw3 IEBAIFJvdW5kZWRSZWN0IGNvbXB1dGVSb3VuZGVkUmVjdEZvckJveFNoYXBlKENTU0JveFR5cGUg Ym94LCBjb25zdCBSZW5kZXJCb3gmIHJlbmRlCiAgICAgICAgICAgICByZXR1cm4gUm91bmRlZFJl Y3QocmVuZGVyZXIubWFyZ2luQm94UmVjdCgpLCBSb3VuZGVkUmVjdDo6UmFkaWkoKSk7CiAKICAg ICAgICAgTGF5b3V0UmVjdCBtYXJnaW5Cb3ggPSByZW5kZXJlci5tYXJnaW5Cb3hSZWN0KCk7Ci0g ICAgICAgIFJvdW5kZWRSZWN0OjpSYWRpaSByYWRpaSA9IGNvbXB1dGVNYXJnaW5Cb3hTaGFwZVJh ZGlpKHN0eWxlLmdldFJvdW5kZWRCb3JkZXJGb3IocmVuZGVyZXIuYm9yZGVyQm94UmVjdCgpLCAm KHJlbmRlcmVyLnZpZXcoKSkpLnJhZGlpKCksIHJlbmRlcmVyKTsKKyAgICAgICAgUm91bmRlZFJl Y3Q6OlJhZGlpIHJhZGlpID0gY29tcHV0ZU1hcmdpbkJveFNoYXBlUmFkaWkoc3R5bGUuZ2V0Um91 bmRlZEJvcmRlckZvcihyZW5kZXJlci5ib3JkZXJCb3hSZWN0KCkpLnJhZGlpKCksIHJlbmRlcmVy KTsKICAgICAgICAgcmFkaWkuc2NhbGUoY2FsY0JvcmRlclJhZGlpQ29uc3RyYWludFNjYWxlRm9y KG1hcmdpbkJveCwgcmFkaWkpKTsKICAgICAgICAgcmV0dXJuIFJvdW5kZWRSZWN0KG1hcmdpbkJv eCwgcmFkaWkpOwogICAgIH0KQEAgLTg3LDExICs4NywxMSBAQCBSb3VuZGVkUmVjdCBjb21wdXRl Um91bmRlZFJlY3RGb3JCb3hTaGFwZShDU1NCb3hUeXBlIGJveCwgY29uc3QgUmVuZGVyQm94JiBy ZW5kZQogICAgIGNhc2UgU3Ryb2tlOgogICAgIGNhc2UgVmlld0JveDoKICAgICBjYXNlIEJveE1p c3Npbmc6Ci0gICAgICAgIHJldHVybiBzdHlsZS5nZXRSb3VuZGVkQm9yZGVyRm9yKHJlbmRlcmVy LmJvcmRlckJveFJlY3QoKSwgJihyZW5kZXJlci52aWV3KCkpKTsKKyAgICAgICAgcmV0dXJuIHN0 eWxlLmdldFJvdW5kZWRCb3JkZXJGb3IocmVuZGVyZXIuYm9yZGVyQm94UmVjdCgpKTsKICAgICB9 CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gc3R5bGUuZ2V0Um91bmRl ZEJvcmRlckZvcihyZW5kZXJlci5ib3JkZXJCb3hSZWN0KCksICYocmVuZGVyZXIudmlldygpKSk7 CisgICAgcmV0dXJuIHN0eWxlLmdldFJvdW5kZWRCb3JkZXJGb3IocmVuZGVyZXIuYm9yZGVyQm94 UmVjdCgpKTsKIH0KIAogTGF5b3V0UmVjdCBCb3hTaGFwZTo6c2hhcGVNYXJnaW5Mb2dpY2FsQm91 bmRpbmdCb3goKSBjb25zdAo=