136590 2014-09-05 16:24:30 -0700 Doing a navigation on a non-opaque WKWebView can result in an empty layer tree 2014-09-05 17:14:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned sam simon.fraser oldest_to_newest 1033584 0 thorton 2014-09-05 16:24:30 -0700 FrameView::setTransparent uses FrameView::renderView to get the RenderView from the Document, but setTransparent can be called from Frame::createView, which is before the new Document has been swapped in, so it gets the old (pre-navigation) RenderView, and uses that to schedule a compositing layer update, which eventually comes through and can blow away the new document's layer tree. rdar://problem/18234000 1033586 1 237719 thorton 2014-09-05 16:28:15 -0700 Created attachment 237719 patch 1033592 2 237719 simon.fraser 2014-09-05 16:42:22 -0700 Comment on attachment 237719 patch View in context: https://bugs.webkit.org/attachment.cgi?id=237719&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + * page/FrameView.cpp: You fail to explain the "can result in an empty layer tree" part here. > Source/WebCore/page/FrameView.cpp:2586 > + if (&renderView->frameView() != this) > + return; This deserves a comment. 1033605 3 thorton 2014-09-05 17:14:38 -0700 http://trac.webkit.org/changeset/173344 237719 2014-09-05 16:28:15 -0700 2014-09-05 16:42:22 -0700 patch rv.diff text/plain 1597 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzN2MwYTE1Li5hOGY3NDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDktMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRG9pbmcgYSBuYXZpZ2F0aW9uIG9uIGEgbm9uLW9wYXF1ZSBXS1dlYlZpZXcgY2Fu IHJlc3VsdCBpbiBhbiBlbXB0eSBsYXllciB0cmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY1OTAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTgy MzQwMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2V0VHJh bnNwYXJlbnQpOgorICAgICAgICBBdm9pZCBzY2hlZHVsaW5nIGEgY29tcG9zaXRpbmcgbGF5ZXIg dXBkYXRlIGlmIHRoZSBSZW5kZXJWaWV3IGlzbid0IHRoZQorICAgICAgICBvbmUgYXNzb2NpYXRl ZCB3aXRoIHRoaXMgRnJhbWVWaWV3LiBUaGlzIGNhbiBoYXBwZW4gZHVyaW5nIGEgbmF2aWdhdGlv biwKKyAgICAgICAgYmVmb3JlIHRoZSBuZXcgRG9jdW1lbnQgKGFuZCBSZW5kZXJWaWV3KSBpcyBz d2FwcGVkIGluLiBUaGlzIGlzIHBhcnRpY3VsYXJseQorICAgICAgICBiYWQgaW4gdGhlIGNhc2Ug b2Ygc2V0VHJhbnNwYXJlbnQgYmVjYXVzZSBpdCBpcyBjYWxsZWQgZnJvbSBGcmFtZTo6Y3JlYXRl VmlldywKKyAgICAgICAgd2hpY2ggaXMgcmlnaHQgaW4gdGhlIG1pZGRsZSBvZiB0aGF0IHRyYW5z aXRpb24gd2luZG93LgorCiAyMDE0LTA5LTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeDsgaW5jbHVkZSBTdHJpbmdQ cmludFN0cmVhbSB0byBwdWxsIGluIHRvU3RyaW5nKCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAKaW5kZXggNGYzOGVhYi4uYTcxMDhlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApA QCAtMjU4Miw2ICsyNTgyLDkgQEAgdm9pZCBGcmFtZVZpZXc6OnNldFRyYW5zcGFyZW50KGJvb2wg aXNUcmFuc3BhcmVudCkKICAgICBpZiAoIXJlbmRlclZpZXcpCiAgICAgICAgIHJldHVybjsKIAor ICAgIGlmICgmcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCkgIT0gdGhpcykKKyAgICAgICAgcmV0dXJu OworCiAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yJiBjb21wb3NpdG9yID0gcmVuZGVyVmlldy0+ Y29tcG9zaXRvcigpOwogICAgIGNvbXBvc2l0b3Iuc2V0Q29tcG9zaXRpbmdMYXllcnNOZWVkUmVi dWlsZCgpOwogICAgIGNvbXBvc2l0b3Iuc2NoZWR1bGVDb21wb3NpdGluZ0xheWVyVXBkYXRlKCk7 Cg==