136585 2014-09-05 13:55:00 -0700 Remove statically used varyings from packing restrictions check 2014-09-11 11:02:56 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 136597 1 roger_fong webkit-unassigned bfulgham commit-queue dino jonlee kondapallykalyan roger_fong oldest_to_newest 1033542 0 roger_fong 2014-09-05 13:55:00 -0700 When checking packing restrictions on a shader's varyings, make sure to not include statically used varyings. Note that this was the reason why blink was passing this test and webkit was not. They were filtering out these statically used varyings before calling the packing restrictions check. 1033544 1 237709 roger_fong 2014-09-05 14:06:21 -0700 Created attachment 237709 patch 1033547 2 commit-queue 2014-09-05 14:08:31 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1033563 3 roger_fong 2014-09-05 15:12:02 -0700 http://trac.webkit.org/changeset/173335 1033644 4 commit-queue 2014-09-06 00:04:35 -0700 Re-opened since this is blocked by bug 136597 1033646 5 ap 2014-09-06 00:06:08 -0700 This broke webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html, rolling out. Diff is just a change from PASS to FAIL. 1034648 6 ap 2014-09-11 11:02:56 -0700 A different fix is being pursued in bug 136734. 237709 2014-09-05 14:06:21 -0700 2014-09-05 14:37:35 -0700 patch patch.patch text/plain 2875 roger_fong SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzMzMSkKKysrIFNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDE0LTA5LTA1ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIHN0YXRpY2FsbHkgdXNlZCB2YXJ5aW5ncyBmcm9tIHBhY2tpbmcgcmVz dHJpY3Rpb25zIGNoZWNrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM2NTg1LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYzMDg0MDk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvY29tcGls ZXIvdHJhbnNsYXRvci9Db21waWxlci5jcHA6CisgICAgICAgIChUQ29tcGlsZXI6OmVuZm9yY2VQ YWNraW5nUmVzdHJpY3Rpb25zKToKKwogMjAxNC0wOC0yOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8 b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aXdlZCwgcmVtb3ZlIGVtcHR5IGRpcmVj dG9yaWVzLgpJbmRleDogU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5z bGF0b3IvQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9jb21waWxlci90cmFuc2xhdG9yL0NvbXBpbGVyLmNwcAkocmV2aXNpb24gMTczMjg4KQor KysgU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvQ29tcGls ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NjAsNyArNDYwLDEzIEBAIGJvb2wgVENvbXBpbGVy OjplbmZvcmNlUGFja2luZ1Jlc3RyaWN0aW8KICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0K IAotICAgIHN1Y2Nlc3MgPSBwYWNrZXIuQ2hlY2tWYXJpYWJsZXNXaXRoaW5QYWNraW5nTGltaXRz KG1heFZhcnlpbmdWZWN0b3JzLCB2YXJ5aW5ncyk7CisgICAgVFZhcmlhYmxlSW5mb0xpc3Qgbm9u U3RhdGljYWxseVVzZWRWYXJ5aW5nczsKKworICAgIGZvciAoVFZhcmlhYmxlSW5mbyBpbmZvIDog dmFyeWluZ3MpIHsKKyAgICAgICAgaWYgKCFpbmZvLnN0YXRpY1VzZSkKKyAgICAgICAgICAgIG5v blN0YXRpY2FsbHlVc2VkVmFyeWluZ3MucHVzaF9iYWNrKGluZm8pOworICAgIH0KKyAgICBzdWNj ZXNzID0gcGFja2VyLkNoZWNrVmFyaWFibGVzV2l0aGluUGFja2luZ0xpbWl0cyhtYXhWYXJ5aW5n VmVjdG9ycywgbm9uU3RhdGljYWxseVVzZWRWYXJ5aW5ncyk7CiAKICAgICBpZiAoIXN1Y2Nlc3Mp IHsKICAgICAgICAgaW5mb1NpbmsuaW5mby5wcmVmaXgoRVByZWZpeEVycm9yKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDE3MzMzMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTA1ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0Bh cHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHN0YXRpY2FsbHkgdXNlZCB2YXJ5aW5ncyBmcm9t IHBhY2tpbmcgcmVzdHJpY3Rpb25zIGNoZWNrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTg1LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYz MDg0MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczogVW5za2lwIGJ1aWxkXzAwOV90b18wMTYu aHRtbCBjb25mb3JtYW5jZSB0ZXN0LgorCiAyMDE0LTA5LTA1ICBDYXJsb3MgQWxiZXJ0byBMb3Bl eiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBJbXBsZW1lbnQg UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1TdWdnZXN0ZWRGaWxlbmFtZSgpIHdoZW4gVVNFKFNP VVApIGlzIGVuYWJsZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwkocmV2aXNpb24gMTczMjg4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rl c3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTY0Miw5ICs2NDIsNiBAQCB3ZWJnbC8x LjAuMS9jb25mb3JtYW5jZS9saW1pdHMvZ2wtbWF4LXRlCiB3ZWJnbC8xLjAuMi9jb25mb3JtYW5j ZS90ZXh0dXJlcy90ZXh0dXJlLXNpemUuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJnbC8xLjAu Mi9jb25mb3JtYW5jZS9saW1pdHMvZ2wtbWF4LXRleHR1cmUtZGltZW5zaW9ucy5odG1sIFsgUGFz cyBGYWlsdXJlIF0KIAotIyBUZXN0IGlzIGZhdWx0eSwgc2tpcHBpbmcgZm9yIG5vdwotd2ViZ2wv MS4wLjIvY29uZm9ybWFuY2Uvb2dsZXMvR0wvYnVpbGQvYnVpbGRfMDA5X3RvXzAxNi5odG1sIFsg RmFpbHVyZSBdCi0KICMgU2tpcHBpbmcgYWxsIHdlYmdsIGNvbmZvcm1hbmNlIHRlc3RzIG9uIHRy dW5rCiB3ZWJnbC9jb25mb3JtYW5jZQogCg==