136575 2014-09-05 07:12:17 -0700 [CSS Grid Layout] Do not grow tracks when the growth factor is 0 2014-10-15 04:44:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 136940 1 svillar svillar commit-queue darin dino esprehn+autocc glenn jfernandez kling kondapallykalyan rego oldest_to_newest 1033453 0 svillar 2014-09-05 07:12:17 -0700 [CSS Grid Layout] Do not grow tracks when the growth factor is 0 1033457 1 237690 svillar 2014-09-05 07:31:22 -0700 Created attachment 237690 Patch 1034852 2 svillar 2014-09-12 06:44:41 -0700 Ping 1034854 3 237690 darin 2014-09-12 07:24:11 -0700 Comment on attachment 237690 Patch If this really makes such a significant difference, there are a lot of other things you should consider to make this code faster. The most obvious one would be to consider if "track.m_maxBreadth - trackBreadth" is usually 0 and if so, skip the availableLogicalSpaceShare computation entirely. It seems bizarre that this would be so hot that adding the branch just to avoid some addition and subtraction operations would make a measurable difference. 1035188 4 svillar 2014-09-15 02:28:54 -0700 (In reply to comment #3) > (From update of attachment 237690 [details]) > If this really makes such a significant difference, there are a lot of other things you should consider to make this code faster. The most obvious one would be to consider if "track.m_maxBreadth - trackBreadth" is usually 0 and if so, skip the availableLogicalSpaceShare computation entirely. > > It seems bizarre that this would be so hot that adding the branch just to avoid some addition and subtraction operations would make a measurable difference. That shocked me too, there seem no be no clear reason why the difference is so significant, but it was there when I tried the patch. I gave it another run today, and it seems that the difference is no longer there, I'm not getting significant improvements (+0.6% at the most) anymore so I think I'm abandoning this. 1035201 5 238111 svillar 2014-09-15 03:11:38 -0700 Created attachment 238111 Patch 1035229 6 svillar 2014-09-15 05:28:25 -0700 So in the end I gave it another shot and decided to implement the improvement you suggested. That resulted in a ~4% gain which was great, but then I realized that we could avoid a lot of useless work when there is no extra space to distribute. So I got a compact patch that gives us 16% of improvement (even 22% in some machines) in the auto-grid-lots-of-data.html perf test case. Obviously for real world use cases the improvement wouldn't likely be that huge but it's a good step forward IMO. 1035254 7 238111 svillar 2014-09-15 08:11:22 -0700 Comment on attachment 238111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238111&action=review > Source/WebCore/rendering/RenderGrid.cpp:605 > + LayoutUnit growthShare = std::min(availableLogicalSpaceShare, track.m_maxBreadth - trackBreadth); This should be obviously std::min(availableLogicalSpaceShare, trackGrowthPotential), will fix it before landing if r+'ed 1035397 8 svillar 2014-09-16 01:10:32 -0700 Darin could you review the patch again please? It's finally quite different to the original one. 1036539 9 svillar 2014-09-22 08:49:35 -0700 Gentle reminder... 1036676 10 svillar 2014-09-23 01:37:24 -0700 Committed r173868: <http://trac.webkit.org/changeset/173868> 237690 2014-09-05 07:31:22 -0700 2014-09-15 03:11:29 -0700 Patch bug-136575-20140905163116.patch text/plain 2493 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg2OTNjMmYzMTRjYjhl NmI3NGQ3ZDQ4NWU2ZWZlMDg1MGU1YmQzZi4uYzM3OWEyMDU2MjI4NWYyNDdjOWQyOGY0MTAyYmYx NzZiODA2NmY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA5LTA1ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIERvIG5vdCBncm93IHRyYWNrcyB3aGVuIHRoZSBncm93dGggZmFjdG9yIGlzIDAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjU3NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyb20gQmxp bmsgcjE2NDY4NSBieSA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVuZGVyR3JpZDo6 ZGlzdHJpYnV0ZVNwYWNlVG9UcmFja3MoKSBpcyBieSBmYXIgdGhlIGhvdHRlc3QgbWV0aG9kCisg ICAgICAgIGluIHRoZSBhdXRvLWdyaWQtbG90cy1vZi1kYXRhLmh0bWwgcGVyZm9ybWFuY2UgdGVz dC4gQnkgcmVkdWNpbmcKKyAgICAgICAgdXNlbGVzcyAiZ3Jvd2luZyIgb2YgZ3JpZCB0cmFja3Mg d2hlbiB0aGUgZ3Jvd3RoIGZhY3RvciBpcyB6ZXJvIHdlCisgICAgICAgIGNhbiBpbXByb3ZlIHRo ZSB0ZXN0IHRpbWUgYnkgfjMuNSUgKDIyNSBydW5zL3MgLT4gMjMzIHJ1bnMvcykuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSBpbiB0aGUgZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHcmlkLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckdyaWQ6OmRpc3RyaWJ1dGVTcGFjZVRvVHJhY2tzKToKKwogMjAxNC0wOS0wNCAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIGJ1aWxkIGZpeCBmb3IgRUZMIGFuZCBHVEsgcG9ydHMgc2luY2UgcjE3MzI3Mi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRleCA5NTdmZWVjNTZkN2YxZDc5 ZmVlNGM4MGYyMWRmMDkxZDE3NmVkNzQyLi4zMzYxYjIzZDE0NmNkZTRhNzdlZmZkZTkwNmRhZDgw NDRhOGM5NjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3Jp ZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCkBAIC01 OTUsMTAgKzU5NSwxMyBAQCB2b2lkIFJlbmRlckdyaWQ6OmRpc3RyaWJ1dGVTcGFjZVRvVHJhY2tz KFZlY3RvcjxHcmlkVHJhY2sqPiYgdHJhY2tzLCBWZWN0b3I8R3JpZAogICAgICAgICBHcmlkVHJh Y2smIHRyYWNrID0gKnRyYWNrc1tpXTsKICAgICAgICAgTGF5b3V0VW5pdCBhdmFpbGFibGVMb2dp Y2FsU3BhY2VTaGFyZSA9IGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSAvICh0cmFja3NTaXplIC0gaSk7 CiAgICAgICAgIExheW91dFVuaXQgdHJhY2tCcmVhZHRoID0gKHRyYWNrc1tpXS0+KnRyYWNrR2V0 dGVyKSgpOwotICAgICAgICBMYXlvdXRVbml0IGdyb3d0aFNoYXJlID0gc3RkOjptYXgoTGF5b3V0 VW5pdCgpLCBzdGQ6Om1pbihhdmFpbGFibGVMb2dpY2FsU3BhY2VTaGFyZSwgdHJhY2subV9tYXhC cmVhZHRoIC0gdHJhY2tCcmVhZHRoKSk7CisgICAgICAgIExheW91dFVuaXQgZ3Jvd3RoU2hhcmUg PSBzdGQ6Om1pbihhdmFpbGFibGVMb2dpY2FsU3BhY2VTaGFyZSwgdHJhY2subV9tYXhCcmVhZHRo IC0gdHJhY2tCcmVhZHRoKTsKKyAgICAgICAgc2l6aW5nRGF0YS5kaXN0cmlidXRlVHJhY2tWZWN0 b3JbaV0gPSB0cmFja0JyZWFkdGg7CiAgICAgICAgIC8vIFdlIHNob3VsZCBuZXZlciBzaHJpbmsg YW55IGdyaWQgdHJhY2sgb3IgZWxzZSB3ZSBjYW4ndCBndWFyYW50ZWUgd2UgYWJpZGUgYnkgb3Vy IG1pbi1zaXppbmcgZnVuY3Rpb24uCi0gICAgICAgIHNpemluZ0RhdGEuZGlzdHJpYnV0ZVRyYWNr VmVjdG9yW2ldID0gdHJhY2tCcmVhZHRoICsgZ3Jvd3RoU2hhcmU7Ci0gICAgICAgIGF2YWlsYWJs ZUxvZ2ljYWxTcGFjZSAtPSBncm93dGhTaGFyZTsKKyAgICAgICAgaWYgKGdyb3d0aFNoYXJlID4g MCkgeworICAgICAgICAgICAgc2l6aW5nRGF0YS5kaXN0cmlidXRlVHJhY2tWZWN0b3JbaV0gKz0g Z3Jvd3RoU2hhcmU7CisgICAgICAgICAgICBhdmFpbGFibGVMb2dpY2FsU3BhY2UgLT0gZ3Jvd3Ro U2hhcmU7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoYXZhaWxhYmxlTG9naWNhbFNwYWNl ID4gMCAmJiB0cmFja3NGb3JHcm93dGhBYm92ZU1heEJyZWFkdGgpIHsK 238111 2014-09-15 03:11:38 -0700 2014-09-22 15:20:48 -0700 Patch bug-136575-20140915121134.patch text/plain 4516 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA4ODhmMTc2MjI5NjU3 ZTEwNjdjZTBhYTlhNjNhNjNiODBmYjY5MS4uNGRmMmI1MzEwY2I1MTExNjJmYWIyYzE0MGFmMzMy N2Q3YzVhYmFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA5LTE1ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIERvIG5vdCBncm93IHRyYWNrcyB3aGVuIHRoZSBncm93dGggZmFjdG9yIGlzIDAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjU3NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgY291cGxl IG9mIHBlcmZvcm1hbmNlIG9wdGltaXphdGlvbnMgZm9yIHRoZSB0cmFjayBzaXppbmcKKyAgICAg ICAgYWxnb3JpdGhtLiBPbiB0aGUgb25lIGhhbmQgd2UgYXZvaWQgdGhlIGNvbXB1dGF0aW9uIG9m IHRoZQorICAgICAgICBhdmFpbGFibGUgbG9naWNhbCBzcGFjZSBzaGFyZSBpZiB0aGUgdHJhY2sg aGFzIG5vIGdyb3d0aCBwb3RlbnRpYWwKKyAgICAgICAgKHRoZSBjdXJyZW50IGJyZWFkdGggaXMg dGhlIG1heGltdW0gYnJlYWR0aCkgYW5kIG9uIHRoZSBvdGhlcgorICAgICAgICBoYW5kLCB3ZSBh dm9pZCBjYWxsaW5nIFJlbmRlckdyaWQ6OmRpc3RyaWJ1dGVTcGFjZVRvVHJhY2tzKCkgaWYKKyAg ICAgICAgdGhlIGF2YWlsYWJsZSBsb2dpY2FsIHNwYWNlIGlzIG5vdCBncmVhdGVyIHRoYW4gMC4K KworICAgICAgICBUaGUgY29tYmluZWQgZWZmZWN0IG9mIHRoZXNlIHR3byBjaGFuZ2VzIGlzIGFu IGltcHJlc3NpdmUgKzE2JQorICAgICAgICBpbXByb3ZlbWVudCBpbiBhdXRvLWdyaWQtbG90cy1v Zi1kYXRhLmh0bWwgcGVyZm9ybWFuY2UgdGVzdC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMg dGhlcmUgaXMgbm8gY2hhbmdlIGluIHRoZSBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6cmVz b2x2ZUNvbnRlbnRCYXNlZFRyYWNrU2l6aW5nRnVuY3Rpb25zRm9ySXRlbXMpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyR3JpZDo6ZGlzdHJpYnV0ZVNwYWNlVG9UcmFja3MpOgorCiAyMDE0LTA5 LTEyICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtDU1MgR3JpZCBMYXlvdXRdIENyYXNoIGF0IENTU1BhcnNlcjo6cGFyc2VHcmlkVGVtcGxhdGVS b3dzQW5kQXJlYXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJH cmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRleCA0 OTNkMWQwNTMzOGIzZGI4YmMxN2QwODNjYzNmMjIzZGE2YzYxOGQ0Li4xNWI4Zjc1ZmE4Y2NhMjkw ODNmYzNlMWE5OTFjNmEyYTU4NWVlOWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckdyaWQuY3BwCkBAIC01NzYsNyArNTc2LDEwIEBAIHZvaWQgUmVuZGVyR3JpZDo6cmVzb2x2ZUNv bnRlbnRCYXNlZFRyYWNrU2l6aW5nRnVuY3Rpb25zRm9ySXRlbXMoR3JpZFRyYWNrU2l6aW5nCiAg ICAgfQogCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBwYXNzIGRpZmZlcmVudCB2YWx1ZXMgZm9y IHx0cmFja3NGb3JHcm93dGhBYm92ZU1heEJyZWFkdGh8LgotICAgIGRpc3RyaWJ1dGVTcGFjZVRv VHJhY2tzKHNpemluZ0RhdGEuZmlsdGVyZWRUcmFja3MsICZzaXppbmdEYXRhLmZpbHRlcmVkVHJh Y2tzLCB0cmFja0dldHRlciwgdHJhY2tHcm93dGhGdW5jdGlvbiwgc2l6aW5nRGF0YSwgYWRkaXRp b25hbEJyZWFkdGhTcGFjZSk7CisgICAgLy8gU3BlY3MgbWFuZGF0ZSB0byBmbG9vciBhZGRpdGlv bmFsQnJlYWR0aFNwYWNlIChleHRyYS1zcGFjZSBpbiBzcGVjcykgdG8gMC4gSW5zdGVhZCB3ZSBk aXJlY3RseSBhdm9pZCB0aGUgZnVuY3Rpb24KKyAgICAvLyBjYWxsIGluIHRob3NlIGNhc2VzIGFz IGl0IHdpbGwgYmUgYSBub29wIGluIHRlcm1zIG9mIHRyYWNrIHNpemluZy4KKyAgICBpZiAoYWRk aXRpb25hbEJyZWFkdGhTcGFjZSA+IDApCisgICAgICAgIGRpc3RyaWJ1dGVTcGFjZVRvVHJhY2tz KHNpemluZ0RhdGEuZmlsdGVyZWRUcmFja3MsICZzaXppbmdEYXRhLmZpbHRlcmVkVHJhY2tzLCB0 cmFja0dldHRlciwgdHJhY2tHcm93dGhGdW5jdGlvbiwgc2l6aW5nRGF0YSwgYWRkaXRpb25hbEJy ZWFkdGhTcGFjZSk7CiB9CiAKIHN0YXRpYyBib29sIHNvcnRCeUdyaWRUcmFja0dyb3d0aFBvdGVu dGlhbChjb25zdCBHcmlkVHJhY2sqIHRyYWNrMSwgY29uc3QgR3JpZFRyYWNrKiB0cmFjazIpCkBA IC01ODYsNiArNTg5LDcgQEAgc3RhdGljIGJvb2wgc29ydEJ5R3JpZFRyYWNrR3Jvd3RoUG90ZW50 aWFsKGNvbnN0IEdyaWRUcmFjayogdHJhY2sxLCBjb25zdCBHcmlkVHIKIAogdm9pZCBSZW5kZXJH cmlkOjpkaXN0cmlidXRlU3BhY2VUb1RyYWNrcyhWZWN0b3I8R3JpZFRyYWNrKj4mIHRyYWNrcywg VmVjdG9yPEdyaWRUcmFjayo+KiB0cmFja3NGb3JHcm93dGhBYm92ZU1heEJyZWFkdGgsIEFjY3Vt dWxhdG9yR2V0dGVyIHRyYWNrR2V0dGVyLCBBY2N1bXVsYXRvckdyb3dGdW5jdGlvbiB0cmFja0dy b3d0aEZ1bmN0aW9uLCBHcmlkU2l6aW5nRGF0YSYgc2l6aW5nRGF0YSwgTGF5b3V0VW5pdCYgYXZh aWxhYmxlTG9naWNhbFNwYWNlKQogeworICAgIEFTU0VSVChhdmFpbGFibGVMb2dpY2FsU3BhY2Ug PiAwKTsKICAgICBzdGQ6OnNvcnQodHJhY2tzLmJlZ2luKCksIHRyYWNrcy5lbmQoKSwgc29ydEJ5 R3JpZFRyYWNrR3Jvd3RoUG90ZW50aWFsKTsKIAogICAgIHNpemVfdCB0cmFja3NTaXplID0gdHJh Y2tzLnNpemUoKTsKQEAgLTU5MywxMiArNTk3LDE2IEBAIHZvaWQgUmVuZGVyR3JpZDo6ZGlzdHJp YnV0ZVNwYWNlVG9UcmFja3MoVmVjdG9yPEdyaWRUcmFjayo+JiB0cmFja3MsIFZlY3RvcjxHcmlk CiAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHRyYWNrc1NpemU7ICsraSkgewogICAgICAg ICBHcmlkVHJhY2smIHRyYWNrID0gKnRyYWNrc1tpXTsKLSAgICAgICAgTGF5b3V0VW5pdCBhdmFp bGFibGVMb2dpY2FsU3BhY2VTaGFyZSA9IGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSAvICh0cmFja3NT aXplIC0gaSk7CiAgICAgICAgIExheW91dFVuaXQgdHJhY2tCcmVhZHRoID0gKHRyYWNrc1tpXS0+ KnRyYWNrR2V0dGVyKSgpOwotICAgICAgICBMYXlvdXRVbml0IGdyb3d0aFNoYXJlID0gc3RkOjpt YXgoTGF5b3V0VW5pdCgpLCBzdGQ6Om1pbihhdmFpbGFibGVMb2dpY2FsU3BhY2VTaGFyZSwgdHJh Y2subV9tYXhCcmVhZHRoIC0gdHJhY2tCcmVhZHRoKSk7Ci0gICAgICAgIC8vIFdlIHNob3VsZCBu ZXZlciBzaHJpbmsgYW55IGdyaWQgdHJhY2sgb3IgZWxzZSB3ZSBjYW4ndCBndWFyYW50ZWUgd2Ug YWJpZGUgYnkgb3VyIG1pbi1zaXppbmcgZnVuY3Rpb24uCi0gICAgICAgIHNpemluZ0RhdGEuZGlz dHJpYnV0ZVRyYWNrVmVjdG9yW2ldID0gdHJhY2tCcmVhZHRoICsgZ3Jvd3RoU2hhcmU7Ci0gICAg ICAgIGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSAtPSBncm93dGhTaGFyZTsKKyAgICAgICAgTGF5b3V0 VW5pdCB0cmFja0dyb3d0aFBvdGVudGlhbCA9IHRyYWNrLm1fbWF4QnJlYWR0aCAtIHRyYWNrQnJl YWR0aDsKKyAgICAgICAgc2l6aW5nRGF0YS5kaXN0cmlidXRlVHJhY2tWZWN0b3JbaV0gPSB0cmFj a0JyZWFkdGg7CisgICAgICAgIGlmICh0cmFja0dyb3d0aFBvdGVudGlhbCA+IDApIHsKKyAgICAg ICAgICAgIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNhbFNwYWNlU2hhcmUgPSBhdmFpbGFibGVM b2dpY2FsU3BhY2UgLyAodHJhY2tzU2l6ZSAtIGkpOworICAgICAgICAgICAgTGF5b3V0VW5pdCBn cm93dGhTaGFyZSA9IHN0ZDo6bWluKGF2YWlsYWJsZUxvZ2ljYWxTcGFjZVNoYXJlLCB0cmFjay5t X21heEJyZWFkdGggLSB0cmFja0JyZWFkdGgpOworICAgICAgICAgICAgLy8gV2Ugc2hvdWxkIG5l dmVyIHNocmluayBhbnkgZ3JpZCB0cmFjayBvciBlbHNlIHdlIGNhbid0IGd1YXJhbnRlZSB3ZSBh YmlkZSBieSBvdXIgbWluLXNpemluZyBmdW5jdGlvbi4KKyAgICAgICAgICAgIHNpemluZ0RhdGEu ZGlzdHJpYnV0ZVRyYWNrVmVjdG9yW2ldICs9IGdyb3d0aFNoYXJlOworICAgICAgICAgICAgYXZh aWxhYmxlTG9naWNhbFNwYWNlIC09IGdyb3d0aFNoYXJlOworICAgICAgICB9CiAgICAgfQogCiAg ICAgaWYgKGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSA+IDAgJiYgdHJhY2tzRm9yR3Jvd3RoQWJvdmVN YXhCcmVhZHRoKSB7Cg==